From: SF Markus Elfring <elfring@users.sourceforge.net> To: linux-ntfs-dev@lists.sourceforge.net, linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>, Richard Russon <ldm@flatcap.org> Cc: Julia Lawall <julia.lawall@lip6.fr>, LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org Subject: [PATCH 5/5] block-LDM: Fine-tuning for the source code formatting Date: Wed, 23 Dec 2015 19:13:55 +0100 [thread overview] Message-ID: <567AE463.4080702@users.sourceforge.net> (raw) In-Reply-To: <567AE1C6.9020108@users.sourceforge.net> From: Markus Elfring <elfring@users.sourceforge.net> Date: Wed, 23 Dec 2015 17:23:25 +0100 1. Remove some space characters and add a few according to the Linux coding style convention. 2. Reformat a bit of source code also for one switch statement. 3. Apply a few more recommendations from the script "checkpatch.pl". Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- block/partitions/ldm.c | 405 ++++++++++++++++++++++++++----------------------- 1 file changed, 213 insertions(+), 192 deletions(-) diff --git a/block/partitions/ldm.c b/block/partitions/ldm.c index 6fc9150..3ebe033 100644 --- a/block/partitions/ldm.c +++ b/block/partitions/ldm.c @@ -42,12 +42,12 @@ #ifndef CONFIG_LDM_DEBUG #define ldm_debug(...) do {} while (0) #else -#define ldm_debug(f, a...) _ldm_printk (KERN_DEBUG, __func__, f, ##a) +#define ldm_debug(f, a...) _ldm_printk(KERN_DEBUG, __func__, f, ##a) #endif -#define ldm_crit(f, a...) _ldm_printk (KERN_CRIT, __func__, f, ##a) -#define ldm_error(f, a...) _ldm_printk (KERN_ERR, __func__, f, ##a) -#define ldm_info(f, a...) _ldm_printk (KERN_INFO, __func__, f, ##a) +#define ldm_crit(f, a...) _ldm_printk(KERN_CRIT, __func__, f, ##a) +#define ldm_error(f, a...) _ldm_printk(KERN_ERR, __func__, f, ##a) +#define ldm_info(f, a...) _ldm_printk(KERN_INFO, __func__, f, ##a) static __printf(3, 4) void _ldm_printk(const char *level, const char *function, const char *fmt, ...) @@ -55,7 +55,7 @@ void _ldm_printk(const char *level, const char *function, const char *fmt, ...) struct va_format vaf; va_list args; - va_start (args, fmt); + va_start(args, fmt); vaf.fmt = fmt; vaf.va = &args; @@ -74,7 +74,7 @@ void _ldm_printk(const char *level, const char *function, const char *fmt, ...) * Return: 0-255 Success, the byte was parsed correctly * -1 Error, an invalid character was supplied */ -static int ldm_parse_hexbyte (const u8 *src) +static int ldm_parse_hexbyte(const u8 *src) { unsigned int x; /* For correct wrapping */ int h; @@ -102,7 +102,7 @@ static int ldm_parse_hexbyte (const u8 *src) * Return: 'true' @dest contains binary GUID * 'false' @dest contents are undefined */ -static bool ldm_parse_guid (const u8 *src, u8 *dest) +static bool ldm_parse_guid(const u8 *src, u8 *dest) { static const int size[] = { 4, 2, 2, 2, 6 }; int i, j, v; @@ -112,10 +112,11 @@ static bool ldm_parse_guid (const u8 *src, u8 *dest) return false; for (j = 0; j < 5; j++, src++) - for (i = 0; i < size[j]; i++, src+=2, *dest++ = v) - if ((v = ldm_parse_hexbyte (src)) < 0) + for (i = 0; i < size[j]; i++, src += 2, *dest++ = v) { + v = ldm_parse_hexbyte(src); + if (v < 0) return false; - + } return true; } @@ -189,36 +190,36 @@ static bool ldm_parse_privhead(const u8 *data, struct privhead *ph) * Return: 'true' @toc contains the TOCBLOCK data * 'false' @toc contents are undefined */ -static bool ldm_parse_tocblock (const u8 *data, struct tocblock *toc) +static bool ldm_parse_tocblock(const u8 *data, struct tocblock *toc) { - BUG_ON (!data || !toc); + BUG_ON(!data || !toc); if (MAGIC_TOCBLOCK != get_unaligned_be64(data)) { - ldm_crit ("Cannot find TOCBLOCK, database may be corrupt."); + ldm_crit("Cannot find TOCBLOCK, database may be corrupt."); return false; } - strncpy (toc->bitmap1_name, data + 0x24, sizeof (toc->bitmap1_name)); + strncpy(toc->bitmap1_name, data + 0x24, sizeof(toc->bitmap1_name)); toc->bitmap1_name[sizeof (toc->bitmap1_name) - 1] = 0; toc->bitmap1_start = get_unaligned_be64(data + 0x2E); toc->bitmap1_size = get_unaligned_be64(data + 0x36); - if (strncmp (toc->bitmap1_name, TOC_BITMAP1, - sizeof (toc->bitmap1_name)) != 0) { - ldm_crit ("TOCBLOCK's first bitmap is '%s', should be '%s'.", + if (strncmp(toc->bitmap1_name, TOC_BITMAP1, + sizeof(toc->bitmap1_name)) != 0) { + ldm_crit("TOCBLOCK's first bitmap is '%s', should be '%s'.", TOC_BITMAP1, toc->bitmap1_name); return false; } - strncpy (toc->bitmap2_name, data + 0x46, sizeof (toc->bitmap2_name)); - toc->bitmap2_name[sizeof (toc->bitmap2_name) - 1] = 0; + strncpy(toc->bitmap2_name, data + 0x46, sizeof(toc->bitmap2_name)); + toc->bitmap2_name[sizeof(toc->bitmap2_name) - 1] = 0; toc->bitmap2_start = get_unaligned_be64(data + 0x50); toc->bitmap2_size = get_unaligned_be64(data + 0x58); - if (strncmp (toc->bitmap2_name, TOC_BITMAP2, - sizeof (toc->bitmap2_name)) != 0) { - ldm_crit ("TOCBLOCK's second bitmap is '%s', should be '%s'.", + if (strncmp(toc->bitmap2_name, TOC_BITMAP2, + sizeof(toc->bitmap2_name)) != 0) { + ldm_crit("TOCBLOCK's second bitmap is '%s', should be '%s'.", TOC_BITMAP2, toc->bitmap2_name); return false; } - ldm_debug ("Parsed TOCBLOCK successfully."); + ldm_debug("Parsed TOCBLOCK successfully."); return true; } @@ -235,33 +236,33 @@ static bool ldm_parse_tocblock (const u8 *data, struct tocblock *toc) * Return: 'true' @vm contains VMDB info * 'false' @vm contents are undefined */ -static bool ldm_parse_vmdb (const u8 *data, struct vmdb *vm) +static bool ldm_parse_vmdb(const u8 *data, struct vmdb *vm) { - BUG_ON (!data || !vm); + BUG_ON(!data || !vm); if (MAGIC_VMDB != get_unaligned_be32(data)) { - ldm_crit ("Cannot find the VMDB, database may be corrupt."); + ldm_crit("Cannot find the VMDB, database may be corrupt."); return false; } vm->ver_major = get_unaligned_be16(data + 0x12); vm->ver_minor = get_unaligned_be16(data + 0x14); if ((vm->ver_major != 4) || (vm->ver_minor != 10)) { - ldm_error ("Expected VMDB version %d.%d, got %d.%d. " + ldm_error("Expected VMDB version %d.%d, got %d.%d. " "Aborting.", 4, 10, vm->ver_major, vm->ver_minor); return false; } vm->vblk_size = get_unaligned_be32(data + 0x08); if (vm->vblk_size == 0) { - ldm_error ("Illegal VBLK size"); + ldm_error("Illegal VBLK size"); return false; } vm->vblk_offset = get_unaligned_be32(data + 0x0C); vm->last_vblk_seq = get_unaligned_be32(data + 0x04); - ldm_debug ("Parsed VMDB successfully."); + ldm_debug("Parsed VMDB successfully."); return true; } @@ -275,10 +276,10 @@ static bool ldm_parse_vmdb (const u8 *data, struct vmdb *vm) * Return: 'true' Identical * 'false' Different */ -static bool ldm_compare_privheads (const struct privhead *ph1, +static bool ldm_compare_privheads(const struct privhead *ph1, const struct privhead *ph2) { - BUG_ON (!ph1 || !ph2); + BUG_ON(!ph1 || !ph2); return ((ph1->ver_major == ph2->ver_major) && (ph1->ver_minor == ph2->ver_minor) && @@ -286,7 +287,7 @@ static bool ldm_compare_privheads (const struct privhead *ph1, (ph1->logical_disk_size == ph2->logical_disk_size) && (ph1->config_start == ph2->config_start) && (ph1->config_size == ph2->config_size) && - !memcmp (ph1->disk_id, ph2->disk_id, GUID_SIZE)); + !memcmp(ph1->disk_id, ph2->disk_id, GUID_SIZE)); } /** @@ -299,19 +300,19 @@ static bool ldm_compare_privheads (const struct privhead *ph1, * Return: 'true' Identical * 'false' Different */ -static bool ldm_compare_tocblocks (const struct tocblock *toc1, +static bool ldm_compare_tocblocks(const struct tocblock *toc1, const struct tocblock *toc2) { - BUG_ON (!toc1 || !toc2); + BUG_ON(!toc1 || !toc2); return ((toc1->bitmap1_start == toc2->bitmap1_start) && (toc1->bitmap1_size == toc2->bitmap1_size) && (toc1->bitmap2_start == toc2->bitmap2_start) && (toc1->bitmap2_size == toc2->bitmap2_size) && - !strncmp (toc1->bitmap1_name, toc2->bitmap1_name, - sizeof (toc1->bitmap1_name)) && - !strncmp (toc1->bitmap2_name, toc2->bitmap2_name, - sizeof (toc1->bitmap2_name))); + !strncmp(toc1->bitmap1_name, toc2->bitmap1_name, + sizeof(toc1->bitmap1_name)) && + !strncmp(toc1->bitmap2_name, toc2->bitmap2_name, + sizeof(toc1->bitmap2_name))); } /** @@ -339,12 +340,12 @@ static bool ldm_validate_privheads(struct parsed_partitions *state, long num_sects; int i; - BUG_ON (!state || !ph1); + BUG_ON(!state || !ph1); - ph[1] = kmalloc (sizeof (*ph[1]), GFP_KERNEL); + ph[1] = kmalloc(sizeof(*ph[1]), GFP_KERNEL); if (!ph[1]) return false; - ph[2] = kmalloc (sizeof (*ph[2]), GFP_KERNEL); + ph[2] = kmalloc(sizeof(*ph[2]), GFP_KERNEL); if (!ph[2]) { result = false; goto free_a_head; @@ -358,18 +359,23 @@ static bool ldm_validate_privheads(struct parsed_partitions *state, data = read_part_sector(state, ph[0]->config_start + off[i], §); if (!data) { - ldm_crit ("Disk read failed."); + ldm_crit("Disk read failed."); result = false; goto free_another_head; } - result = ldm_parse_privhead (data, ph[i]); + result = ldm_parse_privhead(data, ph[i]); put_dev_sector (sect); if (!result) { - ldm_error ("Cannot find PRIVHEAD %d.", i+1); /* Log again */ + /* Log again */ + ldm_error("Cannot find PRIVHEAD %d.", i + 1); if (i < 2) goto free_another_head; /* Already logged */ else - break; /* FIXME ignore for now, 3rd PH can fail on odd-sized disks */ + /* + * FIXME: ignore for now, + * 3rd PH can fail on odd-sized disks + */ + break; } } @@ -377,19 +383,19 @@ static bool ldm_validate_privheads(struct parsed_partitions *state, if ((ph[0]->config_start > num_sects) || ((ph[0]->config_start + ph[0]->config_size) > num_sects)) { - ldm_crit ("Database extends beyond the end of the disk."); + ldm_crit("Database extends beyond the end of the disk."); goto free_another_head; } if ((ph[0]->logical_disk_start > ph[0]->config_start) || ((ph[0]->logical_disk_start + ph[0]->logical_disk_size) > ph[0]->config_start)) { - ldm_crit ("Disk and database overlap."); + ldm_crit("Disk and database overlap."); goto free_another_head; } - if (!ldm_compare_privheads (ph[0], ph[1])) { - ldm_crit ("Primary and backup PRIVHEADs don't match."); + if (!ldm_compare_privheads(ph[0], ph[1])) { + ldm_crit("Primary and backup PRIVHEADs don't match."); goto free_another_head; } /* FIXME ignore this for now @@ -397,7 +403,7 @@ static bool ldm_validate_privheads(struct parsed_partitions *state, ldm_crit ("Primary and backup PRIVHEADs don't match."); goto free_another_head; }*/ - ldm_debug ("Validated PRIVHEADs successfully."); + ldm_debug("Validated PRIVHEADs successfully."); result = true; free_another_head: kfree(ph[2]); @@ -501,42 +507,42 @@ static bool ldm_validate_vmdb(struct parsed_partitions *state, struct vmdb *vm; struct tocblock *toc; - BUG_ON (!state || !ldb); + BUG_ON(!state || !ldb); vm = &ldb->vm; toc = &ldb->toc; data = read_part_sector(state, base + OFF_VMDB, §); if (!data) { - ldm_crit ("Disk read failed."); + ldm_crit("Disk read failed."); return false; } - if (!ldm_parse_vmdb (data, vm)) + if (!ldm_parse_vmdb(data, vm)) goto out; /* Already logged */ /* Are there uncommitted transactions? */ if (get_unaligned_be16(data + 0x10) != 0x01) { - ldm_crit ("Database is not in a consistent state. Aborting."); + ldm_crit("Database is not in a consistent state. Aborting."); goto out; } if (vm->vblk_offset != 512) - ldm_info ("VBLKs start at offset 0x%04x.", vm->vblk_offset); + ldm_info("VBLKs start at offset 0x%04x.", vm->vblk_offset); /* * The last_vblkd_seq can be before the end of the vmdb, just make sure * it is not out of bounds. */ if ((vm->vblk_size * vm->last_vblk_seq) > (toc->bitmap1_size << 9)) { - ldm_crit ("VMDB exceeds allowed size specified by TOCBLOCK. " + ldm_crit("VMDB exceeds allowed size specified by TOCBLOCK. " "Database is corrupt. Aborting."); goto out; } result = true; out: - put_dev_sector (sect); + put_dev_sector(sect); return result; } @@ -569,11 +575,11 @@ static bool ldm_validate_partition_table(struct parsed_partitions *state) data = read_part_sector(state, 0, §); if (!data) { - ldm_info ("Disk read failed."); + ldm_info("Disk read failed."); return false; } - if (*(__le16*) (data + 0x01FE) != cpu_to_le16 (MSDOS_LABEL_MAGIC)) + if (*(__le16 *) (data + 0x01FE) != cpu_to_le16(MSDOS_LABEL_MAGIC)) goto out; p = (struct partition*)(data + 0x01BE); @@ -584,10 +590,10 @@ static bool ldm_validate_partition_table(struct parsed_partitions *state) } if (result) - ldm_debug ("Found W2K dynamic disk partition type."); + ldm_debug("Found W2K dynamic disk partition type."); out: - put_dev_sector (sect); + put_dev_sector(sect); return result; } @@ -603,15 +609,16 @@ out: * Return: Pointer, A matching vblk was found * NULL, No match, or an error */ -static struct vblk * ldm_get_disk_objid (const struct ldmdb *ldb) +static struct vblk *ldm_get_disk_objid(const struct ldmdb *ldb) { struct list_head *item; - BUG_ON (!ldb); + BUG_ON(!ldb); - list_for_each (item, &ldb->v_disk) { - struct vblk *v = list_entry (item, struct vblk, list); - if (!memcmp (v->vblk.disk.disk_id, ldb->ph.disk_id, GUID_SIZE)) + list_for_each(item, &ldb->v_disk) { + struct vblk *v = list_entry(item, struct vblk, list); + + if (!memcmp(v->vblk.disk.disk_id, ldb->ph.disk_id, GUID_SIZE)) return v; } @@ -635,7 +642,7 @@ static struct vblk * ldm_get_disk_objid (const struct ldmdb *ldb) * Return: 'true' Partition created * 'false' Error, probably a range checking problem */ -static bool ldm_create_data_partitions (struct parsed_partitions *pp, +static bool ldm_create_data_partitions(struct parsed_partitions *pp, const struct ldmdb *ldb) { struct list_head *item; @@ -644,25 +651,25 @@ static bool ldm_create_data_partitions (struct parsed_partitions *pp, struct vblk_part *part; int part_num = 1; - BUG_ON (!pp || !ldb); + BUG_ON(!pp || !ldb); - disk = ldm_get_disk_objid (ldb); + disk = ldm_get_disk_objid(ldb); if (!disk) { - ldm_crit ("Can't find the ID of this disk in the database."); + ldm_crit("Can't find the ID of this disk in the database."); return false; } strlcat(pp->pp_buf, " [LDM]", PAGE_SIZE); /* Create the data partitions */ - list_for_each (item, &ldb->v_part) { - vb = list_entry (item, struct vblk, list); + list_for_each(item, &ldb->v_part) { + vb = list_entry(item, struct vblk, list); part = &vb->vblk.part; if (part->disk_id != disk->obj_id) continue; - put_partition (pp, part_num, ldb->ph.logical_disk_start + + put_partition(pp, part_num, ldb->ph.logical_disk_start + part->start, part->size); part_num++; } @@ -722,12 +729,12 @@ static int ldm_relative(const u8 *buffer, int buflen, int base, int offset) * Return: n A number * 0 Zero, or an error occurred */ -static u64 ldm_get_vnum (const u8 *block) +static u64 ldm_get_vnum(const u8 *block) { u64 tmp = 0; u8 length; - BUG_ON (!block); + BUG_ON(!block); length = *block++; @@ -735,7 +742,7 @@ static u64 ldm_get_vnum (const u8 *block) while (length--) tmp = (tmp << 8) | *block++; else - ldm_error ("Illegal length %d.", length); + ldm_error("Illegal length %d.", length); return tmp; } @@ -757,18 +764,18 @@ static u64 ldm_get_vnum (const u8 *block) * n, String length in characters (excluding NULL) * buflen-1, String was truncated. */ -static int ldm_get_vstr (const u8 *block, u8 *buffer, int buflen) +static int ldm_get_vstr(const u8 *block, u8 *buffer, int buflen) { int length; - BUG_ON (!block || !buffer); + BUG_ON(!block || !buffer); length = block[0]; if (length >= buflen) { - ldm_error ("Truncating string %d -> %d.", length, buflen); + ldm_error("Truncating string %d -> %d.", length, buflen); length = buflen - 1; } - memcpy (buffer, block + 1, length); + memcpy(buffer, block + 1, length); buffer[length] = 0; return length; } @@ -785,22 +792,22 @@ static int ldm_get_vstr (const u8 *block, u8 *buffer, int buflen) * Return: 'true' @vb contains a Component VBLK * 'false' @vb contents are not defined */ -static bool ldm_parse_cmp3 (const u8 *buffer, int buflen, struct vblk *vb) +static bool ldm_parse_cmp3(const u8 *buffer, int buflen, struct vblk *vb) { int r_objid, r_name, r_vstate, r_child, r_parent, r_stripe, r_cols, len; struct vblk_comp *comp; - BUG_ON (!buffer || !vb); + BUG_ON(!buffer || !vb); - r_objid = ldm_relative (buffer, buflen, 0x18, 0); - r_name = ldm_relative (buffer, buflen, 0x18, r_objid); - r_vstate = ldm_relative (buffer, buflen, 0x18, r_name); - r_child = ldm_relative (buffer, buflen, 0x1D, r_vstate); - r_parent = ldm_relative (buffer, buflen, 0x2D, r_child); + r_objid = ldm_relative(buffer, buflen, 0x18, 0); + r_name = ldm_relative(buffer, buflen, 0x18, r_objid); + r_vstate = ldm_relative(buffer, buflen, 0x18, r_name); + r_child = ldm_relative(buffer, buflen, 0x1D, r_vstate); + r_parent = ldm_relative(buffer, buflen, 0x2D, r_child); if (buffer[0x12] & VBLK_FLAG_COMP_STRIPE) { - r_stripe = ldm_relative (buffer, buflen, 0x2E, r_parent); - r_cols = ldm_relative (buffer, buflen, 0x2E, r_stripe); + r_stripe = ldm_relative(buffer, buflen, 0x2E, r_parent); + r_cols = ldm_relative(buffer, buflen, 0x2E, r_stripe); len = r_cols; } else { r_stripe = 0; @@ -815,12 +822,12 @@ static bool ldm_parse_cmp3 (const u8 *buffer, int buflen, struct vblk *vb) return false; comp = &vb->vblk.comp; - ldm_get_vstr (buffer + 0x18 + r_name, comp->state, - sizeof (comp->state)); + ldm_get_vstr(buffer + 0x18 + r_name, comp->state, + sizeof(comp->state)); comp->type = buffer[0x18 + r_vstate]; - comp->children = ldm_get_vnum (buffer + 0x1D + r_vstate); - comp->parent_id = ldm_get_vnum (buffer + 0x2D + r_child); - comp->chunksize = r_stripe ? ldm_get_vnum (buffer+r_parent+0x2E) : 0; + comp->children = ldm_get_vnum(buffer + 0x1D + r_vstate); + comp->parent_id = ldm_get_vnum(buffer + 0x2D + r_child); + comp->chunksize = r_stripe ? ldm_get_vnum(buffer + r_parent + 0x2E) : 0; return true; } @@ -836,20 +843,20 @@ static bool ldm_parse_cmp3 (const u8 *buffer, int buflen, struct vblk *vb) * Return: 'true' @vb contains a Disk Group VBLK * 'false' @vb contents are not defined */ -static int ldm_parse_dgr3 (const u8 *buffer, int buflen, struct vblk *vb) +static int ldm_parse_dgr3(const u8 *buffer, int buflen, struct vblk *vb) { int r_objid, r_name, r_diskid, r_id1, r_id2, len; struct vblk_dgrp *dgrp; - BUG_ON (!buffer || !vb); + BUG_ON(!buffer || !vb); - r_objid = ldm_relative (buffer, buflen, 0x18, 0); - r_name = ldm_relative (buffer, buflen, 0x18, r_objid); - r_diskid = ldm_relative (buffer, buflen, 0x18, r_name); + r_objid = ldm_relative(buffer, buflen, 0x18, 0); + r_name = ldm_relative(buffer, buflen, 0x18, r_objid); + r_diskid = ldm_relative(buffer, buflen, 0x18, r_name); if (buffer[0x12] & VBLK_FLAG_DGR3_IDS) { - r_id1 = ldm_relative (buffer, buflen, 0x24, r_diskid); - r_id2 = ldm_relative (buffer, buflen, 0x24, r_id1); + r_id1 = ldm_relative(buffer, buflen, 0x24, r_diskid); + r_id2 = ldm_relative(buffer, buflen, 0x24, r_id1); len = r_id2; } else { r_id1 = 0; @@ -864,8 +871,8 @@ static int ldm_parse_dgr3 (const u8 *buffer, int buflen, struct vblk *vb) return false; dgrp = &vb->vblk.dgrp; - ldm_get_vstr (buffer + 0x18 + r_name, dgrp->disk_id, - sizeof (dgrp->disk_id)); + ldm_get_vstr(buffer + 0x18 + r_name, dgrp->disk_id, + sizeof(dgrp->disk_id)); return true; } @@ -886,14 +893,14 @@ static bool ldm_parse_dgr4 (const u8 *buffer, int buflen, struct vblk *vb) int r_objid, r_name, r_id1, r_id2, len; struct vblk_dgrp *dgrp; - BUG_ON (!buffer || !vb); + BUG_ON(!buffer || !vb); - r_objid = ldm_relative (buffer, buflen, 0x18, 0); - r_name = ldm_relative (buffer, buflen, 0x18, r_objid); + r_objid = ldm_relative(buffer, buflen, 0x18, 0); + r_name = ldm_relative(buffer, buflen, 0x18, r_objid); if (buffer[0x12] & VBLK_FLAG_DGR4_IDS) { - r_id1 = ldm_relative (buffer, buflen, 0x44, r_name); - r_id2 = ldm_relative (buffer, buflen, 0x44, r_id1); + r_id1 = ldm_relative(buffer, buflen, 0x44, r_name); + r_id2 = ldm_relative(buffer, buflen, 0x44, r_id1); len = r_id2; } else { r_id1 = 0; @@ -909,7 +916,7 @@ static bool ldm_parse_dgr4 (const u8 *buffer, int buflen, struct vblk *vb) dgrp = &vb->vblk.dgrp; - ldm_get_vstr (buffer + 0x18 + r_objid, buf, sizeof (buf)); + ldm_get_vstr(buffer + 0x18 + r_objid, buf, sizeof(buf)); return true; } @@ -924,17 +931,17 @@ static bool ldm_parse_dgr4 (const u8 *buffer, int buflen, struct vblk *vb) * Return: 'true' @vb contains a Disk VBLK * 'false' @vb contents are not defined */ -static bool ldm_parse_dsk3 (const u8 *buffer, int buflen, struct vblk *vb) +static bool ldm_parse_dsk3(const u8 *buffer, int buflen, struct vblk *vb) { int r_objid, r_name, r_diskid, r_altname, len; struct vblk_disk *disk; - BUG_ON (!buffer || !vb); + BUG_ON(!buffer || !vb); - r_objid = ldm_relative (buffer, buflen, 0x18, 0); - r_name = ldm_relative (buffer, buflen, 0x18, r_objid); - r_diskid = ldm_relative (buffer, buflen, 0x18, r_name); - r_altname = ldm_relative (buffer, buflen, 0x18, r_diskid); + r_objid = ldm_relative(buffer, buflen, 0x18, 0); + r_name = ldm_relative(buffer, buflen, 0x18, r_objid); + r_diskid = ldm_relative(buffer, buflen, 0x18, r_name); + r_altname = ldm_relative(buffer, buflen, 0x18, r_diskid); len = r_altname; if (len < 0) return false; @@ -944,9 +951,9 @@ static bool ldm_parse_dsk3 (const u8 *buffer, int buflen, struct vblk *vb) return false; disk = &vb->vblk.disk; - ldm_get_vstr (buffer + 0x18 + r_diskid, disk->alt_name, - sizeof (disk->alt_name)); - if (!ldm_parse_guid (buffer + 0x19 + r_name, disk->disk_id)) + ldm_get_vstr(buffer + 0x18 + r_diskid, disk->alt_name, + sizeof(disk->alt_name)); + if (!ldm_parse_guid(buffer + 0x19 + r_name, disk->disk_id)) return false; return true; @@ -963,15 +970,15 @@ static bool ldm_parse_dsk3 (const u8 *buffer, int buflen, struct vblk *vb) * Return: 'true' @vb contains a Disk VBLK * 'false' @vb contents are not defined */ -static bool ldm_parse_dsk4 (const u8 *buffer, int buflen, struct vblk *vb) +static bool ldm_parse_dsk4(const u8 *buffer, int buflen, struct vblk *vb) { int r_objid, r_name, len; struct vblk_disk *disk; - BUG_ON (!buffer || !vb); + BUG_ON(!buffer || !vb); - r_objid = ldm_relative (buffer, buflen, 0x18, 0); - r_name = ldm_relative (buffer, buflen, 0x18, r_objid); + r_objid = ldm_relative(buffer, buflen, 0x18, 0); + r_name = ldm_relative(buffer, buflen, 0x18, r_objid); len = r_name; if (len < 0) return false; @@ -981,7 +988,7 @@ static bool ldm_parse_dsk4 (const u8 *buffer, int buflen, struct vblk *vb) return false; disk = &vb->vblk.disk; - memcpy (disk->disk_id, buffer + 0x18 + r_name, GUID_SIZE); + memcpy(disk->disk_id, buffer + 0x18 + r_name, GUID_SIZE); return true; } @@ -1181,39 +1188,53 @@ static bool ldm_parse_vol5(const u8 *buffer, int buflen, struct vblk *vb) * Return: 'true' @vb contains a VBLK * 'false' @vb contents are not defined */ -static bool ldm_parse_vblk (const u8 *buf, int len, struct vblk *vb) +static bool ldm_parse_vblk(const u8 *buf, int len, struct vblk *vb) { bool result = false; int r_objid; - BUG_ON (!buf || !vb); + BUG_ON(!buf || !vb); - r_objid = ldm_relative (buf, len, 0x18, 0); + r_objid = ldm_relative(buf, len, 0x18, 0); if (r_objid < 0) { - ldm_error ("VBLK header is corrupt."); + ldm_error("VBLK header is corrupt."); return false; } vb->flags = buf[0x12]; vb->type = buf[0x13]; - vb->obj_id = ldm_get_vnum (buf + 0x18); - ldm_get_vstr (buf+0x18+r_objid, vb->name, sizeof (vb->name)); + vb->obj_id = ldm_get_vnum(buf + 0x18); + ldm_get_vstr(buf + 0x18 + r_objid, vb->name, sizeof(vb->name)); switch (vb->type) { - case VBLK_CMP3: result = ldm_parse_cmp3 (buf, len, vb); break; - case VBLK_DSK3: result = ldm_parse_dsk3 (buf, len, vb); break; - case VBLK_DSK4: result = ldm_parse_dsk4 (buf, len, vb); break; - case VBLK_DGR3: result = ldm_parse_dgr3 (buf, len, vb); break; - case VBLK_DGR4: result = ldm_parse_dgr4 (buf, len, vb); break; - case VBLK_PRT3: result = ldm_parse_prt3 (buf, len, vb); break; - case VBLK_VOL5: result = ldm_parse_vol5 (buf, len, vb); break; + case VBLK_CMP3: + result = ldm_parse_cmp3(buf, len, vb); + break; + case VBLK_DSK3: + result = ldm_parse_dsk3(buf, len, vb); + break; + case VBLK_DSK4: + result = ldm_parse_dsk4(buf, len, vb); + break; + case VBLK_DGR3: + result = ldm_parse_dgr3(buf, len, vb); + break; + case VBLK_DGR4: + result = ldm_parse_dgr4(buf, len, vb); + break; + case VBLK_PRT3: + result = ldm_parse_prt3(buf, len, vb); + break; + case VBLK_VOL5: + result = ldm_parse_vol5(buf, len, vb); + break; } if (result) - ldm_debug ("Parsed VBLK 0x%llx (type: 0x%02x) ok.", + ldm_debug("Parsed VBLK 0x%llx (type: 0x%02x) ok.", (unsigned long long) vb->obj_id, vb->type); else - ldm_error ("Failed to parse VBLK 0x%llx (type: 0x%02x).", + ldm_error("Failed to parse VBLK 0x%llx (type: 0x%02x).", (unsigned long long) vb->obj_id, vb->type); return result; @@ -1238,13 +1259,13 @@ static bool ldm_ldmdb_add (u8 *data, int len, struct ldmdb *ldb) struct vblk *vb; struct list_head *item; - BUG_ON (!data || !ldb); + BUG_ON(!data || !ldb); - vb = kmalloc (sizeof (*vb), GFP_KERNEL); + vb = kmalloc(sizeof(*vb), GFP_KERNEL); if (!vb) return false; - if (!ldm_parse_vblk (data, len, vb)) { + if (!ldm_parse_vblk(data, len, vb)) { kfree(vb); return false; /* Already logged */ } @@ -1253,29 +1274,29 @@ static bool ldm_ldmdb_add (u8 *data, int len, struct ldmdb *ldb) switch (vb->type) { case VBLK_DGR3: case VBLK_DGR4: - list_add (&vb->list, &ldb->v_dgrp); + list_add(&vb->list, &ldb->v_dgrp); break; case VBLK_DSK3: case VBLK_DSK4: - list_add (&vb->list, &ldb->v_disk); + list_add(&vb->list, &ldb->v_disk); break; case VBLK_VOL5: - list_add (&vb->list, &ldb->v_volu); + list_add(&vb->list, &ldb->v_volu); break; case VBLK_CMP3: - list_add (&vb->list, &ldb->v_comp); + list_add(&vb->list, &ldb->v_comp); break; case VBLK_PRT3: /* Sort by the partition's start sector. */ - list_for_each (item, &ldb->v_part) { - struct vblk *v = list_entry (item, struct vblk, list); + list_for_each(item, &ldb->v_part) { + struct vblk *v = list_entry(item, struct vblk, list); if ((v->vblk.part.disk_id == vb->vblk.part.disk_id) && (v->vblk.part.start > vb->vblk.part.start)) { - list_add_tail (&vb->list, &v->list); + list_add_tail(&vb->list, &v->list); return true; } } - list_add_tail (&vb->list, &ldb->v_part); + list_add_tail(&vb->list, &ldb->v_part); break; } return true; @@ -1293,13 +1314,13 @@ static bool ldm_ldmdb_add (u8 *data, int len, struct ldmdb *ldb) * Return: 'true' Success, the VBLK was added to the list * 'false' Error, a problem occurred */ -static bool ldm_frag_add (const u8 *data, int size, struct list_head *frags) +static bool ldm_frag_add(const u8 *data, int size, struct list_head *frags) { struct frag *f; struct list_head *item; int rec, num, group; - BUG_ON (!data || !frags); + BUG_ON(!data || !frags); if (size < 2 * VBLK_SIZE_HEAD) { ldm_error("Value of size is to small."); @@ -1310,7 +1331,7 @@ static bool ldm_frag_add (const u8 *data, int size, struct list_head *frags) rec = get_unaligned_be16(data + 0x0C); num = get_unaligned_be16(data + 0x0E); if ((num < 1) || (num > 4)) { - ldm_error ("A VBLK claims to have %d parts.", num); + ldm_error("A VBLK claims to have %d parts.", num); return false; } if (rec >= num) { @@ -1318,13 +1339,13 @@ static bool ldm_frag_add (const u8 *data, int size, struct list_head *frags) return false; } - list_for_each (item, frags) { - f = list_entry (item, struct frag, list); + list_for_each(item, frags) { + f = list_entry(item, struct frag, list); if (f->group == group) goto found; } - f = kmalloc (sizeof (*f) + size*num, GFP_KERNEL); + f = kmalloc(sizeof(*f) + size*num, GFP_KERNEL); if (!f) return false; @@ -1340,7 +1361,7 @@ found: return false; } if (f->map & (1 << rec)) { - ldm_error ("Duplicate VBLK, part %d.", rec); + ldm_error("Duplicate VBLK, part %d.", rec); f->map &= 0x7F; /* Mark the group as broken */ return false; } @@ -1361,14 +1382,14 @@ found: * * Return: none */ -static void ldm_frag_free (struct list_head *list) +static void ldm_frag_free(struct list_head *list) { struct list_head *item, *tmp; - BUG_ON (!list); + BUG_ON(!list); - list_for_each_safe (item, tmp, list) - kfree (list_entry (item, struct frag, list)); + list_for_each_safe(item, tmp, list) + kfree(list_entry(item, struct frag, list)); } /** @@ -1382,23 +1403,23 @@ static void ldm_frag_free (struct list_head *list) * Return: 'true' All the fragments we added successfully * 'false' One or more of the fragments we invalid */ -static bool ldm_frag_commit (struct list_head *frags, struct ldmdb *ldb) +static bool ldm_frag_commit(struct list_head *frags, struct ldmdb *ldb) { struct frag *f; struct list_head *item; - BUG_ON (!frags || !ldb); + BUG_ON(!frags || !ldb); - list_for_each (item, frags) { - f = list_entry (item, struct frag, list); + list_for_each(item, frags) { + f = list_entry(item, struct frag, list); if (f->map != 0xFF) { - ldm_error ("VBLK group %d is incomplete (0x%02x).", + ldm_error("VBLK group %d is incomplete (0x%02x).", f->group, f->map); return false; } - if (!ldm_ldmdb_add (f->data, f->num*ldb->vm.vblk_size, ldb)) + if (!ldm_ldmdb_add(f->data, f->num*ldb->vm.vblk_size, ldb)) return false; /* Already logged */ } return true; @@ -1435,35 +1456,35 @@ static bool ldm_get_vblks(struct parsed_partitions *state, unsigned long base, for (s = skip; s < finish; s++) { /* For each sector */ data = read_part_sector(state, base + OFF_VMDB + s, §); if (!data) { - ldm_crit ("Disk read failed."); + ldm_crit("Disk read failed."); goto out; } for (v = 0; v < perbuf; v++, data+=size) { /* For each vblk */ if (MAGIC_VBLK != get_unaligned_be32(data)) { - ldm_error ("Expected to find a VBLK."); + ldm_error("Expected to find a VBLK."); goto out; } recs = get_unaligned_be16(data + 0x0E); /* Number of records */ if (recs == 1) { - if (!ldm_ldmdb_add (data, size, ldb)) + if (!ldm_ldmdb_add(data, size, ldb)) goto out; /* Already logged */ } else if (recs > 1) { - if (!ldm_frag_add (data, size, &frags)) + if (!ldm_frag_add(data, size, &frags)) goto out; /* Already logged */ } /* else Record is not in use, ignore it. */ } - put_dev_sector (sect); + put_dev_sector(sect); data = NULL; } - result = ldm_frag_commit (&frags, ldb); /* Failures, already logged */ + result = ldm_frag_commit(&frags, ldb); /* Failures, already logged */ out: if (data) - put_dev_sector (sect); - ldm_frag_free (&frags); + put_dev_sector(sect); + ldm_frag_free(&frags); return result; } @@ -1476,14 +1497,14 @@ out: * * Return: none */ -static void ldm_free_vblks (struct list_head *lh) +static void ldm_free_vblks(struct list_head *lh) { struct list_head *item, *tmp; - BUG_ON (!lh); + BUG_ON(!lh); - list_for_each_safe (item, tmp, lh) - kfree (list_entry (item, struct vblk, list)); + list_for_each_safe(item, tmp, lh) + kfree(list_entry(item, struct vblk, list)); } @@ -1516,7 +1537,7 @@ int ldm_partition(struct parsed_partitions *state) if (!ldm_validate_partition_table(state)) return 0; - ldb = kmalloc (sizeof (*ldb), GFP_KERNEL); + ldb = kmalloc(sizeof(*ldb), GFP_KERNEL); if (!ldb) return -1; @@ -1533,31 +1554,31 @@ int ldm_partition(struct parsed_partitions *state) goto out; /* Already logged */ /* Initialize vblk lists in ldmdb struct */ - INIT_LIST_HEAD (&ldb->v_dgrp); - INIT_LIST_HEAD (&ldb->v_disk); - INIT_LIST_HEAD (&ldb->v_volu); - INIT_LIST_HEAD (&ldb->v_comp); - INIT_LIST_HEAD (&ldb->v_part); + INIT_LIST_HEAD(&ldb->v_dgrp); + INIT_LIST_HEAD(&ldb->v_disk); + INIT_LIST_HEAD(&ldb->v_volu); + INIT_LIST_HEAD(&ldb->v_comp); + INIT_LIST_HEAD(&ldb->v_part); if (!ldm_get_vblks(state, base, ldb)) { - ldm_crit ("Failed to read the VBLKs from the database."); + ldm_crit("Failed to read the VBLKs from the database."); goto cleanup; } /* Finally, create the data partition devices. */ if (ldm_create_data_partitions(state, ldb)) { - ldm_debug ("Parsed LDM database successfully."); + ldm_debug("Parsed LDM database successfully."); result = 1; } /* else Already logged */ cleanup: - ldm_free_vblks (&ldb->v_dgrp); - ldm_free_vblks (&ldb->v_disk); - ldm_free_vblks (&ldb->v_volu); - ldm_free_vblks (&ldb->v_comp); - ldm_free_vblks (&ldb->v_part); + ldm_free_vblks(&ldb->v_dgrp); + ldm_free_vblks(&ldb->v_disk); + ldm_free_vblks(&ldb->v_volu); + ldm_free_vblks(&ldb->v_comp); + ldm_free_vblks(&ldb->v_part); out: - kfree (ldb); + kfree(ldb); return result; } -- 2.6.3
WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net> To: linux-ntfs-dev@lists.sourceforge.net, linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>, Richard Russon <ldm@flatcap.org> Cc: Julia Lawall <julia.lawall@lip6.fr>, LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org Subject: [PATCH 5/5] block-LDM: Fine-tuning for the source code formatting Date: Wed, 23 Dec 2015 18:13:55 +0000 [thread overview] Message-ID: <567AE463.4080702@users.sourceforge.net> (raw) In-Reply-To: <567AE1C6.9020108@users.sourceforge.net> From: Markus Elfring <elfring@users.sourceforge.net> Date: Wed, 23 Dec 2015 17:23:25 +0100 1. Remove some space characters and add a few according to the Linux coding style convention. 2. Reformat a bit of source code also for one switch statement. 3. Apply a few more recommendations from the script "checkpatch.pl". Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- block/partitions/ldm.c | 405 ++++++++++++++++++++++++++----------------------- 1 file changed, 213 insertions(+), 192 deletions(-) diff --git a/block/partitions/ldm.c b/block/partitions/ldm.c index 6fc9150..3ebe033 100644 --- a/block/partitions/ldm.c +++ b/block/partitions/ldm.c @@ -42,12 +42,12 @@ #ifndef CONFIG_LDM_DEBUG #define ldm_debug(...) do {} while (0) #else -#define ldm_debug(f, a...) _ldm_printk (KERN_DEBUG, __func__, f, ##a) +#define ldm_debug(f, a...) _ldm_printk(KERN_DEBUG, __func__, f, ##a) #endif -#define ldm_crit(f, a...) _ldm_printk (KERN_CRIT, __func__, f, ##a) -#define ldm_error(f, a...) _ldm_printk (KERN_ERR, __func__, f, ##a) -#define ldm_info(f, a...) _ldm_printk (KERN_INFO, __func__, f, ##a) +#define ldm_crit(f, a...) _ldm_printk(KERN_CRIT, __func__, f, ##a) +#define ldm_error(f, a...) _ldm_printk(KERN_ERR, __func__, f, ##a) +#define ldm_info(f, a...) _ldm_printk(KERN_INFO, __func__, f, ##a) static __printf(3, 4) void _ldm_printk(const char *level, const char *function, const char *fmt, ...) @@ -55,7 +55,7 @@ void _ldm_printk(const char *level, const char *function, const char *fmt, ...) struct va_format vaf; va_list args; - va_start (args, fmt); + va_start(args, fmt); vaf.fmt = fmt; vaf.va = &args; @@ -74,7 +74,7 @@ void _ldm_printk(const char *level, const char *function, const char *fmt, ...) * Return: 0-255 Success, the byte was parsed correctly * -1 Error, an invalid character was supplied */ -static int ldm_parse_hexbyte (const u8 *src) +static int ldm_parse_hexbyte(const u8 *src) { unsigned int x; /* For correct wrapping */ int h; @@ -102,7 +102,7 @@ static int ldm_parse_hexbyte (const u8 *src) * Return: 'true' @dest contains binary GUID * 'false' @dest contents are undefined */ -static bool ldm_parse_guid (const u8 *src, u8 *dest) +static bool ldm_parse_guid(const u8 *src, u8 *dest) { static const int size[] = { 4, 2, 2, 2, 6 }; int i, j, v; @@ -112,10 +112,11 @@ static bool ldm_parse_guid (const u8 *src, u8 *dest) return false; for (j = 0; j < 5; j++, src++) - for (i = 0; i < size[j]; i++, src+=2, *dest++ = v) - if ((v = ldm_parse_hexbyte (src)) < 0) + for (i = 0; i < size[j]; i++, src += 2, *dest++ = v) { + v = ldm_parse_hexbyte(src); + if (v < 0) return false; - + } return true; } @@ -189,36 +190,36 @@ static bool ldm_parse_privhead(const u8 *data, struct privhead *ph) * Return: 'true' @toc contains the TOCBLOCK data * 'false' @toc contents are undefined */ -static bool ldm_parse_tocblock (const u8 *data, struct tocblock *toc) +static bool ldm_parse_tocblock(const u8 *data, struct tocblock *toc) { - BUG_ON (!data || !toc); + BUG_ON(!data || !toc); if (MAGIC_TOCBLOCK != get_unaligned_be64(data)) { - ldm_crit ("Cannot find TOCBLOCK, database may be corrupt."); + ldm_crit("Cannot find TOCBLOCK, database may be corrupt."); return false; } - strncpy (toc->bitmap1_name, data + 0x24, sizeof (toc->bitmap1_name)); + strncpy(toc->bitmap1_name, data + 0x24, sizeof(toc->bitmap1_name)); toc->bitmap1_name[sizeof (toc->bitmap1_name) - 1] = 0; toc->bitmap1_start = get_unaligned_be64(data + 0x2E); toc->bitmap1_size = get_unaligned_be64(data + 0x36); - if (strncmp (toc->bitmap1_name, TOC_BITMAP1, - sizeof (toc->bitmap1_name)) != 0) { - ldm_crit ("TOCBLOCK's first bitmap is '%s', should be '%s'.", + if (strncmp(toc->bitmap1_name, TOC_BITMAP1, + sizeof(toc->bitmap1_name)) != 0) { + ldm_crit("TOCBLOCK's first bitmap is '%s', should be '%s'.", TOC_BITMAP1, toc->bitmap1_name); return false; } - strncpy (toc->bitmap2_name, data + 0x46, sizeof (toc->bitmap2_name)); - toc->bitmap2_name[sizeof (toc->bitmap2_name) - 1] = 0; + strncpy(toc->bitmap2_name, data + 0x46, sizeof(toc->bitmap2_name)); + toc->bitmap2_name[sizeof(toc->bitmap2_name) - 1] = 0; toc->bitmap2_start = get_unaligned_be64(data + 0x50); toc->bitmap2_size = get_unaligned_be64(data + 0x58); - if (strncmp (toc->bitmap2_name, TOC_BITMAP2, - sizeof (toc->bitmap2_name)) != 0) { - ldm_crit ("TOCBLOCK's second bitmap is '%s', should be '%s'.", + if (strncmp(toc->bitmap2_name, TOC_BITMAP2, + sizeof(toc->bitmap2_name)) != 0) { + ldm_crit("TOCBLOCK's second bitmap is '%s', should be '%s'.", TOC_BITMAP2, toc->bitmap2_name); return false; } - ldm_debug ("Parsed TOCBLOCK successfully."); + ldm_debug("Parsed TOCBLOCK successfully."); return true; } @@ -235,33 +236,33 @@ static bool ldm_parse_tocblock (const u8 *data, struct tocblock *toc) * Return: 'true' @vm contains VMDB info * 'false' @vm contents are undefined */ -static bool ldm_parse_vmdb (const u8 *data, struct vmdb *vm) +static bool ldm_parse_vmdb(const u8 *data, struct vmdb *vm) { - BUG_ON (!data || !vm); + BUG_ON(!data || !vm); if (MAGIC_VMDB != get_unaligned_be32(data)) { - ldm_crit ("Cannot find the VMDB, database may be corrupt."); + ldm_crit("Cannot find the VMDB, database may be corrupt."); return false; } vm->ver_major = get_unaligned_be16(data + 0x12); vm->ver_minor = get_unaligned_be16(data + 0x14); if ((vm->ver_major != 4) || (vm->ver_minor != 10)) { - ldm_error ("Expected VMDB version %d.%d, got %d.%d. " + ldm_error("Expected VMDB version %d.%d, got %d.%d. " "Aborting.", 4, 10, vm->ver_major, vm->ver_minor); return false; } vm->vblk_size = get_unaligned_be32(data + 0x08); if (vm->vblk_size = 0) { - ldm_error ("Illegal VBLK size"); + ldm_error("Illegal VBLK size"); return false; } vm->vblk_offset = get_unaligned_be32(data + 0x0C); vm->last_vblk_seq = get_unaligned_be32(data + 0x04); - ldm_debug ("Parsed VMDB successfully."); + ldm_debug("Parsed VMDB successfully."); return true; } @@ -275,10 +276,10 @@ static bool ldm_parse_vmdb (const u8 *data, struct vmdb *vm) * Return: 'true' Identical * 'false' Different */ -static bool ldm_compare_privheads (const struct privhead *ph1, +static bool ldm_compare_privheads(const struct privhead *ph1, const struct privhead *ph2) { - BUG_ON (!ph1 || !ph2); + BUG_ON(!ph1 || !ph2); return ((ph1->ver_major = ph2->ver_major) && (ph1->ver_minor = ph2->ver_minor) && @@ -286,7 +287,7 @@ static bool ldm_compare_privheads (const struct privhead *ph1, (ph1->logical_disk_size = ph2->logical_disk_size) && (ph1->config_start = ph2->config_start) && (ph1->config_size = ph2->config_size) && - !memcmp (ph1->disk_id, ph2->disk_id, GUID_SIZE)); + !memcmp(ph1->disk_id, ph2->disk_id, GUID_SIZE)); } /** @@ -299,19 +300,19 @@ static bool ldm_compare_privheads (const struct privhead *ph1, * Return: 'true' Identical * 'false' Different */ -static bool ldm_compare_tocblocks (const struct tocblock *toc1, +static bool ldm_compare_tocblocks(const struct tocblock *toc1, const struct tocblock *toc2) { - BUG_ON (!toc1 || !toc2); + BUG_ON(!toc1 || !toc2); return ((toc1->bitmap1_start = toc2->bitmap1_start) && (toc1->bitmap1_size = toc2->bitmap1_size) && (toc1->bitmap2_start = toc2->bitmap2_start) && (toc1->bitmap2_size = toc2->bitmap2_size) && - !strncmp (toc1->bitmap1_name, toc2->bitmap1_name, - sizeof (toc1->bitmap1_name)) && - !strncmp (toc1->bitmap2_name, toc2->bitmap2_name, - sizeof (toc1->bitmap2_name))); + !strncmp(toc1->bitmap1_name, toc2->bitmap1_name, + sizeof(toc1->bitmap1_name)) && + !strncmp(toc1->bitmap2_name, toc2->bitmap2_name, + sizeof(toc1->bitmap2_name))); } /** @@ -339,12 +340,12 @@ static bool ldm_validate_privheads(struct parsed_partitions *state, long num_sects; int i; - BUG_ON (!state || !ph1); + BUG_ON(!state || !ph1); - ph[1] = kmalloc (sizeof (*ph[1]), GFP_KERNEL); + ph[1] = kmalloc(sizeof(*ph[1]), GFP_KERNEL); if (!ph[1]) return false; - ph[2] = kmalloc (sizeof (*ph[2]), GFP_KERNEL); + ph[2] = kmalloc(sizeof(*ph[2]), GFP_KERNEL); if (!ph[2]) { result = false; goto free_a_head; @@ -358,18 +359,23 @@ static bool ldm_validate_privheads(struct parsed_partitions *state, data = read_part_sector(state, ph[0]->config_start + off[i], §); if (!data) { - ldm_crit ("Disk read failed."); + ldm_crit("Disk read failed."); result = false; goto free_another_head; } - result = ldm_parse_privhead (data, ph[i]); + result = ldm_parse_privhead(data, ph[i]); put_dev_sector (sect); if (!result) { - ldm_error ("Cannot find PRIVHEAD %d.", i+1); /* Log again */ + /* Log again */ + ldm_error("Cannot find PRIVHEAD %d.", i + 1); if (i < 2) goto free_another_head; /* Already logged */ else - break; /* FIXME ignore for now, 3rd PH can fail on odd-sized disks */ + /* + * FIXME: ignore for now, + * 3rd PH can fail on odd-sized disks + */ + break; } } @@ -377,19 +383,19 @@ static bool ldm_validate_privheads(struct parsed_partitions *state, if ((ph[0]->config_start > num_sects) || ((ph[0]->config_start + ph[0]->config_size) > num_sects)) { - ldm_crit ("Database extends beyond the end of the disk."); + ldm_crit("Database extends beyond the end of the disk."); goto free_another_head; } if ((ph[0]->logical_disk_start > ph[0]->config_start) || ((ph[0]->logical_disk_start + ph[0]->logical_disk_size) > ph[0]->config_start)) { - ldm_crit ("Disk and database overlap."); + ldm_crit("Disk and database overlap."); goto free_another_head; } - if (!ldm_compare_privheads (ph[0], ph[1])) { - ldm_crit ("Primary and backup PRIVHEADs don't match."); + if (!ldm_compare_privheads(ph[0], ph[1])) { + ldm_crit("Primary and backup PRIVHEADs don't match."); goto free_another_head; } /* FIXME ignore this for now @@ -397,7 +403,7 @@ static bool ldm_validate_privheads(struct parsed_partitions *state, ldm_crit ("Primary and backup PRIVHEADs don't match."); goto free_another_head; }*/ - ldm_debug ("Validated PRIVHEADs successfully."); + ldm_debug("Validated PRIVHEADs successfully."); result = true; free_another_head: kfree(ph[2]); @@ -501,42 +507,42 @@ static bool ldm_validate_vmdb(struct parsed_partitions *state, struct vmdb *vm; struct tocblock *toc; - BUG_ON (!state || !ldb); + BUG_ON(!state || !ldb); vm = &ldb->vm; toc = &ldb->toc; data = read_part_sector(state, base + OFF_VMDB, §); if (!data) { - ldm_crit ("Disk read failed."); + ldm_crit("Disk read failed."); return false; } - if (!ldm_parse_vmdb (data, vm)) + if (!ldm_parse_vmdb(data, vm)) goto out; /* Already logged */ /* Are there uncommitted transactions? */ if (get_unaligned_be16(data + 0x10) != 0x01) { - ldm_crit ("Database is not in a consistent state. Aborting."); + ldm_crit("Database is not in a consistent state. Aborting."); goto out; } if (vm->vblk_offset != 512) - ldm_info ("VBLKs start at offset 0x%04x.", vm->vblk_offset); + ldm_info("VBLKs start at offset 0x%04x.", vm->vblk_offset); /* * The last_vblkd_seq can be before the end of the vmdb, just make sure * it is not out of bounds. */ if ((vm->vblk_size * vm->last_vblk_seq) > (toc->bitmap1_size << 9)) { - ldm_crit ("VMDB exceeds allowed size specified by TOCBLOCK. " + ldm_crit("VMDB exceeds allowed size specified by TOCBLOCK. " "Database is corrupt. Aborting."); goto out; } result = true; out: - put_dev_sector (sect); + put_dev_sector(sect); return result; } @@ -569,11 +575,11 @@ static bool ldm_validate_partition_table(struct parsed_partitions *state) data = read_part_sector(state, 0, §); if (!data) { - ldm_info ("Disk read failed."); + ldm_info("Disk read failed."); return false; } - if (*(__le16*) (data + 0x01FE) != cpu_to_le16 (MSDOS_LABEL_MAGIC)) + if (*(__le16 *) (data + 0x01FE) != cpu_to_le16(MSDOS_LABEL_MAGIC)) goto out; p = (struct partition*)(data + 0x01BE); @@ -584,10 +590,10 @@ static bool ldm_validate_partition_table(struct parsed_partitions *state) } if (result) - ldm_debug ("Found W2K dynamic disk partition type."); + ldm_debug("Found W2K dynamic disk partition type."); out: - put_dev_sector (sect); + put_dev_sector(sect); return result; } @@ -603,15 +609,16 @@ out: * Return: Pointer, A matching vblk was found * NULL, No match, or an error */ -static struct vblk * ldm_get_disk_objid (const struct ldmdb *ldb) +static struct vblk *ldm_get_disk_objid(const struct ldmdb *ldb) { struct list_head *item; - BUG_ON (!ldb); + BUG_ON(!ldb); - list_for_each (item, &ldb->v_disk) { - struct vblk *v = list_entry (item, struct vblk, list); - if (!memcmp (v->vblk.disk.disk_id, ldb->ph.disk_id, GUID_SIZE)) + list_for_each(item, &ldb->v_disk) { + struct vblk *v = list_entry(item, struct vblk, list); + + if (!memcmp(v->vblk.disk.disk_id, ldb->ph.disk_id, GUID_SIZE)) return v; } @@ -635,7 +642,7 @@ static struct vblk * ldm_get_disk_objid (const struct ldmdb *ldb) * Return: 'true' Partition created * 'false' Error, probably a range checking problem */ -static bool ldm_create_data_partitions (struct parsed_partitions *pp, +static bool ldm_create_data_partitions(struct parsed_partitions *pp, const struct ldmdb *ldb) { struct list_head *item; @@ -644,25 +651,25 @@ static bool ldm_create_data_partitions (struct parsed_partitions *pp, struct vblk_part *part; int part_num = 1; - BUG_ON (!pp || !ldb); + BUG_ON(!pp || !ldb); - disk = ldm_get_disk_objid (ldb); + disk = ldm_get_disk_objid(ldb); if (!disk) { - ldm_crit ("Can't find the ID of this disk in the database."); + ldm_crit("Can't find the ID of this disk in the database."); return false; } strlcat(pp->pp_buf, " [LDM]", PAGE_SIZE); /* Create the data partitions */ - list_for_each (item, &ldb->v_part) { - vb = list_entry (item, struct vblk, list); + list_for_each(item, &ldb->v_part) { + vb = list_entry(item, struct vblk, list); part = &vb->vblk.part; if (part->disk_id != disk->obj_id) continue; - put_partition (pp, part_num, ldb->ph.logical_disk_start + + put_partition(pp, part_num, ldb->ph.logical_disk_start + part->start, part->size); part_num++; } @@ -722,12 +729,12 @@ static int ldm_relative(const u8 *buffer, int buflen, int base, int offset) * Return: n A number * 0 Zero, or an error occurred */ -static u64 ldm_get_vnum (const u8 *block) +static u64 ldm_get_vnum(const u8 *block) { u64 tmp = 0; u8 length; - BUG_ON (!block); + BUG_ON(!block); length = *block++; @@ -735,7 +742,7 @@ static u64 ldm_get_vnum (const u8 *block) while (length--) tmp = (tmp << 8) | *block++; else - ldm_error ("Illegal length %d.", length); + ldm_error("Illegal length %d.", length); return tmp; } @@ -757,18 +764,18 @@ static u64 ldm_get_vnum (const u8 *block) * n, String length in characters (excluding NULL) * buflen-1, String was truncated. */ -static int ldm_get_vstr (const u8 *block, u8 *buffer, int buflen) +static int ldm_get_vstr(const u8 *block, u8 *buffer, int buflen) { int length; - BUG_ON (!block || !buffer); + BUG_ON(!block || !buffer); length = block[0]; if (length >= buflen) { - ldm_error ("Truncating string %d -> %d.", length, buflen); + ldm_error("Truncating string %d -> %d.", length, buflen); length = buflen - 1; } - memcpy (buffer, block + 1, length); + memcpy(buffer, block + 1, length); buffer[length] = 0; return length; } @@ -785,22 +792,22 @@ static int ldm_get_vstr (const u8 *block, u8 *buffer, int buflen) * Return: 'true' @vb contains a Component VBLK * 'false' @vb contents are not defined */ -static bool ldm_parse_cmp3 (const u8 *buffer, int buflen, struct vblk *vb) +static bool ldm_parse_cmp3(const u8 *buffer, int buflen, struct vblk *vb) { int r_objid, r_name, r_vstate, r_child, r_parent, r_stripe, r_cols, len; struct vblk_comp *comp; - BUG_ON (!buffer || !vb); + BUG_ON(!buffer || !vb); - r_objid = ldm_relative (buffer, buflen, 0x18, 0); - r_name = ldm_relative (buffer, buflen, 0x18, r_objid); - r_vstate = ldm_relative (buffer, buflen, 0x18, r_name); - r_child = ldm_relative (buffer, buflen, 0x1D, r_vstate); - r_parent = ldm_relative (buffer, buflen, 0x2D, r_child); + r_objid = ldm_relative(buffer, buflen, 0x18, 0); + r_name = ldm_relative(buffer, buflen, 0x18, r_objid); + r_vstate = ldm_relative(buffer, buflen, 0x18, r_name); + r_child = ldm_relative(buffer, buflen, 0x1D, r_vstate); + r_parent = ldm_relative(buffer, buflen, 0x2D, r_child); if (buffer[0x12] & VBLK_FLAG_COMP_STRIPE) { - r_stripe = ldm_relative (buffer, buflen, 0x2E, r_parent); - r_cols = ldm_relative (buffer, buflen, 0x2E, r_stripe); + r_stripe = ldm_relative(buffer, buflen, 0x2E, r_parent); + r_cols = ldm_relative(buffer, buflen, 0x2E, r_stripe); len = r_cols; } else { r_stripe = 0; @@ -815,12 +822,12 @@ static bool ldm_parse_cmp3 (const u8 *buffer, int buflen, struct vblk *vb) return false; comp = &vb->vblk.comp; - ldm_get_vstr (buffer + 0x18 + r_name, comp->state, - sizeof (comp->state)); + ldm_get_vstr(buffer + 0x18 + r_name, comp->state, + sizeof(comp->state)); comp->type = buffer[0x18 + r_vstate]; - comp->children = ldm_get_vnum (buffer + 0x1D + r_vstate); - comp->parent_id = ldm_get_vnum (buffer + 0x2D + r_child); - comp->chunksize = r_stripe ? ldm_get_vnum (buffer+r_parent+0x2E) : 0; + comp->children = ldm_get_vnum(buffer + 0x1D + r_vstate); + comp->parent_id = ldm_get_vnum(buffer + 0x2D + r_child); + comp->chunksize = r_stripe ? ldm_get_vnum(buffer + r_parent + 0x2E) : 0; return true; } @@ -836,20 +843,20 @@ static bool ldm_parse_cmp3 (const u8 *buffer, int buflen, struct vblk *vb) * Return: 'true' @vb contains a Disk Group VBLK * 'false' @vb contents are not defined */ -static int ldm_parse_dgr3 (const u8 *buffer, int buflen, struct vblk *vb) +static int ldm_parse_dgr3(const u8 *buffer, int buflen, struct vblk *vb) { int r_objid, r_name, r_diskid, r_id1, r_id2, len; struct vblk_dgrp *dgrp; - BUG_ON (!buffer || !vb); + BUG_ON(!buffer || !vb); - r_objid = ldm_relative (buffer, buflen, 0x18, 0); - r_name = ldm_relative (buffer, buflen, 0x18, r_objid); - r_diskid = ldm_relative (buffer, buflen, 0x18, r_name); + r_objid = ldm_relative(buffer, buflen, 0x18, 0); + r_name = ldm_relative(buffer, buflen, 0x18, r_objid); + r_diskid = ldm_relative(buffer, buflen, 0x18, r_name); if (buffer[0x12] & VBLK_FLAG_DGR3_IDS) { - r_id1 = ldm_relative (buffer, buflen, 0x24, r_diskid); - r_id2 = ldm_relative (buffer, buflen, 0x24, r_id1); + r_id1 = ldm_relative(buffer, buflen, 0x24, r_diskid); + r_id2 = ldm_relative(buffer, buflen, 0x24, r_id1); len = r_id2; } else { r_id1 = 0; @@ -864,8 +871,8 @@ static int ldm_parse_dgr3 (const u8 *buffer, int buflen, struct vblk *vb) return false; dgrp = &vb->vblk.dgrp; - ldm_get_vstr (buffer + 0x18 + r_name, dgrp->disk_id, - sizeof (dgrp->disk_id)); + ldm_get_vstr(buffer + 0x18 + r_name, dgrp->disk_id, + sizeof(dgrp->disk_id)); return true; } @@ -886,14 +893,14 @@ static bool ldm_parse_dgr4 (const u8 *buffer, int buflen, struct vblk *vb) int r_objid, r_name, r_id1, r_id2, len; struct vblk_dgrp *dgrp; - BUG_ON (!buffer || !vb); + BUG_ON(!buffer || !vb); - r_objid = ldm_relative (buffer, buflen, 0x18, 0); - r_name = ldm_relative (buffer, buflen, 0x18, r_objid); + r_objid = ldm_relative(buffer, buflen, 0x18, 0); + r_name = ldm_relative(buffer, buflen, 0x18, r_objid); if (buffer[0x12] & VBLK_FLAG_DGR4_IDS) { - r_id1 = ldm_relative (buffer, buflen, 0x44, r_name); - r_id2 = ldm_relative (buffer, buflen, 0x44, r_id1); + r_id1 = ldm_relative(buffer, buflen, 0x44, r_name); + r_id2 = ldm_relative(buffer, buflen, 0x44, r_id1); len = r_id2; } else { r_id1 = 0; @@ -909,7 +916,7 @@ static bool ldm_parse_dgr4 (const u8 *buffer, int buflen, struct vblk *vb) dgrp = &vb->vblk.dgrp; - ldm_get_vstr (buffer + 0x18 + r_objid, buf, sizeof (buf)); + ldm_get_vstr(buffer + 0x18 + r_objid, buf, sizeof(buf)); return true; } @@ -924,17 +931,17 @@ static bool ldm_parse_dgr4 (const u8 *buffer, int buflen, struct vblk *vb) * Return: 'true' @vb contains a Disk VBLK * 'false' @vb contents are not defined */ -static bool ldm_parse_dsk3 (const u8 *buffer, int buflen, struct vblk *vb) +static bool ldm_parse_dsk3(const u8 *buffer, int buflen, struct vblk *vb) { int r_objid, r_name, r_diskid, r_altname, len; struct vblk_disk *disk; - BUG_ON (!buffer || !vb); + BUG_ON(!buffer || !vb); - r_objid = ldm_relative (buffer, buflen, 0x18, 0); - r_name = ldm_relative (buffer, buflen, 0x18, r_objid); - r_diskid = ldm_relative (buffer, buflen, 0x18, r_name); - r_altname = ldm_relative (buffer, buflen, 0x18, r_diskid); + r_objid = ldm_relative(buffer, buflen, 0x18, 0); + r_name = ldm_relative(buffer, buflen, 0x18, r_objid); + r_diskid = ldm_relative(buffer, buflen, 0x18, r_name); + r_altname = ldm_relative(buffer, buflen, 0x18, r_diskid); len = r_altname; if (len < 0) return false; @@ -944,9 +951,9 @@ static bool ldm_parse_dsk3 (const u8 *buffer, int buflen, struct vblk *vb) return false; disk = &vb->vblk.disk; - ldm_get_vstr (buffer + 0x18 + r_diskid, disk->alt_name, - sizeof (disk->alt_name)); - if (!ldm_parse_guid (buffer + 0x19 + r_name, disk->disk_id)) + ldm_get_vstr(buffer + 0x18 + r_diskid, disk->alt_name, + sizeof(disk->alt_name)); + if (!ldm_parse_guid(buffer + 0x19 + r_name, disk->disk_id)) return false; return true; @@ -963,15 +970,15 @@ static bool ldm_parse_dsk3 (const u8 *buffer, int buflen, struct vblk *vb) * Return: 'true' @vb contains a Disk VBLK * 'false' @vb contents are not defined */ -static bool ldm_parse_dsk4 (const u8 *buffer, int buflen, struct vblk *vb) +static bool ldm_parse_dsk4(const u8 *buffer, int buflen, struct vblk *vb) { int r_objid, r_name, len; struct vblk_disk *disk; - BUG_ON (!buffer || !vb); + BUG_ON(!buffer || !vb); - r_objid = ldm_relative (buffer, buflen, 0x18, 0); - r_name = ldm_relative (buffer, buflen, 0x18, r_objid); + r_objid = ldm_relative(buffer, buflen, 0x18, 0); + r_name = ldm_relative(buffer, buflen, 0x18, r_objid); len = r_name; if (len < 0) return false; @@ -981,7 +988,7 @@ static bool ldm_parse_dsk4 (const u8 *buffer, int buflen, struct vblk *vb) return false; disk = &vb->vblk.disk; - memcpy (disk->disk_id, buffer + 0x18 + r_name, GUID_SIZE); + memcpy(disk->disk_id, buffer + 0x18 + r_name, GUID_SIZE); return true; } @@ -1181,39 +1188,53 @@ static bool ldm_parse_vol5(const u8 *buffer, int buflen, struct vblk *vb) * Return: 'true' @vb contains a VBLK * 'false' @vb contents are not defined */ -static bool ldm_parse_vblk (const u8 *buf, int len, struct vblk *vb) +static bool ldm_parse_vblk(const u8 *buf, int len, struct vblk *vb) { bool result = false; int r_objid; - BUG_ON (!buf || !vb); + BUG_ON(!buf || !vb); - r_objid = ldm_relative (buf, len, 0x18, 0); + r_objid = ldm_relative(buf, len, 0x18, 0); if (r_objid < 0) { - ldm_error ("VBLK header is corrupt."); + ldm_error("VBLK header is corrupt."); return false; } vb->flags = buf[0x12]; vb->type = buf[0x13]; - vb->obj_id = ldm_get_vnum (buf + 0x18); - ldm_get_vstr (buf+0x18+r_objid, vb->name, sizeof (vb->name)); + vb->obj_id = ldm_get_vnum(buf + 0x18); + ldm_get_vstr(buf + 0x18 + r_objid, vb->name, sizeof(vb->name)); switch (vb->type) { - case VBLK_CMP3: result = ldm_parse_cmp3 (buf, len, vb); break; - case VBLK_DSK3: result = ldm_parse_dsk3 (buf, len, vb); break; - case VBLK_DSK4: result = ldm_parse_dsk4 (buf, len, vb); break; - case VBLK_DGR3: result = ldm_parse_dgr3 (buf, len, vb); break; - case VBLK_DGR4: result = ldm_parse_dgr4 (buf, len, vb); break; - case VBLK_PRT3: result = ldm_parse_prt3 (buf, len, vb); break; - case VBLK_VOL5: result = ldm_parse_vol5 (buf, len, vb); break; + case VBLK_CMP3: + result = ldm_parse_cmp3(buf, len, vb); + break; + case VBLK_DSK3: + result = ldm_parse_dsk3(buf, len, vb); + break; + case VBLK_DSK4: + result = ldm_parse_dsk4(buf, len, vb); + break; + case VBLK_DGR3: + result = ldm_parse_dgr3(buf, len, vb); + break; + case VBLK_DGR4: + result = ldm_parse_dgr4(buf, len, vb); + break; + case VBLK_PRT3: + result = ldm_parse_prt3(buf, len, vb); + break; + case VBLK_VOL5: + result = ldm_parse_vol5(buf, len, vb); + break; } if (result) - ldm_debug ("Parsed VBLK 0x%llx (type: 0x%02x) ok.", + ldm_debug("Parsed VBLK 0x%llx (type: 0x%02x) ok.", (unsigned long long) vb->obj_id, vb->type); else - ldm_error ("Failed to parse VBLK 0x%llx (type: 0x%02x).", + ldm_error("Failed to parse VBLK 0x%llx (type: 0x%02x).", (unsigned long long) vb->obj_id, vb->type); return result; @@ -1238,13 +1259,13 @@ static bool ldm_ldmdb_add (u8 *data, int len, struct ldmdb *ldb) struct vblk *vb; struct list_head *item; - BUG_ON (!data || !ldb); + BUG_ON(!data || !ldb); - vb = kmalloc (sizeof (*vb), GFP_KERNEL); + vb = kmalloc(sizeof(*vb), GFP_KERNEL); if (!vb) return false; - if (!ldm_parse_vblk (data, len, vb)) { + if (!ldm_parse_vblk(data, len, vb)) { kfree(vb); return false; /* Already logged */ } @@ -1253,29 +1274,29 @@ static bool ldm_ldmdb_add (u8 *data, int len, struct ldmdb *ldb) switch (vb->type) { case VBLK_DGR3: case VBLK_DGR4: - list_add (&vb->list, &ldb->v_dgrp); + list_add(&vb->list, &ldb->v_dgrp); break; case VBLK_DSK3: case VBLK_DSK4: - list_add (&vb->list, &ldb->v_disk); + list_add(&vb->list, &ldb->v_disk); break; case VBLK_VOL5: - list_add (&vb->list, &ldb->v_volu); + list_add(&vb->list, &ldb->v_volu); break; case VBLK_CMP3: - list_add (&vb->list, &ldb->v_comp); + list_add(&vb->list, &ldb->v_comp); break; case VBLK_PRT3: /* Sort by the partition's start sector. */ - list_for_each (item, &ldb->v_part) { - struct vblk *v = list_entry (item, struct vblk, list); + list_for_each(item, &ldb->v_part) { + struct vblk *v = list_entry(item, struct vblk, list); if ((v->vblk.part.disk_id = vb->vblk.part.disk_id) && (v->vblk.part.start > vb->vblk.part.start)) { - list_add_tail (&vb->list, &v->list); + list_add_tail(&vb->list, &v->list); return true; } } - list_add_tail (&vb->list, &ldb->v_part); + list_add_tail(&vb->list, &ldb->v_part); break; } return true; @@ -1293,13 +1314,13 @@ static bool ldm_ldmdb_add (u8 *data, int len, struct ldmdb *ldb) * Return: 'true' Success, the VBLK was added to the list * 'false' Error, a problem occurred */ -static bool ldm_frag_add (const u8 *data, int size, struct list_head *frags) +static bool ldm_frag_add(const u8 *data, int size, struct list_head *frags) { struct frag *f; struct list_head *item; int rec, num, group; - BUG_ON (!data || !frags); + BUG_ON(!data || !frags); if (size < 2 * VBLK_SIZE_HEAD) { ldm_error("Value of size is to small."); @@ -1310,7 +1331,7 @@ static bool ldm_frag_add (const u8 *data, int size, struct list_head *frags) rec = get_unaligned_be16(data + 0x0C); num = get_unaligned_be16(data + 0x0E); if ((num < 1) || (num > 4)) { - ldm_error ("A VBLK claims to have %d parts.", num); + ldm_error("A VBLK claims to have %d parts.", num); return false; } if (rec >= num) { @@ -1318,13 +1339,13 @@ static bool ldm_frag_add (const u8 *data, int size, struct list_head *frags) return false; } - list_for_each (item, frags) { - f = list_entry (item, struct frag, list); + list_for_each(item, frags) { + f = list_entry(item, struct frag, list); if (f->group = group) goto found; } - f = kmalloc (sizeof (*f) + size*num, GFP_KERNEL); + f = kmalloc(sizeof(*f) + size*num, GFP_KERNEL); if (!f) return false; @@ -1340,7 +1361,7 @@ found: return false; } if (f->map & (1 << rec)) { - ldm_error ("Duplicate VBLK, part %d.", rec); + ldm_error("Duplicate VBLK, part %d.", rec); f->map &= 0x7F; /* Mark the group as broken */ return false; } @@ -1361,14 +1382,14 @@ found: * * Return: none */ -static void ldm_frag_free (struct list_head *list) +static void ldm_frag_free(struct list_head *list) { struct list_head *item, *tmp; - BUG_ON (!list); + BUG_ON(!list); - list_for_each_safe (item, tmp, list) - kfree (list_entry (item, struct frag, list)); + list_for_each_safe(item, tmp, list) + kfree(list_entry(item, struct frag, list)); } /** @@ -1382,23 +1403,23 @@ static void ldm_frag_free (struct list_head *list) * Return: 'true' All the fragments we added successfully * 'false' One or more of the fragments we invalid */ -static bool ldm_frag_commit (struct list_head *frags, struct ldmdb *ldb) +static bool ldm_frag_commit(struct list_head *frags, struct ldmdb *ldb) { struct frag *f; struct list_head *item; - BUG_ON (!frags || !ldb); + BUG_ON(!frags || !ldb); - list_for_each (item, frags) { - f = list_entry (item, struct frag, list); + list_for_each(item, frags) { + f = list_entry(item, struct frag, list); if (f->map != 0xFF) { - ldm_error ("VBLK group %d is incomplete (0x%02x).", + ldm_error("VBLK group %d is incomplete (0x%02x).", f->group, f->map); return false; } - if (!ldm_ldmdb_add (f->data, f->num*ldb->vm.vblk_size, ldb)) + if (!ldm_ldmdb_add(f->data, f->num*ldb->vm.vblk_size, ldb)) return false; /* Already logged */ } return true; @@ -1435,35 +1456,35 @@ static bool ldm_get_vblks(struct parsed_partitions *state, unsigned long base, for (s = skip; s < finish; s++) { /* For each sector */ data = read_part_sector(state, base + OFF_VMDB + s, §); if (!data) { - ldm_crit ("Disk read failed."); + ldm_crit("Disk read failed."); goto out; } for (v = 0; v < perbuf; v++, data+=size) { /* For each vblk */ if (MAGIC_VBLK != get_unaligned_be32(data)) { - ldm_error ("Expected to find a VBLK."); + ldm_error("Expected to find a VBLK."); goto out; } recs = get_unaligned_be16(data + 0x0E); /* Number of records */ if (recs = 1) { - if (!ldm_ldmdb_add (data, size, ldb)) + if (!ldm_ldmdb_add(data, size, ldb)) goto out; /* Already logged */ } else if (recs > 1) { - if (!ldm_frag_add (data, size, &frags)) + if (!ldm_frag_add(data, size, &frags)) goto out; /* Already logged */ } /* else Record is not in use, ignore it. */ } - put_dev_sector (sect); + put_dev_sector(sect); data = NULL; } - result = ldm_frag_commit (&frags, ldb); /* Failures, already logged */ + result = ldm_frag_commit(&frags, ldb); /* Failures, already logged */ out: if (data) - put_dev_sector (sect); - ldm_frag_free (&frags); + put_dev_sector(sect); + ldm_frag_free(&frags); return result; } @@ -1476,14 +1497,14 @@ out: * * Return: none */ -static void ldm_free_vblks (struct list_head *lh) +static void ldm_free_vblks(struct list_head *lh) { struct list_head *item, *tmp; - BUG_ON (!lh); + BUG_ON(!lh); - list_for_each_safe (item, tmp, lh) - kfree (list_entry (item, struct vblk, list)); + list_for_each_safe(item, tmp, lh) + kfree(list_entry(item, struct vblk, list)); } @@ -1516,7 +1537,7 @@ int ldm_partition(struct parsed_partitions *state) if (!ldm_validate_partition_table(state)) return 0; - ldb = kmalloc (sizeof (*ldb), GFP_KERNEL); + ldb = kmalloc(sizeof(*ldb), GFP_KERNEL); if (!ldb) return -1; @@ -1533,31 +1554,31 @@ int ldm_partition(struct parsed_partitions *state) goto out; /* Already logged */ /* Initialize vblk lists in ldmdb struct */ - INIT_LIST_HEAD (&ldb->v_dgrp); - INIT_LIST_HEAD (&ldb->v_disk); - INIT_LIST_HEAD (&ldb->v_volu); - INIT_LIST_HEAD (&ldb->v_comp); - INIT_LIST_HEAD (&ldb->v_part); + INIT_LIST_HEAD(&ldb->v_dgrp); + INIT_LIST_HEAD(&ldb->v_disk); + INIT_LIST_HEAD(&ldb->v_volu); + INIT_LIST_HEAD(&ldb->v_comp); + INIT_LIST_HEAD(&ldb->v_part); if (!ldm_get_vblks(state, base, ldb)) { - ldm_crit ("Failed to read the VBLKs from the database."); + ldm_crit("Failed to read the VBLKs from the database."); goto cleanup; } /* Finally, create the data partition devices. */ if (ldm_create_data_partitions(state, ldb)) { - ldm_debug ("Parsed LDM database successfully."); + ldm_debug("Parsed LDM database successfully."); result = 1; } /* else Already logged */ cleanup: - ldm_free_vblks (&ldb->v_dgrp); - ldm_free_vblks (&ldb->v_disk); - ldm_free_vblks (&ldb->v_volu); - ldm_free_vblks (&ldb->v_comp); - ldm_free_vblks (&ldb->v_part); + ldm_free_vblks(&ldb->v_dgrp); + ldm_free_vblks(&ldb->v_disk); + ldm_free_vblks(&ldb->v_volu); + ldm_free_vblks(&ldb->v_comp); + ldm_free_vblks(&ldb->v_part); out: - kfree (ldb); + kfree(ldb); return result; } -- 2.6.3
next prev parent reply other threads:[~2015-12-23 18:14 UTC|newest] Thread overview: 3089+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-12-11 12:08 Source code review around jump label usage SF Markus Elfring 2015-12-11 12:08 ` SF Markus Elfring 2015-12-11 12:14 ` Julia Lawall 2015-12-11 12:14 ` Julia Lawall 2015-12-11 12:48 ` Dan Carpenter 2015-12-11 12:48 ` Dan Carpenter 2015-12-11 18:00 ` Christophe JAILLET 2015-12-11 18:19 ` [PATCH 0/2] block: Fine-tuning for two function implementations SF Markus Elfring 2015-12-11 18:19 ` SF Markus Elfring 2015-12-11 18:24 ` [PATCH 1/2] zram: Less checks in zram_bvec_write() after error detection SF Markus Elfring 2015-12-11 18:24 ` SF Markus Elfring 2015-12-14 0:27 ` Sergey Senozhatsky 2015-12-14 0:27 ` Sergey Senozhatsky 2015-12-14 6:58 ` SF Markus Elfring 2015-12-14 6:58 ` SF Markus Elfring 2015-12-14 7:17 ` Julia Lawall 2015-12-14 7:17 ` Julia Lawall 2015-12-14 10:03 ` Sergey Senozhatsky 2015-12-14 10:03 ` Sergey Senozhatsky 2015-12-14 14:03 ` SF Markus Elfring 2015-12-14 14:03 ` SF Markus Elfring 2015-12-11 18:26 ` [PATCH 2/2] z2ram: Delete a jump label in z2_init() SF Markus Elfring 2015-12-11 18:26 ` SF Markus Elfring 2015-12-14 0:36 ` Sergey Senozhatsky 2015-12-14 0:36 ` Sergey Senozhatsky 2015-12-14 9:10 ` Geert Uytterhoeven 2015-12-14 9:10 ` Geert Uytterhoeven 2015-12-12 9:16 ` [PATCH] uinput: Rename a jump label in uinput_ioctl_handler() SF Markus Elfring 2015-12-12 9:16 ` SF Markus Elfring 2015-12-12 22:23 ` Dmitry Torokhov 2015-12-12 22:23 ` Dmitry Torokhov 2015-12-12 14:30 ` [PATCH 0/7] iSCSI-target: Fine-tuning for three function implementations SF Markus Elfring 2015-12-12 14:30 ` SF Markus Elfring 2015-12-12 14:34 ` [PATCH 1/7] iscsi-target: Use a variable initialisation in iscsi_set_default_param() directly SF Markus Elfring 2015-12-12 14:34 ` SF Markus Elfring 2015-12-12 19:49 ` Dan Carpenter 2015-12-12 19:49 ` Dan Carpenter 2015-12-12 21:22 ` SF Markus Elfring 2015-12-12 21:22 ` SF Markus Elfring 2015-12-14 8:41 ` Johannes Thumshirn 2015-12-14 8:41 ` Johannes Thumshirn 2015-12-14 11:38 ` SF Markus Elfring 2015-12-14 11:38 ` SF Markus Elfring 2015-12-12 14:37 ` [PATCH 2/7] iscsi-target: Less checks in iscsi_set_default_param() after error detection SF Markus Elfring 2015-12-12 14:37 ` SF Markus Elfring 2015-12-12 14:40 ` [PATCH 3/7] iscsi-target: Delete an unnecessary variable initialisation in iscsi_create_default_params() SF Markus Elfring 2015-12-12 14:40 ` [PATCH 3/7] iscsi-target: Delete an unnecessary variable initialisation in iscsi_create_default_para SF Markus Elfring 2015-12-12 14:41 ` [PATCH 4/7] iscsi-target: Make a variable initialisation a bit more obvious in iscsi_create_default_params() SF Markus Elfring 2015-12-12 14:41 ` [PATCH 4/7] iscsi-target: Make a variable initialisation a bit more obvious in iscsi_create_default_ SF Markus Elfring 2015-12-12 14:45 ` [PATCH 4/7] iscsi-target: Make a variable initialisation a bit more obvious in iscsi_create_default_params() Julia Lawall 2015-12-12 14:45 ` [PATCH 4/7] iscsi-target: Make a variable initialisation a bit more obvious in iscsi_create_defa Julia Lawall 2015-12-12 15:02 ` [PATCH 4/7] iscsi-target: Make a variable initialisation a bit more obvious in iscsi_create_default_params() SF Markus Elfring 2015-12-12 15:02 ` [PATCH 4/7] iscsi-target: Make a variable initialisation a bit more obvious in iscsi_create_defa SF Markus Elfring 2015-12-12 14:42 ` [PATCH 5/7] iscsi-target: Rename a jump label in iscsi_create_default_params() SF Markus Elfring 2015-12-12 14:42 ` SF Markus Elfring 2015-12-12 14:43 ` [PATCH 6/7] iscsi-target: Delete unnecessary variable initialisations in iscsi_check_valuelist_for_support() SF Markus Elfring 2015-12-12 14:43 ` [PATCH 6/7] iscsi-target: Delete unnecessary variable initialisations in iscsi_check_valuelist_for_s SF Markus Elfring 2015-12-12 14:45 ` [PATCH 7/7] iscsi-target: Make two variable initialisations a bit more obvious in iscsi_check_valuelist_for_support() SF Markus Elfring 2015-12-12 14:45 ` [PATCH 7/7] iscsi-target: Make two variable initialisations a bit more obvious in iscsi_check_valuel SF Markus Elfring 2015-12-12 17:17 ` [PATCH 7/7] iscsi-target: Make two variable initialisations a bit more obvious in iscsi_check_valuelist_for_support() walter harms 2015-12-12 17:17 ` [PATCH 7/7] iscsi-target: Make two variable initialisations a bit more obvious in iscsi_check_va walter harms 2015-12-13 13:48 ` [PATCH 0/7] staging-Lustre: Fine-tuning for some function implementations SF Markus Elfring 2015-12-13 13:48 ` [lustre-devel] " SF Markus Elfring 2015-12-13 13:48 ` SF Markus Elfring 2015-12-13 13:52 ` [PATCH 1/7] staging: lustre: Delete unnecessary goto statements in six functions SF Markus Elfring 2015-12-13 13:52 ` [lustre-devel] " SF Markus Elfring 2015-12-13 13:52 ` SF Markus Elfring 2015-12-15 14:27 ` Joe Perches 2015-12-15 14:27 ` [lustre-devel] " Joe Perches 2015-12-15 14:27 ` Joe Perches 2015-12-15 14:41 ` Dan Carpenter 2015-12-15 14:41 ` [lustre-devel] " Dan Carpenter 2015-12-15 14:41 ` Dan Carpenter 2015-12-15 15:02 ` Joe Perches 2015-12-15 15:02 ` [lustre-devel] " Joe Perches 2015-12-15 15:02 ` Joe Perches 2015-12-15 17:48 ` Dan Carpenter 2015-12-15 17:48 ` [lustre-devel] " Dan Carpenter 2015-12-15 17:48 ` Dan Carpenter 2015-12-15 18:10 ` Joe Perches 2015-12-15 18:10 ` [lustre-devel] " Joe Perches 2015-12-15 18:10 ` Joe Perches 2015-12-15 18:26 ` SF Markus Elfring 2015-12-15 18:26 ` [lustre-devel] " SF Markus Elfring 2015-12-15 18:26 ` SF Markus Elfring 2015-12-15 18:34 ` Joe Perches 2015-12-15 18:34 ` [lustre-devel] " Joe Perches 2015-12-15 18:34 ` Joe Perches 2015-12-15 18:49 ` SF Markus Elfring 2015-12-15 18:49 ` [lustre-devel] " SF Markus Elfring 2015-12-15 18:49 ` SF Markus Elfring 2015-12-15 18:55 ` Joe Perches 2015-12-15 18:55 ` [lustre-devel] " Joe Perches 2015-12-15 18:55 ` Joe Perches 2015-12-15 18:02 ` SF Markus Elfring 2015-12-15 18:02 ` [lustre-devel] " SF Markus Elfring 2015-12-15 18:02 ` SF Markus Elfring 2015-12-15 18:22 ` Joe Perches 2015-12-15 18:22 ` [lustre-devel] " Joe Perches 2015-12-15 18:22 ` Joe Perches 2015-12-13 13:54 ` [PATCH 2/7] staging: lustre: Rename a jump label for ptlrpc_req_finished() calls SF Markus Elfring 2015-12-13 13:54 ` [lustre-devel] " SF Markus Elfring 2015-12-13 13:54 ` SF Markus Elfring 2015-12-14 6:53 ` Dan Carpenter 2015-12-14 6:53 ` [lustre-devel] " Dan Carpenter 2015-12-14 6:53 ` Dan Carpenter 2015-12-14 9:08 ` SF Markus Elfring 2015-12-14 9:08 ` [lustre-devel] " SF Markus Elfring 2015-12-14 9:08 ` SF Markus Elfring 2015-12-14 9:31 ` Dan Carpenter 2015-12-14 9:31 ` [lustre-devel] " Dan Carpenter 2015-12-14 9:31 ` Dan Carpenter 2015-12-14 10:03 ` SF Markus Elfring 2015-12-14 10:03 ` [lustre-devel] " SF Markus Elfring 2015-12-14 10:03 ` SF Markus Elfring 2015-12-13 13:55 ` [PATCH 3/7] staging: lustre: Rename a jump label for a kfree(key) call SF Markus Elfring 2015-12-13 13:55 ` [lustre-devel] " SF Markus Elfring 2015-12-13 13:55 ` SF Markus Elfring 2015-12-13 13:56 ` [PATCH 4/7] staging: lustre: Delete an unnecessary variable initialisation in mgc_process_recover_log() SF Markus Elfring 2015-12-13 13:56 ` [lustre-devel] " SF Markus Elfring 2015-12-13 13:56 ` [PATCH 4/7] staging: lustre: Delete an unnecessary variable initialisation in mgc_process_recover_lo SF Markus Elfring 2015-12-13 13:57 ` [PATCH 5/7] staging: lustre: Less checks in mgc_process_recover_log() after error detection SF Markus Elfring 2015-12-13 13:57 ` [lustre-devel] " SF Markus Elfring 2015-12-13 13:57 ` SF Markus Elfring 2015-12-14 11:00 ` Dan Carpenter 2015-12-14 11:00 ` [lustre-devel] " Dan Carpenter 2015-12-14 11:00 ` Dan Carpenter 2015-12-14 12:04 ` SF Markus Elfring 2015-12-14 12:04 ` [lustre-devel] " SF Markus Elfring 2015-12-14 12:04 ` SF Markus Elfring 2015-12-14 12:38 ` Dan Carpenter 2015-12-14 12:38 ` [lustre-devel] " Dan Carpenter 2015-12-14 12:38 ` Dan Carpenter 2015-12-14 12:45 ` SF Markus Elfring 2015-12-14 12:45 ` [lustre-devel] " SF Markus Elfring 2015-12-14 12:45 ` SF Markus Elfring 2015-12-14 13:57 ` Dan Carpenter 2015-12-14 13:57 ` [lustre-devel] " Dan Carpenter 2015-12-14 13:57 ` Dan Carpenter 2015-12-14 17:43 ` SF Markus Elfring 2015-12-14 17:43 ` [lustre-devel] " SF Markus Elfring 2015-12-14 17:43 ` SF Markus Elfring 2015-12-15 11:42 ` Dan Carpenter 2015-12-15 11:42 ` [lustre-devel] " Dan Carpenter 2015-12-15 11:42 ` Dan Carpenter 2015-12-15 15:00 ` SF Markus Elfring 2015-12-15 15:00 ` [lustre-devel] " SF Markus Elfring 2015-12-15 15:00 ` SF Markus Elfring 2015-12-13 13:58 ` [PATCH 6/7] staging: lustre: A few checks less " SF Markus Elfring 2015-12-13 13:58 ` [lustre-devel] " SF Markus Elfring 2015-12-13 13:58 ` SF Markus Elfring 2015-12-13 14:00 ` [PATCH 7/7] staging: lustre: Rename a jump label for module_put() calls SF Markus Elfring 2015-12-13 14:00 ` [lustre-devel] " SF Markus Elfring 2015-12-13 14:00 ` SF Markus Elfring 2015-12-21 19:05 ` [PATCH v2 0/4] staging-Lustre: Fine-tuning for some function implementations SF Markus Elfring 2015-12-21 19:05 ` SF Markus Elfring 2015-12-21 19:09 ` [PATCH v2 1/4] staging: lustre: Delete unnecessary goto statements in six functions SF Markus Elfring 2015-12-21 19:09 ` SF Markus Elfring 2015-12-21 19:10 ` [PATCH v2 2/4] staging: lustre: Delete an unnecessary variable initialisation in mgc_process_recover_log() SF Markus Elfring 2015-12-21 19:10 ` [PATCH v2 2/4] staging: lustre: Delete an unnecessary variable initialisation in mgc_process_recover SF Markus Elfring 2015-12-21 19:12 ` [PATCH v2 3/4] staging: lustre: Less checks in mgc_process_recover_log() after error detection SF Markus Elfring 2015-12-21 19:12 ` SF Markus Elfring 2015-12-21 23:48 ` Greg Kroah-Hartman 2015-12-21 23:48 ` Greg Kroah-Hartman 2015-12-22 7:15 ` SF Markus Elfring 2015-12-22 7:15 ` SF Markus Elfring 2015-12-22 8:00 ` Dan Carpenter 2015-12-22 8:00 ` Dan Carpenter 2016-07-26 18:54 ` [PATCH 00/12] staging-Lustre: Fine-tuning for seven function implementations SF Markus Elfring 2016-07-26 18:54 ` [lustre-devel] " SF Markus Elfring 2016-07-26 18:54 ` SF Markus Elfring 2016-07-26 18:56 ` [PATCH 01/12] staging/lustre/ldlm: Delete unnecessary checks before the function call "kset_unregister" SF Markus Elfring 2016-07-26 18:56 ` [lustre-devel] " SF Markus Elfring 2016-07-26 18:56 ` [PATCH 01/12] staging/lustre/ldlm: Delete unnecessary checks before the function call "kset_unregist SF Markus Elfring 2016-07-26 19:00 ` [PATCH 02/12] staging: lustre: Delete unnecessary checks before the function call "kobject_put" SF Markus Elfring 2016-07-26 19:00 ` [lustre-devel] " SF Markus Elfring 2016-07-26 19:00 ` SF Markus Elfring 2016-07-26 19:02 ` [PATCH 03/12] staging: lustre: One function call less in class_register_type() after error detection SF Markus Elfring 2016-07-26 19:02 ` [lustre-devel] " SF Markus Elfring 2016-07-26 19:02 ` SF Markus Elfring 2016-07-26 19:08 ` Oleg Drokin 2016-07-26 19:08 ` [lustre-devel] " Oleg Drokin 2016-07-26 19:08 ` [PATCH 03/12] staging: lustre: One function call less in class_register_type() after error detec Oleg Drokin 2016-07-26 19:04 ` [PATCH 04/12] staging: lustre: Split a condition check in class_register_type() SF Markus Elfring 2016-07-26 19:04 ` [lustre-devel] " SF Markus Elfring 2016-07-26 19:04 ` SF Markus Elfring 2016-07-26 19:05 ` [PATCH 05/12] staging: lustre: Optimize error handling " SF Markus Elfring 2016-07-26 19:05 ` [lustre-devel] " SF Markus Elfring 2016-07-26 19:05 ` SF Markus Elfring 2016-07-26 19:11 ` Oleg Drokin 2016-07-26 19:11 ` [lustre-devel] " Oleg Drokin 2016-07-26 19:11 ` Oleg Drokin 2016-07-26 19:07 ` [PATCH 06/12] staging: lustre: Return directly after a failed kcalloc() in mgc_process_recover_log() SF Markus Elfring 2016-07-26 19:07 ` [lustre-devel] " SF Markus Elfring 2016-07-26 19:07 ` SF Markus Elfring 2016-07-26 19:08 ` [PATCH 07/12] staging: lustre: Less checks after a failed alloc_page() " SF Markus Elfring 2016-07-26 19:08 ` [lustre-devel] " SF Markus Elfring 2016-07-26 19:08 ` SF Markus Elfring 2016-07-26 19:09 ` [PATCH 08/12] staging: lustre: Less checks after a failed ptlrpc_request_alloc() " SF Markus Elfring 2016-07-26 19:09 ` [lustre-devel] " SF Markus Elfring 2016-07-26 19:09 ` [PATCH 08/12] staging: lustre: Less checks after a failed ptlrpc_request_alloc() in mgc_process_reco SF Markus Elfring 2016-07-26 19:10 ` [PATCH 09/12] staging: lustre: Delete a check for the variable "req" in mgc_process_recover_log() SF Markus Elfring 2016-07-26 19:10 ` [lustre-devel] " SF Markus Elfring 2016-07-26 19:10 ` SF Markus Elfring 2016-07-26 19:12 ` [PATCH 10/12] staging: lustre: Rename jump labels " SF Markus Elfring 2016-07-26 19:12 ` [lustre-devel] " SF Markus Elfring 2016-07-26 19:12 ` SF Markus Elfring 2016-07-26 19:13 ` [PATCH 11/12] staging: lustre: Move an assignment for the variable "eof" " SF Markus Elfring 2016-07-26 19:13 ` [lustre-devel] " SF Markus Elfring 2016-07-26 19:13 ` [PATCH 11/12] staging: lustre: Move an assignment for the variable "eof" in mgc_process_recover_log( SF Markus Elfring 2016-07-26 19:14 ` [PATCH 12/12] staging: lustre: Delete an unnecessary variable initialisation in mgc_process_recover_log() SF Markus Elfring 2015-12-21 19:13 ` [PATCH v2 4/4] staging: lustre: Fix a jump label position in osc_get_info() SF Markus Elfring 2015-12-21 19:13 ` SF Markus Elfring 2015-12-14 22:10 ` [POWERPC] bootwrapper: One check less in fsl_get_immr() after error detection SF Markus Elfring 2015-12-14 22:10 ` SF Markus Elfring 2015-12-14 22:20 ` Scott Wood 2015-12-14 22:20 ` Scott Wood 2015-12-23 9:43 ` [PATCH] block-LDM: One function call less in ldm_validate_tocblocks() " SF Markus Elfring 2015-12-23 9:43 ` SF Markus Elfring 2015-12-23 10:41 ` Julia Lawall 2015-12-23 10:41 ` Julia Lawall 2015-12-23 18:02 ` [PATCH 0/5] block-LDM: Improvements for exception handling SF Markus Elfring 2015-12-23 18:02 ` SF Markus Elfring 2015-12-23 18:06 ` [PATCH 1/5] block-LDM: One function call less in ldm_validate_tocblocks() after error detection SF Markus Elfring 2015-12-23 18:06 ` SF Markus Elfring 2015-12-23 18:09 ` [PATCH 2/5] block-LDM: Delete extra log messages for memory allocation failures SF Markus Elfring 2015-12-23 18:09 ` SF Markus Elfring 2015-12-23 18:10 ` [PATCH 3/5] block-LDM: One function call less in ldm_partition() after error detection SF Markus Elfring 2015-12-23 18:10 ` SF Markus Elfring 2015-12-23 18:12 ` [PATCH 4/5] block-LDM: Less function calls in ldm_validate_privheads() " SF Markus Elfring 2015-12-23 18:12 ` SF Markus Elfring 2015-12-23 18:13 ` SF Markus Elfring [this message] 2015-12-23 18:13 ` [PATCH 5/5] block-LDM: Fine-tuning for the source code formatting SF Markus Elfring 2015-12-24 12:31 ` [PATCH 0/3] Documentation-getdelays: Fine-tuning for two functions SF Markus Elfring 2015-12-24 12:31 ` SF Markus Elfring 2015-12-24 12:34 ` [PATCH 1/3] Documentation-getdelays: Fix a check for container file usage in main() SF Markus Elfring 2015-12-24 12:34 ` SF Markus Elfring 2015-12-24 14:22 ` Jonathan Corbet 2015-12-24 14:22 ` Jonathan Corbet 2015-12-24 17:54 ` SF Markus Elfring 2015-12-24 17:54 ` SF Markus Elfring 2015-12-24 12:36 ` [PATCH 2/3] Documentation-getdelays: Apply a recommendation from "checkpatch.pl" " SF Markus Elfring 2015-12-24 12:36 ` SF Markus Elfring 2015-12-24 14:22 ` Jonathan Corbet 2015-12-24 14:22 ` Jonathan Corbet 2015-12-24 12:38 ` [PATCH 3/3] Documentation-getdelays: Less function calls in usage() SF Markus Elfring 2015-12-24 12:38 ` SF Markus Elfring 2015-12-24 14:23 ` Jonathan Corbet 2015-12-24 14:23 ` Jonathan Corbet 2015-12-24 19:40 ` SF Markus Elfring 2015-12-24 19:40 ` SF Markus Elfring 2015-12-25 10:35 ` ACPI-fan: Another source code review around null pointer handling? SF Markus Elfring 2015-12-25 10:35 ` SF Markus Elfring 2015-12-25 16:00 ` sata_mv: Another source code review around exception handling? SF Markus Elfring 2015-12-25 16:00 ` SF Markus Elfring 2015-12-28 16:10 ` Tejun Heo 2015-12-28 16:10 ` Tejun Heo 2015-12-25 18:49 ` [PATCH] gpio-ucb1400: Delete an unnecessary variable initialisation in ucb1400_gpio_probe() SF Markus Elfring 2015-12-25 18:49 ` SF Markus Elfring 2015-12-26 6:34 ` [PATCH] i2c-core: One function call less in acpi_i2c_space_handler() after error detection SF Markus Elfring 2015-12-26 6:34 ` SF Markus Elfring 2015-12-26 6:47 ` kbuild test robot 2015-12-26 6:47 ` kbuild test robot 2015-12-26 7:08 ` [PATCH v2] " SF Markus Elfring 2015-12-26 7:08 ` SF Markus Elfring 2015-12-26 7:48 ` Wolfram Sang 2015-12-26 7:48 ` Wolfram Sang 2015-12-26 8:52 ` SF Markus Elfring 2015-12-26 8:52 ` SF Markus Elfring 2015-12-26 18:41 ` Wolfram Sang 2015-12-26 18:41 ` Wolfram Sang 2015-12-26 19:30 ` SF Markus Elfring 2015-12-26 19:30 ` SF Markus Elfring 2015-12-26 10:10 ` [PATCH 0/3] IDE-ACPI: Fine-tuning for a function SF Markus Elfring 2015-12-26 10:10 ` SF Markus Elfring 2015-12-26 10:15 ` [PATCH 1/3] IDE-ACPI: One function call less in ide_get_dev_handle() after error detection SF Markus Elfring 2015-12-26 10:15 ` SF Markus Elfring 2015-12-26 10:17 ` [PATCH 2/3] IDE-ACPI: Delete unnecessary null pointer checks in ide_get_dev_handle() SF Markus Elfring 2015-12-26 10:17 ` SF Markus Elfring 2015-12-26 10:20 ` [PATCH 3/3] IDE-ACPI: Move an assignment for one variable " SF Markus Elfring 2015-12-26 10:20 ` SF Markus Elfring 2015-12-26 18:12 ` [PATCH 0/3] IDE-ACPI: Fine-tuning for a function David Miller 2015-12-26 18:12 ` David Miller 2015-12-26 23:43 ` Joe Perches 2015-12-26 23:43 ` Joe Perches 2015-12-27 6:08 ` Julia Lawall 2015-12-27 6:08 ` Julia Lawall 2015-12-26 13:04 ` [PATCH] iio: qcom-spmi-vadc: One check less in vadc_measure_ref_points() after error detection SF Markus Elfring 2015-12-26 13:04 ` SF Markus Elfring 2016-01-02 18:28 ` Jonathan Cameron 2016-01-02 18:28 ` Jonathan Cameron 2015-12-26 18:39 ` [PATCH 0/6] InfiniBand-ocrdma: Fine-tuning for some function implementations SF Markus Elfring 2015-12-26 18:39 ` SF Markus Elfring 2015-12-26 18:43 ` [PATCH 1/6] InfiniBand-ocrdma: One variable and jump label less in ocrdma_alloc_ucontext_pd() SF Markus Elfring 2015-12-26 18:43 ` SF Markus Elfring 2015-12-26 19:41 ` kbuild test robot 2015-12-26 19:41 ` kbuild test robot 2015-12-26 21:28 ` [PATCH v2 1/6] InfiniBand-ocrdma: One " SF Markus Elfring 2015-12-26 21:28 ` SF Markus Elfring 2016-01-11 13:11 ` Selvin Xavier 2016-01-11 13:23 ` Selvin Xavier [not found] ` <567EDED5.4040201-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org> 2015-12-26 18:45 ` [PATCH 2/6] InfiniBand-ocrdma: Delete unnecessary variable initialisations in 11 functions SF Markus Elfring 2015-12-26 18:45 ` SF Markus Elfring 2015-12-26 18:45 ` SF Markus Elfring 2015-12-26 18:47 ` [PATCH 3/6] InfiniBand-ocrdma: Returning only value constants in ocrdma_qp_state_change() SF Markus Elfring 2015-12-26 18:47 ` SF Markus Elfring 2015-12-26 18:47 ` SF Markus Elfring 2015-12-26 18:49 ` [PATCH 4/6] InfiniBand-ocrdma: Return a value from a function call in _ocrdma_modify_qp() directly SF Markus Elfring 2015-12-26 18:49 ` SF Markus Elfring 2015-12-26 18:49 ` SF Markus Elfring 2016-01-14 17:18 ` [PATCH v3 0/6] InfiniBand-ocrdma: Fine-tuning for some function implementations SF Markus Elfring 2016-01-14 17:18 ` SF Markus Elfring 2016-01-14 17:18 ` SF Markus Elfring [not found] ` <5697D865.5010507-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org> 2016-01-14 17:38 ` [PATCH v3 1/6] InfiniBand-ocrdma: One jump label less in ocrdma_alloc_ucontext_pd() SF Markus Elfring 2016-01-14 17:38 ` SF Markus Elfring 2016-01-14 17:38 ` SF Markus Elfring 2016-01-14 17:50 ` [PATCH v3 5/6] InfiniBand-ocrdma: Returning only value constants in ocrdma_resize_cq() SF Markus Elfring 2016-01-14 17:50 ` SF Markus Elfring 2016-01-14 17:50 ` SF Markus Elfring 2016-01-14 17:43 ` [PATCH v3 2/6] InfiniBand-ocrdma: Delete unnecessary variable initialisations in 11 functions SF Markus Elfring 2016-01-14 17:43 ` SF Markus Elfring 2016-01-15 13:20 ` Leon Romanovsky 2016-01-15 13:20 ` Leon Romanovsky [not found] ` <20160115132014.GC30615-2ukJVAZIZ/Y@public.gmane.org> 2016-01-15 14:50 ` SF Markus Elfring 2016-01-15 14:50 ` SF Markus Elfring 2016-01-15 14:50 ` SF Markus Elfring [not found] ` <56990733.7000506-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org> 2016-01-15 15:09 ` Leon Romanovsky 2016-01-15 15:09 ` Leon Romanovsky 2016-01-15 15:09 ` Leon Romanovsky [not found] ` <20160115150935.GA32346-2ukJVAZIZ/Y@public.gmane.org> 2016-01-15 15:26 ` SF Markus Elfring 2016-01-15 15:26 ` SF Markus Elfring 2016-01-15 15:26 ` SF Markus Elfring [not found] ` <56990FAC.6000506-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org> 2016-01-15 15:59 ` Leon Romanovsky 2016-01-15 15:59 ` Leon Romanovsky 2016-01-15 15:59 ` Leon Romanovsky [not found] ` <20160115155938.GB32346-2ukJVAZIZ/Y@public.gmane.org> 2016-01-15 16:10 ` Dan Carpenter 2016-01-15 16:10 ` Dan Carpenter 2016-01-15 16:10 ` Dan Carpenter 2016-01-15 16:24 ` SF Markus Elfring 2016-01-15 16:24 ` SF Markus Elfring 2016-01-15 16:24 ` SF Markus Elfring [not found] ` <56991D52.8030808-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org> 2016-01-15 17:00 ` Leon Romanovsky 2016-01-15 17:00 ` Leon Romanovsky 2016-01-15 17:00 ` Leon Romanovsky [not found] ` <20160115170048.GC32346-2ukJVAZIZ/Y@public.gmane.org> 2016-01-15 17:19 ` Bart Van Assche 2016-01-15 17:19 ` Bart Van Assche 2016-01-15 17:19 ` Bart Van Assche 2016-01-15 17:41 ` Leon Romanovsky 2016-01-15 17:41 ` Leon Romanovsky 2016-01-15 18:19 ` SF Markus Elfring 2016-01-15 18:19 ` SF Markus Elfring 2016-01-16 6:18 ` Leon Romanovsky 2016-01-16 6:18 ` Leon Romanovsky [not found] ` <20160116061843.GE32346-2ukJVAZIZ/Y@public.gmane.org> 2016-01-16 8:30 ` SF Markus Elfring 2016-01-16 8:30 ` [LTP] " SF Markus Elfring 2016-01-16 8:30 ` SF Markus Elfring 2016-01-16 8:30 ` SF Markus Elfring 2016-01-14 17:45 ` [PATCH v3 3/6] InfiniBand-ocrdma: Returning only value constants in ocrdma_qp_state_change() SF Markus Elfring 2016-01-14 17:45 ` SF Markus Elfring 2016-01-14 17:48 ` [PATCH v3 4/6] InfiniBand-ocrdma: Return a value from a function call in _ocrdma_modify_qp() directly SF Markus Elfring 2016-01-14 17:48 ` [PATCH v3 4/6] InfiniBand-ocrdma: Return a value from a function call in _ocrdma_modify_qp() directl SF Markus Elfring 2016-01-14 17:51 ` [PATCH v3 6/6] InfiniBand-ocrdma: Delete an unnecessary variable in ocrdma_dealloc_pd() SF Markus Elfring 2016-01-14 17:51 ` SF Markus Elfring 2015-12-26 18:50 ` [PATCH 5/6] InfiniBand-ocrdma: Returning only value constants in ocrdma_resize_cq() SF Markus Elfring 2015-12-26 18:50 ` SF Markus Elfring 2015-12-26 18:51 ` [PATCH 6/6] InfiniBand-ocrdma: Delete an unnecessary variable in ocrdma_dealloc_pd() SF Markus Elfring 2015-12-26 18:51 ` SF Markus Elfring 2015-12-27 12:36 ` [PATCH 0/2] InfiniBand-iSER: Refactoring for two function implementations SF Markus Elfring 2015-12-27 12:36 ` SF Markus Elfring 2015-12-27 12:40 ` [PATCH 1/2] InfiniBand-iSER: One jump label less in iser_reg_sig_mr() SF Markus Elfring 2015-12-27 12:40 ` SF Markus Elfring 2015-12-27 12:41 ` [PATCH 2/2] InfiniBand-iSER-target: One jump label less in isert_reg_sig_mr() SF Markus Elfring 2015-12-27 12:41 ` SF Markus Elfring [not found] ` <567FDB4E.2040000-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org> 2015-12-27 12:43 ` [PATCH 0/2] InfiniBand-iSER: Refactoring for two function implementations Leon Romanovsky 2015-12-27 12:43 ` Leon Romanovsky 2015-12-27 12:43 ` Leon Romanovsky 2015-12-27 12:52 ` Leon Romanovsky 2015-12-27 12:52 ` Leon Romanovsky 2015-12-27 12:52 ` Leon Romanovsky 2016-01-06 18:47 ` Nicholas A. Bellinger 2016-01-06 18:47 ` Nicholas A. Bellinger 2016-01-06 18:47 ` Nicholas A. Bellinger 2015-12-27 15:26 ` Sagi Grimberg 2015-12-27 15:26 ` Sagi Grimberg 2015-12-27 17:33 ` [PATCH] [media] si2165: Refactoring for si2165_writereg_mask8() SF Markus Elfring 2015-12-27 17:33 ` SF Markus Elfring 2016-01-04 8:39 ` Matthias Schwarzott 2016-01-04 8:39 ` Matthias Schwarzott 2015-12-27 21:22 ` [PATCH] [media] bttv: Returning only value constants in two functions SF Markus Elfring 2015-12-27 21:22 ` SF Markus Elfring 2015-12-28 9:15 ` [PATCH] [media] tuners: One check less in m88rs6000t_get_rf_strength() after error detection SF Markus Elfring 2015-12-28 9:15 ` SF Markus Elfring 2015-12-28 9:20 ` Julia Lawall 2015-12-28 9:20 ` Julia Lawall 2015-12-28 10:30 ` SF Markus Elfring 2015-12-28 10:30 ` SF Markus Elfring 2015-12-28 10:36 ` Julia Lawall 2015-12-28 10:36 ` Julia Lawall 2015-12-28 14:36 ` [PATCH 0/2] [media] m88rs6000t: Fine-tuning for some function implementations SF Markus Elfring 2015-12-28 14:36 ` SF Markus Elfring 2015-12-28 14:38 ` [PATCH 1/2] [media] m88rs6000t: Better exception handling in five functions SF Markus Elfring 2015-12-28 14:38 ` SF Markus Elfring 2015-12-28 14:42 ` Julia Lawall 2015-12-28 14:42 ` Julia Lawall 2015-12-28 15:03 ` SF Markus Elfring 2015-12-28 15:03 ` SF Markus Elfring 2015-12-28 15:12 ` Julia Lawall 2015-12-28 15:12 ` Julia Lawall 2016-01-25 17:01 ` [PATCH 1/2] " Mauro Carvalho Chehab 2016-01-25 17:01 ` Mauro Carvalho Chehab 2016-01-25 18:15 ` SF Markus Elfring 2016-01-25 18:15 ` SF Markus Elfring 2015-12-28 14:42 ` [PATCH 2/2] [media] tuners: Refactoring for m88rs6000t_sleep() SF Markus Elfring 2015-12-28 14:42 ` SF Markus Elfring 2015-12-28 16:24 ` [PATCH 0/2] [media] r820t: Fine-tuning for generic_set_freq() SF Markus Elfring 2015-12-28 16:24 ` SF Markus Elfring 2015-12-28 16:30 ` [PATCH 1/2] [media] r820t: Delete an unnecessary variable initialisation in generic_set_freq() SF Markus Elfring 2015-12-28 16:30 ` SF Markus Elfring 2015-12-28 16:32 ` [PATCH 2/2] [media] r820t: Better exception handling " SF Markus Elfring 2015-12-28 16:32 ` SF Markus Elfring 2016-01-25 17:04 ` Mauro Carvalho Chehab 2016-01-25 17:04 ` Mauro Carvalho Chehab 2015-12-28 19:20 ` [PATCH] [media] xc5000: Faster result reporting in xc_load_fw_and_init_tuner() SF Markus Elfring 2015-12-28 19:20 ` SF Markus Elfring 2016-01-25 17:06 ` Mauro Carvalho Chehab 2016-01-25 17:06 ` Mauro Carvalho Chehab 2016-01-25 18:23 ` SF Markus Elfring 2016-01-25 18:23 ` SF Markus Elfring 2016-01-25 18:38 ` Devin Heitmueller 2016-01-25 18:38 ` Devin Heitmueller 2015-12-28 21:15 ` [PATCH] [media] airspy: Better exception handling in two functions SF Markus Elfring 2015-12-28 21:15 ` SF Markus Elfring 2015-12-28 21:56 ` [PATCH] [media] au0828: Refactoring for start_urb_transfer() SF Markus Elfring 2015-12-28 21:56 ` SF Markus Elfring 2015-12-29 10:18 ` [PATCH] [media] hdpvr: Refactoring for hdpvr_read() SF Markus Elfring 2015-12-29 10:18 ` SF Markus Elfring 2015-12-29 11:37 ` [PATCH] [media] msi2500: Delete an unnecessary check in msi2500_set_usb_adc() SF Markus Elfring 2015-12-29 11:37 ` SF Markus Elfring 2015-12-29 13:04 ` [PATCH] mfd-dm355evm_msp: One function call less in add_child() after error detection SF Markus Elfring 2015-12-29 13:04 ` SF Markus Elfring 2016-01-11 8:31 ` Lee Jones 2016-01-11 8:31 ` Lee Jones 2016-01-12 8:34 ` SF Markus Elfring 2016-01-12 8:34 ` SF Markus Elfring 2016-01-12 9:06 ` Lee Jones 2016-01-12 9:06 ` Lee Jones 2016-01-12 11:48 ` SF Markus Elfring 2016-01-12 11:48 ` SF Markus Elfring 2016-01-12 11:59 ` Lee Jones 2016-01-12 11:59 ` Lee Jones 2016-01-12 11:59 ` [PATCH] " Lee Jones 2016-01-12 11:59 ` Lee Jones 2016-01-12 12:20 ` SF Markus Elfring 2016-01-12 12:20 ` SF Markus Elfring 2015-12-29 14:15 ` [PATCH 0/2] mfd: smsc-ece1099: Fine-tuning for smsc_i2c_probe() SF Markus Elfring 2015-12-29 14:15 ` SF Markus Elfring 2015-12-29 14:17 ` [PATCH 1/2] mfd: smsc-ece1099: Delete an unnecessary variable initialisation in smsc_i2c_probe() SF Markus Elfring 2015-12-29 14:17 ` SF Markus Elfring 2016-01-11 8:15 ` Lee Jones 2016-01-11 8:15 ` Lee Jones 2015-12-29 14:18 ` [PATCH 2/2] mfd: smsc-ece1099: Refactoring for smsc_i2c_probe() SF Markus Elfring 2015-12-29 14:18 ` SF Markus Elfring 2016-01-11 8:10 ` Lee Jones 2016-01-11 8:10 ` Lee Jones 2016-01-11 8:12 ` Lee Jones 2016-01-11 8:12 ` Lee Jones [not found] ` <5694BE21.3010504@users.sourceforge.net> 2016-01-12 9:05 ` Lee Jones 2016-01-12 9:05 ` Lee Jones 2016-01-12 11:28 ` SF Markus Elfring 2016-01-12 11:28 ` SF Markus Elfring 2016-01-11 8:08 ` [PATCH 0/2] mfd: smsc-ece1099: Fine-tuning " Lee Jones 2016-01-11 8:08 ` Lee Jones 2016-01-12 9:00 ` SF Markus Elfring 2016-01-12 9:00 ` SF Markus Elfring 2016-01-12 9:12 ` Lee Jones 2016-01-12 11:03 ` SF Markus Elfring 2016-01-12 11:03 ` SF Markus Elfring 2016-01-12 11:14 ` Lee Jones 2016-01-12 11:42 ` SF Markus Elfring 2016-01-12 11:42 ` SF Markus Elfring 2016-01-12 12:03 ` Lee Jones 2016-01-12 12:03 ` Lee Jones 2015-12-29 18:34 ` [PATCH] mfd: twl-core: One function call less in add_numbered_child() after error detection SF Markus Elfring 2015-12-29 18:34 ` SF Markus Elfring 2016-01-11 8:29 ` Lee Jones 2016-01-11 8:29 ` Lee Jones 2016-01-11 8:29 ` Lee Jones 2016-05-15 18:11 ` [PATCH 0/2] mfd: twl-core: Fine-tuning for add_numbered_child() SF Markus Elfring 2016-05-15 18:11 ` SF Markus Elfring 2016-05-16 6:26 ` [PATCH 1/2] mfd: twl-core: Return directly after a failed platform_device_alloc() in add_numbered_child() SF Markus Elfring 2016-05-16 6:26 ` [PATCH 1/2] mfd: twl-core: Return directly after a failed platform_device_alloc() in add_numbered_ch SF Markus Elfring 2016-05-16 6:51 ` [PATCH 1/2] mfd: twl-core: Return directly after a failed platform_device_alloc() in add_numbered_child() Julia Lawall 2016-05-16 6:51 ` [PATCH 1/2] mfd: twl-core: Return directly after a failed platform_device_alloc() in add_numbere Julia Lawall 2016-05-16 7:54 ` mfd: twl-core: Return directly after a failed platform_device_alloc() in add_numbered_child() SF Markus Elfring 2016-05-16 7:54 ` SF Markus Elfring 2016-05-16 8:07 ` Julia Lawall 2016-05-16 8:07 ` Julia Lawall 2016-05-17 6:00 ` Lee Jones 2016-05-17 6:00 ` Lee Jones 2016-05-17 14:15 ` SF Markus Elfring 2016-05-17 14:15 ` SF Markus Elfring 2016-05-16 6:28 ` [PATCH 2/2] mfd: twl-core: Refactoring for add_numbered_child() SF Markus Elfring 2016-05-16 6:28 ` SF Markus Elfring 2016-06-08 11:14 ` Lee Jones 2016-06-08 11:14 ` Lee Jones 2016-06-26 13:34 ` [PATCH 0/6] mfd: Fine-tuning for three function implementations SF Markus Elfring 2016-06-26 13:34 ` SF Markus Elfring 2016-06-26 13:45 ` [PATCH 1/6] mfd: twl-core: Return directly after a failed platform_device_alloc() in add_numbered_child() SF Markus Elfring 2016-06-26 13:45 ` [PATCH 1/6] mfd: twl-core: Return directly after a failed platform_device_alloc() in add_numbered_ch SF Markus Elfring 2016-06-28 15:02 ` [PATCH 1/6] mfd: twl-core: Return directly after a failed platform_device_alloc() in add_numbered_child() Lee Jones 2016-06-28 15:02 ` [PATCH 1/6] mfd: twl-core: Return directly after a failed platform_device_alloc() in add_numbere Lee Jones 2016-06-26 13:47 ` [PATCH 2/6] mfd: twl-core: Refactoring for add_numbered_child() SF Markus Elfring 2016-06-26 13:47 ` SF Markus Elfring 2016-06-28 15:03 ` Lee Jones 2016-06-28 15:03 ` Lee Jones 2016-06-28 15:03 ` Lee Jones 2016-06-26 13:48 ` [PATCH 3/6] mfd: dm355evm_msp: Return directly after a failed platform_device_alloc() in add_child() SF Markus Elfring 2016-06-26 13:48 ` SF Markus Elfring 2016-06-28 15:03 ` Lee Jones 2016-06-28 15:03 ` [PATCH 3/6] mfd: dm355evm_msp: Return directly after a failed platform_device_alloc() in add_chi Lee Jones 2016-06-26 13:50 ` [PATCH 4/6] mfd: dm355evm_msp: Refactoring for add_child() SF Markus Elfring 2016-06-26 13:50 ` SF Markus Elfring 2016-06-28 15:07 ` Lee Jones 2016-06-28 15:07 ` Lee Jones 2016-06-28 15:07 ` Lee Jones 2016-06-28 15:40 ` SF Markus Elfring 2016-06-28 15:40 ` SF Markus Elfring 2016-06-28 16:31 ` Lee Jones 2016-06-28 16:31 ` Lee Jones 2016-06-30 20:15 ` [PATCH] " SF Markus Elfring 2016-06-30 20:15 ` SF Markus Elfring 2016-06-30 20:34 ` Joe Perches 2016-06-30 20:34 ` Joe Perches 2016-06-30 20:59 ` Lee Jones 2016-06-30 21:00 ` Lee Jones 2016-07-01 14:40 ` SF Markus Elfring 2016-07-01 14:40 ` SF Markus Elfring 2016-07-01 16:23 ` Joe Perches 2016-07-01 16:23 ` Joe Perches 2016-07-01 9:17 ` [PATCH] " Lee Jones 2016-07-01 9:17 ` Lee Jones 2016-07-01 14:54 ` SF Markus Elfring 2016-07-01 14:54 ` SF Markus Elfring 2016-06-26 13:51 ` [PATCH 5/6] mfd: smsc-ece1099: Delete an unnecessary variable initialisation in smsc_i2c_probe() SF Markus Elfring 2016-06-26 13:51 ` SF Markus Elfring 2016-06-28 15:07 ` Lee Jones 2016-06-28 15:07 ` Lee Jones 2016-06-28 15:07 ` Lee Jones 2016-06-26 13:54 ` [PATCH 6/6] mfd: smsc-ece1099: Return directly after a function failure " SF Markus Elfring 2016-06-26 13:54 ` SF Markus Elfring 2016-06-28 15:08 ` Lee Jones 2016-06-28 15:08 ` Lee Jones 2016-06-28 15:01 ` [PATCH 0/6] mfd: Fine-tuning for three function implementations Lee Jones 2016-06-28 15:01 ` Lee Jones 2016-06-28 15:01 ` Lee Jones 2015-12-29 19:50 ` [PATCH] mmc-core: One check less in mmc_select_hs200() after error detection SF Markus Elfring 2015-12-29 19:50 ` SF Markus Elfring 2016-01-12 15:07 ` Ulf Hansson 2016-01-12 15:07 ` Ulf Hansson 2015-12-29 20:57 ` [PATCH 0/2] mmc-host: Fine-tuning for one function SF Markus Elfring 2015-12-29 20:57 ` SF Markus Elfring 2015-12-29 21:00 ` [PATCH 1/2] mmc-sdricoh_cs: Delete unnecessary variable initialisations in sdricoh_init_mmc() SF Markus Elfring 2015-12-29 21:00 ` SF Markus Elfring 2016-02-21 9:11 ` Sascha Sommer 2016-02-21 9:11 ` Sascha Sommer 2015-12-29 21:02 ` [PATCH 2/2] mmc-sdricoh_cs: Less checks in sdricoh_init_mmc() after, error detection SF Markus Elfring 2015-12-29 21:02 ` SF Markus Elfring 2016-02-21 9:15 ` Sascha Sommer 2016-02-21 9:15 ` Sascha Sommer 2016-01-27 14:15 ` [PATCH 0/2] mmc-host: Fine-tuning for one function Ulf Hansson 2016-01-27 14:15 ` Ulf Hansson 2015-12-31 20:21 ` [PATCH 0/3] mtd-rfd_ftl: Fine-tuning for two function implementations SF Markus Elfring 2015-12-31 20:21 ` SF Markus Elfring 2015-12-31 20:25 ` [PATCH 1/3] mtd-rfd_ftl: Replace a variable initialisation by assignments in move_block_contents() SF Markus Elfring 2015-12-31 20:25 ` SF Markus Elfring 2015-12-31 20:26 ` [PATCH 2/3] mtd-rfd_ftl: Refactoring for move_block_contents() SF Markus Elfring 2015-12-31 20:26 ` SF Markus Elfring 2015-12-31 20:27 ` [PATCH 3/3] mtd-rfd_ftl: Refactoring for erase_block() SF Markus Elfring 2015-12-31 20:27 ` SF Markus Elfring 2016-01-05 0:13 ` [PATCH 0/3] mtd-rfd_ftl: Fine-tuning for two function implementations Brian Norris 2016-01-05 0:13 ` Brian Norris 2015-12-31 21:47 ` [PATCH] net-thunder: One check less in nicvf_register_interrupts() after error detection SF Markus Elfring 2015-12-31 21:47 ` SF Markus Elfring 2015-12-31 21:47 ` SF Markus Elfring 2015-12-31 21:47 ` SF Markus Elfring 2016-01-07 11:07 ` Robert Richter 2016-01-07 11:07 ` Robert Richter 2016-01-07 11:07 ` Robert Richter 2016-01-07 19:30 ` SF Markus Elfring 2016-01-07 19:30 ` SF Markus Elfring 2016-01-07 19:30 ` SF Markus Elfring 2016-01-07 19:44 ` Joe Perches 2016-01-07 19:44 ` Joe Perches 2016-01-07 19:44 ` Joe Perches 2016-01-07 19:56 ` SF Markus Elfring 2016-01-07 19:56 ` SF Markus Elfring 2016-01-07 19:56 ` SF Markus Elfring 2016-01-07 19:59 ` Joe Perches 2016-01-07 19:59 ` Joe Perches 2016-01-07 19:59 ` Joe Perches 2016-01-07 20:07 ` SF Markus Elfring 2016-01-07 20:07 ` SF Markus Elfring 2016-01-07 20:07 ` SF Markus Elfring 2016-01-07 20:28 ` Joe Perches 2016-01-07 20:28 ` Joe Perches 2016-01-07 20:28 ` Joe Perches 2016-01-07 20:38 ` SF Markus Elfring 2016-01-07 20:38 ` SF Markus Elfring 2016-01-07 20:38 ` SF Markus Elfring 2016-01-07 20:42 ` Joe Perches 2016-01-07 20:42 ` Joe Perches 2016-01-07 20:42 ` Joe Perches 2015-12-31 23:22 ` [PATCH] be2net: Delete an unnecessary check in two functions SF Markus Elfring 2015-12-31 23:22 ` SF Markus Elfring 2016-01-06 6:25 ` Sathya Perla 2016-01-06 6:37 ` Sathya Perla 2016-01-01 12:18 ` [PATCH 0/3] net-gianfar: Fine-tuning for gfar_ethflow_to_filer_table() SF Markus Elfring 2016-01-01 12:18 ` SF Markus Elfring 2016-01-01 12:22 ` [PATCH 1/3] net-gianfar: Less function calls in gfar_ethflow_to_filer_table() after error detection SF Markus Elfring 2016-01-01 12:22 ` SF Markus Elfring 2016-01-01 12:35 ` Julia Lawall 2016-01-01 12:35 ` [PATCH 1/3] net-gianfar: Less function calls in gfar_ethflow_to_filer_table() after error detect Julia Lawall 2016-01-01 12:50 ` [PATCH 1/3] net-gianfar: Less function calls in gfar_ethflow_to_filer_table() after error detection SF Markus Elfring 2016-01-01 12:50 ` [PATCH 1/3] net-gianfar: Less function calls in gfar_ethflow_to_filer_table() after error detect SF Markus Elfring 2016-01-01 13:05 ` [PATCH 1/3] net-gianfar: Less function calls in gfar_ethflow_to_filer_table() after error detection Julia Lawall 2016-01-01 13:05 ` [PATCH 1/3] net-gianfar: Less function calls in gfar_ethflow_to_filer_table() after error detect Julia Lawall 2016-01-01 14:45 ` [PATCH 1/3] net-gianfar: Less function calls in gfar_ethflow_to_filer_table() after error detection Francois Romieu 2016-01-01 14:45 ` [PATCH 1/3] net-gianfar: Less function calls in gfar_ethflow_to_filer_table() after error detect Francois Romieu 2016-01-01 13:04 ` [PATCH v2 1/3] net-gianfar: Less function calls in gfar_ethflow_to_filer_table() after error detection SF Markus Elfring 2016-01-01 13:04 ` [PATCH v2 1/3] net-gianfar: Less function calls in gfar_ethflow_to_filer_table() after error detecti SF Markus Elfring 2016-01-02 3:16 ` [PATCH v2 1/3] net-gianfar: Less function calls in gfar_ethflow_to_filer_table() after error detection David Miller 2016-01-02 3:16 ` [PATCH v2 1/3] net-gianfar: Less function calls in gfar_ethflow_to_filer_table() after error det David Miller 2016-01-01 12:23 ` [PATCH 2/3] net-gianfar: Delete unnecessary variable initialisations in gfar_ethflow_to_filer_table() SF Markus Elfring 2016-01-01 12:23 ` [PATCH 2/3] net-gianfar: Delete unnecessary variable initialisations in gfar_ethflow_to_filer_table( SF Markus Elfring 2016-01-01 12:24 ` [PATCH 3/3] net-gianfar: Extend an initialisation clause of a for loop in gfar_ethflow_to_filer_table() SF Markus Elfring 2016-01-01 12:24 ` [PATCH 3/3] net-gianfar: Extend an initialisation clause of a for loop in gfar_ethflow_to_filer_tabl SF Markus Elfring 2016-01-15 10:09 ` [PATCH v3 0/3] gianfar: Fine-tuning for gfar_ethflow_to_filer_table() SF Markus Elfring 2016-01-15 10:09 ` SF Markus Elfring 2016-01-15 10:11 ` [PATCH v3 1/3] gianfar: Less function calls in gfar_ethflow_to_filer_table() after error detection SF Markus Elfring 2016-01-15 10:11 ` SF Markus Elfring 2016-01-15 10:37 ` Joe Perches 2016-01-15 10:37 ` [PATCH v3 1/3] gianfar: Less function calls in gfar_ethflow_to_filer_table() after error detecti Joe Perches 2016-01-15 11:47 ` gianfar: Less function calls in gfar_ethflow_to_filer_table() after error detection SF Markus Elfring 2016-01-15 11:47 ` SF Markus Elfring 2016-01-15 12:03 ` Joe Perches 2016-01-15 12:03 ` Joe Perches 2016-01-15 12:03 ` Joe Perches 2016-01-15 17:32 ` SF Markus Elfring 2016-01-15 17:32 ` SF Markus Elfring 2016-01-18 13:11 ` Claudiu Manoil 2016-01-15 10:12 ` [PATCH v3 2/3] gianfar: Delete unnecessary variable initialisations in gfar_ethflow_to_filer_table() SF Markus Elfring 2016-01-15 10:12 ` SF Markus Elfring 2016-01-15 10:29 ` Dan Carpenter 2016-01-15 10:29 ` [PATCH v3 2/3] gianfar: Delete unnecessary variable initialisations in gfar_ethflow_to_filer_tab Dan Carpenter 2016-01-15 11:34 ` [PATCH v3 2/3] gianfar: Delete unnecessary variable initialisations in gfar_ethflow_to_filer_table() SF Markus Elfring 2016-01-15 11:34 ` [PATCH v3 2/3] gianfar: Delete unnecessary variable initialisations in gfar_ethflow_to_filer_tab SF Markus Elfring 2016-01-15 12:15 ` [PATCH v3 2/3] gianfar: Delete unnecessary variable initialisations in gfar_ethflow_to_filer_table() Dan Carpenter 2016-01-15 12:15 ` [PATCH v3 2/3] gianfar: Delete unnecessary variable initialisations in gfar_ethflow_to_filer_tab Dan Carpenter 2016-01-15 16:42 ` [PATCH v3 2/3] gianfar: Delete unnecessary variable initialisations in gfar_ethflow_to_filer_table() David Miller 2016-01-15 16:42 ` [PATCH v3 2/3] gianfar: Delete unnecessary variable initialisations in gfar_ethflow_to_filer_tab David Miller 2016-01-15 17:15 ` gianfar: Delete unnecessary variable initialisations in gfar_ethflow_to_filer_table() SF Markus Elfring 2016-01-15 17:15 ` SF Markus Elfring 2016-01-15 10:14 ` [PATCH v3 3/3] gianfar: Extend an initialisation clause of a for loop " SF Markus Elfring 2016-01-15 10:14 ` [PATCH v3 3/3] gianfar: Extend an initialisation clause of a for loop in gfar_ethflow_to_filer_table SF Markus Elfring 2016-01-01 14:32 ` [PATCH] net-i40e: Replace variable initialisations by assignments in i40e_vc_get_vf_resources_msg() SF Markus Elfring 2016-01-01 14:32 ` [Intel-wired-lan] " SF Markus Elfring 2016-01-01 14:32 ` SF Markus Elfring 2016-01-01 14:51 ` net-i40e: Reconsider further usage of variable "i" " SF Markus Elfring 2016-01-01 14:51 ` [Intel-wired-lan] " SF Markus Elfring 2016-01-01 14:51 ` SF Markus Elfring 2016-01-08 20:51 ` Nelson, Shannon 2016-01-08 20:51 ` [Intel-wired-lan] " Nelson, Shannon 2016-01-08 20:51 ` Nelson, Shannon 2016-01-07 22:43 ` [PATCH] net-i40e: Replace variable initialisations by assignments " Nelson, Shannon 2016-01-07 22:43 ` [Intel-wired-lan] " Nelson, Shannon 2016-01-07 22:43 ` [PATCH] net-i40e: Replace variable initialisations by assignments in i40e_vc_get_vf_resources_ms Nelson, Shannon 2016-01-08 10:42 ` [PATCH] net-i40e: Replace variable initialisations by assignments in i40e_vc_get_vf_resources_msg() Jeff Kirsher 2016-01-08 10:42 ` [Intel-wired-lan] " Jeff Kirsher 2016-01-08 10:42 ` [PATCH] net-i40e: Replace variable initialisations by assignments in i40e_vc_get_vf_resources_ms Jeff Kirsher 2016-01-01 15:57 ` [PATCH] net-huawei_cdc_ncm: Delete an unnecessary variable initialisation in huawei_cdc_ncm_bind() SF Markus Elfring 2016-01-01 15:57 ` SF Markus Elfring 2016-01-01 16:50 ` [PATCH 0/2] net-qmi_wwan: Fine-tuning for two function implementations SF Markus Elfring 2016-01-01 16:50 ` SF Markus Elfring 2016-01-01 16:50 ` SF Markus Elfring 2016-01-01 16:54 ` [PATCH 1/2] net-qmi_wwan: Refactoring for qmi_wwan_bind() SF Markus Elfring 2016-01-01 16:54 ` SF Markus Elfring 2016-01-01 16:54 ` SF Markus Elfring 2016-01-02 21:38 ` Bjørn Mork 2016-01-02 21:38 ` Bjørn Mork 2016-01-02 21:38 ` Bjørn Mork 2016-01-01 16:56 ` [PATCH 2/2] net-qmi_wwan: Delete an unnecessary variable initialisation in qmi_wwan_register_subdriver() SF Markus Elfring 2016-01-01 16:56 ` [PATCH 2/2] net-qmi_wwan: Delete an unnecessary variable initialisation in qmi_wwan_register_subdriv SF Markus Elfring 2016-01-02 21:30 ` [PATCH 2/2] net-qmi_wwan: Delete an unnecessary variable initialisation in qmi_wwan_register_subdriver() Bjørn Mork 2016-01-02 21:30 ` [PATCH 2/2] net-qmi_wwan: Delete an unnecessary variable initialisation in qmi_wwan_register_sub Bjørn Mork 2016-01-02 21:30 ` [PATCH 2/2] net-qmi_wwan: Delete an unnecessary variable initialisation in qmi_wwan_register_subdriver() Bjørn Mork 2016-01-03 1:45 ` David Miller 2016-01-03 1:45 ` [PATCH 2/2] net-qmi_wwan: Delete an unnecessary variable initialisation in qmi_wwan_register_sub David Miller 2016-01-03 1:45 ` [PATCH 2/2] net-qmi_wwan: Delete an unnecessary variable initialisation in qmi_wwan_register_subdriver() David Miller 2016-01-01 18:21 ` [PATCH 0/2] net-ath9k_htc: Fine-tuning for two function implementations SF Markus Elfring 2016-01-01 18:21 ` [ath9k-devel] " SF Markus Elfring 2016-01-01 18:21 ` SF Markus Elfring 2016-01-01 18:21 ` SF Markus Elfring 2016-01-01 18:21 ` SF Markus Elfring 2016-01-01 18:23 ` [PATCH 1/2] net-ath9k_htc: Delete an unnecessary variable initialisation in ath9k_hif_usb_rx_stream() SF Markus Elfring 2016-01-01 18:23 ` [ath9k-devel] " SF Markus Elfring 2016-01-01 18:23 ` [PATCH 1/2] net-ath9k_htc: Delete an unnecessary variable initialisation in ath9k_hif_usb_rx_stream( SF Markus Elfring 2016-01-01 18:23 ` [PATCH 1/2] net-ath9k_htc: Delete an unnecessary variable initialisation in ath9k_hif_usb_rx_stream() SF Markus Elfring 2016-01-01 19:14 ` Oleksij Rempel 2016-01-01 19:14 ` [ath9k-devel] " Oleksij Rempel 2016-01-01 19:14 ` [PATCH 1/2] net-ath9k_htc: Delete an unnecessary variable initialisation in ath9k_hif_usb_rx_str Oleksij Rempel 2016-01-01 19:14 ` [PATCH 1/2] net-ath9k_htc: Delete an unnecessary variable initialisation in ath9k_hif_usb_rx_stream() Oleksij Rempel 2016-01-01 19:14 ` Oleksij Rempel 2016-01-01 18:25 ` [PATCH 2/2] net-ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_channel() SF Markus Elfring 2016-01-01 18:25 ` [ath9k-devel] " SF Markus Elfring 2016-01-01 18:25 ` [PATCH 2/2] net-ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_chann SF Markus Elfring 2016-01-01 18:25 ` [PATCH 2/2] net-ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_channel() SF Markus Elfring 2016-01-01 19:14 ` Oleksij Rempel 2016-01-01 19:14 ` [ath9k-devel] " Oleksij Rempel 2016-01-01 19:14 ` [PATCH 2/2] net-ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_c Oleksij Rempel 2016-01-01 19:14 ` [PATCH 2/2] net-ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_channel() Oleksij Rempel 2016-04-08 1:40 ` Julian Calaby 2016-04-08 1:40 ` [ath9k-devel] " Julian Calaby 2016-04-08 1:40 ` [PATCH 2/2] net-ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_c Julian Calaby 2016-04-08 1:40 ` [PATCH 2/2] net-ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_channel() Julian Calaby 2016-04-15 12:09 ` Kalle Valo 2016-04-15 12:09 ` [ath9k-devel] " Kalle Valo 2016-04-15 12:09 ` [PATCH 2/2] net-ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_c Kalle Valo 2016-04-15 12:09 ` [PATCH 2/2] net-ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_channel() Kalle Valo 2016-04-15 14:34 ` Julian Calaby 2016-04-15 14:34 ` [ath9k-devel] " Julian Calaby 2016-04-15 14:34 ` [PATCH 2/2] net-ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_c Julian Calaby 2016-04-15 14:34 ` [PATCH 2/2] net-ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_channel() Julian Calaby 2016-04-19 16:13 ` Kalle Valo 2016-04-19 16:13 ` [ath9k-devel] " Kalle Valo 2016-04-19 16:13 ` [PATCH 2/2] net-ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_c Kalle Valo 2016-04-19 16:13 ` [PATCH 2/2] net-ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_channel() Kalle Valo 2016-01-01 19:26 ` [PATCH] net-brcmfmac: Delete an unnecessary variable initialisation in brcmf_sdio_download_firmware() SF Markus Elfring 2016-01-01 19:26 ` [PATCH] net-brcmfmac: Delete an unnecessary variable initialisation in brcmf_sdio_download_firmware( SF Markus Elfring 2016-01-02 8:50 ` [PATCH] net-brcmfmac: Delete an unnecessary variable initialisation in brcmf_sdio_download_firmware() Arend van Spriel 2016-01-02 8:50 ` [PATCH] net-brcmfmac: Delete an unnecessary variable initialisation in brcmf_sdio_download_firmw Arend van Spriel 2016-01-02 8:50 ` [PATCH] net-brcmfmac: Delete an unnecessary variable initialisation in brcmf_sdio_download_firmware() Arend van Spriel 2016-01-14 6:58 ` Kalle Valo 2016-01-14 6:58 ` [PATCH] net-brcmfmac: Delete an unnecessary variable initialisation in brcmf_sdio_download_firmw Kalle Valo 2016-01-01 20:27 ` [PATCH 0/3] net-iwlegacy: Fine-tuning for il_eeprom_init() SF Markus Elfring 2016-01-01 20:27 ` SF Markus Elfring 2016-01-01 20:30 ` [PATCH 1/3] net-iwlegacy: Refactoring " SF Markus Elfring 2016-01-01 20:30 ` SF Markus Elfring 2016-01-04 9:33 ` Stanislaw Gruszka 2016-01-04 9:33 ` Stanislaw Gruszka 2016-01-04 9:33 ` Stanislaw Gruszka 2016-01-01 20:31 ` [PATCH 2/3] net-iwlegacy: One check less in il_eeprom_init() after error detection SF Markus Elfring 2016-01-01 20:31 ` SF Markus Elfring 2016-01-01 23:13 ` Sergei Shtylyov 2016-01-01 23:13 ` Sergei Shtylyov 2016-01-01 20:32 ` [PATCH 3/3] net-iwlegacy: Another refactoring for il_eeprom_init() SF Markus Elfring 2016-01-01 20:32 ` SF Markus Elfring 2016-01-02 18:18 ` Souptick Joarder 2016-01-02 18:30 ` Souptick Joarder 2016-01-01 21:33 ` [PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker() SF Markus Elfring 2016-01-01 21:33 ` SF Markus Elfring 2016-01-01 21:41 ` Julia Lawall 2016-01-01 21:41 ` Julia Lawall 2016-01-01 23:14 ` Sergei Shtylyov 2016-01-01 23:14 ` Sergei Shtylyov 2016-01-02 8:09 ` SF Markus Elfring 2016-01-02 8:09 ` SF Markus Elfring 2016-01-02 8:21 ` Julia Lawall 2016-01-02 8:21 ` Julia Lawall 2016-01-02 8:21 ` Julia Lawall 2016-01-02 9:08 ` SF Markus Elfring 2016-01-02 9:08 ` SF Markus Elfring 2016-01-02 10:13 ` Arend van Spriel 2016-01-02 10:13 ` Arend van Spriel 2016-01-02 11:21 ` SF Markus Elfring 2016-01-02 11:21 ` SF Markus Elfring 2016-01-03 9:36 ` Arend van Spriel 2016-01-03 9:36 ` Arend van Spriel 2016-01-03 12:13 ` SF Markus Elfring 2016-01-03 12:13 ` SF Markus Elfring 2016-01-03 12:13 ` SF Markus Elfring 2016-01-03 15:18 ` Rafał Miłecki 2016-01-03 15:18 ` Rafał Miłecki 2016-01-03 15:18 ` Rafał Miłecki 2016-01-04 10:05 ` Arend van Spriel 2016-01-04 10:05 ` Arend van Spriel 2016-01-04 10:05 ` Arend van Spriel 2016-01-04 11:18 ` Rafał Miłecki 2016-01-04 11:18 ` Rafał Miłecki 2016-01-04 11:18 ` Rafał Miłecki 2016-01-21 15:07 ` [PATCH] " Kalle Valo 2016-01-21 15:07 ` Kalle Valo 2016-01-02 14:40 ` [PATCH 0/3] net-rsi: Fine-tuning for two function implementations SF Markus Elfring 2016-01-02 14:40 ` SF Markus Elfring 2016-01-02 14:43 ` [PATCH 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt() SF Markus Elfring 2016-01-02 14:43 ` SF Markus Elfring 2016-01-02 15:12 ` net-rsi: Reconsider usage of variable "vap_id" " SF Markus Elfring 2016-01-02 15:12 ` SF Markus Elfring 2016-01-02 16:32 ` [PATCH 1/3] rsi: Delete unnecessary variable initialisations " kbuild test robot 2016-01-02 16:32 ` kbuild test robot 2016-01-02 18:27 ` [PATCH v2 " SF Markus Elfring 2016-01-02 18:27 ` SF Markus Elfring 2016-01-04 9:28 ` [PATCH " Dan Carpenter 2016-01-04 9:28 ` Dan Carpenter 2016-01-04 9:38 ` Dan Carpenter 2016-01-04 9:38 ` Dan Carpenter 2016-01-04 10:44 ` SF Markus Elfring 2016-01-04 10:44 ` SF Markus Elfring 2016-01-04 11:48 ` Dan Carpenter 2016-01-04 11:48 ` Dan Carpenter 2016-01-04 12:33 ` SF Markus Elfring 2016-01-04 12:33 ` SF Markus Elfring 2016-01-04 23:54 ` Julian Calaby 2016-01-04 23:54 ` Julian Calaby 2016-01-04 23:54 ` Julian Calaby 2016-01-05 8:29 ` SF Markus Elfring 2016-01-05 8:29 ` SF Markus Elfring 2016-01-05 9:47 ` Julian Calaby 2016-01-05 9:47 ` Julian Calaby 2016-01-05 16:23 ` SF Markus Elfring 2016-01-05 16:23 ` SF Markus Elfring 2016-01-04 13:17 ` [PATCH 1/3] " Bjørn Mork 2016-01-04 13:17 ` Bjørn Mork 2016-01-04 13:17 ` Bjørn Mork 2016-01-04 14:25 ` Dan Carpenter 2016-01-04 14:25 ` Dan Carpenter 2016-01-04 14:25 ` Dan Carpenter 2016-01-04 17:14 ` David Miller 2016-01-04 17:14 ` David Miller 2016-01-02 14:44 ` [PATCH 2/3] rsi: Delete unnecessary variable initialisations in rsi_send_data_pkt() SF Markus Elfring 2016-01-02 14:44 ` SF Markus Elfring 2016-01-02 14:45 ` [PATCH 3/3] rsi: Replace variable initialisations by assignments " SF Markus Elfring 2016-01-02 14:45 ` SF Markus Elfring 2016-01-02 15:07 ` Francois Romieu 2016-01-02 15:07 ` Francois Romieu 2016-01-15 13:04 ` [PATCH v3 0/3] net-rsi: Fine-tuning for two function implementations SF Markus Elfring 2016-01-15 13:04 ` SF Markus Elfring 2016-01-15 13:04 ` SF Markus Elfring 2016-01-15 13:09 ` [PATCH v3 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt() SF Markus Elfring 2016-01-15 13:09 ` SF Markus Elfring 2016-01-15 13:10 ` [PATCH v3 2/3] rsi: Delete unnecessary variable initialisations in rsi_send_data_pkt() SF Markus Elfring 2016-01-15 13:10 ` SF Markus Elfring 2016-01-15 13:12 ` [PATCH v3 3/3] rsi: Replace variable initialisations by assignments " SF Markus Elfring 2016-01-15 13:12 ` SF Markus Elfring 2016-01-19 12:40 ` Dan Carpenter 2016-01-19 12:40 ` Dan Carpenter 2016-01-02 17:50 ` [PATCH 0/5] xen-netback: Fine-tuning for three function implementations SF Markus Elfring 2016-01-02 17:50 ` SF Markus Elfring 2016-01-02 17:54 ` [PATCH 1/5] xen-netback: Delete an unnecessary assignment in connect_rings() SF Markus Elfring 2016-01-02 17:54 ` SF Markus Elfring 2016-01-02 17:54 ` SF Markus Elfring 2016-01-02 17:55 ` [PATCH 2/5] xen-netback: Delete an unnecessary goto statement " SF Markus Elfring 2016-01-02 17:55 ` SF Markus Elfring 2016-01-02 17:55 ` SF Markus Elfring 2016-01-02 17:57 ` [PATCH 3/5] xen-netback: Replace a variable initialisation by an assignment in read_xenbus_vif_flags() SF Markus Elfring 2016-01-02 17:57 ` SF Markus Elfring 2016-01-02 17:57 ` [PATCH 3/5] xen-netback: Replace a variable initialisation by an assignment in read_xenbus_vif_flags SF Markus Elfring 2016-01-02 17:58 ` [PATCH 4/5] xen-netback: Replace a variable initialisation by an assignment in xen_register_watchers() SF Markus Elfring 2016-01-02 17:58 ` SF Markus Elfring 2016-01-02 17:58 ` [PATCH 4/5] xen-netback: Replace a variable initialisation by an assignment in xen_register_watchers SF Markus Elfring 2016-01-02 18:00 ` [PATCH 5/5] xen-netback: Delete an unnecessary variable initialisation in xen_register_watchers() SF Markus Elfring 2016-01-02 18:00 ` SF Markus Elfring 2016-01-02 18:00 ` SF Markus Elfring 2016-01-03 1:34 ` [PATCH 0/5] xen-netback: Fine-tuning for three function implementations Joe Perches 2016-01-03 1:34 ` Joe Perches 2016-01-03 1:34 ` Joe Perches 2016-01-04 9:40 ` Dan Carpenter 2016-01-04 9:40 ` Dan Carpenter 2016-01-04 9:40 ` Dan Carpenter 2016-01-04 11:08 ` Wei Liu 2016-01-04 11:08 ` Wei Liu 2016-01-04 11:08 ` Wei Liu 2016-01-02 17:50 ` SF Markus Elfring 2016-01-02 20:51 ` [PATCH 0/3] NFC-mei_phy: Fine-tuning for two " SF Markus Elfring 2016-01-02 20:51 ` SF Markus Elfring 2016-01-02 20:54 ` [PATCH 1/3] NFC-mei_phy: Refactoring for mei_nfc_connect() SF Markus Elfring 2016-01-02 20:54 ` SF Markus Elfring 2016-01-02 23:41 ` Julian Calaby 2016-01-02 23:41 ` Julian Calaby 2016-01-03 7:00 ` SF Markus Elfring 2016-01-03 7:00 ` SF Markus Elfring 2016-01-03 7:29 ` Joe Perches 2016-01-03 7:29 ` Joe Perches 2016-01-02 20:55 ` [PATCH 2/3] NFC-mei_phy: Refactoring for mei_nfc_if_version() SF Markus Elfring 2016-01-02 20:55 ` SF Markus Elfring 2016-01-02 20:56 ` [PATCH 3/3] NFC-mei_phy: Delete an unnecessary variable initialisation in mei_nfc_if_version() SF Markus Elfring 2016-01-02 20:56 ` SF Markus Elfring 2016-01-03 8:43 ` [PATCH 0/8] rtc-ab-b5ze-s3: Fine-tuning for some function implementations SF Markus Elfring 2016-01-03 8:43 ` SF Markus Elfring 2016-01-03 8:43 ` [rtc-linux] " SF Markus Elfring 2016-01-03 8:50 ` [PATCH 1/8] rtc-ab-b5ze-s3: Better exception handling in abb5zes3_probe() SF Markus Elfring 2016-01-03 8:50 ` SF Markus Elfring 2016-01-03 8:50 ` [rtc-linux] " SF Markus Elfring 2016-01-03 8:51 ` [PATCH 2/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in abb5zes3_rtc_set_alarm() SF Markus Elfring 2016-01-03 8:51 ` SF Markus Elfring 2016-01-03 8:51 ` [rtc-linux] " SF Markus Elfring 2016-01-03 8:52 ` [PATCH 3/8] rtc-ab-b5ze-s3: Delete an unnecessary variable initialisation in _abb5zes3_rtc_set_timer() SF Markus Elfring 2016-01-03 8:52 ` [PATCH 3/8] rtc-ab-b5ze-s3: Delete an unnecessary variable initialisation in _abb5zes3_rtc_set_timer SF Markus Elfring 2016-01-03 8:52 ` [rtc-linux] [PATCH 3/8] rtc-ab-b5ze-s3: Delete an unnecessary variable initialisation in _abb5zes3_rtc_set_timer() SF Markus Elfring 2016-01-03 8:53 ` [PATCH 4/8] rtc-ab-b5ze-s3: Replace a variable initialisation by an assignment in _abb5zes3_rtc_set_alarm() SF Markus Elfring 2016-01-03 8:53 ` [PATCH 4/8] rtc-ab-b5ze-s3: Replace a variable initialisation by an assignment in _abb5zes3_rtc_set_ SF Markus Elfring 2016-01-03 8:53 ` [rtc-linux] [PATCH 4/8] rtc-ab-b5ze-s3: Replace a variable initialisation by an assignment in _abb5zes3_rtc_set_alarm() SF Markus Elfring 2016-01-03 8:54 ` [PATCH 5/8] rtc-ab-b5ze-s3: Replace a variable initialisation by an assignment in _abb5zes3_rtc_read_alarm() SF Markus Elfring 2016-01-03 8:54 ` [PATCH 5/8] rtc-ab-b5ze-s3: Replace a variable initialisation by an assignment in _abb5zes3_rtc_read SF Markus Elfring 2016-01-03 8:54 ` [rtc-linux] [PATCH 5/8] rtc-ab-b5ze-s3: Replace a variable initialisation by an assignment in _abb5zes3_rtc_read_alarm() SF Markus Elfring 2016-01-03 8:55 ` [PATCH 6/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in _abb5zes3_rtc_read_timer() SF Markus Elfring 2016-01-03 8:55 ` SF Markus Elfring 2016-01-03 8:55 ` [rtc-linux] " SF Markus Elfring 2016-01-03 8:56 ` [PATCH 7/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in _abb5zes3_rtc_interrupt() SF Markus Elfring 2016-01-03 8:56 ` SF Markus Elfring 2016-01-03 8:56 ` [rtc-linux] " SF Markus Elfring 2016-01-03 12:48 ` Julia Lawall 2016-01-03 12:48 ` Julia Lawall 2016-01-03 12:48 ` [rtc-linux] " Julia Lawall 2016-01-03 16:54 ` SF Markus Elfring 2016-01-03 16:54 ` SF Markus Elfring 2016-01-03 16:54 ` [rtc-linux] " SF Markus Elfring 2016-01-03 16:59 ` Julia Lawall 2016-01-03 16:59 ` Julia Lawall 2016-01-03 16:59 ` [rtc-linux] " Julia Lawall 2016-01-03 12:48 ` Julia Lawall 2016-01-03 12:48 ` Julia Lawall 2016-01-03 12:48 ` [rtc-linux] " Julia Lawall 2016-01-03 17:00 ` SF Markus Elfring 2016-01-03 17:00 ` SF Markus Elfring 2016-01-03 17:00 ` [rtc-linux] " SF Markus Elfring 2016-01-03 8:57 ` [PATCH 8/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in _abb5zes3_rtc_set_timer() SF Markus Elfring 2016-01-03 8:57 ` SF Markus Elfring 2016-01-03 8:57 ` [rtc-linux] " SF Markus Elfring 2016-01-03 12:47 ` Julia Lawall 2016-01-03 12:47 ` Julia Lawall 2016-01-03 12:47 ` [rtc-linux] " Julia Lawall 2016-01-03 17:25 ` SF Markus Elfring 2016-01-03 17:25 ` SF Markus Elfring 2016-01-03 17:25 ` [rtc-linux] " SF Markus Elfring 2016-01-03 17:29 ` Julia Lawall 2016-01-03 17:29 ` Julia Lawall 2016-01-03 17:29 ` [rtc-linux] " Julia Lawall 2016-01-03 10:00 ` [PATCH 0/2] 390/qeth: Fine-tuning for qeth_core_set_online() SF Markus Elfring 2016-01-03 10:00 ` SF Markus Elfring 2016-01-03 10:02 ` [PATCH 1/2] 390/qeth: Delete an unnecessary variable initialisation in qeth_core_set_online() SF Markus Elfring 2016-01-03 10:02 ` SF Markus Elfring 2016-01-04 11:29 ` Heiko Carstens 2016-01-04 11:29 ` Heiko Carstens 2016-01-07 14:33 ` Ursula Braun 2016-01-07 14:33 ` Ursula Braun 2016-01-08 7:18 ` SF Markus Elfring 2016-01-08 7:18 ` SF Markus Elfring 2016-01-08 8:25 ` Ursula Braun 2016-01-08 8:25 ` Ursula Braun 2016-01-08 12:00 ` SF Markus Elfring 2016-01-08 12:00 ` SF Markus Elfring 2016-01-03 10:02 ` [PATCH 2/2] 390/qeth: Refactoring for qeth_core_set_online() SF Markus Elfring 2016-01-03 10:02 ` SF Markus Elfring 2016-01-04 11:30 ` Heiko Carstens 2016-01-04 11:30 ` Heiko Carstens 2016-01-04 13:10 ` SF Markus Elfring 2016-01-04 13:10 ` SF Markus Elfring 2016-01-04 14:04 ` Heiko Carstens 2016-01-04 14:04 ` Heiko Carstens 2016-01-04 14:10 ` SF Markus Elfring 2016-01-04 14:10 ` SF Markus Elfring 2016-01-05 7:54 ` Heiko Carstens 2016-01-05 7:54 ` Heiko Carstens 2016-01-03 16:32 ` [PATCH] staging-slicoss: Replace variable initialisations by assignments in slic_if_init() SF Markus Elfring 2016-01-03 16:32 ` SF Markus Elfring 2016-01-03 16:41 ` Julia Lawall 2016-01-03 16:41 ` Julia Lawall 2016-01-03 17:48 ` SF Markus Elfring 2016-01-03 17:48 ` SF Markus Elfring 2016-01-03 17:58 ` Greg Kroah-Hartman 2016-01-03 17:58 ` Greg Kroah-Hartman 2016-01-03 18:16 ` SF Markus Elfring 2016-01-03 18:16 ` SF Markus Elfring 2016-01-03 18:26 ` Greg Kroah-Hartman 2016-01-03 18:26 ` Greg Kroah-Hartman 2016-01-03 18:50 ` SF Markus Elfring 2016-01-03 18:50 ` SF Markus Elfring 2016-01-03 19:45 ` Greg Kroah-Hartman 2016-01-03 19:45 ` Greg Kroah-Hartman 2016-01-03 20:10 ` SF Markus Elfring 2016-01-03 20:10 ` SF Markus Elfring 2016-01-03 20:15 ` Greg Kroah-Hartman 2016-01-03 20:15 ` Greg Kroah-Hartman 2016-01-03 20:21 ` SF Markus Elfring 2016-01-03 20:21 ` SF Markus Elfring 2016-07-02 19:00 ` [PATCH 0/2] Input-at32psif: Fine-tuning for OOM handling in psif_probe() SF Markus Elfring 2016-07-02 19:00 ` SF Markus Elfring 2016-07-02 19:05 ` [PATCH 1/2] Input-at32psif: Return directly after a failed kzalloc() " SF Markus Elfring 2016-07-02 19:05 ` SF Markus Elfring 2016-07-02 19:07 ` [PATCH 2/2] Input-at32psif: Remove OOM messages " SF Markus Elfring 2016-07-02 19:07 ` SF Markus Elfring 2016-07-02 19:29 ` Julia Lawall 2016-07-02 19:29 ` Julia Lawall 2016-07-02 20:45 ` [PATCH 0/2] Input-at32psif: Fine-tuning for OOM handling " Joe Perches 2016-07-02 20:45 ` Joe Perches 2016-07-02 20:45 ` Joe Perches 2016-07-03 8:01 ` SF Markus Elfring 2016-07-03 8:01 ` SF Markus Elfring 2016-07-13 22:01 ` Dmitry Torokhov 2016-07-13 22:01 ` Dmitry Torokhov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=567AE463.4080702@users.sourceforge.net \ --to=elfring@users.sourceforge.net \ --cc=axboe@kernel.dk \ --cc=julia.lawall@lip6.fr \ --cc=kernel-janitors@vger.kernel.org \ --cc=ldm@flatcap.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-ntfs-dev@lists.sourceforge.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.