* [PATCH] mm: Fix missing #include in <linux/mmdebug.h>
@ 2015-12-19 20:30 Ben Hutchings
2016-01-04 14:08 ` Vlastimil Babka
2016-01-04 14:08 ` Vlastimil Babka
0 siblings, 2 replies; 4+ messages in thread
From: Ben Hutchings @ 2015-12-19 20:30 UTC (permalink / raw)
To: linux-mm; +Cc: xen-devel
[-- Attachment #1: Type: text/plain, Size: 1130 bytes --]
The various VM_WARN_ON/VM_BUG_ON macros depend on those defined by
<linux/bug.h>. Most users already include those, but not all; for
example:
CC arch/arm64/xen/../../arm/xen/grant-table.o
In file included from arch/arm64/include/../../arm/include/asm/xen/page.h:5:0,
from arch/arm64/include/asm/xen/page.h:1,
from include/xen/page.h:28,
from arch/arm64/xen/../../arm/xen/grant-table.c:33:
arch/arm64/include/asm/pgtable.h: In function 'set_pte_at':
arch/arm64/include/asm/pgtable.h:281:3: error: implicit declaration of function 'BUILD_BUG_ON_INVALID' [-Werror=implicit-function-declaration]
VM_WARN_ONCE(!pte_young(pte),
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
include/linux/mmdebug.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h
index 877ef22..772362a 100644
--- a/include/linux/mmdebug.h
+++ b/include/linux/mmdebug.h
@@ -1,6 +1,7 @@
#ifndef LINUX_MM_DEBUG_H
#define LINUX_MM_DEBUG_H 1
+#include <linux/bug.h>
#include <linux/stringify.h>
struct page;
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mm: Fix missing #include in <linux/mmdebug.h>
2015-12-19 20:30 [PATCH] mm: Fix missing #include in <linux/mmdebug.h> Ben Hutchings
2016-01-04 14:08 ` Vlastimil Babka
@ 2016-01-04 14:08 ` Vlastimil Babka
1 sibling, 0 replies; 4+ messages in thread
From: Vlastimil Babka @ 2016-01-04 14:08 UTC (permalink / raw)
To: Ben Hutchings, linux-mm; +Cc: xen-devel
On 12/19/2015 09:30 PM, Ben Hutchings wrote:
> The various VM_WARN_ON/VM_BUG_ON macros depend on those defined by
> <linux/bug.h>. Most users already include those, but not all; for
> example:
>
> CC arch/arm64/xen/../../arm/xen/grant-table.o
> In file included from arch/arm64/include/../../arm/include/asm/xen/page.h:5:0,
> from arch/arm64/include/asm/xen/page.h:1,
> from include/xen/page.h:28,
> from arch/arm64/xen/../../arm/xen/grant-table.c:33:
> arch/arm64/include/asm/pgtable.h: In function 'set_pte_at':
> arch/arm64/include/asm/pgtable.h:281:3: error: implicit declaration of function 'BUILD_BUG_ON_INVALID' [-Werror=implicit-function-declaration]
> VM_WARN_ONCE(!pte_young(pte),
>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
> ---
> include/linux/mmdebug.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h
> index 877ef22..772362a 100644
> --- a/include/linux/mmdebug.h
> +++ b/include/linux/mmdebug.h
> @@ -1,6 +1,7 @@
> #ifndef LINUX_MM_DEBUG_H
> #define LINUX_MM_DEBUG_H 1
>
> +#include <linux/bug.h>
> #include <linux/stringify.h>
>
> struct page;
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mm: Fix missing #include in <linux/mmdebug.h>
2015-12-19 20:30 [PATCH] mm: Fix missing #include in <linux/mmdebug.h> Ben Hutchings
@ 2016-01-04 14:08 ` Vlastimil Babka
2016-01-04 14:08 ` Vlastimil Babka
1 sibling, 0 replies; 4+ messages in thread
From: Vlastimil Babka @ 2016-01-04 14:08 UTC (permalink / raw)
To: Ben Hutchings, linux-mm; +Cc: xen-devel
On 12/19/2015 09:30 PM, Ben Hutchings wrote:
> The various VM_WARN_ON/VM_BUG_ON macros depend on those defined by
> <linux/bug.h>. Most users already include those, but not all; for
> example:
>
> CC arch/arm64/xen/../../arm/xen/grant-table.o
> In file included from arch/arm64/include/../../arm/include/asm/xen/page.h:5:0,
> from arch/arm64/include/asm/xen/page.h:1,
> from include/xen/page.h:28,
> from arch/arm64/xen/../../arm/xen/grant-table.c:33:
> arch/arm64/include/asm/pgtable.h: In function 'set_pte_at':
> arch/arm64/include/asm/pgtable.h:281:3: error: implicit declaration of function 'BUILD_BUG_ON_INVALID' [-Werror=implicit-function-declaration]
> VM_WARN_ONCE(!pte_young(pte),
>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
> ---
> include/linux/mmdebug.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h
> index 877ef22..772362a 100644
> --- a/include/linux/mmdebug.h
> +++ b/include/linux/mmdebug.h
> @@ -1,6 +1,7 @@
> #ifndef LINUX_MM_DEBUG_H
> #define LINUX_MM_DEBUG_H 1
>
> +#include <linux/bug.h>
> #include <linux/stringify.h>
>
> struct page;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] mm: Fix missing #include in <linux/mmdebug.h>
@ 2015-12-19 20:30 Ben Hutchings
0 siblings, 0 replies; 4+ messages in thread
From: Ben Hutchings @ 2015-12-19 20:30 UTC (permalink / raw)
To: linux-mm; +Cc: xen-devel
[-- Attachment #1.1: Type: text/plain, Size: 1130 bytes --]
The various VM_WARN_ON/VM_BUG_ON macros depend on those defined by
<linux/bug.h>. Most users already include those, but not all; for
example:
CC arch/arm64/xen/../../arm/xen/grant-table.o
In file included from arch/arm64/include/../../arm/include/asm/xen/page.h:5:0,
from arch/arm64/include/asm/xen/page.h:1,
from include/xen/page.h:28,
from arch/arm64/xen/../../arm/xen/grant-table.c:33:
arch/arm64/include/asm/pgtable.h: In function 'set_pte_at':
arch/arm64/include/asm/pgtable.h:281:3: error: implicit declaration of function 'BUILD_BUG_ON_INVALID' [-Werror=implicit-function-declaration]
VM_WARN_ONCE(!pte_young(pte),
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
include/linux/mmdebug.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h
index 877ef22..772362a 100644
--- a/include/linux/mmdebug.h
+++ b/include/linux/mmdebug.h
@@ -1,6 +1,7 @@
#ifndef LINUX_MM_DEBUG_H
#define LINUX_MM_DEBUG_H 1
+#include <linux/bug.h>
#include <linux/stringify.h>
struct page;
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-04 14:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-19 20:30 [PATCH] mm: Fix missing #include in <linux/mmdebug.h> Ben Hutchings
2016-01-04 14:08 ` Vlastimil Babka
2016-01-04 14:08 ` Vlastimil Babka
2015-12-19 20:30 Ben Hutchings
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.