[meta-networking][PATCH] samba: move RDEPENDS of perl from samba to samba-pidl

[meta-networking][PATCH] samba: move RDEPENDS of perl from samba to samba-pidl

[Jens Rehsack]

[-- Attachment #1: Type: text/plain, Size: 1333 bytes --]

samba-pidl is the package containing the perl-extension, so RDEPENDS
must include perl for samba-pidl, not for samba.

Signed-off-by: Jens Rehsack <sno@netbsd.org>
---
 meta-networking/recipes-connectivity/samba/samba_4.1.12.bb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta-networking/recipes-connectivity/samba/samba_4.1.12.bb b/meta-networking/recipes-connectivity/samba/samba_4.1.12.bb
index 5b343f2..de1f033 100644
--- a/meta-networking/recipes-connectivity/samba/samba_4.1.12.bb
+++ b/meta-networking/recipes-connectivity/samba/samba_4.1.12.bb
@@ -39,6 +39,8 @@ SRC_URI[md5sum] = "232016d7581a1ba11e991ec2674553c4"
 SRC_URI[sha256sum] = "033604674936bf5c77d7df299b0626052b84a41505a6a6afe902f6274fc29898"

 inherit systemd waf-samba cpan-base perlnative
+# remove default added RDEPENDS on perl
+RDEPENDS_${PN}_remove = "perl"

 DEPENDS += "readline virtual/libiconv zlib popt libtalloc libtdb libtevent libldb krb5 ctdb libbsd"

@@ -319,4 +321,5 @@ FILES_${PN}-python-dbg = "${libdir}/python${PYTHON_BASEVERSION}/site-packages/.d
                           ${libdir}/python${PYTHON_BASEVERSION}/site-packages/samba/dcerpc/.debug/* \
 "

+RDEPENDS_${PN}-pidl_append = " perl "
 FILES_${PN}-pidl = "${bindir}/pidl ${PERL_VERNDORLIB}/*"
--
1.9.1

--
Jens Rehsack - rehsack@gmail.com


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 859 bytes --]

Re: [meta-networking][PATCH] samba: move RDEPENDS of perl from samba to samba-pidl

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1827 bytes --]

On Mon, Jan 04, 2016 at 08:06:04PM +0100, Jens Rehsack wrote:
> samba-pidl is the package containing the perl-extension, so RDEPENDS
> must include perl for samba-pidl, not for samba.
> 
> Signed-off-by: Jens Rehsack <sno@netbsd.org>
> ---
>  meta-networking/recipes-connectivity/samba/samba_4.1.12.bb | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/meta-networking/recipes-connectivity/samba/samba_4.1.12.bb b/meta-networking/recipes-connectivity/samba/samba_4.1.12.bb
> index 5b343f2..de1f033 100644
> --- a/meta-networking/recipes-connectivity/samba/samba_4.1.12.bb
> +++ b/meta-networking/recipes-connectivity/samba/samba_4.1.12.bb
> @@ -39,6 +39,8 @@ SRC_URI[md5sum] = "232016d7581a1ba11e991ec2674553c4"
>  SRC_URI[sha256sum] = "033604674936bf5c77d7df299b0626052b84a41505a6a6afe902f6274fc29898"
> 
>  inherit systemd waf-samba cpan-base perlnative
> +# remove default added RDEPENDS on perl
> +RDEPENDS_${PN}_remove = "perl"
> 
>  DEPENDS += "readline virtual/libiconv zlib popt libtalloc libtdb libtevent libldb krb5 ctdb libbsd"
> 
> @@ -319,4 +321,5 @@ FILES_${PN}-python-dbg = "${libdir}/python${PYTHON_BASEVERSION}/site-packages/.d
>                            ${libdir}/python${PYTHON_BASEVERSION}/site-packages/samba/dcerpc/.debug/* \
>  "
> 
> +RDEPENDS_${PN}-pidl_append = " perl "

You don't need the trailing space (only the leading space is needed for
append).

>  FILES_${PN}-pidl = "${bindir}/pidl ${PERL_VERNDORLIB}/*"
> --
> 1.9.1
> 
> --
> Jens Rehsack - rehsack@gmail.com
> 



> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

Re: [meta-networking][PATCH] samba: move RDEPENDS of perl from samba to samba-pidl

[Mike Looijmans]

On 04-01-16 20:06, Jens Rehsack wrote:
> samba-pidl is the package containing the perl-extension, so RDEPENDS
> must include perl for samba-pidl, not for samba.
>
> Signed-off-by: Jens Rehsack <sno@netbsd.org>
> ---
>   meta-networking/recipes-connectivity/samba/samba_4.1.12.bb | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/meta-networking/recipes-connectivity/samba/samba_4.1.12.bb b/meta-networking/recipes-connectivity/samba/samba_4.1.12.bb
> index 5b343f2..de1f033 100644
> --- a/meta-networking/recipes-connectivity/samba/samba_4.1.12.bb
> +++ b/meta-networking/recipes-connectivity/samba/samba_4.1.12.bb
> @@ -39,6 +39,8 @@ SRC_URI[md5sum] = "232016d7581a1ba11e991ec2674553c4"
>   SRC_URI[sha256sum] = "033604674936bf5c77d7df299b0626052b84a41505a6a6afe902f6274fc29898"
>
>   inherit systemd waf-samba cpan-base perlnative
> +# remove default added RDEPENDS on perl
> +RDEPENDS_${PN}_remove = "perl"

This is a hack, not a solution.

Better to fix this at its core: cpan-base.bbclass forces both DEPENDS_${PN} 
and RDEPENDS_${PN} to contain "perl".

All that the recipe really wants to have is the perl version. It does not need 
a perl for the target, regardless of whether you'd want to install samba-pidl.

Fixing this at the proper level will considerably reduce compilation time for 
samba, which is already excessively long because of parallel build issues (the 
patch that fixes that isn't integrated).

>
>   DEPENDS += "readline virtual/libiconv zlib popt libtalloc libtdb libtevent libldb krb5 ctdb libbsd"
>
> @@ -319,4 +321,5 @@ FILES_${PN}-python-dbg = "${libdir}/python${PYTHON_BASEVERSION}/site-packages/.d
>                             ${libdir}/python${PYTHON_BASEVERSION}/site-packages/samba/dcerpc/.debug/* \
>   "
>
> +RDEPENDS_${PN}-pidl_append = " perl "
>   FILES_${PN}-pidl = "${bindir}/pidl ${PERL_VERNDORLIB}/*"
> --
> 1.9.1
>
> --
> Jens Rehsack - rehsack@gmail.com
>



Kind regards,

Mike Looijmans
System Expert

TOPIC Embedded Products
Eindhovenseweg 32-C, NL-5683 KH Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
Telefax: +31 (0) 499 33 69 70
E-mail: mike.looijmans@topicproducts.com
Website: www.topicproducts.com

Please consider the environment before printing this e-mail

Re: [meta-networking][PATCH] samba: move RDEPENDS of perl from samba to samba-pidl

[Jens Rehsack]

[-- Attachment #1: Type: text/plain, Size: 2382 bytes --]


> Am 05.01.2016 um 12:32 schrieb Mike Looijmans <mike.looijmans@topic.nl>:
> 
> On 04-01-16 20:06, Jens Rehsack wrote:
>> samba-pidl is the package containing the perl-extension, so RDEPENDS
>> must include perl for samba-pidl, not for samba.
>> 
>> Signed-off-by: Jens Rehsack <sno@netbsd.org>
>> ---
>>  meta-networking/recipes-connectivity/samba/samba_4.1.12.bb | 3 +++
>>  1 file changed, 3 insertions(+)
>> 
>> diff --git a/meta-networking/recipes-connectivity/samba/samba_4.1.12.bb b/meta-networking/recipes-connectivity/samba/samba_4.1.12.bb
>> index 5b343f2..de1f033 100644
>> --- a/meta-networking/recipes-connectivity/samba/samba_4.1.12.bb
>> +++ b/meta-networking/recipes-connectivity/samba/samba_4.1.12.bb
>> @@ -39,6 +39,8 @@ SRC_URI[md5sum] = "232016d7581a1ba11e991ec2674553c4"
>>  SRC_URI[sha256sum] = "033604674936bf5c77d7df299b0626052b84a41505a6a6afe902f6274fc29898"
>> 
>>  inherit systemd waf-samba cpan-base perlnative
>> +# remove default added RDEPENDS on perl
>> +RDEPENDS_${PN}_remove = "perl"
> 
> This is a hack, not a solution.

Neither, nor.

> Better to fix this at its core: cpan-base.bbclass forces both DEPENDS_${PN} and RDEPENDS_${PN} to contain "perl".

That's an API / behavior change to cpan-base.bbclass.
Since other recipes rely on that, it's not an easy solution to remove the dependency injection from cpab-base.bbclass.

> All that the recipe really wants to have is the perl version. It does not need a perl for the target, regardless of whether you'd want to install samba-pidl.

Wrong. The recipe wants the perl paths, too.

> Fixing this at the proper level will considerably reduce compilation time for samba, which is already excessively long because of parallel build issues (the patch that fixes that isn't integrated).
> 
>> 
>>  DEPENDS += "readline virtual/libiconv zlib popt libtalloc libtdb libtevent libldb krb5 ctdb libbsd"
>> 
>> @@ -319,4 +321,5 @@ FILES_${PN}-python-dbg = "${libdir}/python${PYTHON_BASEVERSION}/site-packages/.d
>>                            ${libdir}/python${PYTHON_BASEVERSION}/site-packages/samba/dcerpc/.debug/* \
>>  "
>> 
>> +RDEPENDS_${PN}-pidl_append = " perl "
>>  FILES_${PN}-pidl = "${bindir}/pidl ${PERL_VERNDORLIB}/*"
>> --
>> 1.9.1
>> 
>> --
>> Jens Rehsack - rehsack@gmail.com
>> 

Best regards
--
Jens Rehsack - rehsack@gmail.com


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 859 bytes --]