From: Laxman Dewangan <ldewangan@nvidia.com>
To: Mark Brown <broonie@kernel.org>
Cc: <robh+dt@kernel.org>, <pawel.moll@arm.com>,
<mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
<galak@codeaurora.org>, <lgirdwood@gmail.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] regulator: max8973: add support for junction thermal warning
Date: Wed, 6 Jan 2016 19:29:52 +0530 [thread overview]
Message-ID: <568D1DD8.9070705@nvidia.com> (raw)
In-Reply-To: <20160106123735.GX6588@sirena.org.uk>
On Wednesday 06 January 2016 06:07 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
>
>> In one of design, interrupt from MAX77620, and alert from both MAX77621
>> shorted and going to Arm GIC controller. On this case, I need to register
>> the interrupt as SHARED interrupt. This property can not be passed via
>> "interrupt" properties from DT.
>> That's why this flag is added to support this.
> If the driver supports shared interrupts it should just register as a
> shared interrupt all the time, there is nothing about shared interrupts
> which requires that the pin actually be shared.
>
>> Now, by default, if I register the interrupt as SHARED in driver then it
>> failed on second design as GPIO does not offer to register as SHARED
>> interrupt.
> What makes you say that this would fail?
The failure was due to the mismatch flags when registering interrupts. I
used flag as ONESHOT, TRIGGER Type and SHARED.
I experimented as make the interrupt flag as SHARED all places (and
ONESHOT always) so that all interrupt flag same for all registration on
both design. This way it works fine. It success on GPIO based flag also.
Now I am passing SHARED | ONESHOT on both driver interrupt registration.
I will drop the interrupt flag option from DT on next patch.
Thanks,
Laxman
WARNING: multiple messages have this Message-ID (diff)
From: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/1] regulator: max8973: add support for junction thermal warning
Date: Wed, 6 Jan 2016 19:29:52 +0530 [thread overview]
Message-ID: <568D1DD8.9070705@nvidia.com> (raw)
In-Reply-To: <20160106123735.GX6588-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On Wednesday 06 January 2016 06:07 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
>
>> In one of design, interrupt from MAX77620, and alert from both MAX77621
>> shorted and going to Arm GIC controller. On this case, I need to register
>> the interrupt as SHARED interrupt. This property can not be passed via
>> "interrupt" properties from DT.
>> That's why this flag is added to support this.
> If the driver supports shared interrupts it should just register as a
> shared interrupt all the time, there is nothing about shared interrupts
> which requires that the pin actually be shared.
>
>> Now, by default, if I register the interrupt as SHARED in driver then it
>> failed on second design as GPIO does not offer to register as SHARED
>> interrupt.
> What makes you say that this would fail?
The failure was due to the mismatch flags when registering interrupts. I
used flag as ONESHOT, TRIGGER Type and SHARED.
I experimented as make the interrupt flag as SHARED all places (and
ONESHOT always) so that all interrupt flag same for all registration on
both design. This way it works fine. It success on GPIO based flag also.
Now I am passing SHARED | ONESHOT on both driver interrupt registration.
I will drop the interrupt flag option from DT on next patch.
Thanks,
Laxman
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-01-06 14:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 6:15 [PATCH 1/1] regulator: max8973: add support for junction thermal warning Laxman Dewangan
2016-01-06 6:15 ` Laxman Dewangan
2016-01-06 12:18 ` Mark Brown
2016-01-06 12:18 ` Mark Brown
2016-01-06 12:19 ` Laxman Dewangan
2016-01-06 12:19 ` Laxman Dewangan
2016-01-06 12:37 ` Mark Brown
2016-01-06 13:59 ` Laxman Dewangan [this message]
2016-01-06 13:59 ` Laxman Dewangan
2016-01-06 14:25 ` Rob Herring
2016-01-06 14:20 ` Laxman Dewangan
2016-01-06 14:20 ` Laxman Dewangan
2016-01-06 16:28 ` Mark Brown
2016-01-06 16:28 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568D1DD8.9070705@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.