* [Qemu-devel] [PATCH v2 0/3] qemu-nbd.texi formatting, grammar and completeness fixes
@ 2016-01-05 7:33 Sitsofe Wheeler
2016-01-05 7:33 ` [Qemu-devel] [PATCH v2 1/3] qemu-nbd: Fix unintended texi verbatim formatting Sitsofe Wheeler
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Sitsofe Wheeler @ 2016-01-05 7:33 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Paolo Bonzini
Bring the qemu-nbd man page up to date with options and fix some styling and
grammar issues along the way.
Changes from v1:
- Add disconnect usage to synopsis.
- Add styling to synopsis usage.
- Fix up the grammar in the description.
- Move filename variable description out of the option table.
- Add a description of the NBD dev variable.
- Add reference to qemu man page to see also section.
- Fix sentence capitalisation in options section.
Sitsofe Wheeler (3):
qemu-nbd: Fix unintended texi verbatim formatting
qemu-nbd: Minor texi updates
qemu-nbd: Fix texi sentence capitalisation
qemu-nbd.texi | 80 +++++++++++++++++++++++++++++++++--------------------------
1 file changed, 45 insertions(+), 35 deletions(-)
--
2.4.3
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Qemu-devel] [PATCH v2 1/3] qemu-nbd: Fix unintended texi verbatim formatting
2016-01-05 7:33 [Qemu-devel] [PATCH v2 0/3] qemu-nbd.texi formatting, grammar and completeness fixes Sitsofe Wheeler
@ 2016-01-05 7:33 ` Sitsofe Wheeler
2016-01-05 7:33 ` [Qemu-devel] [PATCH v2 2/3] qemu-nbd: Minor texi updates Sitsofe Wheeler
` (2 subsequent siblings)
3 siblings, 0 replies; 9+ messages in thread
From: Sitsofe Wheeler @ 2016-01-05 7:33 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Paolo Bonzini
Indented lines in the texi meant the perlpod produced interpreted the
paragraph as being verbatim (thus formatting codes were not
interpreted). Fix this by un-indenting problem lines.
Signed-off-by: Sitsofe Wheeler <sitsofe@yahoo.com>
---
qemu-nbd.texi | 58 +++++++++++++++++++++++++++++-----------------------------
1 file changed, 29 insertions(+), 29 deletions(-)
diff --git a/qemu-nbd.texi b/qemu-nbd.texi
index 46fd483..26cc985 100644
--- a/qemu-nbd.texi
+++ b/qemu-nbd.texi
@@ -13,56 +13,56 @@ Export QEMU disk image using NBD protocol.
@c man begin OPTIONS
@table @option
@item @var{filename}
- is a disk image filename
+is a disk image filename
@item -p, --port=@var{port}
- port to listen on (default @samp{10809})
+port to listen on (default @samp{10809})
@item -o, --offset=@var{offset}
- offset into the image
+offset into the image
@item -b, --bind=@var{iface}
- interface to bind to (default @samp{0.0.0.0})
+interface to bind to (default @samp{0.0.0.0})
@item -k, --socket=@var{path}
- Use a unix socket with path @var{path}
+Use a unix socket with path @var{path}
@item -f, --format=@var{format}
- Set image format as @var{format}
+Set image format as @var{format}
@item -r, --read-only
- export read-only
+export read-only
@item -P, --partition=@var{num}
- only expose partition @var{num}
+only expose partition @var{num}
@item -s, --snapshot
- use @var{filename} as an external snapshot, create a temporary
- file with backing_file=@var{filename}, redirect the write to
- the temporary one
+use @var{filename} as an external snapshot, create a temporary
+file with backing_file=@var{filename}, redirect the write to
+the temporary one
@item -l, --load-snapshot=@var{snapshot_param}
- load an internal snapshot inside @var{filename} and export it
- as an read-only device, @var{snapshot_param} format is
- 'snapshot.id=[ID],snapshot.name=[NAME]' or '[ID_OR_NAME]'
+load an internal snapshot inside @var{filename} and export it
+as an read-only device, @var{snapshot_param} format is
+'snapshot.id=[ID],snapshot.name=[NAME]' or '[ID_OR_NAME]'
@item -n, --nocache
@itemx --cache=@var{cache}
- set cache mode to be used with the file. See the documentation of
- the emulator's @code{-drive cache=...} option for allowed values.
+set cache mode to be used with the file. See the documentation of
+the emulator's @code{-drive cache=...} option for allowed values.
@item --aio=@var{aio}
- choose asynchronous I/O mode between @samp{threads} (the default)
- and @samp{native} (Linux only).
+choose asynchronous I/O mode between @samp{threads} (the default)
+and @samp{native} (Linux only).
@item --discard=@var{discard}
- toggles whether @dfn{discard} (also known as @dfn{trim} or @dfn{unmap})
- requests are ignored or passed to the filesystem. The default is no
- (@samp{--discard=ignore}).
+toggles whether @dfn{discard} (also known as @dfn{trim} or @dfn{unmap})
+requests are ignored or passed to the filesystem. The default is no
+(@samp{--discard=ignore}).
@item -c, --connect=@var{dev}
- connect @var{filename} to NBD device @var{dev}
+connect @var{filename} to NBD device @var{dev}
@item -d, --disconnect
- disconnect the specified device
+disconnect the specified device
@item -e, --shared=@var{num}
- device can be shared by @var{num} clients (default @samp{1})
+device can be shared by @var{num} clients (default @samp{1})
@item -f, --format=@var{fmt}
- force block driver for format @var{fmt} instead of auto-detecting
+force block driver for format @var{fmt} instead of auto-detecting
@item -t, --persistent
- don't exit on the last connection
+don't exit on the last connection
@item -v, --verbose
- display extra debugging information
+display extra debugging information
@item -h, --help
- display this help and exit
+display this help and exit
@item -V, --version
- output version information and exit
+output version information and exit
@end table
@c man end
--
2.4.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Qemu-devel] [PATCH v2 2/3] qemu-nbd: Minor texi updates
2016-01-05 7:33 [Qemu-devel] [PATCH v2 0/3] qemu-nbd.texi formatting, grammar and completeness fixes Sitsofe Wheeler
2016-01-05 7:33 ` [Qemu-devel] [PATCH v2 1/3] qemu-nbd: Fix unintended texi verbatim formatting Sitsofe Wheeler
@ 2016-01-05 7:33 ` Sitsofe Wheeler
2016-01-07 12:41 ` Paolo Bonzini
2016-01-05 7:33 ` [Qemu-devel] [PATCH v2 3/3] qemu-nbd: Fix texi sentence capitalisation Sitsofe Wheeler
2016-01-07 12:42 ` [Qemu-devel] [PATCH v2 0/3] qemu-nbd.texi formatting, grammar and completeness fixes Paolo Bonzini
3 siblings, 1 reply; 9+ messages in thread
From: Sitsofe Wheeler @ 2016-01-05 7:33 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Paolo Bonzini
- Change some spacing.
- Add disconnect usage to synopsis.
- Highlight the command and its options in the synopsis.
- Fix up the grammar in the description.
- Move filename variable description out of the option table.
- Add a description of the dev variable.
- Remove duplicate entry for --format.
- Reword --discard documentation.
- Add --detect-zeroes documentation.
- Add reference to qemu man page to see also section.
Signed-off-by: Sitsofe Wheeler <sitsofe@yahoo.com>
---
qemu-nbd.texi | 34 ++++++++++++++++++++++------------
1 file changed, 22 insertions(+), 12 deletions(-)
diff --git a/qemu-nbd.texi b/qemu-nbd.texi
index 26cc985..5331d69 100644
--- a/qemu-nbd.texi
+++ b/qemu-nbd.texi
@@ -1,19 +1,23 @@
@example
@c man begin SYNOPSIS
-usage: qemu-nbd [OPTION]... @var{filename}
+@command{qemu-nbd} [OPTION]... @var{filename}
+
+@command{qemu-nbd} @option{-d} @var{dev}
@c man end
@end example
@c man begin DESCRIPTION
-Export QEMU disk image using NBD protocol.
+Export a QEMU disk image using the NBD protocol.
@c man end
@c man begin OPTIONS
+@var{filename} is a disk image filename.
+
+@var{dev} is an NBD device.
+
@table @option
-@item @var{filename}
-is a disk image filename
@item -p, --port=@var{port}
port to listen on (default @samp{10809})
@item -o, --offset=@var{offset}
@@ -22,8 +26,9 @@ offset into the image
interface to bind to (default @samp{0.0.0.0})
@item -k, --socket=@var{path}
Use a unix socket with path @var{path}
-@item -f, --format=@var{format}
-Set image format as @var{format}
+@item -f, --format=@var{fmt}
+force the use of the block driver for format @var{fmt} instead of
+auto-detecting
@item -r, --read-only
export read-only
@item -P, --partition=@var{num}
@@ -44,17 +49,22 @@ the emulator's @code{-drive cache=...} option for allowed values.
choose asynchronous I/O mode between @samp{threads} (the default)
and @samp{native} (Linux only).
@item --discard=@var{discard}
-toggles whether @dfn{discard} (also known as @dfn{trim} or @dfn{unmap})
-requests are ignored or passed to the filesystem. The default is no
-(@samp{--discard=ignore}).
+controls whether @dfn{discard} (also known as @dfn{trim} or @dfn{unmap})
+requests are ignored or passed to the filesystem. @var{discard} is one of
+@samp{ignore} (or @samp{off}), @samp{unmap} (or @samp{on}). The default is
+@samp{ignore}.
+@item --detect-zeroes=@var{detect-zeroes}
+enables the automatic conversion of plain zero writes by the OS to
+driver-specific optimized zero write commands. @var{detect-zeroes} is one of
+@samp{off}, @samp{on} or @samp{unmap}. @samp{unmap}
+converts a zero write to an unmap operation and can only be used if
+@var{discard} is set to @samp{unmap}. The default is @samp{off}.
@item -c, --connect=@var{dev}
connect @var{filename} to NBD device @var{dev}
@item -d, --disconnect
disconnect the specified device
@item -e, --shared=@var{num}
device can be shared by @var{num} clients (default @samp{1})
-@item -f, --format=@var{fmt}
-force block driver for format @var{fmt} instead of auto-detecting
@item -t, --persistent
don't exit on the last connection
@item -v, --verbose
@@ -79,7 +89,7 @@ warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
@c man end
@c man begin SEEALSO
-qemu-img(1)
+qemu(1), qemu-img(1)
@c man end
@end ignore
--
2.4.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Qemu-devel] [PATCH v2 3/3] qemu-nbd: Fix texi sentence capitalisation
2016-01-05 7:33 [Qemu-devel] [PATCH v2 0/3] qemu-nbd.texi formatting, grammar and completeness fixes Sitsofe Wheeler
2016-01-05 7:33 ` [Qemu-devel] [PATCH v2 1/3] qemu-nbd: Fix unintended texi verbatim formatting Sitsofe Wheeler
2016-01-05 7:33 ` [Qemu-devel] [PATCH v2 2/3] qemu-nbd: Minor texi updates Sitsofe Wheeler
@ 2016-01-05 7:33 ` Sitsofe Wheeler
2016-01-07 12:42 ` [Qemu-devel] [PATCH v2 0/3] qemu-nbd.texi formatting, grammar and completeness fixes Paolo Bonzini
3 siblings, 0 replies; 9+ messages in thread
From: Sitsofe Wheeler @ 2016-01-05 7:33 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Paolo Bonzini
Capitalise the first letter of sentences (and reword for grammar) the
options section of qemu-nbd.texi.
Signed-off-by: Sitsofe Wheeler <sitsofe@yahoo.com>
---
qemu-nbd.texi | 38 +++++++++++++++++++-------------------
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/qemu-nbd.texi b/qemu-nbd.texi
index 5331d69..0027841 100644
--- a/qemu-nbd.texi
+++ b/qemu-nbd.texi
@@ -19,60 +19,60 @@ Export a QEMU disk image using the NBD protocol.
@table @option
@item -p, --port=@var{port}
-port to listen on (default @samp{10809})
+The TCP port to listen on (default @samp{10809})
@item -o, --offset=@var{offset}
-offset into the image
+The offset into the image
@item -b, --bind=@var{iface}
-interface to bind to (default @samp{0.0.0.0})
+The interface to bind to (default @samp{0.0.0.0})
@item -k, --socket=@var{path}
Use a unix socket with path @var{path}
@item -f, --format=@var{fmt}
-force the use of the block driver for format @var{fmt} instead of
+Force the use of the block driver for format @var{fmt} instead of
auto-detecting
@item -r, --read-only
-export read-only
+Export the disk as read-only
@item -P, --partition=@var{num}
-only expose partition @var{num}
+Only expose partition @var{num}
@item -s, --snapshot
-use @var{filename} as an external snapshot, create a temporary
+Use @var{filename} as an external snapshot, create a temporary
file with backing_file=@var{filename}, redirect the write to
the temporary one
@item -l, --load-snapshot=@var{snapshot_param}
-load an internal snapshot inside @var{filename} and export it
+Load an internal snapshot inside @var{filename} and export it
as an read-only device, @var{snapshot_param} format is
'snapshot.id=[ID],snapshot.name=[NAME]' or '[ID_OR_NAME]'
@item -n, --nocache
@itemx --cache=@var{cache}
-set cache mode to be used with the file. See the documentation of
+The cache mode to be used with the file. See the documentation of
the emulator's @code{-drive cache=...} option for allowed values.
@item --aio=@var{aio}
-choose asynchronous I/O mode between @samp{threads} (the default)
+Set the asynchronous I/O mode between @samp{threads} (the default)
and @samp{native} (Linux only).
@item --discard=@var{discard}
-controls whether @dfn{discard} (also known as @dfn{trim} or @dfn{unmap})
+Control whether @dfn{discard} (also known as @dfn{trim} or @dfn{unmap})
requests are ignored or passed to the filesystem. @var{discard} is one of
@samp{ignore} (or @samp{off}), @samp{unmap} (or @samp{on}). The default is
@samp{ignore}.
@item --detect-zeroes=@var{detect-zeroes}
-enables the automatic conversion of plain zero writes by the OS to
+Control the automatic conversion of plain zero writes by the OS to
driver-specific optimized zero write commands. @var{detect-zeroes} is one of
@samp{off}, @samp{on} or @samp{unmap}. @samp{unmap}
converts a zero write to an unmap operation and can only be used if
@var{discard} is set to @samp{unmap}. The default is @samp{off}.
@item -c, --connect=@var{dev}
-connect @var{filename} to NBD device @var{dev}
+Connect @var{filename} to NBD device @var{dev}
@item -d, --disconnect
-disconnect the specified device
+Disconnect the device @var{dev}
@item -e, --shared=@var{num}
-device can be shared by @var{num} clients (default @samp{1})
+Allow up to @var{num} clients to share the device (default @samp{1})
@item -t, --persistent
-don't exit on the last connection
+Don't exit on the last connection
@item -v, --verbose
-display extra debugging information
+Display extra debugging information
@item -h, --help
-display this help and exit
+Display this help and exit
@item -V, --version
-output version information and exit
+Display version information and exit
@end table
@c man end
--
2.4.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [PATCH v2 2/3] qemu-nbd: Minor texi updates
2016-01-05 7:33 ` [Qemu-devel] [PATCH v2 2/3] qemu-nbd: Minor texi updates Sitsofe Wheeler
@ 2016-01-07 12:41 ` Paolo Bonzini
2016-01-13 19:03 ` Sitsofe Wheeler
0 siblings, 1 reply; 9+ messages in thread
From: Paolo Bonzini @ 2016-01-07 12:41 UTC (permalink / raw)
To: Sitsofe Wheeler, qemu-devel; +Cc: qemu-trivial
On 05/01/2016 08:33, Sitsofe Wheeler wrote:
> @example
> @c man begin SYNOPSIS
> -usage: qemu-nbd [OPTION]... @var{filename}
> +@command{qemu-nbd} [OPTION]... @var{filename}
Could you send another patch that does this change (add @command, remove
"usage:") for the other man pages as well?
Paolo
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [PATCH v2 0/3] qemu-nbd.texi formatting, grammar and completeness fixes
2016-01-05 7:33 [Qemu-devel] [PATCH v2 0/3] qemu-nbd.texi formatting, grammar and completeness fixes Sitsofe Wheeler
` (2 preceding siblings ...)
2016-01-05 7:33 ` [Qemu-devel] [PATCH v2 3/3] qemu-nbd: Fix texi sentence capitalisation Sitsofe Wheeler
@ 2016-01-07 12:42 ` Paolo Bonzini
2016-01-31 13:25 ` Sitsofe Wheeler
3 siblings, 1 reply; 9+ messages in thread
From: Paolo Bonzini @ 2016-01-07 12:42 UTC (permalink / raw)
To: Sitsofe Wheeler, qemu-devel; +Cc: qemu-trivial
On 05/01/2016 08:33, Sitsofe Wheeler wrote:
> Bring the qemu-nbd man page up to date with options and fix some styling and
> grammar issues along the way.
>
> Changes from v1:
> - Add disconnect usage to synopsis.
> - Add styling to synopsis usage.
> - Fix up the grammar in the description.
> - Move filename variable description out of the option table.
> - Add a description of the NBD dev variable.
> - Add reference to qemu man page to see also section.
> - Fix sentence capitalisation in options section.
>
> Sitsofe Wheeler (3):
> qemu-nbd: Fix unintended texi verbatim formatting
> qemu-nbd: Minor texi updates
> qemu-nbd: Fix texi sentence capitalisation
>
> qemu-nbd.texi | 80 +++++++++++++++++++++++++++++++++--------------------------
> 1 file changed, 45 insertions(+), 35 deletions(-)
>
Thanks, queued. Will send a pull request some time next week.
Paolo
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [PATCH v2 2/3] qemu-nbd: Minor texi updates
2016-01-07 12:41 ` Paolo Bonzini
@ 2016-01-13 19:03 ` Sitsofe Wheeler
0 siblings, 0 replies; 9+ messages in thread
From: Sitsofe Wheeler @ 2016-01-13 19:03 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-trivial, qemu-devel
On Thu, Jan 07, 2016 at 01:41:53PM +0100, Paolo Bonzini wrote:
>
> On 05/01/2016 08:33, Sitsofe Wheeler wrote:
> > @example
> > @c man begin SYNOPSIS
> > -usage: qemu-nbd [OPTION]... @var{filename}
> > +@command{qemu-nbd} [OPTION]... @var{filename}
>
> Could you send another patch that does this change (add @command, remove
> "usage:") for the other man pages as well?
OK I'll see what I can do.
--
Sitsofe | http://sucs.org/~sits/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [PATCH v2 0/3] qemu-nbd.texi formatting, grammar and completeness fixes
2016-01-07 12:42 ` [Qemu-devel] [PATCH v2 0/3] qemu-nbd.texi formatting, grammar and completeness fixes Paolo Bonzini
@ 2016-01-31 13:25 ` Sitsofe Wheeler
2016-02-01 0:44 ` Paolo Bonzini
0 siblings, 1 reply; 9+ messages in thread
From: Sitsofe Wheeler @ 2016-01-31 13:25 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-trivial, Michael Tokarev, qemu-devel
Hi,
On Thu, Jan 07, 2016 at 01:42:17PM +0100, Paolo Bonzini wrote:
>
> On 05/01/2016 08:33, Sitsofe Wheeler wrote:
> > Bring the qemu-nbd man page up to date with options and fix some styling and
> > grammar issues along the way.
> >
> > Changes from v1:
> > - Add disconnect usage to synopsis.
> > - Add styling to synopsis usage.
> > - Fix up the grammar in the description.
> > - Move filename variable description out of the option table.
> > - Add a description of the NBD dev variable.
> > - Add reference to qemu man page to see also section.
> > - Fix sentence capitalisation in options section.
> >
> > Sitsofe Wheeler (3):
> > qemu-nbd: Fix unintended texi verbatim formatting
> > qemu-nbd: Minor texi updates
> > qemu-nbd: Fix texi sentence capitalisation
> >
> > qemu-nbd.texi | 80 +++++++++++++++++++++++++++++++++--------------------------
> > 1 file changed, 45 insertions(+), 35 deletions(-)
> >
>
> Thanks, queued. Will send a pull request some time next week.
Just checking - did this one get lost? Nothing's popped up in the QEMU
git repos yet...
--
Sitsofe | http://sucs.org/~sits/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [PATCH v2 0/3] qemu-nbd.texi formatting, grammar and completeness fixes
2016-01-31 13:25 ` Sitsofe Wheeler
@ 2016-02-01 0:44 ` Paolo Bonzini
0 siblings, 0 replies; 9+ messages in thread
From: Paolo Bonzini @ 2016-02-01 0:44 UTC (permalink / raw)
To: Sitsofe Wheeler; +Cc: qemu-trivial, Michael Tokarev, qemu-devel
On 31/01/2016 14:25, Sitsofe Wheeler wrote:
>> > Thanks, queued. Will send a pull request some time next week.
> Just checking - did this one get lost? Nothing's popped up in the QEMU
> git repos yet...
Hmm, yes. Thanks for telling me.
Paolo
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-02-01 0:44 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-05 7:33 [Qemu-devel] [PATCH v2 0/3] qemu-nbd.texi formatting, grammar and completeness fixes Sitsofe Wheeler
2016-01-05 7:33 ` [Qemu-devel] [PATCH v2 1/3] qemu-nbd: Fix unintended texi verbatim formatting Sitsofe Wheeler
2016-01-05 7:33 ` [Qemu-devel] [PATCH v2 2/3] qemu-nbd: Minor texi updates Sitsofe Wheeler
2016-01-07 12:41 ` Paolo Bonzini
2016-01-13 19:03 ` Sitsofe Wheeler
2016-01-05 7:33 ` [Qemu-devel] [PATCH v2 3/3] qemu-nbd: Fix texi sentence capitalisation Sitsofe Wheeler
2016-01-07 12:42 ` [Qemu-devel] [PATCH v2 0/3] qemu-nbd.texi formatting, grammar and completeness fixes Paolo Bonzini
2016-01-31 13:25 ` Sitsofe Wheeler
2016-02-01 0:44 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.