All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shuah Khan <shuahkh@osg.samsung.com>
To: Brian Norris <computersforpeace@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Ming Lei <ming.lei@canonical.com>
Cc: Kees Cook <keescook@chromium.org>,
	linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
	"Luis R. Rodriguez" <mcgrof@suse.com>,
	Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH v2 3/5] test: firmware_class: add asynchronous request trigger
Date: Thu, 7 Jan 2016 13:56:22 -0700	[thread overview]
Message-ID: <568ED0F6.5090701@osg.samsung.com> (raw)
In-Reply-To: <1449701429-121423-3-git-send-email-computersforpeace@gmail.com>

On 12/09/2015 03:50 PM, Brian Norris wrote:
> We might want to test for bugs like that found in commit f9692b2699bd
> ("firmware: fix possible use after free on name on asynchronous
> request"), where the asynchronous request API had race conditions.
> 
> Let's add a simple file that will launch the async request, then wait
> until it's complete and report the status. It's not a true async test
> (we're using a mutex + wait_for_completion(), so we can't get more than
> one going at the same time), but it does help make sure the basic API is
> sane, and it can catch some class of bugs.
> 
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Cc: Luis R. Rodriguez <mcgrof@suse.com>


Thanks for the patch. Applied to linux-kselftest next for 4.5-rc1.

thanks,
-- Shuah
-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978

  parent reply	other threads:[~2016-01-07 20:56 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-09 22:50 [PATCH v2 1/5] test: firmware_class: report errors properly on failure Brian Norris
2015-12-09 22:50 ` Brian Norris
2015-12-09 22:50 ` [PATCH v2 2/5] test: firmware_class: use kstrndup() where appropriate Brian Norris
2015-12-09 22:50   ` Brian Norris
2016-01-07 20:55   ` Shuah Khan
2016-01-07 20:55     ` Shuah Khan
2015-12-09 22:50 ` [PATCH v2 3/5] test: firmware_class: add asynchronous request trigger Brian Norris
2015-12-09 22:50   ` Brian Norris
2015-12-09 23:22   ` Kees Cook
2015-12-09 23:22     ` Kees Cook
2016-01-07 20:56   ` Shuah Khan [this message]
2015-12-09 22:50 ` [PATCH v2 4/5] firmware: actually return NULL on failed request_firmware_nowait() Brian Norris
2015-12-09 22:50   ` Brian Norris
2015-12-21 19:06   ` Luis R. Rodriguez
2016-01-07 20:56   ` Shuah Khan
2016-01-07 20:56     ` Shuah Khan
2015-12-09 22:50 ` [PATCH v2 5/5] selftests: firmware: add empty string and async tests Brian Norris
2015-12-09 22:50   ` Brian Norris
2016-01-07 20:57   ` Shuah Khan
2016-01-07 20:57     ` Shuah Khan
2016-01-07 21:39     ` Brian Norris
2016-01-07 21:39       ` Brian Norris
2016-01-07 21:42       ` Shuah Khan
2016-01-07 21:42         ` Shuah Khan
2016-01-07 20:54 ` [PATCH v2 1/5] test: firmware_class: report errors properly on failure Shuah Khan
2016-01-07 20:54   ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=568ED0F6.5090701@osg.samsung.com \
    --to=shuahkh@osg.samsung.com \
    --cc=computersforpeace@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=keescook@chromium.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@suse.com \
    --cc=ming.lei@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.