From: Shuah Khan <shuahkh@osg.samsung.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ming Lei <ming.lei@canonical.com>,
Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
"Luis R. Rodriguez" <mcgrof@suse.com>,
Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH v2 5/5] selftests: firmware: add empty string and async tests
Date: Thu, 7 Jan 2016 14:42:37 -0700 [thread overview]
Message-ID: <568EDBCD.7070201@osg.samsung.com> (raw)
In-Reply-To: <20160107213953.GA49009@google.com>
On 01/07/2016 02:39 PM, Brian Norris wrote:
> Hi Shuah,
>
> On Thu, Jan 07, 2016 at 01:57:26PM -0700, Shuah Khan wrote:
>> On 12/09/2015 03:50 PM, Brian Norris wrote:
>>> Now that we've added a 'trigger_async_request' knob to test the
>>> request_firmware_nowait() API, let's use it. Also add tests for the
>>> empty ("") string, since there have been a couple errors in that
>>> handling already.
>>>
>>> Since we now have real ways that the sysfs write might fail, let's add
>>> the appropriate check on the 'echo' lines too.
>>>
>>> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
>>> Acked-by: Kees Cook <keescook@chromium.org>
>>
>> Thanks for the patch. Applied to linux-kselftest next for 4.5-rc1.
>
> Great! Perhaps I'm missing something: I see patches 1-4, but not this
> patch (patch 5) in:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git +next
>
Should show up in a bit. Looks like I applied to my local
and didn't do a push. Thanks for double checking.
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
WARNING: multiple messages have this Message-ID (diff)
From: Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
To: Brian Norris <computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Ming Lei <ming.lei-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
Kees Cook <keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Luis R. Rodriguez" <mcgrof-IBi9RG/b67k@public.gmane.org>,
Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
Subject: Re: [PATCH v2 5/5] selftests: firmware: add empty string and async tests
Date: Thu, 7 Jan 2016 14:42:37 -0700 [thread overview]
Message-ID: <568EDBCD.7070201@osg.samsung.com> (raw)
In-Reply-To: <20160107213953.GA49009-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
On 01/07/2016 02:39 PM, Brian Norris wrote:
> Hi Shuah,
>
> On Thu, Jan 07, 2016 at 01:57:26PM -0700, Shuah Khan wrote:
>> On 12/09/2015 03:50 PM, Brian Norris wrote:
>>> Now that we've added a 'trigger_async_request' knob to test the
>>> request_firmware_nowait() API, let's use it. Also add tests for the
>>> empty ("") string, since there have been a couple errors in that
>>> handling already.
>>>
>>> Since we now have real ways that the sysfs write might fail, let's add
>>> the appropriate check on the 'echo' lines too.
>>>
>>> Signed-off-by: Brian Norris <computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>> Acked-by: Kees Cook <keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
>>
>> Thanks for the patch. Applied to linux-kselftest next for 4.5-rc1.
>
> Great! Perhaps I'm missing something: I see patches 1-4, but not this
> patch (patch 5) in:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git +next
>
Should show up in a bit. Looks like I applied to my local
and didn't do a push. Thanks for double checking.
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org | (970) 217-8978
next prev parent reply other threads:[~2016-01-07 21:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 22:50 [PATCH v2 1/5] test: firmware_class: report errors properly on failure Brian Norris
2015-12-09 22:50 ` Brian Norris
2015-12-09 22:50 ` [PATCH v2 2/5] test: firmware_class: use kstrndup() where appropriate Brian Norris
2015-12-09 22:50 ` Brian Norris
2016-01-07 20:55 ` Shuah Khan
2016-01-07 20:55 ` Shuah Khan
2015-12-09 22:50 ` [PATCH v2 3/5] test: firmware_class: add asynchronous request trigger Brian Norris
2015-12-09 22:50 ` Brian Norris
2015-12-09 23:22 ` Kees Cook
2015-12-09 23:22 ` Kees Cook
2016-01-07 20:56 ` Shuah Khan
2015-12-09 22:50 ` [PATCH v2 4/5] firmware: actually return NULL on failed request_firmware_nowait() Brian Norris
2015-12-09 22:50 ` Brian Norris
2015-12-21 19:06 ` Luis R. Rodriguez
2016-01-07 20:56 ` Shuah Khan
2016-01-07 20:56 ` Shuah Khan
2015-12-09 22:50 ` [PATCH v2 5/5] selftests: firmware: add empty string and async tests Brian Norris
2015-12-09 22:50 ` Brian Norris
2016-01-07 20:57 ` Shuah Khan
2016-01-07 20:57 ` Shuah Khan
2016-01-07 21:39 ` Brian Norris
2016-01-07 21:39 ` Brian Norris
2016-01-07 21:42 ` Shuah Khan [this message]
2016-01-07 21:42 ` Shuah Khan
2016-01-07 20:54 ` [PATCH v2 1/5] test: firmware_class: report errors properly on failure Shuah Khan
2016-01-07 20:54 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568EDBCD.7070201@osg.samsung.com \
--to=shuahkh@osg.samsung.com \
--cc=computersforpeace@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@suse.com \
--cc=ming.lei@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.