All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: u-boot@lists.denx.de, Ramon Fried <rfried.dev@gmail.com>,
	Priyanka Jain <priyanka.jain@nxp.com>
Subject: Re: [PATCH v2] board: sl28: add DSA support for variant 2
Date: Wed, 30 Jun 2021 13:21:29 +0200	[thread overview]
Message-ID: <568d9ce6ef5432ca6d7b8d08657b9b87@walle.cc> (raw)
In-Reply-To: <20210630103456.6fwem735ue7r7dzg@skbuf>

Am 2021-06-30 12:34, schrieb Vladimir Oltean:
> On Wed, Jun 30, 2021 at 10:26:57AM +0200, Michael Walle wrote:
>> Can this please go through the net queue?
>> 
>> By chance, I've seen this patch:
>> https://patchwork.ozlabs.org/project/uboot/patch/20210629175317.2607470-5-vladimir.oltean@nxp.com/
>> 
>> Now I'm lucky that I have the following chunk, otherwise the patch 
>> wouldn't
>> work.
>> 
>> +&enetc2 {
>> +	status = "okay";
>> +};
> 
> Why "lucky"? I remember you were pushing this device tree style in the
> first place.

Thats correct, but in u-boot this device was still defaulting to
status = "okay", thus it would have been superfluous to still enable
it in the board dts. And tbh, I don't exactly know why I enabled
it nonetheless. Normally I keep things small ;)

Its not about the change (which is good), but there seems to be
a disconnect between which patches goes through which queue and
you have to be lucky that a (newer) patch doesn't break your patch
which is sitting on another queue to be picked up while the newer
one is already pulled in.

-- 
-michael

  reply	other threads:[~2021-06-30 11:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-23 11:56 [PATCH v2] board: sl28: add DSA support for variant 2 Michael Walle
2021-06-30  8:26 ` Michael Walle
2021-06-30 10:34   ` Vladimir Oltean
2021-06-30 11:21     ` Michael Walle [this message]
2021-07-02  9:41       ` Ramon Fried

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=568d9ce6ef5432ca6d7b8d08657b9b87@walle.cc \
    --to=michael@walle.cc \
    --cc=olteanv@gmail.com \
    --cc=priyanka.jain@nxp.com \
    --cc=rfried.dev@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.