* [PATCH] staging: iio: cdc: Prefer using the BIT macro
@ 2016-01-10 6:20 Bhaktipriya Shridhar
2016-01-10 11:53 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Bhaktipriya Shridhar @ 2016-01-10 6:20 UTC (permalink / raw)
To: lars, Michael.Hennerich, jic23, knaack.h, pmeerw, gregkh, bhaktipriya96
Cc: linux-iio, devel, linux-kernel
Replace all occurences of (1<<x) by BIT(x) in the file ad7150.c to get rid
of checkpatch.pl "CHECK" output "Prefer using the BIT macro"
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/staging/iio/cdc/ad7150.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/iio/cdc/ad7150.c b/drivers/staging/iio/cdc/ad7150.c
index e8d0ff2..0b934f7 100644
--- a/drivers/staging/iio/cdc/ad7150.c
+++ b/drivers/staging/iio/cdc/ad7150.c
@@ -21,8 +21,8 @@
*/
#define AD7150_STATUS 0
-#define AD7150_STATUS_OUT1 (1 << 3)
-#define AD7150_STATUS_OUT2 (1 << 5)
+#define AD7150_STATUS_OUT1 BIT(3)
+#define AD7150_STATUS_OUT2 BIT(5)
#define AD7150_CH1_DATA_HIGH 1
#define AD7150_CH2_DATA_HIGH 3
#define AD7150_CH1_AVG_HIGH 5
@@ -36,7 +36,7 @@
#define AD7150_CH2_TIMEOUT 13
#define AD7150_CH2_SETUP 14
#define AD7150_CFG 15
-#define AD7150_CFG_FIX (1 << 7)
+#define AD7150_CFG_FIX BIT(7)
#define AD7150_PD_TIMER 16
#define AD7150_CH1_CAPDAC 17
#define AD7150_CH2_CAPDAC 18
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: iio: cdc: Prefer using the BIT macro
2016-01-10 6:20 [PATCH] staging: iio: cdc: Prefer using the BIT macro Bhaktipriya Shridhar
@ 2016-01-10 11:53 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2016-01-10 11:53 UTC (permalink / raw)
To: Bhaktipriya Shridhar, lars, Michael.Hennerich, knaack.h, pmeerw, gregkh
Cc: linux-iio, devel, linux-kernel
On 10/01/16 06:20, Bhaktipriya Shridhar wrote:
> Replace all occurences of (1<<x) by BIT(x) in the file ad7150.c to get rid
> of checkpatch.pl "CHECK" output "Prefer using the BIT macro"
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Hi,
I'm afraid that a similar patch was sent by Shraddha Barke back at the end
of December. It just missed the last merge window so can currently only
be found in the testing branch of iio.git.
Thanks anyway. It is always amazing how long code can sit in a given state
before several patches turn up for it in a couple of weeks!
Jonathan
> ---
> drivers/staging/iio/cdc/ad7150.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/iio/cdc/ad7150.c b/drivers/staging/iio/cdc/ad7150.c
> index e8d0ff2..0b934f7 100644
> --- a/drivers/staging/iio/cdc/ad7150.c
> +++ b/drivers/staging/iio/cdc/ad7150.c
> @@ -21,8 +21,8 @@
> */
>
> #define AD7150_STATUS 0
> -#define AD7150_STATUS_OUT1 (1 << 3)
> -#define AD7150_STATUS_OUT2 (1 << 5)
> +#define AD7150_STATUS_OUT1 BIT(3)
> +#define AD7150_STATUS_OUT2 BIT(5)
> #define AD7150_CH1_DATA_HIGH 1
> #define AD7150_CH2_DATA_HIGH 3
> #define AD7150_CH1_AVG_HIGH 5
> @@ -36,7 +36,7 @@
> #define AD7150_CH2_TIMEOUT 13
> #define AD7150_CH2_SETUP 14
> #define AD7150_CFG 15
> -#define AD7150_CFG_FIX (1 << 7)
> +#define AD7150_CFG_FIX BIT(7)
> #define AD7150_PD_TIMER 16
> #define AD7150_CH1_CAPDAC 17
> #define AD7150_CH2_CAPDAC 18
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] Staging: iio: cdc: Prefer using the BIT macro
@ 2015-09-30 13:57 Shraddha Barke
0 siblings, 0 replies; 3+ messages in thread
From: Shraddha Barke @ 2015-09-30 13:57 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Shraddha Barke
Replace bit shifting on 1 with the BIT(x) macro
This was done with coccinelle:
@@ int g; @@
-(1 << g)
+BIT(g)
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
drivers/staging/iio/cdc/ad7746.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
index 10fa372..aa97437 100644
--- a/drivers/staging/iio/cdc/ad7746.c
+++ b/drivers/staging/iio/cdc/ad7746.c
@@ -52,10 +52,10 @@
#define AD7746_STATUS_RDYCAP BIT(0)
/* Capacitive Channel Setup Register Bit Designations (AD7746_REG_CAP_SETUP) */
-#define AD7746_CAPSETUP_CAPEN (1 << 7)
-#define AD7746_CAPSETUP_CIN2 (1 << 6) /* AD7746 only */
-#define AD7746_CAPSETUP_CAPDIFF (1 << 5)
-#define AD7746_CAPSETUP_CACHOP (1 << 0)
+#define AD7746_CAPSETUP_CAPEN BIT(7)
+#define AD7746_CAPSETUP_CIN2 BIT(6) /* AD7746 only */
+#define AD7746_CAPSETUP_CAPDIFF BIT(5)
+#define AD7746_CAPSETUP_CACHOP BIT(0)
/* Voltage/Temperature Setup Register Bit Designations (AD7746_REG_VT_SETUP) */
#define AD7746_VTSETUP_VTEN (1 << 7)
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-10 11:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-10 6:20 [PATCH] staging: iio: cdc: Prefer using the BIT macro Bhaktipriya Shridhar
2016-01-10 11:53 ` Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2015-09-30 13:57 [PATCH] Staging: " Shraddha Barke
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.