From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Damien Riegel <damien.riegel@savoirfairelinux.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-can@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Wolfgang Grandegger <wg@grandegger.com>,
kernel@savoirfairelinux.com
Subject: Re: [PATCH v2 3/3] can: sja1000: of: add compatibility with Technologic Systems version
Date: Tue, 12 Jan 2016 08:55:38 +0100 [thread overview]
Message-ID: <5694B17A.10406@pengutronix.de> (raw)
In-Reply-To: <1450978973-30417-4-git-send-email-damien.riegel@savoirfairelinux.com>
[-- Attachment #1: Type: text/plain, Size: 678 bytes --]
On 12/24/2015 06:42 PM, Damien Riegel wrote:
> Technologic Systems provides an IP compatible with the SJA1000,
> instantiated in an FPGA. Because of some bus widths issue, access to
> registers is made through a "window" that works like this:
>
> base + 0x0: address to read/write
> base + 0x2: 8-bit register value
Why do you use io{read,write}16 if it's a 8 bit register?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2016-01-12 7:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-24 17:42 [PATCH v2 0/3] can: sja1000: support for technologic version Damien Riegel
2015-12-24 17:42 ` [PATCH v2 1/3] can: sja1000: of: add per-compatible init hook Damien Riegel
2016-01-12 7:52 ` Marc Kleine-Budde
2016-01-12 15:53 ` Damien Riegel
2016-01-12 16:24 ` Marc Kleine-Budde
2015-12-24 17:42 ` [PATCH v2 2/3] can: sja1000: add documentation for Technologic Systems version Damien Riegel
2015-12-24 17:42 ` [PATCH v2 3/3] can: sja1000: of: add compatibility with " Damien Riegel
2016-01-12 7:55 ` Marc Kleine-Budde [this message]
2016-01-12 15:51 ` Damien Riegel
2016-01-11 16:58 ` [PATCH v2 0/3] can: sja1000: support for technologic version Damien Riegel
2016-01-12 7:56 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5694B17A.10406@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=damien.riegel@savoirfairelinux.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@savoirfairelinux.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.