All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>,
	QEMU Developers <qemu-devel@nongnu.org>
Cc: "Wei-Bo, Chen" <webberapple@gmail.com>
Subject: Re: [Qemu-devel] [RFC] util: Fix QEMU_LD_PREFIX endless loop
Date: Fri, 15 Jan 2016 10:15:28 -0800	[thread overview]
Message-ID: <56993740.2090801@twiddle.net> (raw)
In-Reply-To: <CAFEAcA92g2feKUvsejKzWkRL4waO_hxA_k73VxJFir3Yy_s0FA@mail.gmail.com>

On 01/15/2016 09:53 AM, Peter Maydell wrote:
>> @@ -58,7 +58,7 @@ static struct pathelem *new_entry(const char *root,
>>  #if defined(DT_DIR) && defined(DT_UNKNOWN) && defined(DT_LNK)
>>  # define dirent_type(dirent) ((dirent)->d_type)
>>  # define is_dir_maybe(type) \
>> -    ((type) == DT_DIR || (type) == DT_UNKNOWN || (type) == DT_LNK)
>> +    ((type) == DT_DIR || (type) == DT_UNKNOWN)
>>  #else
>>  # define dirent_type(dirent) (1)
>>  # define is_dir_maybe(type)  (type)
>> --
>> 2.5.0
> 
> This change would be essentially reverting commit 338d80dd353c50b63,
> which specifically added support for symbolic links in the directory
> structure. So if we applied it we'd be regressing on the problem
> that that change was meant to fix.
> 
> Richard, git says that commit was one of yours :-)

Because gcc and qemu have different names for their sysroot trees, and in my
disks, gcc is the "master".  So I normally have

   .../qemu/run/qemu-alpha -> .../gcc/run-cross/alphaev67-linux/sys-root
   .../qemu/run/qemu-arm -> .../gcc/run-cross/arm-linux-gnueabi/sys-root
   .../qemu/run/qemu-sparc -> .../gcc/run-cross/sparc64-linux/sys-root
   .../qemu/run/qemu-sparc64 -> .../gcc/run-cross/sparc64-linux/sys-root

The DT_LNK is required for traversing even the first link.


r~

  reply	other threads:[~2016-01-15 18:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-06 15:21 [Qemu-devel] [RFC] util: Fix QEMU_LD_PREFIX endless loop Wei-Bo, Chen
2016-01-06 16:25 ` 陳威伯
2016-01-11 18:52   ` 陳威伯
2016-01-11 19:07     ` Peter Maydell
2016-01-15 17:53 ` Peter Maydell
2016-01-15 18:15   ` Richard Henderson [this message]
2016-01-19 18:15     ` Peter Maydell
2016-01-19 20:11       ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56993740.2090801@twiddle.net \
    --to=rth@twiddle.net \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=webberapple@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.