All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Jonathan Creekmore <jonathan.creekmore@gmail.com>
Cc: xen-devel@lists.xenproject.org, Keir Fraser <keir@xen.org>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>, Tim Deegan <tim@xen.org>
Subject: Re: [PATCH v6 1/5] build: Env var to enable expert config options
Date: Mon, 18 Jan 2016 00:46:54 -0700	[thread overview]
Message-ID: <569CA67E02000078000C7C49@prv-mh.provo.novell.com> (raw)
In-Reply-To: <AB25544A-186D-4F96-8BD3-6C9D2F06D950@gmail.com>

>>> On 15.01.16 at 18:33, <jonathan.creekmore@gmail.com> wrote:

>> On Jan 15, 2016, at 11:20 AM, Jan Beulich <JBeulich@suse.com> wrote:
>> 
>>>>> On 15.01.16 at 18:01, <jonathan.creekmore@gmail.com> wrote:
>>> --- a/xen/Makefile
>>> +++ b/xen/Makefile
>>> @@ -11,6 +11,7 @@ export XEN_DOMAIN	?= $(shell ([ -x /bin/dnsdomainname ] && 
> /bin/dnsdomainname) |
>>> export XEN_BUILD_DATE	?= $(shell LC_ALL=C date)
>>> export XEN_BUILD_TIME	?= $(shell LC_ALL=C date +%T)
>>> export XEN_BUILD_HOST	?= $(shell hostname)
>>> +export XEN_CONFIG_EXPERT ?= n
>> 
>> This, I'm afraid, invalidates what I've said in another reply on
>> the earlier thread a few minutes ago. What Makefile.kconfig
>> gets to see must be consistent for FORCE to not be added to
>> include/config/auto.conf's dependencies by auto.conf.cmd.
>> 
>> Or in other words - did you check (in conjunction with that other
>> patch fixing incremental rebuilds) whether incremental rebuilds
>> aren't again becoming full rebuilds because of this when there's
>> no XEN_CONFIG_EXPERT in the environment?
> 
> I have applied your patch on top of my branch and I do not see incremental 
> rebuilds becoming full rebuilds whether XEN_CONFIG_EXPERT is not in the
> environment.

Thanks; indeed I've meanwhile realized that the "export" here
should be taking care of avoiding that situation

Jan

  reply	other threads:[~2016-01-18  7:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-15 17:01 [PATCH v6 0/5] Allow schedulers to be selectable through Kconfig Jonathan Creekmore
2016-01-15 17:01 ` [PATCH v6 1/5] build: Env var to enable expert config options Jonathan Creekmore
2016-01-15 17:20   ` Jan Beulich
2016-01-15 17:33     ` Jonathan Creekmore
2016-01-18  7:46       ` Jan Beulich [this message]
2016-01-15 17:01 ` [PATCH v6 2/5] build: Hook the schedulers into Kconfig Jonathan Creekmore
2016-01-19 10:55   ` Dario Faggioli
2016-01-15 17:01 ` [PATCH v6 3/5] build: Alloc space for sched list in the link file Jonathan Creekmore
2016-01-20 14:34   ` Jonathan Creekmore
2016-01-20 14:45     ` Ian Campbell
2016-01-15 17:01 ` [PATCH v6 4/5] sched: Register the schedulers into the list Jonathan Creekmore
2016-01-15 17:01 ` [PATCH v6 5/5] sched: Use the auto-generated list of schedulers Jonathan Creekmore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=569CA67E02000078000C7C49@prv-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jonathan.creekmore@gmail.com \
    --cc=keir@xen.org \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.