All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] e2fsprogs: disable libblkid again
@ 2016-01-21  7:20 Koen Kooi
  2016-01-21  7:42 ` Robert Yang
  2016-01-21 20:32 ` Burton, Ross
  0 siblings, 2 replies; 6+ messages in thread
From: Koen Kooi @ 2016-01-21  7:20 UTC (permalink / raw)
  To: openembedded-core; +Cc: Koen Kooi

We use the util-linux one and do_install deletes it anyway.

See OE-core commit fb8e776ea91c39d586b46400ad30aeea8dead1c4 for more info.

Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
---
 meta/recipes-devtools/e2fsprogs/e2fsprogs_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs_git.bb b/meta/recipes-devtools/e2fsprogs/e2fsprogs_git.bb
index c82e99a..f244473 100644
--- a/meta/recipes-devtools/e2fsprogs/e2fsprogs_git.bb
+++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs_git.bb
@@ -14,7 +14,7 @@ UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>\d+\.\d+(\.\d+)*)$"
 
 EXTRA_OECONF += "--libdir=${base_libdir} --sbindir=${base_sbindir} \
                 --enable-elf-shlibs --disable-libuuid --disable-uuidd \
-                --enable-libblkid --enable-verbose-makecmds"
+                --disable-libblkid --enable-verbose-makecmds"
 
 EXTRA_OECONF_darwin = "--libdir=${base_libdir} --sbindir=${base_sbindir} --enable-bsd-shlibs"
 
-- 
2.4.3



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] e2fsprogs: disable libblkid again
  2016-01-21  7:20 [PATCH] e2fsprogs: disable libblkid again Koen Kooi
@ 2016-01-21  7:42 ` Robert Yang
  2016-01-21  7:44   ` Koen Kooi
  2016-01-21 20:32 ` Burton, Ross
  1 sibling, 1 reply; 6+ messages in thread
From: Robert Yang @ 2016-01-21  7:42 UTC (permalink / raw)
  To: Koen Kooi, openembedded-core



On 01/21/2016 03:20 PM, Koen Kooi wrote:
> We use the util-linux one and do_install deletes it anyway.
>
> See OE-core commit fb8e776ea91c39d586b46400ad30aeea8dead1c4 for more info.
>
> Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
> ---
>   meta/recipes-devtools/e2fsprogs/e2fsprogs_git.bb | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs_git.bb b/meta/recipes-devtools/e2fsprogs/e2fsprogs_git.bb
> index c82e99a..f244473 100644
> --- a/meta/recipes-devtools/e2fsprogs/e2fsprogs_git.bb
> +++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs_git.bb
> @@ -14,7 +14,7 @@ UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>\d+\.\d+(\.\d+)*)$"
>
>   EXTRA_OECONF += "--libdir=${base_libdir} --sbindir=${base_sbindir} \
>                   --enable-elf-shlibs --disable-libuuid --disable-uuidd \
> -                --enable-libblkid --enable-verbose-makecmds"
> +                --disable-libblkid --enable-verbose-makecmds"

Thanks, maybe we also need cleanup other codes like:

     # We use blkid from util-linux now so remove from here
     rm -f ${D}${base_libdir}/libblkid*

And:

ALTERNATIVE_${PN}-doc = "libblkid.3 blkid.8"
ALTERNATIVE_LINK_NAME[libblkid.3] = "${mandir}/man3/libblkid.3"
ALTERNATIVE_LINK_NAME[blkid.8] = "${mandir}/man8/blkid.8"

// Robert

>
>   EXTRA_OECONF_darwin = "--libdir=${base_libdir} --sbindir=${base_sbindir} --enable-bsd-shlibs"
>
>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] e2fsprogs: disable libblkid again
  2016-01-21  7:42 ` Robert Yang
@ 2016-01-21  7:44   ` Koen Kooi
  2016-01-21 21:53     ` Richard Purdie
  0 siblings, 1 reply; 6+ messages in thread
From: Koen Kooi @ 2016-01-21  7:44 UTC (permalink / raw)
  To: Robert Yang; +Cc: Patches and discussions about the oe-core layer

On 21 January 2016 at 08:42, Robert Yang <liezhi.yang@windriver.com> wrote:
>
>
> On 01/21/2016 03:20 PM, Koen Kooi wrote:
>>
>> We use the util-linux one and do_install deletes it anyway.
>>
>> See OE-core commit fb8e776ea91c39d586b46400ad30aeea8dead1c4 for more info.
>>
>> Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
>> ---
>>   meta/recipes-devtools/e2fsprogs/e2fsprogs_git.bb | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs_git.bb
>> b/meta/recipes-devtools/e2fsprogs/e2fsprogs_git.bb
>> index c82e99a..f244473 100644
>> --- a/meta/recipes-devtools/e2fsprogs/e2fsprogs_git.bb
>> +++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs_git.bb
>> @@ -14,7 +14,7 @@ UPSTREAM_CHECK_GITTAGREGEX =
>> "v(?P<pver>\d+\.\d+(\.\d+)*)$"
>>
>>   EXTRA_OECONF += "--libdir=${base_libdir} --sbindir=${base_sbindir} \
>>                   --enable-elf-shlibs --disable-libuuid --disable-uuidd \
>> -                --enable-libblkid --enable-verbose-makecmds"
>> +                --disable-libblkid --enable-verbose-makecmds"
>
>
> Thanks, maybe we also need cleanup other codes like:
>
>     # We use blkid from util-linux now so remove from here
>     rm -f ${D}${base_libdir}/libblkid*

That one should stay in, because we *really* don't want it to end up
in packages.

>
> And:
>
> ALTERNATIVE_${PN}-doc = "libblkid.3 blkid.8"
> ALTERNATIVE_LINK_NAME[libblkid.3] = "${mandir}/man3/libblkid.3"
> ALTERNATIVE_LINK_NAME[blkid.8] = "${mandir}/man8/blkid.8"

I don't have a strong opinion on those, RP?

>
> // Robert
>
>
>>
>>   EXTRA_OECONF_darwin = "--libdir=${base_libdir} --sbindir=${base_sbindir}
>> --enable-bsd-shlibs"
>>
>>
>



-- 
Koen Kooi

Builds and Baselines | Release Manager
Linaro.org | Open source software for ARM SoCs


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] e2fsprogs: disable libblkid again
  2016-01-21  7:20 [PATCH] e2fsprogs: disable libblkid again Koen Kooi
  2016-01-21  7:42 ` Robert Yang
@ 2016-01-21 20:32 ` Burton, Ross
  2016-01-22  9:20   ` Robert Yang
  1 sibling, 1 reply; 6+ messages in thread
From: Burton, Ross @ 2016-01-21 20:32 UTC (permalink / raw)
  To: Koen Kooi; +Cc: OE-core

[-- Attachment #1: Type: text/plain, Size: 1393 bytes --]

On 21 January 2016 at 07:20, Koen Kooi <koen.kooi@linaro.org> wrote:

> We use the util-linux one and do_install deletes it anyway.
>
> See OE-core commit fb8e776ea91c39d586b46400ad30aeea8dead1c4 for more info.
>

Not sure this is complete:

WARNING: e2fsprogs: alternative target (/usr/share/man/man3/libblkid.3 or
/usr/share/man/man3/libblkid.3.e2fsprogs) does not exist, skipping...
WARNING: e2fsprogs: alternative target (/usr/share/man/man8/blkid.8 or
/usr/share/man/man8/blkid.8.e2fsprogs) does not exist, skipping...
WARNING: e2fsprogs: alternative target (/usr/share/man/man8/findfs.8 or
/usr/share/man/man8/findfs.8.e2fsprogs) does not exist, skipping...
WARNING: e2fsprogs: NOT adding alternative provide
/usr/share/man/man3/libblkid.3: /usr/share/man/man3/libblkid.3.e2fsprogs
does not exist
WARNING: e2fsprogs: NOT adding alternative provide
/usr/share/man/man8/blkid.8: /usr/share/man/man8/blkid.8.e2fsprogs does not
exist
WARNING: e2fsprogs: NOT adding alternative provide
/usr/share/man/man8/findfs.8: /usr/share/man/man8/findfs.8.e2fsprogs does
not exist
WARNING: alt_link == alt_target: /usr/share/man/man3/libblkid.3 ==
/usr/share/man/man3/libblkid.3
WARNING: alt_link == alt_target: /usr/share/man/man8/blkid.8 ==
/usr/share/man/man8/blkid.8
WARNING: alt_link == alt_target: /usr/share/man/man8/findfs.8 ==
/usr/share/man/man8/findfs.8

Ross

[-- Attachment #2: Type: text/html, Size: 2172 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] e2fsprogs: disable libblkid again
  2016-01-21  7:44   ` Koen Kooi
@ 2016-01-21 21:53     ` Richard Purdie
  0 siblings, 0 replies; 6+ messages in thread
From: Richard Purdie @ 2016-01-21 21:53 UTC (permalink / raw)
  To: Koen Kooi, Robert Yang; +Cc: Patches and discussions about the oe-core layer

On Thu, 2016-01-21 at 08:44 +0100, Koen Kooi wrote:
> On 21 January 2016 at 08:42, Robert Yang <liezhi.yang@windriver.com>
> wrote:
> > 
> > 
> > On 01/21/2016 03:20 PM, Koen Kooi wrote:
> > > 
> > > We use the util-linux one and do_install deletes it anyway.
> > > 
> > > See OE-core commit fb8e776ea91c39d586b46400ad30aeea8dead1c4 for
> > > more info.
> > > 
> > > Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
> > > ---
> > >   meta/recipes-devtools/e2fsprogs/e2fsprogs_git.bb | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs_git.bb
> > > b/meta/recipes-devtools/e2fsprogs/e2fsprogs_git.bb
> > > index c82e99a..f244473 100644
> > > --- a/meta/recipes-devtools/e2fsprogs/e2fsprogs_git.bb
> > > +++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs_git.bb
> > > @@ -14,7 +14,7 @@ UPSTREAM_CHECK_GITTAGREGEX =
> > > "v(?P<pver>\d+\.\d+(\.\d+)*)$"
> > > 
> > >   EXTRA_OECONF += "--libdir=${base_libdir} -
> > > -sbindir=${base_sbindir} \
> > >                   --enable-elf-shlibs --disable-libuuid --disable
> > > -uuidd \
> > > -                --enable-libblkid --enable-verbose-makecmds"
> > > +                --disable-libblkid --enable-verbose-makecmds"
> > 
> > 
> > Thanks, maybe we also need cleanup other codes like:
> > 
> >     # We use blkid from util-linux now so remove from here
> >     rm -f ${D}${base_libdir}/libblkid*
> 
> That one should stay in, because we *really* don't want it to end up
> in packages.
> 
> > 
> > And:
> > 
> > ALTERNATIVE_${PN}-doc = "libblkid.3 blkid.8"
> > ALTERNATIVE_LINK_NAME[libblkid.3] = "${mandir}/man3/libblkid.3"
> > ALTERNATIVE_LINK_NAME[blkid.8] = "${mandir}/man8/blkid.8"
> 
> I don't have a strong opinion on those, RP?

The reply from Ross suggests we do need to remove these otherwise the
system warns about missing files...

Cheers,

Richard


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] e2fsprogs: disable libblkid again
  2016-01-21 20:32 ` Burton, Ross
@ 2016-01-22  9:20   ` Robert Yang
  0 siblings, 0 replies; 6+ messages in thread
From: Robert Yang @ 2016-01-22  9:20 UTC (permalink / raw)
  To: Burton, Ross, Koen Kooi; +Cc: OE-core



On 01/22/2016 04:32 AM, Burton, Ross wrote:
>
> On 21 January 2016 at 07:20, Koen Kooi <koen.kooi@linaro.org
> <mailto:koen.kooi@linaro.org>> wrote:
>
>     We use the util-linux one and do_install deletes it anyway.
>
>     See OE-core commit fb8e776ea91c39d586b46400ad30aeea8dead1c4 for more info.
>
>
> Not sure this is complete:

I remembered why I added --enable-libblkid, it is because of this warning,
The /lib/libblkid* had been removed but mannuals were installed before I
updated the recipe, so we got no warning. But after ugprade, none of them
were installed, so we got the warnings.

// Robert

>
> WARNING: e2fsprogs: alternative target (/usr/share/man/man3/libblkid.3 or
> /usr/share/man/man3/libblkid.3.e2fsprogs) does not exist, skipping...
> WARNING: e2fsprogs: alternative target (/usr/share/man/man8/blkid.8 or
> /usr/share/man/man8/blkid.8.e2fsprogs) does not exist, skipping...
> WARNING: e2fsprogs: alternative target (/usr/share/man/man8/findfs.8 or
> /usr/share/man/man8/findfs.8.e2fsprogs) does not exist, skipping...
> WARNING: e2fsprogs: NOT adding alternative provide
> /usr/share/man/man3/libblkid.3: /usr/share/man/man3/libblkid.3.e2fsprogs does
> not exist
> WARNING: e2fsprogs: NOT adding alternative provide /usr/share/man/man8/blkid.8:
> /usr/share/man/man8/blkid.8.e2fsprogs does not exist
> WARNING: e2fsprogs: NOT adding alternative provide /usr/share/man/man8/findfs.8:
> /usr/share/man/man8/findfs.8.e2fsprogs does not exist
> WARNING: alt_link == alt_target: /usr/share/man/man3/libblkid.3 ==
> /usr/share/man/man3/libblkid.3
> WARNING: alt_link == alt_target: /usr/share/man/man8/blkid.8 ==
> /usr/share/man/man8/blkid.8
> WARNING: alt_link == alt_target: /usr/share/man/man8/findfs.8 ==
> /usr/share/man/man8/findfs.8
>
> Ross
>
>


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-01-22  9:20 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-21  7:20 [PATCH] e2fsprogs: disable libblkid again Koen Kooi
2016-01-21  7:42 ` Robert Yang
2016-01-21  7:44   ` Koen Kooi
2016-01-21 21:53     ` Richard Purdie
2016-01-21 20:32 ` Burton, Ross
2016-01-22  9:20   ` Robert Yang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.