All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] iio:adc:at91-sama5d2: fix vref_uv type
@ 2016-01-18  8:41 ` Ludovic Desroches
  0 siblings, 0 replies; 8+ messages in thread
From: Ludovic Desroches @ 2016-01-18  8:41 UTC (permalink / raw)
  To: jic23, nicolas.ferre
  Cc: linux-kernel, linux-iio, linux-arm-kernel, Ludovic Desroches

vref_uv has to be an int.

Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
---
 drivers/iio/adc/at91-sama5d2_adc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
index ecb2d90..f2d8bd5 100644
--- a/drivers/iio/adc/at91-sama5d2_adc.c
+++ b/drivers/iio/adc/at91-sama5d2_adc.c
@@ -171,7 +171,7 @@ struct at91_adc_state {
 	struct clk			*per_clk;
 	struct regulator		*reg;
 	struct regulator		*vref;
-	u32				vref_uv;
+	int				vref_uv;
 	const struct iio_chan_spec	*chan;
 	bool				conversion_done;
 	u32				conversion_value;
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH 1/2] iio:adc:at91-sama5d2: fix vref_uv type
@ 2016-01-18  8:41 ` Ludovic Desroches
  0 siblings, 0 replies; 8+ messages in thread
From: Ludovic Desroches @ 2016-01-18  8:41 UTC (permalink / raw)
  To: linux-arm-kernel

vref_uv has to be an int.

Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
---
 drivers/iio/adc/at91-sama5d2_adc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
index ecb2d90..f2d8bd5 100644
--- a/drivers/iio/adc/at91-sama5d2_adc.c
+++ b/drivers/iio/adc/at91-sama5d2_adc.c
@@ -171,7 +171,7 @@ struct at91_adc_state {
 	struct clk			*per_clk;
 	struct regulator		*reg;
 	struct regulator		*vref;
-	u32				vref_uv;
+	int				vref_uv;
 	const struct iio_chan_spec	*chan;
 	bool				conversion_done;
 	u32				conversion_value;
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH 2/2] iio:adc:at91-sama5d2: code cleanup
  2016-01-18  8:41 ` Ludovic Desroches
@ 2016-01-18  8:41   ` Ludovic Desroches
  -1 siblings, 0 replies; 8+ messages in thread
From: Ludovic Desroches @ 2016-01-18  8:41 UTC (permalink / raw)
  To: jic23, nicolas.ferre
  Cc: linux-kernel, linux-iio, linux-arm-kernel, Ludovic Desroches

Use var type for sizeof argument instead of the struct name.

Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
---
 drivers/iio/adc/at91-sama5d2_adc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
index f2d8bd5..dbee13a 100644
--- a/drivers/iio/adc/at91-sama5d2_adc.c
+++ b/drivers/iio/adc/at91-sama5d2_adc.c
@@ -353,8 +353,7 @@ static int at91_adc_probe(struct platform_device *pdev)
 	struct resource	*res;
 	int ret;
 
-	indio_dev = devm_iio_device_alloc(&pdev->dev,
-					  sizeof(struct at91_adc_state));
+	indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*st));
 	if (!indio_dev)
 		return -ENOMEM;
 
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH 2/2] iio:adc:at91-sama5d2: code cleanup
@ 2016-01-18  8:41   ` Ludovic Desroches
  0 siblings, 0 replies; 8+ messages in thread
From: Ludovic Desroches @ 2016-01-18  8:41 UTC (permalink / raw)
  To: linux-arm-kernel

Use var type for sizeof argument instead of the struct name.

Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
---
 drivers/iio/adc/at91-sama5d2_adc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
index f2d8bd5..dbee13a 100644
--- a/drivers/iio/adc/at91-sama5d2_adc.c
+++ b/drivers/iio/adc/at91-sama5d2_adc.c
@@ -353,8 +353,7 @@ static int at91_adc_probe(struct platform_device *pdev)
 	struct resource	*res;
 	int ret;
 
-	indio_dev = devm_iio_device_alloc(&pdev->dev,
-					  sizeof(struct at91_adc_state));
+	indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*st));
 	if (!indio_dev)
 		return -ENOMEM;
 
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] iio:adc:at91-sama5d2: fix vref_uv type
  2016-01-18  8:41 ` Ludovic Desroches
@ 2016-01-23 16:16   ` Jonathan Cameron
  -1 siblings, 0 replies; 8+ messages in thread
From: Jonathan Cameron @ 2016-01-23 16:16 UTC (permalink / raw)
  To: Ludovic Desroches, nicolas.ferre
  Cc: linux-kernel, linux-iio, linux-arm-kernel, Julia Lawall

On 18/01/16 08:41, Ludovic Desroches wrote:
> vref_uv has to be an int.
> 
Applied, with a reported-by tag for Julia added.

Thanks,

Jonathan
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
> ---
>  drivers/iio/adc/at91-sama5d2_adc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
> index ecb2d90..f2d8bd5 100644
> --- a/drivers/iio/adc/at91-sama5d2_adc.c
> +++ b/drivers/iio/adc/at91-sama5d2_adc.c
> @@ -171,7 +171,7 @@ struct at91_adc_state {
>  	struct clk			*per_clk;
>  	struct regulator		*reg;
>  	struct regulator		*vref;
> -	u32				vref_uv;
> +	int				vref_uv;
>  	const struct iio_chan_spec	*chan;
>  	bool				conversion_done;
>  	u32				conversion_value;
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH 1/2] iio:adc:at91-sama5d2: fix vref_uv type
@ 2016-01-23 16:16   ` Jonathan Cameron
  0 siblings, 0 replies; 8+ messages in thread
From: Jonathan Cameron @ 2016-01-23 16:16 UTC (permalink / raw)
  To: linux-arm-kernel

On 18/01/16 08:41, Ludovic Desroches wrote:
> vref_uv has to be an int.
> 
Applied, with a reported-by tag for Julia added.

Thanks,

Jonathan
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
> ---
>  drivers/iio/adc/at91-sama5d2_adc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
> index ecb2d90..f2d8bd5 100644
> --- a/drivers/iio/adc/at91-sama5d2_adc.c
> +++ b/drivers/iio/adc/at91-sama5d2_adc.c
> @@ -171,7 +171,7 @@ struct at91_adc_state {
>  	struct clk			*per_clk;
>  	struct regulator		*reg;
>  	struct regulator		*vref;
> -	u32				vref_uv;
> +	int				vref_uv;
>  	const struct iio_chan_spec	*chan;
>  	bool				conversion_done;
>  	u32				conversion_value;
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] iio:adc:at91-sama5d2: code cleanup
  2016-01-18  8:41   ` Ludovic Desroches
@ 2016-01-23 16:17     ` Jonathan Cameron
  -1 siblings, 0 replies; 8+ messages in thread
From: Jonathan Cameron @ 2016-01-23 16:17 UTC (permalink / raw)
  To: Ludovic Desroches, nicolas.ferre
  Cc: linux-kernel, linux-iio, linux-arm-kernel

On 18/01/16 08:41, Ludovic Desroches wrote:
> Use var type for sizeof argument instead of the struct name.
> 
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Applied, thanks.

Jonathan
> ---
>  drivers/iio/adc/at91-sama5d2_adc.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
> index f2d8bd5..dbee13a 100644
> --- a/drivers/iio/adc/at91-sama5d2_adc.c
> +++ b/drivers/iio/adc/at91-sama5d2_adc.c
> @@ -353,8 +353,7 @@ static int at91_adc_probe(struct platform_device *pdev)
>  	struct resource	*res;
>  	int ret;
>  
> -	indio_dev = devm_iio_device_alloc(&pdev->dev,
> -					  sizeof(struct at91_adc_state));
> +	indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*st));
>  	if (!indio_dev)
>  		return -ENOMEM;
>  
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH 2/2] iio:adc:at91-sama5d2: code cleanup
@ 2016-01-23 16:17     ` Jonathan Cameron
  0 siblings, 0 replies; 8+ messages in thread
From: Jonathan Cameron @ 2016-01-23 16:17 UTC (permalink / raw)
  To: linux-arm-kernel

On 18/01/16 08:41, Ludovic Desroches wrote:
> Use var type for sizeof argument instead of the struct name.
> 
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Applied, thanks.

Jonathan
> ---
>  drivers/iio/adc/at91-sama5d2_adc.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
> index f2d8bd5..dbee13a 100644
> --- a/drivers/iio/adc/at91-sama5d2_adc.c
> +++ b/drivers/iio/adc/at91-sama5d2_adc.c
> @@ -353,8 +353,7 @@ static int at91_adc_probe(struct platform_device *pdev)
>  	struct resource	*res;
>  	int ret;
>  
> -	indio_dev = devm_iio_device_alloc(&pdev->dev,
> -					  sizeof(struct at91_adc_state));
> +	indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*st));
>  	if (!indio_dev)
>  		return -ENOMEM;
>  
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-01-23 16:17 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-18  8:41 [PATCH 1/2] iio:adc:at91-sama5d2: fix vref_uv type Ludovic Desroches
2016-01-18  8:41 ` Ludovic Desroches
2016-01-18  8:41 ` [PATCH 2/2] iio:adc:at91-sama5d2: code cleanup Ludovic Desroches
2016-01-18  8:41   ` Ludovic Desroches
2016-01-23 16:17   ` Jonathan Cameron
2016-01-23 16:17     ` Jonathan Cameron
2016-01-23 16:16 ` [PATCH 1/2] iio:adc:at91-sama5d2: fix vref_uv type Jonathan Cameron
2016-01-23 16:16   ` Jonathan Cameron

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.