From: John Crispin <blogic@openwrt.org>
To: Mark Brown <broonie@kernel.org>
Cc: devicetree@vger.kernel.org, Steven Liu <steven.liu@mediatek.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Henry Chen <henryc.chen@mediatek.com>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Chen Zhong <chen.zhong@mediatek.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2 1/2] dt-bindings: regulator: Add document for MT6323 regulator
Date: Mon, 25 Jan 2016 13:05:52 +0100 [thread overview]
Message-ID: <56A60FA0.3060503@openwrt.org> (raw)
In-Reply-To: <20160125113710.GJ6588@sirena.org.uk>
On 25/01/2016 12:37, Mark Brown wrote:
> On Mon, Jan 25, 2016 at 11:40:04AM +0100, John Crispin wrote:
>> Based on the MT6397 binding documentation.
>>
>> Signed-off-by: John Crispin <blogic@openwrt.org>
>> Cc: devicetree@vger.kernel.org
>
> In reply to your previous submission I said:
>
> | important. Please also use subject lines matching the style for the
> | subsystem (for patch 1).
>
> Please don't ignore review comments, people are generally making them
> for a reason and are likely to have the same concerns if issues remain
> unaddressed. Having to repeat the same comments can get repetitive and
> make people question the value of time spent reviewing. If you disagree
> with the review comments that's fine but you need to reply and discuss
> your concerns so that the reviewer can understand your decisions.
>
Hi,
sorry about that. I've been juggling with a pile of patches the last
couple of weeks and missed folding the fixup into the patch before
sending it. I've just sent you a V3.
John
WARNING: multiple messages have this Message-ID (diff)
From: John Crispin <blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Steven Liu <steven.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Henry Chen <henryc.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Matthias Brugger
<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Chen Zhong <chen.zhong-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH V2 1/2] dt-bindings: regulator: Add document for MT6323 regulator
Date: Mon, 25 Jan 2016 13:05:52 +0100 [thread overview]
Message-ID: <56A60FA0.3060503@openwrt.org> (raw)
In-Reply-To: <20160125113710.GJ6588-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On 25/01/2016 12:37, Mark Brown wrote:
> On Mon, Jan 25, 2016 at 11:40:04AM +0100, John Crispin wrote:
>> Based on the MT6397 binding documentation.
>>
>> Signed-off-by: John Crispin <blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
>> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>
> In reply to your previous submission I said:
>
> | important. Please also use subject lines matching the style for the
> | subsystem (for patch 1).
>
> Please don't ignore review comments, people are generally making them
> for a reason and are likely to have the same concerns if issues remain
> unaddressed. Having to repeat the same comments can get repetitive and
> make people question the value of time spent reviewing. If you disagree
> with the review comments that's fine but you need to reply and discuss
> your concerns so that the reviewer can understand your decisions.
>
Hi,
sorry about that. I've been juggling with a pile of patches the last
couple of weeks and missed folding the fixup into the patch before
sending it. I've just sent you a V3.
John
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: blogic@openwrt.org (John Crispin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 1/2] dt-bindings: regulator: Add document for MT6323 regulator
Date: Mon, 25 Jan 2016 13:05:52 +0100 [thread overview]
Message-ID: <56A60FA0.3060503@openwrt.org> (raw)
In-Reply-To: <20160125113710.GJ6588@sirena.org.uk>
On 25/01/2016 12:37, Mark Brown wrote:
> On Mon, Jan 25, 2016 at 11:40:04AM +0100, John Crispin wrote:
>> Based on the MT6397 binding documentation.
>>
>> Signed-off-by: John Crispin <blogic@openwrt.org>
>> Cc: devicetree at vger.kernel.org
>
> In reply to your previous submission I said:
>
> | important. Please also use subject lines matching the style for the
> | subsystem (for patch 1).
>
> Please don't ignore review comments, people are generally making them
> for a reason and are likely to have the same concerns if issues remain
> unaddressed. Having to repeat the same comments can get repetitive and
> make people question the value of time spent reviewing. If you disagree
> with the review comments that's fine but you need to reply and discuss
> your concerns so that the reviewer can understand your decisions.
>
Hi,
sorry about that. I've been juggling with a pile of patches the last
couple of weeks and missed folding the fixup into the patch before
sending it. I've just sent you a V3.
John
next prev parent reply other threads:[~2016-01-25 12:06 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 10:40 [PATCH V2 1/2] dt-bindings: regulator: Add document for MT6323 regulator John Crispin
2016-01-25 10:40 ` John Crispin
2016-01-25 10:40 ` [PATCH V2 2/2] regulator: mt6323: Add support " John Crispin
2016-01-25 10:40 ` John Crispin
2016-01-25 12:11 ` Javier Martinez Canillas
2016-01-25 12:11 ` Javier Martinez Canillas
2016-01-25 12:11 ` Javier Martinez Canillas
2016-01-25 12:19 ` John Crispin
2016-01-25 12:19 ` John Crispin
2016-01-25 12:19 ` John Crispin
2016-01-25 12:30 ` Javier Martinez Canillas
2016-01-25 12:30 ` Javier Martinez Canillas
2016-01-25 12:30 ` Javier Martinez Canillas
[not found] ` <CABxcv=kC3tOrfJvCCaXcMSO4ufBXc_GoWeGBcX56k1RV-BX=ow-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-25 12:33 ` John Crispin
2016-01-25 12:35 ` Mark Brown
2016-01-25 12:35 ` Mark Brown
2016-01-25 12:35 ` Mark Brown
2016-01-25 13:13 ` John Crispin
2016-01-25 13:13 ` John Crispin
2016-01-25 13:13 ` John Crispin
2016-01-25 13:19 ` Javier Martinez Canillas
2016-01-25 13:19 ` Javier Martinez Canillas
2016-01-25 13:19 ` Javier Martinez Canillas
2016-01-25 13:25 ` Javier Martinez Canillas
2016-01-25 13:25 ` Javier Martinez Canillas
2016-01-25 13:25 ` Javier Martinez Canillas
2016-01-25 13:46 ` John Crispin
2016-01-25 13:46 ` John Crispin
2016-01-25 13:46 ` John Crispin
2016-01-25 14:01 ` Javier Martinez Canillas
2016-01-25 14:01 ` Javier Martinez Canillas
2016-01-25 14:01 ` Javier Martinez Canillas
2016-01-25 14:02 ` John Crispin
2016-01-25 14:02 ` John Crispin
2016-01-25 14:02 ` John Crispin
2016-01-25 11:37 ` [PATCH V2 1/2] dt-bindings: regulator: Add document " Mark Brown
2016-01-25 11:37 ` Mark Brown
2016-01-25 11:37 ` Mark Brown
2016-01-25 12:05 ` John Crispin [this message]
2016-01-25 12:05 ` John Crispin
2016-01-25 12:05 ` John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A60FA0.3060503@openwrt.org \
--to=blogic@openwrt.org \
--cc=broonie@kernel.org \
--cc=chen.zhong@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=henryc.chen@mediatek.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=steven.liu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.