All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Arnd Bergmann <arnd@arndb.de>, Shawn Guo <shawnguo@kernel.org>,
	Russell King <linux@arm.linux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Hauke Mehrtens <hauke@hauke-m.de>,
	Rob Herring <robh+dt@kernel.org>, <guohanjun@huawei.com>
Subject: Re: [PATCH 14/15] Revert "bus: uniphier: allow only built-in driver"
Date: Thu, 28 Jan 2016 09:41:23 +0800	[thread overview]
Message-ID: <56A971C3.6000608@huawei.com> (raw)
In-Reply-To: <CAK7LNAR=E5kYzsO9=YDeAVzp9cLWd9C8ANeVGJOvM=BSM4aTjg@mail.gmail.com>

Hi Masahiro,

On 2016/1/27 21:48, Masahiro Yamada wrote:
> 2016-01-27 13:27 GMT+09:00 Kefeng Wang <wangkefeng.wang@huawei.com>:
>> This reverts commit 326ea45aa827da6686c78b5907f9839f91ef5782.
>>
>> After covering to use helper of_platform_default_populate() to
>> populate the default bus, no error in build uniphier driver as
>> a module.
> 
> This statement is weird.
> There is no error for building this driver as a module
> at the point of v4.5-rc1.

Yes, but after drop export of_default_bus_match_table in patchset(15/15),
we will meet build issue, so the statement can be changed to
------------
After covering to use helper of_platform_default_populate() to
populate the default bus, this driver can be safely as a tristate
one, no error in build uniphier driver as a module once we drop
export of_default_bus_match_table in later patch.
------------
> 
> The of_platform_default_populate() conversion (11/15) is unrelated
> to fixing the build error.
> 
> BTW, I had already posted an equivalent patch a few days before:
> 
> https://patchwork.kernel.org/patch/8096991/
> 
I didn't notice this before, it is ok for me to use your patch, or I will send
a new one with update changlog, thanks for your review.

> 
> 
> 
>> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>> ---
>>  drivers/bus/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
>> index 129d47b..9a92c07 100644
>> --- a/drivers/bus/Kconfig
>> +++ b/drivers/bus/Kconfig
>> @@ -132,7 +132,7 @@ config SUNXI_RSB
>>           and AC100/AC200 ICs.
>>
>>  config UNIPHIER_SYSTEM_BUS
>> -       bool "UniPhier System Bus driver"
>> +       tristate "UniPhier System Bus driver"
>>         depends on ARCH_UNIPHIER && OF
>>         default y
>>         help
>> --
>> 2.6.0.GIT
>>
> 
> 

WARNING: multiple messages have this Message-ID (diff)
From: wangkefeng.wang@huawei.com (Kefeng Wang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 14/15] Revert "bus: uniphier: allow only built-in driver"
Date: Thu, 28 Jan 2016 09:41:23 +0800	[thread overview]
Message-ID: <56A971C3.6000608@huawei.com> (raw)
In-Reply-To: <CAK7LNAR=E5kYzsO9=YDeAVzp9cLWd9C8ANeVGJOvM=BSM4aTjg@mail.gmail.com>

Hi Masahiro,

On 2016/1/27 21:48, Masahiro Yamada wrote:
> 2016-01-27 13:27 GMT+09:00 Kefeng Wang <wangkefeng.wang@huawei.com>:
>> This reverts commit 326ea45aa827da6686c78b5907f9839f91ef5782.
>>
>> After covering to use helper of_platform_default_populate() to
>> populate the default bus, no error in build uniphier driver as
>> a module.
> 
> This statement is weird.
> There is no error for building this driver as a module
> at the point of v4.5-rc1.

Yes, but after drop export of_default_bus_match_table in patchset(15/15),
we will meet build issue, so the statement can be changed to
------------
After covering to use helper of_platform_default_populate() to
populate the default bus, this driver can be safely as a tristate
one, no error in build uniphier driver as a module once we drop
export of_default_bus_match_table in later patch.
------------
> 
> The of_platform_default_populate() conversion (11/15) is unrelated
> to fixing the build error.
> 
> BTW, I had already posted an equivalent patch a few days before:
> 
> https://patchwork.kernel.org/patch/8096991/
> 
I didn't notice this before, it is ok for me to use your patch, or I will send
a new one with update changlog, thanks for your review.

> 
> 
> 
>> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>> ---
>>  drivers/bus/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
>> index 129d47b..9a92c07 100644
>> --- a/drivers/bus/Kconfig
>> +++ b/drivers/bus/Kconfig
>> @@ -132,7 +132,7 @@ config SUNXI_RSB
>>           and AC100/AC200 ICs.
>>
>>  config UNIPHIER_SYSTEM_BUS
>> -       bool "UniPhier System Bus driver"
>> +       tristate "UniPhier System Bus driver"
>>         depends on ARCH_UNIPHIER && OF
>>         default y
>>         help
>> --
>> 2.6.0.GIT
>>
> 
> 

  reply	other threads:[~2016-01-28  1:42 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-27  4:27 [PATCH 00/15] use of_platform_default_populate() to populate default bus Kefeng Wang
2016-01-27  4:27 ` Kefeng Wang
2016-01-27  4:27 ` [PATCH 01/15] arm: " Kefeng Wang
2016-01-27  4:27   ` Kefeng Wang
2016-01-27  7:08   ` kbuild test robot
2016-01-27  7:08     ` kbuild test robot
2016-01-27  7:50     ` Kefeng Wang
2016-01-27  7:50       ` Kefeng Wang
2016-01-27  7:53   ` [PATCH v2 " Kefeng Wang
2016-01-27  7:53     ` Kefeng Wang
2016-02-01 13:53     ` Shawn Guo
2016-02-01 13:53       ` Shawn Guo
2016-02-01 14:22     ` Heiko Stübner
2016-02-01 14:22       ` Heiko Stübner
2016-02-16  9:32     ` Krzysztof Hałasa
2016-02-16  9:32       ` Krzysztof Hałasa
2016-02-22 12:43     ` Nicolas Ferre
2016-02-22 12:43       ` Nicolas Ferre
2016-01-27  4:27 ` [PATCH 02/15] arm64: " Kefeng Wang
2016-01-27  4:27   ` Kefeng Wang
2016-01-27 10:38   ` Catalin Marinas
2016-01-27 10:38     ` Catalin Marinas
2016-01-27  4:27 ` [PATCH 03/15] mips: " Kefeng Wang
2016-01-27  4:27   ` Kefeng Wang
2016-01-29 16:00   ` Joshua Henderson
2016-01-29 16:00     ` Joshua Henderson
2016-01-30  2:52     ` Kefeng Wang
2016-01-30  2:52       ` Kefeng Wang
2016-01-27  4:27 ` [PATCH 04/15] arc: " Kefeng Wang
2016-01-27  4:27   ` Kefeng Wang
2016-01-27  7:56   ` Vineet Gupta
2016-01-27  7:56     ` Vineet Gupta
2016-01-27  4:27 ` [PATCH 05/15] c6x: " Kefeng Wang
2016-01-27  4:27   ` Kefeng Wang
2016-02-11 22:52   ` Mark Salter
2016-02-11 22:52     ` Mark Salter
2016-01-27  4:27 ` [PATCH 06/15] metag: " Kefeng Wang
2016-01-27  4:27   ` Kefeng Wang
2016-01-27 11:34   ` James Hogan
2016-01-27 11:34     ` James Hogan
2016-01-27 11:34     ` James Hogan
2016-01-27  4:27 ` [PATCH 07/15] cris: " Kefeng Wang
2016-01-27  4:27   ` Kefeng Wang
2016-01-27  4:27 ` [PATCH 08/15] nios2: " Kefeng Wang
2016-01-27  4:27   ` Kefeng Wang
2016-01-27  4:27 ` [PATCH 09/15] xtensa: " Kefeng Wang
2016-01-27  4:27   ` Kefeng Wang
2016-01-27  4:33   ` Max Filippov
2016-01-27  4:33     ` Max Filippov
2016-01-27  4:27 ` [PATCH 10/15] bus: imx-weim: " Kefeng Wang
2016-01-27  4:27   ` Kefeng Wang
2016-02-01 13:55   ` Shawn Guo
2016-02-01 13:55     ` Shawn Guo
2016-01-27  4:27 ` [PATCH 11/15] bus: uniphier-system-bus: " Kefeng Wang
2016-01-27  4:27   ` Kefeng Wang
2016-01-27 13:40   ` Masahiro Yamada
2016-01-27 13:40     ` Masahiro Yamada
2016-01-27  4:27 ` [PATCH 12/15] memory: omap-gpmc: " Kefeng Wang
2016-01-27  4:27   ` Kefeng Wang
2016-01-27  4:27 ` [PATCH 13/15] of: unittest: " Kefeng Wang
2016-01-27  4:27   ` Kefeng Wang
2016-01-27  4:27 ` [PATCH 14/15] Revert "bus: uniphier: allow only built-in driver" Kefeng Wang
2016-01-27  4:27   ` Kefeng Wang
2016-01-27 13:48   ` Masahiro Yamada
2016-01-27 13:48     ` Masahiro Yamada
2016-01-28  1:41     ` Kefeng Wang [this message]
2016-01-28  1:41       ` Kefeng Wang
2016-01-27  4:27 ` [PATCH 15/15] Revert "of/platform: export of_default_bus_match_table" Kefeng Wang
2016-01-27  4:27   ` Kefeng Wang
2016-01-27 13:50   ` Masahiro Yamada
2016-01-27 13:50     ` Masahiro Yamada
2016-01-27 22:10   ` Hauke Mehrtens
2016-01-27 22:10     ` Hauke Mehrtens
2016-01-28  2:11     ` Kefeng Wang
2016-01-28  2:11       ` Kefeng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56A971C3.6000608@huawei.com \
    --to=wangkefeng.wang@huawei.com \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=guohanjun@huawei.com \
    --cc=hauke@hauke-m.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.