From: Xunlei Pang <xpang@redhat.com>
To: Michael Holzheu <holzheu@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-s390@vger.kernel.org,
Dmitry Safonov <dsafonov@virtuozzo.com>,
heiko.carstens@de.ibm.com, linux-kernel@vger.kernel.org,
ebiederm@xmission.com, 0x7f454c46@gmail.com,
schwidefsky@de.ibm.com, dyoung@redhat.com,
kexec@lists.infradead.org, Xunlei Pang <xlpang@redhat.com>
Subject: Re: [PATCH] kexec: unmap reserved pages for each error-return way
Date: Thu, 28 Jan 2016 19:56:56 +0800 [thread overview]
Message-ID: <56AA0208.7050508@redhat.com> (raw)
In-Reply-To: <20160128113217.79d37ff5@holzheu>
On 2016/01/28 at 18:32, Michael Holzheu wrote:
> On Wed, 27 Jan 2016 11:15:46 -0800
> Andrew Morton <akpm@linux-foundation.org> wrote:
>
>> On Wed, 27 Jan 2016 14:48:31 +0300 Dmitry Safonov <dsafonov@virtuozzo.com> wrote:
>>
>>> For allocation of kimage failure or kexec_prepare or load segments
>>> errors there is no need to keep crashkernel memory mapped.
>>> It will affect only s390 as map/unmap hook defined only for it.
>>> As on unmap s390 also changes os_info structure let's check return code
>>> and add info only on success.
>>>
>> This conflicts (both mechanically and somewhat conceptually) with
>> Xunlei Pang's "kexec: Introduce a protection mechanism for the
>> crashkernel reserved memory" and "kexec: provide
>> arch_kexec_protect(unprotect)_crashkres()".
>>
>> http://ozlabs.org/~akpm/mmots/broken-out/kexec-introduce-a-protection-mechanism-for-the-crashkernel-reserved-memory.patch
>> http://ozlabs.org/~akpm/mmots/broken-out/kexec-introduce-a-protection-mechanism-for-the-crashkernel-reserved-memory-v4.patch
>>
>> and
>>
>> http://ozlabs.org/~akpm/mmots/broken-out/kexec-provide-arch_kexec_protectunprotect_crashkres.patch
>> http://ozlabs.org/~akpm/mmots/broken-out/kexec-provide-arch_kexec_protectunprotect_crashkres-v4.patch
> Hmm, It looks to me that arch_kexec_(un)protect_crashkres() has exactly
> the same semantics as crash_(un)map_reserved_pages().
>
> On s390 we don't have the crashkernel memory mapped and therefore need
> crash_map_reserved_pages() before loading something into crashkernel
> memory.
I don't know s390, just curious, if s390 doesn't have crash kernel memory mapped,
what's the purpose of the commit(558df7209e) for s390 as the reserved crash memory
with no kernel mapping already means the protection is on?
Regards,
Xunlei
>
> Perhaps I missed something?
> Michael
>
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Xunlei Pang <xpang@redhat.com>
To: Michael Holzheu <holzheu@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-s390@vger.kernel.org, 0x7f454c46@gmail.com,
heiko.carstens@de.ibm.com, linux-kernel@vger.kernel.org,
ebiederm@xmission.com, Dmitry Safonov <dsafonov@virtuozzo.com>,
schwidefsky@de.ibm.com, dyoung@redhat.com,
kexec@lists.infradead.org, Xunlei Pang <xlpang@redhat.com>
Subject: Re: [PATCH] kexec: unmap reserved pages for each error-return way
Date: Thu, 28 Jan 2016 19:56:56 +0800 [thread overview]
Message-ID: <56AA0208.7050508@redhat.com> (raw)
In-Reply-To: <20160128113217.79d37ff5@holzheu>
On 2016/01/28 at 18:32, Michael Holzheu wrote:
> On Wed, 27 Jan 2016 11:15:46 -0800
> Andrew Morton <akpm@linux-foundation.org> wrote:
>
>> On Wed, 27 Jan 2016 14:48:31 +0300 Dmitry Safonov <dsafonov@virtuozzo.com> wrote:
>>
>>> For allocation of kimage failure or kexec_prepare or load segments
>>> errors there is no need to keep crashkernel memory mapped.
>>> It will affect only s390 as map/unmap hook defined only for it.
>>> As on unmap s390 also changes os_info structure let's check return code
>>> and add info only on success.
>>>
>> This conflicts (both mechanically and somewhat conceptually) with
>> Xunlei Pang's "kexec: Introduce a protection mechanism for the
>> crashkernel reserved memory" and "kexec: provide
>> arch_kexec_protect(unprotect)_crashkres()".
>>
>> http://ozlabs.org/~akpm/mmots/broken-out/kexec-introduce-a-protection-mechanism-for-the-crashkernel-reserved-memory.patch
>> http://ozlabs.org/~akpm/mmots/broken-out/kexec-introduce-a-protection-mechanism-for-the-crashkernel-reserved-memory-v4.patch
>>
>> and
>>
>> http://ozlabs.org/~akpm/mmots/broken-out/kexec-provide-arch_kexec_protectunprotect_crashkres.patch
>> http://ozlabs.org/~akpm/mmots/broken-out/kexec-provide-arch_kexec_protectunprotect_crashkres-v4.patch
> Hmm, It looks to me that arch_kexec_(un)protect_crashkres() has exactly
> the same semantics as crash_(un)map_reserved_pages().
>
> On s390 we don't have the crashkernel memory mapped and therefore need
> crash_map_reserved_pages() before loading something into crashkernel
> memory.
I don't know s390, just curious, if s390 doesn't have crash kernel memory mapped,
what's the purpose of the commit(558df7209e) for s390 as the reserved crash memory
with no kernel mapping already means the protection is on?
Regards,
Xunlei
>
> Perhaps I missed something?
> Michael
>
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2016-01-28 11:57 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 11:48 [PATCH] kexec: unmap reserved pages for each error-return way Dmitry Safonov
2016-01-27 11:48 ` Dmitry Safonov
2016-01-27 11:48 ` Dmitry Safonov
2016-01-27 19:15 ` Andrew Morton
2016-01-27 19:15 ` Andrew Morton
2016-01-27 19:15 ` Andrew Morton
2016-01-28 10:32 ` Michael Holzheu
2016-01-28 10:32 ` Michael Holzheu
2016-01-28 10:32 ` Michael Holzheu
2016-01-28 11:56 ` Xunlei Pang [this message]
2016-01-28 11:56 ` Xunlei Pang
2016-01-28 12:44 ` Michael Holzheu
2016-01-28 12:44 ` Michael Holzheu
2016-01-28 13:12 ` Xunlei Pang
2016-01-28 13:12 ` Xunlei Pang
2016-01-28 14:01 ` Michael Holzheu
2016-01-28 14:01 ` Michael Holzheu
[not found] ` <56A983F3.5010506@redhat.com>
[not found] ` <56A9D927.70402@virtuozzo.com>
2016-01-29 3:14 ` Xunlei Pang
2016-01-29 3:14 ` Xunlei Pang
2016-01-28 3:36 ` Xunlei Pang
2016-01-28 3:36 ` Xunlei Pang
2016-01-28 6:29 ` Minfei Huang
2016-01-28 6:29 ` Minfei Huang
2016-01-28 8:57 ` Dmitry Safonov
2016-01-28 8:57 ` Dmitry Safonov
2016-01-28 8:57 ` Dmitry Safonov
2016-02-02 5:45 ` Andrew Morton
2016-02-02 5:45 ` Andrew Morton
2016-02-02 5:45 ` Andrew Morton
2016-02-02 13:56 ` Minfei Huang
2016-02-02 13:56 ` Minfei Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AA0208.7050508@redhat.com \
--to=xpang@redhat.com \
--cc=0x7f454c46@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dsafonov@virtuozzo.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=heiko.carstens@de.ibm.com \
--cc=holzheu@linux.vnet.ibm.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=xlpang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.