All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package, toolchain: remove BR2_TOOLCHAIN_HAS_GCC_BUG_* options
@ 2016-01-29 23:24 Thomas Petazzoni
  2016-01-30  7:55 ` Arnout Vandecappelle
  2016-01-30 10:03 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2016-01-29 23:24 UTC (permalink / raw)
  To: buildroot

Quite some time ago, we added the options
BR2_TOOLCHAIN_HAS_GCC_BUG_58595 and BR2_TOOLCHAIN_HAS_GCC_BUG_58854 to
indicate if the toolchain was affected by those gcc bugs, which were
causing build failure with a number of packages.

With the recent change in the external toolchain logic to provide only
the latest version of each toolchain "family", all the toolchains
which were affected by those issues disappeared from Buildroot. Those
options are no longer being selected anywhere, and being blind
options, it means their value is always going to be "disabled".

Conquently, this commit removes those options completely, and updates
all the packages where they were used.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/liburcu/Config.in      | 5 -----
 package/lttng-libust/Config.in | 6 ------
 package/lttng-tools/Config.in  | 8 --------
 package/netsniff-ng/Config.in  | 6 ------
 toolchain/toolchain-common.in  | 6 ------
 5 files changed, 31 deletions(-)

diff --git a/package/liburcu/Config.in b/package/liburcu/Config.in
index 36d5353..49510da 100644
--- a/package/liburcu/Config.in
+++ b/package/liburcu/Config.in
@@ -6,7 +6,6 @@ config BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
 config BR2_PACKAGE_LIBURCU
 	bool "liburcu"
 	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
-	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854 # liburcu/gcc-4.8.x bug
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help
 	  Userspace implementation of the Read-Copy-Update (RCU)
@@ -24,8 +23,4 @@ config BR2_PACKAGE_LIBURCU
 
 comment "liburcu needs a toolchain w/ threads"
 	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
-	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854 # liburcu/gcc-4.8.x bug
 	depends on !BR2_TOOLCHAIN_HAS_THREADS
-
-comment "liburcu needs a toolchain not affected by GCC bug 58854"
-	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_58854
diff --git a/package/lttng-libust/Config.in b/package/lttng-libust/Config.in
index 26838bb..ce60599 100644
--- a/package/lttng-libust/Config.in
+++ b/package/lttng-libust/Config.in
@@ -6,7 +6,6 @@ config BR2_PACKAGE_LTTNG_LIBUST
 	depends on BR2_USE_WCHAR # util-linux
 	# liburcu only works on some architectures and requires threads support"
 	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
-	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854 # liburcu/gcc-4.8.x bug
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on !BR2_STATIC_LIBS
 	help
@@ -20,8 +19,3 @@ config BR2_PACKAGE_LTTNG_LIBUST
 comment "lttng-libust needs a toolchain w/ dynamic library, wchar, threads"
 	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
 	depends on BR2_STATIC_LIBS || !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
-	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854 # liburcu/gcc-4.8.x bug
-
-comment "lttng-libust needs a toolchain not affected by GCC bug 58854"
-	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
-	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_58854
diff --git a/package/lttng-tools/Config.in b/package/lttng-tools/Config.in
index b758d32..dd72cc6 100644
--- a/package/lttng-tools/Config.in
+++ b/package/lttng-tools/Config.in
@@ -2,8 +2,6 @@ config BR2_PACKAGE_LTTNG_TOOLS
 	bool "lttng-tools"
 	# liburcu only works on some architectures and requires thread support
 	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
-	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58595 # lttng-tools/gcc-4.{7,8}.x bug
-	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854 # liburcu/gcc-4.8.x bug
 	depends on BR2_USE_WCHAR # util-linux
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on !BR2_STATIC_LIBS # uses dlfcn
@@ -33,9 +31,3 @@ config BR2_PACKAGE_LTTNG_TOOLS
 comment "lttng-tools needs a toolchain w/ threads, wchar, dynamic library"
 	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR || BR2_STATIC_LIBS
-	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58595 # lttng-tools/gcc-4.{7,8}.x bug
-	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854 # liburcu/gcc-4.8.x bug
-
-comment "lttng-tools needs a toolchain not affected by GCC bug 58854 and 58595"
-	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
-	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_58854 || BR2_TOOLCHAIN_HAS_GCC_BUG_58595
diff --git a/package/netsniff-ng/Config.in b/package/netsniff-ng/Config.in
index a2494a9..5d2f5df 100644
--- a/package/netsniff-ng/Config.in
+++ b/package/netsniff-ng/Config.in
@@ -11,7 +11,6 @@ config BR2_PACKAGE_NETSNIFF_NG
 	depends on BR2_TOOLCHAIN_USES_GLIBC
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0
 	depends on BR2_TOOLCHAIN_HAS_THREADS
-	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854 # liburcu
 	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
 	help
 	  netsniff-ng is a free, performant Linux network analyzer and
@@ -22,8 +21,3 @@ comment "netsniff-ng needs an (e)glibc toolchain w/ threads, headers >= 3.0"
 	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_USES_GLIBC \
 		|| !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0
-	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854
-
-comment "netsniff-ng needs a toolchain not affected by GCC bug 58854"
-	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
-	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_58854
diff --git a/toolchain/toolchain-common.in b/toolchain/toolchain-common.in
index 014a23d..8408852 100644
--- a/toolchain/toolchain-common.in
+++ b/toolchain/toolchain-common.in
@@ -5,12 +5,6 @@
 # so put it here instead
 source "package/gdb/Config.in.host"
 
-config BR2_TOOLCHAIN_HAS_GCC_BUG_58595
-	bool
-
-config BR2_TOOLCHAIN_HAS_GCC_BUG_58854
-	bool
-
 config BR2_TOOLCHAIN_HAS_NATIVE_RPC
 	bool
 
-- 
2.6.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] package, toolchain: remove BR2_TOOLCHAIN_HAS_GCC_BUG_* options
  2016-01-29 23:24 [Buildroot] [PATCH] package, toolchain: remove BR2_TOOLCHAIN_HAS_GCC_BUG_* options Thomas Petazzoni
@ 2016-01-30  7:55 ` Arnout Vandecappelle
  2016-01-30 10:03 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2016-01-30  7:55 UTC (permalink / raw)
  To: buildroot

On 30-01-16 00:24, Thomas Petazzoni wrote:
> Quite some time ago, we added the options
> BR2_TOOLCHAIN_HAS_GCC_BUG_58595 and BR2_TOOLCHAIN_HAS_GCC_BUG_58854 to
> indicate if the toolchain was affected by those gcc bugs, which were
> causing build failure with a number of packages.
> 
> With the recent change in the external toolchain logic to provide only
> the latest version of each toolchain "family", all the toolchains
> which were affected by those issues disappeared from Buildroot. Those
> options are no longer being selected anywhere, and being blind
> options, it means their value is always going to be "disabled".
> 
> Conquently, this commit removes those options completely, and updates
> all the packages where they were used.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>


 Regards,
 Arnout

[snip]


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] package, toolchain: remove BR2_TOOLCHAIN_HAS_GCC_BUG_* options
  2016-01-29 23:24 [Buildroot] [PATCH] package, toolchain: remove BR2_TOOLCHAIN_HAS_GCC_BUG_* options Thomas Petazzoni
  2016-01-30  7:55 ` Arnout Vandecappelle
@ 2016-01-30 10:03 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2016-01-30 10:03 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > Quite some time ago, we added the options
 > BR2_TOOLCHAIN_HAS_GCC_BUG_58595 and BR2_TOOLCHAIN_HAS_GCC_BUG_58854 to
 > indicate if the toolchain was affected by those gcc bugs, which were
 > causing build failure with a number of packages.

 > With the recent change in the external toolchain logic to provide only
 > the latest version of each toolchain "family", all the toolchains
 > which were affected by those issues disappeared from Buildroot. Those
 > options are no longer being selected anywhere, and being blind
 > options, it means their value is always going to be "disabled".

 > Conquently, this commit removes those options completely, and updates
 > all the packages where they were used.

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-30 10:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-29 23:24 [Buildroot] [PATCH] package, toolchain: remove BR2_TOOLCHAIN_HAS_GCC_BUG_* options Thomas Petazzoni
2016-01-30  7:55 ` Arnout Vandecappelle
2016-01-30 10:03 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.