All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Lawrence <slawrence@tresys.com>
To: Nicolas Iooss <nicolas.iooss@m4x.org>, <selinux@tycho.nsa.gov>
Subject: Re: [PATCH 1/3] libsepol: cil: always initialize __cil_permx_to_sepol_class_perms() result
Date: Mon, 1 Feb 2016 09:14:44 -0500	[thread overview]
Message-ID: <56AF6854.50200@tresys.com> (raw)
In-Reply-To: <1454236598-1829-1-git-send-email-nicolas.iooss@m4x.org>

On 01/31/2016 05:36 AM, Nicolas Iooss wrote:
> clang warns that __cil_permx_to_sepol_class_perms() return value, rc,
> may be unitialized:
> 
>     ../cil/src/cil_binary.c:4188:9: error: variable 'rc' may be
>     uninitialized when used here [-Werror,-Wconditional-uninitialized]
>             return rc;
>                    ^~
>     ../cil/src/cil_binary.c:4148:8: note: initialize the variable 'rc'
>     to silence this warning
>             int rc;
>                   ^
>                    = 0
> 
> This theoretically happens when cil_expand_class(permx->obj) returns an
> empty list.
> 
> Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>

All patches applied. Thanks!

- Steve

> ---
>  libsepol/cil/src/cil_binary.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libsepol/cil/src/cil_binary.c b/libsepol/cil/src/cil_binary.c
> index 433f92e40a8e..47c751c0ef06 100644
> --- a/libsepol/cil/src/cil_binary.c
> +++ b/libsepol/cil/src/cil_binary.c
> @@ -4145,7 +4145,7 @@ exit:
>  
>  static int __cil_permx_to_sepol_class_perms(policydb_t *pdb, struct cil_permissionx *permx, class_perm_node_t **sepol_class_perms)
>  {
> -	int rc;
> +	int rc = SEPOL_OK;
>  	struct cil_list *class_list = NULL;
>  	struct cil_list_item *c;
>  	class_datum_t *sepol_obj = NULL;
> 

      parent reply	other threads:[~2016-02-01 14:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-31 10:36 [PATCH 1/3] libsepol: cil: always initialize __cil_permx_to_sepol_class_perms() result Nicolas Iooss
2016-01-31 10:36 ` [PATCH 2/3] libsemanage: initialize bools_modified variable Nicolas Iooss
2016-01-31 10:36 ` [PATCH 3/3] libsemanage: move modinfo_tmp definition before goto cleanup Nicolas Iooss
2016-02-01 14:14 ` Steve Lawrence [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56AF6854.50200@tresys.com \
    --to=slawrence@tresys.com \
    --cc=nicolas.iooss@m4x.org \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.