From: "Andrew F. Davis" <afd@ti.com> To: Jonathan Cameron <jic23@kernel.org>, Hartmut Knaack <knaack.h@gmx.de>, Lars-Peter Clausen <lars@metafoo.de>, Peter Meerwald <pmeerw@pmeerw.net>, Dan Murphy <dmurphy@ti.com>, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org> Cc: <linux-iio@vger.kernel.org>, <linux-api@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v4 2/4] iio: health: Add driver for the TI AFE4404 heart monitor Date: Tue, 2 Feb 2016 09:50:35 -0600 [thread overview] Message-ID: <56B0D04B.1090208@ti.com> (raw) In-Reply-To: <56ACCFC6.2000700@kernel.org> On 01/30/2016 08:59 AM, Jonathan Cameron wrote: > On 25/01/16 17:28, Andrew F. Davis wrote: >> Add driver for the TI AFE4404 heart rate monitor and pulse oximeter. >> This device detects reflected LED light fluctuations and presents an ADC >> value to the user space for further signal processing. >> >> Datasheet: http://www.ti.com/product/AFE4404/datasheet >> >> Signed-off-by: Andrew F. Davis <afd@ti.com> > Hi Andrew, > > This changed rather more than I was expecting, but fair enough. > > A few bits are missing from remove. Few other little bits inline, > though mostly those are about readability rather than what the code > is doing. > > I was a little suprised to see no control over whether the trigger is > enabled or not. I'm trying to get my head around what the result of this will > be. I guess we'll have interrupts pinging away merilly doing nothing until > the buffer is attached then the demux will get set up to actually do > something with the data. > > hmm. Might be fine, if I ususual. Normally devices have some means of > masking the interrupt. I wasn't sure about this ether, but it doesn't seem to break anything. > > Jonathan > >> --- >> .../ABI/testing/sysfs-bus-iio-health-afe440x | 54 ++ >> drivers/iio/health/Kconfig | 19 +- [...] >> + >> +static const struct afe440x_reg_info afe4404_reg_info[] = { > > As noted below, I'd find > [LED1] = AFE440X_REG_INFO(AFE440_LED1VAL... > more readable. > ACK [...] >> + int ret; >> + >> + iio_device_unregister(indio_dev); >> + > Would expect unwinding of the triggered_buffer here. > iio_triggered_buffer_cleanup() > ACK >> + iio_trigger_unregister(afe->trig); > This should be protected by a check on afe->irq as for the register in probe. > There is no protection against afe->trig == NULL in iio_trigger_unregister. > That is kind of deliberate as it makes sure the probe / remove in drivers > are balanced unlike here. > Makes sense, will add. [...] > I'm not overly keen on the hiding fo the indexing. I'd prefer > this was just the bit {...} and you had the fact it was filling in an > indexed element explicit where used. That works. [...] > I'd prefix reg_type to avoid possible name clashes in future. >> +enum reg_type { >> + SIMPLE, >> + RESISTANCE, >> + CAPACITANCE, >> +}; ACK >> + >> +/* this could be made more general for other IIO drivers if needed --------- */ > > Yes, but lets do that at as a follow up. > Sure. Thanks, Andrew
WARNING: multiple messages have this Message-ID (diff)
From: "Andrew F. Davis" <afd-l0cyMroinI0@public.gmane.org> To: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Hartmut Knaack <knaack.h-Mmb7MZpHnFY@public.gmane.org>, Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>, Peter Meerwald <pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org>, Dan Murphy <dmurphy-l0cyMroinI0@public.gmane.org>, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>, Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>, Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Cc: linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH v4 2/4] iio: health: Add driver for the TI AFE4404 heart monitor Date: Tue, 2 Feb 2016 09:50:35 -0600 [thread overview] Message-ID: <56B0D04B.1090208@ti.com> (raw) In-Reply-To: <56ACCFC6.2000700-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> On 01/30/2016 08:59 AM, Jonathan Cameron wrote: > On 25/01/16 17:28, Andrew F. Davis wrote: >> Add driver for the TI AFE4404 heart rate monitor and pulse oximeter. >> This device detects reflected LED light fluctuations and presents an ADC >> value to the user space for further signal processing. >> >> Datasheet: http://www.ti.com/product/AFE4404/datasheet >> >> Signed-off-by: Andrew F. Davis <afd-l0cyMroinI0@public.gmane.org> > Hi Andrew, > > This changed rather more than I was expecting, but fair enough. > > A few bits are missing from remove. Few other little bits inline, > though mostly those are about readability rather than what the code > is doing. > > I was a little suprised to see no control over whether the trigger is > enabled or not. I'm trying to get my head around what the result of this will > be. I guess we'll have interrupts pinging away merilly doing nothing until > the buffer is attached then the demux will get set up to actually do > something with the data. > > hmm. Might be fine, if I ususual. Normally devices have some means of > masking the interrupt. I wasn't sure about this ether, but it doesn't seem to break anything. > > Jonathan > >> --- >> .../ABI/testing/sysfs-bus-iio-health-afe440x | 54 ++ >> drivers/iio/health/Kconfig | 19 +- [...] >> + >> +static const struct afe440x_reg_info afe4404_reg_info[] = { > > As noted below, I'd find > [LED1] = AFE440X_REG_INFO(AFE440_LED1VAL... > more readable. > ACK [...] >> + int ret; >> + >> + iio_device_unregister(indio_dev); >> + > Would expect unwinding of the triggered_buffer here. > iio_triggered_buffer_cleanup() > ACK >> + iio_trigger_unregister(afe->trig); > This should be protected by a check on afe->irq as for the register in probe. > There is no protection against afe->trig == NULL in iio_trigger_unregister. > That is kind of deliberate as it makes sure the probe / remove in drivers > are balanced unlike here. > Makes sense, will add. [...] > I'm not overly keen on the hiding fo the indexing. I'd prefer > this was just the bit {...} and you had the fact it was filling in an > indexed element explicit where used. That works. [...] > I'd prefix reg_type to avoid possible name clashes in future. >> +enum reg_type { >> + SIMPLE, >> + RESISTANCE, >> + CAPACITANCE, >> +}; ACK >> + >> +/* this could be made more general for other IIO drivers if needed --------- */ > > Yes, but lets do that at as a follow up. > Sure. Thanks, Andrew
next prev parent reply other threads:[~2016-02-02 15:51 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-01-25 17:28 [PATCH v4 0/4] iio: AFE4404 Heart Rate Monitor and Bio-Sensing Andrew F. Davis 2016-01-25 17:28 ` Andrew F. Davis 2016-01-25 17:28 ` [PATCH v4 1/4] Documentation: afe4404: Add DT bindings for the AFE4404 heart monitor Andrew F. Davis 2016-01-25 17:28 ` Andrew F. Davis 2016-01-25 20:06 ` Peter Meerwald-Stadler 2016-01-25 20:24 ` Andrew F. Davis 2016-01-25 17:28 ` [PATCH v4 2/4] iio: health: Add driver for the TI " Andrew F. Davis 2016-01-25 17:28 ` Andrew F. Davis 2016-01-25 20:17 ` Peter Meerwald-Stadler 2016-01-25 20:30 ` Andrew F. Davis 2016-01-30 14:59 ` Jonathan Cameron 2016-01-30 14:59 ` Jonathan Cameron 2016-02-02 15:50 ` Andrew F. Davis [this message] 2016-02-02 15:50 ` Andrew F. Davis 2016-01-25 17:29 ` [PATCH v4 3/4] Documentation: afe4403: Add DT bindings for the AFE4403 " Andrew F. Davis 2016-01-25 17:29 ` Andrew F. Davis 2016-01-25 17:29 ` [PATCH v4 4/4] iio: health: Add driver for the TI " Andrew F. Davis 2016-01-25 17:29 ` Andrew F. Davis 2016-01-25 20:21 ` Peter Meerwald-Stadler 2016-01-25 20:21 ` Peter Meerwald-Stadler 2016-01-25 20:36 ` Andrew F. Davis 2016-01-25 20:36 ` Andrew F. Davis 2016-01-30 15:10 ` Jonathan Cameron 2016-02-02 17:38 ` Andrew F. Davis 2016-02-02 17:38 ` Andrew F. Davis
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=56B0D04B.1090208@ti.com \ --to=afd@ti.com \ --cc=devicetree@vger.kernel.org \ --cc=dmurphy@ti.com \ --cc=galak@codeaurora.org \ --cc=ijc+devicetree@hellion.org.uk \ --cc=jic23@kernel.org \ --cc=knaack.h@gmx.de \ --cc=lars@metafoo.de \ --cc=linux-api@vger.kernel.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=pawel.moll@arm.com \ --cc=pmeerw@pmeerw.net \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.