From: Andre Przywara <andre.przywara@arm.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: "Chen-Yu Tsai" <wens@csie.org>,
linux-sunxi@googlegroups.com, "Arnd Bergmann" <arnd@arndb.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Emilio López" <emilio@elopez.com.ar>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@codeaurora.org>,
linux-clk@vger.kernel.org
Subject: Re: [PATCH 08/11] clk: sunxi: improve error reporting for the mux clock
Date: Tue, 2 Feb 2016 18:05:49 +0000 [thread overview]
Message-ID: <56B0EFFD.8070900@arm.com> (raw)
In-Reply-To: <20160202180227.GC4652@lukather>
Salut,
On 02/02/16 18:02, Maxime Ripard wrote:
> On Mon, Feb 01, 2016 at 05:39:27PM +0000, Andre Przywara wrote:
>> clk_register_mux returns a pointer wrapped error value in case of
>> failure, so a simple NULL check is not sufficient to catch errors.
>> Fix that and elaborate on the failure reason on the way. The whole
>> function does not return any error value, so silently failing may
>> leave users scratching their heads because the kernel does not
>> provide any clues on what's wrong.
>>
>> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
>
> Applied, thanks.
>
> Any chance you do that for the other functions? :)
Sure, that was actually a test balloon ;-)
Cheers,
Andre
WARNING: multiple messages have this Message-ID (diff)
From: andre.przywara@arm.com (Andre Przywara)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/11] clk: sunxi: improve error reporting for the mux clock
Date: Tue, 2 Feb 2016 18:05:49 +0000 [thread overview]
Message-ID: <56B0EFFD.8070900@arm.com> (raw)
In-Reply-To: <20160202180227.GC4652@lukather>
Salut,
On 02/02/16 18:02, Maxime Ripard wrote:
> On Mon, Feb 01, 2016 at 05:39:27PM +0000, Andre Przywara wrote:
>> clk_register_mux returns a pointer wrapped error value in case of
>> failure, so a simple NULL check is not sufficient to catch errors.
>> Fix that and elaborate on the failure reason on the way. The whole
>> function does not return any error value, so silently failing may
>> leave users scratching their heads because the kernel does not
>> provide any clues on what's wrong.
>>
>> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
>
> Applied, thanks.
>
> Any chance you do that for the other functions? :)
Sure, that was actually a test balloon ;-)
Cheers,
Andre
next prev parent reply other threads:[~2016-02-02 18:06 UTC|newest]
Thread overview: 155+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 17:39 [PATCH 00/11] arm64: Introduce Allwinner A64 and Pine64 support Andre Przywara
2016-02-01 17:39 ` Andre Przywara
2016-02-01 17:39 ` [PATCH 01/11] irqchip: sun4i: fix compilation outside of arch/arm Andre Przywara
2016-02-01 17:39 ` Andre Przywara
2016-02-02 14:51 ` [tip:irq/urgent] irqchip/sun4i: Fix compilation outside of arch/ arm tip-bot for Andre Przywara
2016-02-02 15:12 ` [PATCH 01/11] irqchip: sun4i: fix compilation outside of arch/arm Matthias Brugger
2016-02-02 15:12 ` Matthias Brugger
2016-02-02 15:32 ` Andre Przywara
2016-02-02 15:32 ` Andre Przywara
2016-02-02 16:50 ` Matthias Brugger
2016-02-02 16:50 ` Matthias Brugger
2016-02-01 17:39 ` [PATCH 03/11] drivers: rtc: allow compilation of sun6i RTC for all sunxi SoCs Andre Przywara
2016-02-01 17:39 ` Andre Przywara
2016-02-01 17:39 ` [rtc-linux] " Andre Przywara
2016-02-02 9:44 ` Maxime Ripard
2016-02-02 9:44 ` Maxime Ripard
2016-02-02 9:44 ` [rtc-linux] " Maxime Ripard
2016-02-04 22:58 ` Alexandre Belloni
2016-02-04 22:58 ` Alexandre Belloni
2016-02-04 22:58 ` [rtc-linux] " Alexandre Belloni
2016-02-01 17:39 ` [PATCH 04/11] arm64: Introduce Allwinner SoC config option Andre Przywara
2016-02-01 17:39 ` Andre Przywara
2016-02-02 15:20 ` Matthias Brugger
2016-02-02 15:20 ` Matthias Brugger
2016-02-02 15:30 ` Andre Przywara
2016-02-02 15:30 ` Andre Przywara
2016-02-02 16:04 ` Arnd Bergmann
2016-02-02 16:04 ` Arnd Bergmann
[not found] ` <1454348370-3816-1-git-send-email-andre.przywara-5wv7dgnIgG8@public.gmane.org>
2016-02-01 17:39 ` [PATCH 02/11] crypto: sunxi-ss: prevent compilation on 64-bit Andre Przywara
2016-02-01 17:39 ` Andre Przywara
2016-02-01 17:39 ` Andre Przywara
[not found] ` <1454348370-3816-3-git-send-email-andre.przywara-5wv7dgnIgG8@public.gmane.org>
2016-02-02 3:16 ` Herbert Xu
2016-02-02 3:16 ` Herbert Xu
2016-02-02 3:16 ` Herbert Xu
2016-02-02 8:42 ` LABBE Corentin
2016-02-02 8:42 ` [linux-sunxi] " LABBE Corentin
2016-02-02 8:42 ` LABBE Corentin
2016-02-06 7:46 ` Herbert Xu
2016-02-06 7:46 ` Herbert Xu
2016-02-06 7:46 ` Herbert Xu
2016-02-01 17:39 ` [PATCH 05/11] drivers: pinctrl: add driver for Allwinner A64 SoC Andre Przywara
2016-02-01 17:39 ` Andre Przywara
2016-02-01 17:39 ` Andre Przywara
2016-02-01 18:27 ` Karsten Merker
2016-02-01 18:45 ` [linux-sunxi] " Karsten Merker
[not found] ` <20160201184505.GB14737-Hlt6eto4P0pdWf7zwHaZWbNAH6kLmebB@public.gmane.org>
2016-02-01 23:02 ` André Przywara
2016-02-01 23:02 ` [linux-sunxi] " André Przywara
2016-02-01 23:02 ` André Przywara
[not found] ` <20160201182754.GA14737-Hlt6eto4P0pdWf7zwHaZWbNAH6kLmebB@public.gmane.org>
2016-02-01 22:49 ` André Przywara
2016-02-01 22:49 ` André Przywara
2016-02-01 22:49 ` André Przywara
[not found] ` <56AFE0EC.8080207-5wv7dgnIgG8@public.gmane.org>
2016-02-02 1:58 ` Siarhei Siamashka
2016-02-02 1:58 ` [linux-sunxi] " Siarhei Siamashka
2016-02-02 1:58 ` Siarhei Siamashka
2016-02-02 14:24 ` Andre Przywara
2016-02-02 14:24 ` Andre Przywara
2016-02-02 14:24 ` Andre Przywara
2016-02-02 17:37 ` Maxime Ripard
2016-02-02 17:37 ` [linux-sunxi] " Maxime Ripard
2016-02-02 17:37 ` Maxime Ripard
2016-02-02 10:00 ` Maxime Ripard
2016-02-02 10:00 ` Maxime Ripard
2016-02-02 10:00 ` Maxime Ripard
2016-02-02 10:09 ` Chen-Yu Tsai
2016-02-02 10:09 ` Chen-Yu Tsai
2016-02-02 10:09 ` Chen-Yu Tsai
2016-02-02 16:53 ` Andre Przywara
2016-02-02 16:53 ` Andre Przywara
2016-02-02 16:53 ` Andre Przywara
[not found] ` <56B0DF26.10203-5wv7dgnIgG8@public.gmane.org>
2016-02-04 16:51 ` Maxime Ripard
2016-02-04 16:51 ` Maxime Ripard
2016-02-04 16:51 ` Maxime Ripard
2016-02-08 15:54 ` Rob Herring
2016-02-08 15:54 ` Rob Herring
2016-02-08 15:54 ` Rob Herring
2016-02-08 15:58 ` Andre Przywara
2016-02-08 15:58 ` Andre Przywara
2016-02-08 15:58 ` Andre Przywara
[not found] ` <56B8BB1A.8010705-5wv7dgnIgG8@public.gmane.org>
2016-02-09 17:12 ` Maxime Ripard
2016-02-09 17:12 ` Maxime Ripard
2016-02-09 17:12 ` Maxime Ripard
2016-02-01 17:39 ` [PATCH 06/11] clk: sunxi: add generic multi-parent bus clock gates driver Andre Przywara
2016-02-01 17:39 ` Andre Przywara
2016-02-01 18:40 ` Jean-Francois Moine
2016-02-01 18:40 ` Jean-Francois Moine
2016-02-01 18:40 ` Jean-Francois Moine
2016-02-01 23:01 ` André Przywara
2016-02-01 23:01 ` André Przywara
2016-02-01 17:39 ` [PATCH 07/11] clk: sunxi: add generic allwinner,sunxi name Andre Przywara
2016-02-01 17:39 ` Andre Przywara
2016-02-01 17:39 ` Andre Przywara
2016-02-08 15:57 ` Rob Herring
2016-02-08 15:57 ` Rob Herring
2016-02-08 16:06 ` Andre Przywara
2016-02-08 16:06 ` Andre Przywara
2016-02-08 16:06 ` Andre Przywara
2016-02-01 17:39 ` [PATCH 08/11] clk: sunxi: improve error reporting for the mux clock Andre Przywara
2016-02-01 17:39 ` Andre Przywara
2016-02-02 18:02 ` Maxime Ripard
2016-02-02 18:02 ` Maxime Ripard
2016-02-02 18:05 ` Andre Przywara [this message]
2016-02-02 18:05 ` Andre Przywara
2016-02-01 17:39 ` [PATCH 09/11] clk: sunxi: add critical-clocks property to mux clocks Andre Przywara
2016-02-01 17:39 ` Andre Przywara
2016-02-01 17:39 ` [PATCH 10/11] arm64: dts: add Allwinner A64 SoC .dtsi Andre Przywara
2016-02-01 17:39 ` Andre Przywara
2016-02-01 17:39 ` Andre Przywara
2016-02-01 19:05 ` [linux-sunxi] " Karsten Merker
2016-02-01 23:03 ` André Przywara
2016-02-01 23:03 ` André Przywara
2016-02-01 23:03 ` André Przywara
2016-02-02 16:24 ` Jens Kuske
2016-02-02 16:24 ` Jens Kuske
2016-02-02 16:24 ` Jens Kuske
2016-02-02 16:46 ` [linux-sunxi] " Andre Przywara
2016-02-02 16:46 ` Andre Przywara
2016-02-02 17:40 ` Jens Kuske
2016-02-02 17:40 ` Jens Kuske
2016-02-02 17:40 ` Jens Kuske
2016-02-05 8:55 ` [linux-sunxi] " Chen-Yu Tsai
2016-02-05 8:55 ` Chen-Yu Tsai
2016-02-05 8:55 ` Chen-Yu Tsai
2016-02-05 8:50 ` Maxime Ripard
2016-02-05 8:50 ` Maxime Ripard
2016-02-05 8:50 ` Maxime Ripard
2016-02-08 9:42 ` Andre Przywara
2016-02-08 9:42 ` Andre Przywara
2016-02-23 18:45 ` Maxime Ripard
2016-02-23 18:45 ` Maxime Ripard
2016-02-23 18:45 ` Maxime Ripard
2016-02-01 17:39 ` [PATCH 11/11] arm64: dts: add Pine64 support Andre Przywara
2016-02-01 17:39 ` Andre Przywara
2016-02-01 17:39 ` Andre Przywara
2016-02-01 19:22 ` [linux-sunxi] " Karsten Merker
2016-02-01 23:04 ` André Przywara
2016-02-01 23:04 ` André Przywara
2016-02-01 23:04 ` André Przywara
2016-02-05 9:03 ` Maxime Ripard
2016-02-05 9:03 ` Maxime Ripard
2016-02-05 9:03 ` Maxime Ripard
2016-02-05 10:04 ` Andre Przywara
2016-02-05 10:04 ` Andre Przywara
2016-02-05 10:04 ` Andre Przywara
2016-02-08 0:55 ` [linux-sunxi] " Julian Calaby
2016-02-08 0:55 ` Julian Calaby
2016-02-09 20:33 ` Danny Milosavljevic
2016-02-09 20:33 ` Danny Milosavljevic
2016-02-09 20:33 ` Danny Milosavljevic
2016-02-11 10:32 ` Maxime Ripard
2016-02-11 10:32 ` Maxime Ripard
2016-02-11 10:32 ` Maxime Ripard
2016-02-02 7:57 ` [PATCH 00/11] arm64: Introduce Allwinner A64 and " lists.nick.betteridge
2016-02-02 7:57 ` lists.nick.betteridge at gmail.com
2016-02-02 8:12 ` André Przywara
2016-02-02 8:12 ` André Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B0EFFD.8070900@arm.com \
--to=andre.przywara@arm.com \
--cc=arnd@arndb.de \
--cc=emilio@elopez.com.ar \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.