Re: [Qemu-devel] [PULL 00/17] Net patches

[Jason Wang <jasowang@redhat.com>]

On 02/02/2016 07:05 PM, Peter Maydell wrote:
> On 2 February 2016 at 02:36, Jason Wang <jasowang@redhat.com> wrote:
>> The following changes since commit 0430891ce162b986c6e02a7729a942ecd2a32ca4:
>>
>>   hw: Clean up includes (2016-01-29 15:07:25 +0000)
>>
>> are available in the git repository at:
>>
>>   https://github.com/jasowang/qemu.git tags/net-pull-request
>>
>> for you to fetch changes up to e8a7a1a574ed6728422959c8aa79ca584cdd1d4d:
>>
>>   net/filter: Fix the output information for command 'info network' (2016-02-02 10:21:28 +0800)
>>
>> ----------------------------------------------------------------
>>
>> Major changes for net:
>>
>> - preparation for ipv6 support in slirp
>> - fix tx infinite loops of e1000
>> - fix cadence_gem buffer overflow
>> - rx netfilter were gone in reverse for future complex netfilter setups
> Hi. I'm afraid this failed to build on w32:
>
> In file included from /home/petmay01/linaro/qemu-for-merges/slirp/slirp.h:146,
>                  from /home/petmay01/linaro/qemu-for-merges/stubs/slirp.c:2:
> /home/petmay01/linaro/qemu-for-merges/slirp/udp.h:79: error: expected
> declaration specifiers or ‘...’ before ‘sa_family_t’
> In file included from /home/petmay01/linaro/qemu-for-merges/stubs/slirp.c:2:
> /home/petmay01/linaro/qemu-for-merges/slirp/slirp.h:330: error:
> expected declaration specifiers or ‘...’ before ‘sa_family_t’
>
> thanks
> -- PMM

Oops, very sorry for the build failure. I've setup a cross build
environment to test win32 build before each pull request in the future.

For this issue, looks like there's no sa_family_t for windows. Possible
solutions are:

- switch to use unsigned short
- or typedef sa_family_t as unsigned short for windows

Samuel and Guillaume, thoughts for this?

Thanks