* [PATCH] pci: fix typo in nvkm_pcie_set_link()
@ 2016-02-03 9:33 Alexandre Courbot
[not found] ` <1454491991-5839-1-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Alexandre Courbot @ 2016-02-03 9:33 UTC (permalink / raw)
To: Ben Skeggs; +Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Fix a test that would either do nothing on PCI systems, or crash badly
on Tegra.
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Cc: Karol Herbst <nouveau@karolherbst.de>
---
drm/nouveau/nvkm/subdev/pci/pcie.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drm/nouveau/nvkm/subdev/pci/pcie.c b/drm/nouveau/nvkm/subdev/pci/pcie.c
index b32954f5311e..d71e5db5028a 100644
--- a/drm/nouveau/nvkm/subdev/pci/pcie.c
+++ b/drm/nouveau/nvkm/subdev/pci/pcie.c
@@ -119,7 +119,7 @@ nvkm_pcie_set_link(struct nvkm_pci *pci, enum nvkm_pcie_speed speed, u8 width)
struct pci_bus *pbus;
int ret;
- if (pci || !pci_is_pcie(pci->pdev))
+ if (!pci || !pci_is_pcie(pci->pdev))
return 0;
pbus = pci->pdev->bus;
--
2.7.0
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pci: fix typo in nvkm_pcie_set_link()
[not found] ` <1454491991-5839-1-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
@ 2016-02-03 10:03 ` Samuel Pitoiset
[not found] ` <56B1D07E.1030704-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Samuel Pitoiset @ 2016-02-03 10:03 UTC (permalink / raw)
To: Alexandre Courbot, Ben Skeggs; +Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
On 02/03/2016 10:33 AM, Alexandre Courbot wrote:
> Fix a test that would either do nothing on PCI systems, or crash badly
> on Tegra.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> Cc: Karol Herbst <nouveau@karolherbst.de>
> ---
> drm/nouveau/nvkm/subdev/pci/pcie.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drm/nouveau/nvkm/subdev/pci/pcie.c b/drm/nouveau/nvkm/subdev/pci/pcie.c
> index b32954f5311e..d71e5db5028a 100644
> --- a/drm/nouveau/nvkm/subdev/pci/pcie.c
> +++ b/drm/nouveau/nvkm/subdev/pci/pcie.c
> @@ -119,7 +119,7 @@ nvkm_pcie_set_link(struct nvkm_pci *pci, enum nvkm_pcie_speed speed, u8 width)
> struct pci_bus *pbus;
> int ret;
>
> - if (pci || !pci_is_pcie(pci->pdev))
> + if (!pci || !pci_is_pcie(pci->pdev))
> return 0;
> pbus = pci->pdev->bus;
This has already been fixed but Ben still didn't apply this change to
his repository.
http://cgit.freedesktop.org/~airlied/linux/tree/drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c?h=drm-next#n122
>
>
--
-Samuel
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pci: fix typo in nvkm_pcie_set_link()
[not found] ` <56B1D07E.1030704-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2016-02-03 13:22 ` Alexandre Courbot
0 siblings, 0 replies; 3+ messages in thread
From: Alexandre Courbot @ 2016-02-03 13:22 UTC (permalink / raw)
To: Samuel Pitoiset; +Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Ben Skeggs
On Wed, Feb 3, 2016 at 7:03 PM, Samuel Pitoiset
<samuel.pitoiset@gmail.com> wrote:
>
>
> On 02/03/2016 10:33 AM, Alexandre Courbot wrote:
>>
>> Fix a test that would either do nothing on PCI systems, or crash badly
>> on Tegra.
>>
>> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
>> Cc: Karol Herbst <nouveau@karolherbst.de>
>> ---
>> drm/nouveau/nvkm/subdev/pci/pcie.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drm/nouveau/nvkm/subdev/pci/pcie.c
>> b/drm/nouveau/nvkm/subdev/pci/pcie.c
>> index b32954f5311e..d71e5db5028a 100644
>> --- a/drm/nouveau/nvkm/subdev/pci/pcie.c
>> +++ b/drm/nouveau/nvkm/subdev/pci/pcie.c
>> @@ -119,7 +119,7 @@ nvkm_pcie_set_link(struct nvkm_pci *pci, enum
>> nvkm_pcie_speed speed, u8 width)
>> struct pci_bus *pbus;
>> int ret;
>>
>> - if (pci || !pci_is_pcie(pci->pdev))
>> + if (!pci || !pci_is_pcie(pci->pdev))
>> return 0;
>> pbus = pci->pdev->bus;
>
>
> This has already been fixed but Ben still didn't apply this change to his
> repository.
>
> http://cgit.freedesktop.org/~airlied/linux/tree/drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c?h=drm-next#n122
Ah, perfect then. Dropping this patch.
Cheers,
Alex.
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-03 13:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-03 9:33 [PATCH] pci: fix typo in nvkm_pcie_set_link() Alexandre Courbot
[not found] ` <1454491991-5839-1-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-02-03 10:03 ` Samuel Pitoiset
[not found] ` <56B1D07E.1030704-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-03 13:22 ` Alexandre Courbot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.