From: Stephen Warren <swarren@wwwdotorg.org>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: linux-rpi-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Eric Anholt <eric@anholt.net>,
Lee Jones <lee@kernel.org>, Peter Chen <peter.chen@freescale.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 2/2] ARM: bcm2835: dt: Add the ethernet to the device tree
Date: Wed, 3 Feb 2016 09:11:14 -0700 [thread overview]
Message-ID: <56B226A2.6000101@wwwdotorg.org> (raw)
In-Reply-To: <1454511759-24827-3-git-send-email-lkundrak@v3.sk>
On 02/03/2016 08:02 AM, Lubomir Rintel wrote:
> The hub and the ethernet in its port 1 are hardwired on the board.
>
> Compared to the adapters that can be plugged into the USB ports, this
> one has no serial EEPROM to store its MAC. Nevertheless, the Raspberry Pi
> has the MAC address for this adapter in its ROM, accessible from its
> firmware.
>
> U-Boot can read out the address and set the local-mac-address property of the
> node with "ethernet" alias. Let's add the node so that U-Boot can do its
> business.
Good to see we're getting a standard for this.
Have you talked to the RPi Foundation about updating their binary
bootloader to follow this protocol? I'll certainly ack changes to make
this work for U-Boot, provided the USB core patch this relies upon is
accepted.
> diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts
> +&usb {
> + usb1@01 {
> + compatible = "usb1d6b,0002";
> + reg = <01>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + ethernet: usbether@01 {
> + compatible = "usb0424,9514";
> + reg = <01>;
Ib both unit addresses and both reg properties, I would expect "1" not
"01" since there's usually no leading 0 fill for those.
I'm curious why the VID values for the hub and Ethernet device don't
match since those are part of the same combo chip. Is there a typo
there, or did SMSC really do something odd in HW?
next prev parent reply other threads:[~2016-02-03 16:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 15:02 [PATCH 0/2] Set the Raspberry Pi Ethernet MAC address Lubomir Rintel
2016-02-03 15:02 ` [PATCH 1/2] net/smscx5xx: use the device tree for mac address Lubomir Rintel
2016-02-03 15:23 ` Arnd Bergmann
2016-02-03 15:42 ` Lubomir Rintel
2016-02-03 15:02 ` [PATCH 2/2] ARM: bcm2835: dt: Add the ethernet to the device tree Lubomir Rintel
2016-02-03 15:02 ` Lubomir Rintel
2016-02-03 15:11 ` Lubomir Rintel
2016-02-03 15:11 ` Lubomir Rintel
2016-02-03 16:11 ` Stephen Warren [this message]
2016-02-03 16:32 ` Lubomir Rintel
2016-02-03 23:41 ` Olivier Blin
2016-02-03 23:41 ` Olivier Blin
2016-02-04 6:28 ` Peter Chen
2016-02-04 6:28 ` Peter Chen
2016-02-04 7:18 ` Lubomir Rintel
2016-02-04 7:18 ` Lubomir Rintel
2016-02-07 10:10 ` kbuild test robot
2016-02-07 10:10 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B226A2.6000101@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lkundrak@v3.sk \
--cc=peter.chen@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.