From: Lubomir Rintel <lkundrak@v3.sk> To: Peter Chen <peter.chen@nxp.com>, Olivier Blin <dev@blino.org> Cc: "linux-rpi-kernel@lists.infradead.org" <linux-rpi-kernel@lists.infradead.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Arnd Bergmann <arnd@arndb.de>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Peter Chen <peter.chen@freescale.com> Subject: Re: [PATCH 2/2] ARM: bcm2835: dt: Add the ethernet to the device tree Date: Thu, 04 Feb 2016 08:18:13 +0100 [thread overview] Message-ID: <1454570293.25750.23.camel@v3.sk> (raw) In-Reply-To: <HE1PR04MB14503FBA55F4F9C19EE669B68BD10@HE1PR04MB1450.eurprd04.prod.outlook.com> On Thu, 2016-02-04 at 06:28 +0000, Peter Chen wrote: > > > Lubomir Rintel <lkundrak@v3.sk> writes: > > > > > diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts > > > b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts > > > index ef54050..32bbd2a 100644 > > > --- a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts > > > +++ b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts > > > > Hi, > > > > Shouldn't this be common to all RPi1 B and RPi2 models, instead of > > being > > specific to just RPi B+? > > > > > +&usb { > > > + usb1@01 { > > > + compatible = "usb1d6b,0002"; > > > + reg = <01>; > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + > > > + ethernet: usbether@01 { > > > + compatible = "usb0424,9514"; > > > + reg = <01>; > > > + }; > > > + }; > > > +}; > > > > For reference, on RPi2: > > Using "lsusb -t" you may get bus topology. > > > Bus 001 Device 003: ID 0424:ec00 Standard Microsystems Corp. > > SMSC9512/9514 Fast Ethernet Adapter > > It is the ethernet device, you may need to change vid/pid in dts. > > > Bus 001 Device 002: ID 0424:9514 Standard Microsystems Corp. > > SMC9514 Hub > > It is the hub device, you may need to change vid/pid in dts. > > > Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub > > > > It is root hub, it doesn't need to be described at dts. Thank you; neither of the vid/pid pairs in the original submission is okay. I'll follow up with an updated version. I've also checked this on RPi B rev2; and I'll be including that one, and the RPI2 too. I can't find my rev1 RPi B; but maybe I can just do the same for the same board. It would likely work, but I may get the vid/pid wrong if it's different from rev2. > Best regards, > Peter Thanks Lubo
WARNING: multiple messages have this Message-ID (diff)
From: Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org> To: Peter Chen <peter.chen-3arQi8VN3Tc@public.gmane.org>, Olivier Blin <dev-RZzICDNEOQ/YtjvyW6yDsg@public.gmane.org> Cc: "linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" <linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Peter Chen <peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org> Subject: Re: [PATCH 2/2] ARM: bcm2835: dt: Add the ethernet to the device tree Date: Thu, 04 Feb 2016 08:18:13 +0100 [thread overview] Message-ID: <1454570293.25750.23.camel@v3.sk> (raw) In-Reply-To: <HE1PR04MB14503FBA55F4F9C19EE669B68BD10-6LN7OEpIatVC+P/YwrXEHc9NdZoXdze2vxpqHgZTriW3zl9H0oFU5g@public.gmane.org> On Thu, 2016-02-04 at 06:28 +0000, Peter Chen wrote: > > > Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org> writes: > > > > > diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts > > > b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts > > > index ef54050..32bbd2a 100644 > > > --- a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts > > > +++ b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts > > > > Hi, > > > > Shouldn't this be common to all RPi1 B and RPi2 models, instead of > > being > > specific to just RPi B+? > > > > > +&usb { > > > + usb1@01 { > > > + compatible = "usb1d6b,0002"; > > > + reg = <01>; > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + > > > + ethernet: usbether@01 { > > > + compatible = "usb0424,9514"; > > > + reg = <01>; > > > + }; > > > + }; > > > +}; > > > > For reference, on RPi2: > > Using "lsusb -t" you may get bus topology. > > > Bus 001 Device 003: ID 0424:ec00 Standard Microsystems Corp. > > SMSC9512/9514 Fast Ethernet Adapter > > It is the ethernet device, you may need to change vid/pid in dts. > > > Bus 001 Device 002: ID 0424:9514 Standard Microsystems Corp. > > SMC9514 Hub > > It is the hub device, you may need to change vid/pid in dts. > > > Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub > > > > It is root hub, it doesn't need to be described at dts. Thank you; neither of the vid/pid pairs in the original submission is okay. I'll follow up with an updated version. I've also checked this on RPi B rev2; and I'll be including that one, and the RPI2 too. I can't find my rev1 RPi B; but maybe I can just do the same for the same board. It would likely work, but I may get the vid/pid wrong if it's different from rev2. > Best regards, > Peter Thanks Lubo -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-02-04 7:18 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-02-03 15:02 [PATCH 0/2] Set the Raspberry Pi Ethernet MAC address Lubomir Rintel 2016-02-03 15:02 ` [PATCH 1/2] net/smscx5xx: use the device tree for mac address Lubomir Rintel 2016-02-03 15:23 ` Arnd Bergmann 2016-02-03 15:42 ` Lubomir Rintel 2016-02-03 15:02 ` [PATCH 2/2] ARM: bcm2835: dt: Add the ethernet to the device tree Lubomir Rintel 2016-02-03 15:02 ` Lubomir Rintel 2016-02-03 15:11 ` Lubomir Rintel 2016-02-03 15:11 ` Lubomir Rintel 2016-02-03 16:11 ` Stephen Warren 2016-02-03 16:32 ` Lubomir Rintel 2016-02-03 23:41 ` Olivier Blin 2016-02-03 23:41 ` Olivier Blin 2016-02-04 6:28 ` Peter Chen 2016-02-04 6:28 ` Peter Chen 2016-02-04 7:18 ` Lubomir Rintel [this message] 2016-02-04 7:18 ` Lubomir Rintel 2016-02-07 10:10 ` kbuild test robot 2016-02-07 10:10 ` kbuild test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1454570293.25750.23.camel@v3.sk \ --to=lkundrak@v3.sk \ --cc=arnd@arndb.de \ --cc=dev@blino.org \ --cc=devicetree@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rpi-kernel@lists.infradead.org \ --cc=peter.chen@freescale.com \ --cc=peter.chen@nxp.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.