All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@codeaurora.org>
To: fu.wei@linaro.org, robh+dt@kernel.org, pawel.moll@arm.com,
	mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
	galak@codeaurora.org, wim@iguana.be, linux@roeck-us.net,
	corbet@lwn.net, catalin.marinas@arm.com, will.deacon@arm.com,
	Suravee.Suthikulpanit@amd.com
Cc: linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
	linux-doc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linaro-acpi@lists.linaro.org, rruigrok@codeaurora.org,
	harba@codeaurora.org, cov@codeaurora.org, dyoung@redhat.com,
	panand@redhat.com, graeme.gregory@linaro.org,
	al.stone@linaro.org, hanjun.guo@linaro.org, jcm@redhat.com,
	arnd@arndb.de, leo.duran@amd.com, sudeep.holla@arm.com
Subject: Re: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver
Date: Wed, 3 Feb 2016 11:48:17 -0600	[thread overview]
Message-ID: <56B23D61.2050001@codeaurora.org> (raw)
In-Reply-To: <1454519923-25230-5-git-send-email-fu.wei@linaro.org>

fu.wei@linaro.org wrote:
> +static struct platform_driver sbsa_gwdt_driver = {
> +	.driver = {
> +		.name = "sbsa-gwdt",
> +		.pm = &sbsa_gwdt_pm_ops,
> +		.of_match_table = sbsa_gwdt_of_match,
> +	},
> +	.probe = sbsa_gwdt_probe,
> +	.remove = sbsa_gwdt_remove,
> +	.shutdown = sbsa_gwdt_shutdown,
> +	.id_table = sbsa_gwdt_pdev_match,
> +};

I just noticed you dropped ACPI support.  Server platforms are supposed 
to use ACPI, so that seems like a critical omission to me.  You had a 
GTDT parser in an older version of this patch.  What happened to it?

WARNING: multiple messages have this Message-ID (diff)
From: timur@codeaurora.org (Timur Tabi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver
Date: Wed, 3 Feb 2016 11:48:17 -0600	[thread overview]
Message-ID: <56B23D61.2050001@codeaurora.org> (raw)
In-Reply-To: <1454519923-25230-5-git-send-email-fu.wei@linaro.org>

fu.wei at linaro.org wrote:
> +static struct platform_driver sbsa_gwdt_driver = {
> +	.driver = {
> +		.name = "sbsa-gwdt",
> +		.pm = &sbsa_gwdt_pm_ops,
> +		.of_match_table = sbsa_gwdt_of_match,
> +	},
> +	.probe = sbsa_gwdt_probe,
> +	.remove = sbsa_gwdt_remove,
> +	.shutdown = sbsa_gwdt_shutdown,
> +	.id_table = sbsa_gwdt_pdev_match,
> +};

I just noticed you dropped ACPI support.  Server platforms are supposed 
to use ACPI, so that seems like a critical omission to me.  You had a 
GTDT parser in an older version of this patch.  What happened to it?

  reply	other threads:[~2016-02-03 17:48 UTC|newest]

Thread overview: 130+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-03 17:18 [PATCH v10 0/5] Watchdog: introduce ARM SBSA watchdog driver fu.wei
2016-02-03 17:18 ` fu.wei at linaro.org
2016-02-03 17:18 ` [PATCH v10 1/5] Documentation: add sbsa-gwdt driver documentation fu.wei
2016-02-03 17:18   ` fu.wei at linaro.org
2016-02-03 17:18 ` [PATCH v10 2/5] ARM64: add SBSA Generic Watchdog device node in foundation-v8.dts fu.wei
2016-02-03 17:18   ` fu.wei at linaro.org
2016-02-03 17:18 ` [PATCH v10 3/5] ARM64: add SBSA Generic Watchdog device node in amd-seattle-soc.dtsi fu.wei
2016-02-03 17:18   ` fu.wei at linaro.org
2016-02-03 17:18   ` fu.wei-QSEj5FYQhm4dnm+yROfE0A
2016-02-03 17:18 ` [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver fu.wei
2016-02-03 17:18   ` fu.wei at linaro.org
2016-02-03 17:48   ` Timur Tabi [this message]
2016-02-03 17:48     ` Timur Tabi
2016-02-03 17:57     ` Fu Wei
2016-02-03 17:57       ` Fu Wei
2016-02-03 17:57       ` Fu Wei
2016-02-03 17:58       ` Timur Tabi
2016-02-03 17:58         ` Timur Tabi
2016-02-03 17:58         ` Timur Tabi
2016-02-03 18:09         ` Fu Wei
2016-02-03 18:09           ` Fu Wei
2016-02-03 18:09           ` Fu Wei
2016-02-03 18:12           ` Timur Tabi
2016-02-03 18:12             ` Timur Tabi
2016-02-03 18:12             ` Timur Tabi
2016-02-04 16:25   ` Mathieu Poirier
2016-02-04 16:25     ` Mathieu Poirier
2016-02-04 16:25     ` Mathieu Poirier
2016-02-05  9:01     ` Fu Wei
2016-02-05  9:01       ` Fu Wei
2016-02-05  9:01       ` Fu Wei
2016-02-04 16:31   ` Will Deacon
2016-02-04 16:31     ` Will Deacon
2016-02-04 16:31     ` Will Deacon
2016-02-04 16:37     ` Timur Tabi
2016-02-04 16:37       ` Timur Tabi
2016-02-04 16:37       ` Timur Tabi
2016-02-04 16:46       ` Guenter Roeck
2016-02-04 16:46         ` Guenter Roeck
2016-02-05  8:52         ` Fu Wei
2016-02-05  8:52           ` Fu Wei
2016-02-05  8:52           ` Fu Wei
2016-02-03 17:18 ` [PATCH v10 5/5] Watchdog: ARM SBSA Generic Watchdog half timeout panic support fu.wei
2016-02-03 17:18   ` fu.wei at linaro.org
2016-02-03 17:27   ` Timur Tabi
2016-02-03 17:27     ` Timur Tabi
2016-02-03 17:49     ` Fu Wei
2016-02-03 17:49       ` Fu Wei
2016-02-03 17:49       ` Fu Wei
2016-02-03 17:53       ` Timur Tabi
2016-02-03 17:53         ` Timur Tabi
2016-02-03 17:53         ` Timur Tabi
2016-02-03 18:06         ` Fu Wei
2016-02-03 18:06           ` Fu Wei
2016-02-03 18:06           ` Fu Wei
2016-02-03 18:08           ` Timur Tabi
2016-02-03 18:08             ` Timur Tabi
2016-02-03 18:08             ` Timur Tabi
2016-02-03 18:18             ` Fu Wei
2016-02-03 18:18               ` Fu Wei
2016-02-03 18:18               ` Fu Wei
2016-02-03 18:26               ` Timur Tabi
2016-02-03 18:26                 ` Timur Tabi
2016-02-03 18:26                 ` Timur Tabi
2016-02-03 18:37                 ` Fu Wei
2016-02-03 18:37                   ` Fu Wei
2016-02-03 18:37                   ` Fu Wei
2016-02-03 18:45                   ` Timur Tabi
2016-02-03 18:45                     ` Timur Tabi
2016-02-03 18:45                     ` Timur Tabi
2016-02-03 23:00                     ` Fu Wei
2016-02-03 23:00                       ` Fu Wei
2016-02-03 23:00                       ` Fu Wei
2016-02-04  5:17                       ` Guenter Roeck
2016-02-04  5:17                         ` Guenter Roeck
2016-02-04  5:17                         ` Guenter Roeck
2016-02-04 13:48                         ` Timur Tabi
2016-02-04 13:48                           ` Timur Tabi
2016-02-04 13:48                           ` Timur Tabi
2016-02-04 14:41                           ` Guenter Roeck
2016-02-04 14:41                             ` Guenter Roeck
2016-02-04 14:41                             ` Guenter Roeck
2016-02-05  9:51                         ` Fu Wei
2016-02-05  9:51                           ` Fu Wei
2016-02-05  9:51                           ` Fu Wei
2016-02-05 13:02                           ` Thomas Petazzoni
2016-02-05 13:02                             ` Thomas Petazzoni
2016-02-05 13:02                             ` Thomas Petazzoni
2016-02-05 13:08                             ` Timur Tabi
2016-02-05 13:08                               ` Timur Tabi
2016-02-05 13:08                               ` Timur Tabi
2016-02-05 13:33                               ` Thomas Petazzoni
2016-02-05 13:33                                 ` Thomas Petazzoni
2016-02-05 13:33                                 ` Thomas Petazzoni
2016-02-05 14:42                           ` Guenter Roeck
2016-02-05 14:42                             ` Guenter Roeck
2016-02-05 14:42                             ` Guenter Roeck
2016-02-05 18:21                             ` Fu Wei
2016-02-05 18:21                               ` Fu Wei
2016-02-05 18:21                               ` Fu Wei
2016-02-05 23:54                               ` Guenter Roeck
2016-02-05 23:54                                 ` Guenter Roeck
2016-02-05 23:54                                 ` Guenter Roeck
2016-02-06 18:02                                 ` Fu Wei
2016-02-06 18:02                                   ` Fu Wei
2016-02-06 18:02                                   ` Fu Wei
2016-02-06 18:55                                   ` Timur Tabi
2016-02-06 18:55                                     ` Timur Tabi
2016-02-06 18:55                                     ` Timur Tabi
2016-02-07  2:02                                     ` Fu Wei
2016-02-07  2:02                                       ` Fu Wei
2016-02-07  2:02                                       ` Fu Wei
2016-02-06 18:57                                   ` Guenter Roeck
2016-02-06 18:57                                     ` Guenter Roeck
2016-02-06 18:57                                     ` Guenter Roeck
2016-02-07  2:12                                     ` Fu Wei
2016-02-07  2:12                                       ` Fu Wei
2016-02-07  2:12                                       ` Fu Wei
2016-02-04 16:32   ` Mathieu Poirier
2016-02-04 16:32     ` Mathieu Poirier
2016-02-04 16:32     ` Mathieu Poirier
2016-02-04 16:41     ` Guenter Roeck
2016-02-04 16:41       ` Guenter Roeck
2016-02-04 16:41       ` Guenter Roeck
2016-02-04 16:43     ` Timur Tabi
2016-02-04 16:43       ` Timur Tabi
2016-02-04 16:43       ` Timur Tabi
2016-02-05  9:20       ` Fu Wei
2016-02-05  9:20         ` Fu Wei
2016-02-05  9:20         ` Fu Wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56B23D61.2050001@codeaurora.org \
    --to=timur@codeaurora.org \
    --cc=Suravee.Suthikulpanit@amd.com \
    --cc=al.stone@linaro.org \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=corbet@lwn.net \
    --cc=cov@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dyoung@redhat.com \
    --cc=fu.wei@linaro.org \
    --cc=galak@codeaurora.org \
    --cc=graeme.gregory@linaro.org \
    --cc=hanjun.guo@linaro.org \
    --cc=harba@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jcm@redhat.com \
    --cc=leo.duran@amd.com \
    --cc=linaro-acpi@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mark.rutland@arm.com \
    --cc=panand@redhat.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=rruigrok@codeaurora.org \
    --cc=sudeep.holla@arm.com \
    --cc=will.deacon@arm.com \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.