From: Rick Jones <rick.jones2@hpe.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Nikolay Aleksandrov <razor@blackwall.org>,
netdev@vger.kernel.org, roopa@cumulusnetworks.com,
davem@davemloft.net,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
linux-api@vger.kernel.org
Subject: Re: [PATCH net-next v5 1/2] ethtool: add speed/duplex validation functions
Date: Thu, 4 Feb 2016 09:30:14 -0800 [thread overview]
Message-ID: <56B38AA6.9050307@hpe.com> (raw)
In-Reply-To: <20160204142327-mutt-send-email-mst@redhat.com>
On 02/04/2016 04:47 AM, Michael S. Tsirkin wrote:
> On Wed, Feb 03, 2016 at 03:49:04PM -0800, Rick Jones wrote:
>> And even for not-quite-virtual devices - such as a VC/FlexNIC in an HPE
>> blade server there can be just about any speed set. I think we went down a
>> path of patching some things to address that many years ago. It would be a
>> shame to undo that.
>>
>> rick
>
> I'm not sure I understand. The question is in defining the UAPI.
> We currently have:
>
> * @speed: Low bits of the speed
> * @speed_hi: Hi bits of the speed
>
> with the assumption that all values come from the defines.
>
> So if we allow any value here we need to define what it means.
I may be mixing apples and kiwis. Many years ago when HP came-out with
their blades and VirtualConnect, they included the ability to create
"flex NICs" - "sub-NICs" out of a given interface port on a blade, and
to assign each a specific bitrate in increments (IIRC) of 100 Mbit/s.
This was reported up through the driver and it became necessary to make
ethtool (again, IIRC) not so picky about "valid" speed values.
rick
next prev parent reply other threads:[~2016-02-04 17:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 3:04 [PATCH net-next v5 0/2] virtio_net: add ethtool get/set settings support Nikolay Aleksandrov
2016-02-03 3:04 ` [PATCH net-next v5 1/2] ethtool: add speed/duplex validation functions Nikolay Aleksandrov
2016-02-03 23:32 ` Stephen Hemminger
2016-02-03 23:49 ` Rick Jones
2016-02-04 12:47 ` Michael S. Tsirkin
2016-02-04 17:30 ` Rick Jones [this message]
2016-02-04 11:02 ` Nikolay Aleksandrov
2016-02-04 12:18 ` Michael S. Tsirkin
2016-02-03 3:04 ` [PATCH net-next v5 2/2] virtio_net: add ethtool support for set and get of settings Nikolay Aleksandrov
2016-02-03 9:19 ` Nikolay Aleksandrov
2016-02-04 12:23 ` Michael S. Tsirkin
2016-02-04 12:21 ` Michael S. Tsirkin
2016-02-04 12:26 ` Nikolay Aleksandrov
2016-02-07 19:31 ` [PATCH net-next v5 0/2] virtio_net: add ethtool get/set settings support David Miller
2016-02-07 19:35 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B38AA6.9050307@hpe.com \
--to=rick.jones2@hpe.com \
--cc=davem@davemloft.net \
--cc=linux-api@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=razor@blackwall.org \
--cc=roopa@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.