From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
To: David Miller <davem@davemloft.net>, razor@blackwall.org
Cc: netdev@vger.kernel.org, mst@redhat.com, roopa@cumulusnetworks.com
Subject: Re: [PATCH net-next v5 0/2] virtio_net: add ethtool get/set settings support
Date: Sun, 7 Feb 2016 20:35:28 +0100 [thread overview]
Message-ID: <56B79C80.2070508@cumulusnetworks.com> (raw)
In-Reply-To: <20160207.143117.2074335859138369633.davem@davemloft.net>
On 02/07/2016 08:31 PM, David Miller wrote:
> From: Nikolay Aleksandrov <razor@blackwall.org>
> Date: Wed, 3 Feb 2016 04:04:35 +0100
>
>> Patch 1 adds ethtool speed/duplex validation functions which check if the
>> value is defined. Patch 2 adds support for ethtool (get|set)_settings and
>> uses the validation functions to check the user-supplied values.
>>
>> v2: split in 2 patches to allow everyone to make use of the validation
>> functions and allow virtio_net devices to be half duplex
>> v3: added a check to return error if the user tries to change anything else
>> besides duplex/speed as per Michael's comment
>> v4: Set port type to PORT_OTHER
>> v5: clear diff1.port (ignore port) when checking for changes since we set
>> it now and ethtool uses it in the set request
>>
>> Sorry about the pointless iterations, should've all covered now.
>
> Series applied, thanks Nik.
>
Thank you Dave, I was actually waiting for Michael's ethtool patch to go in.
I'll send a follow-up to make sure the port is what we set it to and also
to allow setting any speed (as people commented, devices can have any speed
these days, so we don't want to limit them to the defined ones).
prev parent reply other threads:[~2016-02-07 19:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 3:04 [PATCH net-next v5 0/2] virtio_net: add ethtool get/set settings support Nikolay Aleksandrov
2016-02-03 3:04 ` [PATCH net-next v5 1/2] ethtool: add speed/duplex validation functions Nikolay Aleksandrov
2016-02-03 23:32 ` Stephen Hemminger
2016-02-03 23:49 ` Rick Jones
2016-02-04 12:47 ` Michael S. Tsirkin
2016-02-04 17:30 ` Rick Jones
2016-02-04 11:02 ` Nikolay Aleksandrov
2016-02-04 12:18 ` Michael S. Tsirkin
2016-02-03 3:04 ` [PATCH net-next v5 2/2] virtio_net: add ethtool support for set and get of settings Nikolay Aleksandrov
2016-02-03 9:19 ` Nikolay Aleksandrov
2016-02-04 12:23 ` Michael S. Tsirkin
2016-02-04 12:21 ` Michael S. Tsirkin
2016-02-04 12:26 ` Nikolay Aleksandrov
2016-02-07 19:31 ` [PATCH net-next v5 0/2] virtio_net: add ethtool get/set settings support David Miller
2016-02-07 19:35 ` Nikolay Aleksandrov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B79C80.2070508@cumulusnetworks.com \
--to=nikolay@cumulusnetworks.com \
--cc=davem@davemloft.net \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=razor@blackwall.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.