* [Qemu-devel] [PATCH] linux-user: set ppc64/ppc64le default CPU to POWER8
@ 2016-02-04 18:56 Laurent Vivier
2016-02-04 19:01 ` Alexander Graf
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Laurent Vivier @ 2016-02-04 18:56 UTC (permalink / raw)
To: Riku Voipio; +Cc: Laurent Vivier, peter.maydell, mjt, agraf, qemu-devel, gkurz
Set the default to the latest CPU version to have the
largest set of available features.
It is also really needed in little-endian mode because
POWER7 is not really supported in this mode and some distros
(at least debian) generate POWER8 code for their ppc64le target.
Fixes: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813698
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
linux-user/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/main.c b/linux-user/main.c
index e719a2d..2a692e0 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -4160,7 +4160,7 @@ int main(int argc, char **argv, char **envp)
cpu_model = "or1200";
#elif defined(TARGET_PPC)
# ifdef TARGET_PPC64
- cpu_model = "POWER7";
+ cpu_model = "POWER8";
# else
cpu_model = "750";
# endif
--
2.5.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] linux-user: set ppc64/ppc64le default CPU to POWER8
2016-02-04 18:56 [Qemu-devel] [PATCH] linux-user: set ppc64/ppc64le default CPU to POWER8 Laurent Vivier
@ 2016-02-04 19:01 ` Alexander Graf
2016-02-04 21:24 ` Michael Tokarev
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Alexander Graf @ 2016-02-04 19:01 UTC (permalink / raw)
To: Laurent Vivier, Riku Voipio; +Cc: peter.maydell, mjt, qemu-devel, gkurz
On 02/04/2016 07:56 PM, Laurent Vivier wrote:
> Set the default to the latest CPU version to have the
> largest set of available features.
>
> It is also really needed in little-endian mode because
> POWER7 is not really supported in this mode and some distros
> (at least debian) generate POWER8 code for their ppc64le target.
>
> Fixes: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813698
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Makes a lot of sense.
Reviewed-by: Alexander Graf <agraf@suse.de>
Alex
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] linux-user: set ppc64/ppc64le default CPU to POWER8
2016-02-04 18:56 [Qemu-devel] [PATCH] linux-user: set ppc64/ppc64le default CPU to POWER8 Laurent Vivier
2016-02-04 19:01 ` Alexander Graf
@ 2016-02-04 21:24 ` Michael Tokarev
2016-02-15 13:15 ` Riku Voipio
2016-02-15 13:25 ` Peter Maydell
3 siblings, 0 replies; 5+ messages in thread
From: Michael Tokarev @ 2016-02-04 21:24 UTC (permalink / raw)
To: Laurent Vivier, Riku Voipio; +Cc: peter.maydell, gkurz, agraf, qemu-devel
04.02.2016 21:56, Laurent Vivier wrote:
> Set the default to the latest CPU version to have the
> largest set of available features.
>
> It is also really needed in little-endian mode because
> POWER7 is not really supported in this mode and some distros
> (at least debian) generate POWER8 code for their ppc64le target.
>
> Fixes: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813698
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Thank you!
/mjt
> ---
> linux-user/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/main.c b/linux-user/main.c
> index e719a2d..2a692e0 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -4160,7 +4160,7 @@ int main(int argc, char **argv, char **envp)
> cpu_model = "or1200";
> #elif defined(TARGET_PPC)
> # ifdef TARGET_PPC64
> - cpu_model = "POWER7";
> + cpu_model = "POWER8";
> # else
> cpu_model = "750";
> # endif
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] linux-user: set ppc64/ppc64le default CPU to POWER8
2016-02-04 18:56 [Qemu-devel] [PATCH] linux-user: set ppc64/ppc64le default CPU to POWER8 Laurent Vivier
2016-02-04 19:01 ` Alexander Graf
2016-02-04 21:24 ` Michael Tokarev
@ 2016-02-15 13:15 ` Riku Voipio
2016-02-15 13:25 ` Peter Maydell
3 siblings, 0 replies; 5+ messages in thread
From: Riku Voipio @ 2016-02-15 13:15 UTC (permalink / raw)
To: Laurent Vivier; +Cc: qemu-devel
On torstaina 4. helmikuuta 2016 20.56.01 EET, Laurent Vivier wrote:
> Set the default to the latest CPU version to have the
> largest set of available features.
>
> It is also really needed in little-endian mode because
> POWER7 is not really supported in this mode and some distros
> (at least debian) generate POWER8 code for their ppc64le target.
Applied, thanks.
> Fixes: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813698
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> linux-user/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/main.c b/linux-user/main.c
> index e719a2d..2a692e0 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -4160,7 +4160,7 @@ int main(int argc, char **argv, char **envp)
> cpu_model = "or1200";
> #elif defined(TARGET_PPC)
> # ifdef TARGET_PPC64
> - cpu_model = "POWER7";
> + cpu_model = "POWER8";
> # else
> cpu_model = "750";
> # endif
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] linux-user: set ppc64/ppc64le default CPU to POWER8
2016-02-04 18:56 [Qemu-devel] [PATCH] linux-user: set ppc64/ppc64le default CPU to POWER8 Laurent Vivier
` (2 preceding siblings ...)
2016-02-15 13:15 ` Riku Voipio
@ 2016-02-15 13:25 ` Peter Maydell
3 siblings, 0 replies; 5+ messages in thread
From: Peter Maydell @ 2016-02-15 13:25 UTC (permalink / raw)
To: Laurent Vivier
Cc: Riku Voipio, Michael Tokarev, Alexander Graf, Greg Kurz, QEMU Developers
On 4 February 2016 at 18:56, Laurent Vivier <lvivier@redhat.com> wrote:
> Set the default to the latest CPU version to have the
> largest set of available features.
>
> It is also really needed in little-endian mode because
> POWER7 is not really supported in this mode and some distros
> (at least debian) generate POWER8 code for their ppc64le target.
>
> Fixes: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813698
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
This patch is a good fix, but for the longer term is it possible
on PPC to define an "any" CPU which is the largest possible set
of usable-together userspace features? That would make it easier
for us to avoid this problem in the future for POWER9, POWER10,...
thanks
-- PMM
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-02-15 13:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-04 18:56 [Qemu-devel] [PATCH] linux-user: set ppc64/ppc64le default CPU to POWER8 Laurent Vivier
2016-02-04 19:01 ` Alexander Graf
2016-02-04 21:24 ` Michael Tokarev
2016-02-15 13:15 ` Riku Voipio
2016-02-15 13:25 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.