All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <marc.zyngier@arm.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: tglx@linutronix.de, mark.rutland@arm.com, sboyd@codeaurora.org
Subject: Re: [PATCH v2] clocksource/arm_arch_timer: Enable and verify MMIO access
Date: Mon, 8 Feb 2016 14:09:25 +0000	[thread overview]
Message-ID: <56B8A195.2050807@arm.com> (raw)
In-Reply-To: <56B89F98.7020909@linaro.org>

On 08/02/16 14:00, Daniel Lezcano wrote:
> On 02/01/2016 01:00 PM, Robin Murphy wrote:
>> So far, we have been blindly assuming that having access to a
>> memory-mapped timer frame implies that the individual elements of that
>> frame frame are already enabled. Whilst it's the firmware's job to give
>> us non-secure access to frames in the first place, we should not rely
>> on implementations always being generous enough to also configure CNTACR
>> for those non-secure frames (e.g. [1]).
>>
>> Explicitly enable feature-level access per-frame, and verify that the
>> access we want is really implemented before trying to make use of it.
>>
>> [1]:https://github.com/ARM-software/tf-issues/issues/170
>>
>> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
>> ---
> 
> Hi Marc,
> 
> can you give your opinion on this patch ?

This seems to do the right thing, so FWIW:

Acked-by: Marc Zyngier <marc.zyngier@arm.com>

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

WARNING: multiple messages have this Message-ID (diff)
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] clocksource/arm_arch_timer: Enable and verify MMIO access
Date: Mon, 8 Feb 2016 14:09:25 +0000	[thread overview]
Message-ID: <56B8A195.2050807@arm.com> (raw)
In-Reply-To: <56B89F98.7020909@linaro.org>

On 08/02/16 14:00, Daniel Lezcano wrote:
> On 02/01/2016 01:00 PM, Robin Murphy wrote:
>> So far, we have been blindly assuming that having access to a
>> memory-mapped timer frame implies that the individual elements of that
>> frame frame are already enabled. Whilst it's the firmware's job to give
>> us non-secure access to frames in the first place, we should not rely
>> on implementations always being generous enough to also configure CNTACR
>> for those non-secure frames (e.g. [1]).
>>
>> Explicitly enable feature-level access per-frame, and verify that the
>> access we want is really implemented before trying to make use of it.
>>
>> [1]:https://github.com/ARM-software/tf-issues/issues/170
>>
>> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
>> ---
> 
> Hi Marc,
> 
> can you give your opinion on this patch ?

This seems to do the right thing, so FWIW:

Acked-by: Marc Zyngier <marc.zyngier@arm.com>

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

  reply	other threads:[~2016-02-08 14:09 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-01 12:00 [PATCH v2] clocksource/arm_arch_timer: Enable and verify MMIO access Robin Murphy
2016-02-01 12:00 ` Robin Murphy
2016-02-01 13:44 ` Mark Rutland
2016-02-01 13:44   ` Mark Rutland
2016-02-01 19:58 ` Stephen Boyd
2016-02-01 19:58   ` Stephen Boyd
2016-02-05 15:29   ` Robin Murphy
2016-02-05 15:29     ` Robin Murphy
2016-02-05 15:32     ` Daniel Lezcano
2016-02-05 15:32       ` Daniel Lezcano
2016-02-05 15:34       ` Robin Murphy
2016-02-05 15:34         ` Robin Murphy
2016-02-08 14:00 ` Daniel Lezcano
2016-02-08 14:00   ` Daniel Lezcano
2016-02-08 14:09   ` Marc Zyngier [this message]
2016-02-08 14:09     ` Marc Zyngier
2016-02-08 14:30 ` Daniel Lezcano
2016-02-08 14:30   ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56B8A195.2050807@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robin.murphy@arm.com \
    --cc=sboyd@codeaurora.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.