From: Joao Pinto <Joao.Pinto@synopsys.com>
To: Mark Rutland <mark.rutland@arm.com>,
Joao Pinto <Joao.Pinto@synopsys.com>
Cc: Arnd Bergmann <arnd@arndb.de>, <santosh.sy@samsung.com>,
<h.vinayak@samsung.com>, <julian.calaby@gmail.com>,
<akinobu.mita@gmail.com>, <hch@infradead.org>,
<gbroner@codeaurora.org>, <subhashj@codeaurora.org>,
<CARLOS.PALMINHA@synopsys.com>, <ijc+devicetree@hellion.org.uk>,
<linux-kernel@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCH 3/3] add support for DWC UFS Host Controller
Date: Mon, 8 Feb 2016 16:17:20 +0000 [thread overview]
Message-ID: <56B8BF90.3050602@synopsys.com> (raw)
In-Reply-To: <20160208161530.GB14146@leverpostej>
On 2/8/2016 4:15 PM, Mark Rutland wrote:
> On Mon, Feb 08, 2016 at 03:36:52PM +0000, Joao Pinto wrote:
>> Hi Mark,
>>
>> On 2/8/2016 3:30 PM, Mark Rutland wrote:
>>> On Mon, Feb 08, 2016 at 03:17:11PM +0000, Joao Pinto wrote:
>>>> Hi Mark and Arnd,
>>>> Are you saying that a user that puts "snps,ufshcd-1.1"
>>>> in the DT compatibility string disables the UFS 2.0 in the core driver despite
>>>> the controller is 2.0? Please clarify.
>>>
>>> If you can consistently and safely detect that the HW is 2.0, using 2.0
>>> functionality is fine.
>>>
>>> Regardless, you should have a -1.1 compatible string for the 1.1 HW, and
>>> a -2.0 string for the 2.0 HW, so that DTs are explicit about what the
>>> hardware is. If 2.0 is intended to be a superset of 1.1, you can have a
>>> 1.1 fallback entry for the 2.0 hardware.
>>>
>>
>> Ok, I will include the version in the compatibility strings, but if someone
>> mentions "snps,ufshcd-1.1" only and the driver detects that the HW is 2.0
>> capable it will activate the 2.0 features independently of what mentioned in the
>> DT, correct?
>
> As above, if that can be detected safely and reliably, then I don't see
> a problem with that.
Ok, thanks for the comments! I am working a bit in PCI next version patch and so
I predict to produce a new version for UFS next Wednesday.
Joao
>
> Thanks,
> Mark.
>
WARNING: multiple messages have this Message-ID (diff)
From: Joao Pinto <Joao.Pinto@synopsys.com>
To: Mark Rutland <mark.rutland@arm.com>,
Joao Pinto <Joao.Pinto@synopsys.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
santosh.sy@samsung.com, h.vinayak@samsung.com,
julian.calaby@gmail.com, akinobu.mita@gmail.com,
hch@infradead.org, gbroner@codeaurora.org,
subhashj@codeaurora.org, CARLOS.PALMINHA@synopsys.com,
ijc+devicetree@hellion.org.uk, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] add support for DWC UFS Host Controller
Date: Mon, 8 Feb 2016 16:17:20 +0000 [thread overview]
Message-ID: <56B8BF90.3050602@synopsys.com> (raw)
In-Reply-To: <20160208161530.GB14146@leverpostej>
On 2/8/2016 4:15 PM, Mark Rutland wrote:
> On Mon, Feb 08, 2016 at 03:36:52PM +0000, Joao Pinto wrote:
>> Hi Mark,
>>
>> On 2/8/2016 3:30 PM, Mark Rutland wrote:
>>> On Mon, Feb 08, 2016 at 03:17:11PM +0000, Joao Pinto wrote:
>>>> Hi Mark and Arnd,
>>>> Are you saying that a user that puts "snps,ufshcd-1.1"
>>>> in the DT compatibility string disables the UFS 2.0 in the core driver despite
>>>> the controller is 2.0? Please clarify.
>>>
>>> If you can consistently and safely detect that the HW is 2.0, using 2.0
>>> functionality is fine.
>>>
>>> Regardless, you should have a -1.1 compatible string for the 1.1 HW, and
>>> a -2.0 string for the 2.0 HW, so that DTs are explicit about what the
>>> hardware is. If 2.0 is intended to be a superset of 1.1, you can have a
>>> 1.1 fallback entry for the 2.0 hardware.
>>>
>>
>> Ok, I will include the version in the compatibility strings, but if someone
>> mentions "snps,ufshcd-1.1" only and the driver detects that the HW is 2.0
>> capable it will activate the 2.0 features independently of what mentioned in the
>> DT, correct?
>
> As above, if that can be detected safely and reliably, then I don't see
> a problem with that.
Ok, thanks for the comments! I am working a bit in PCI next version patch and so
I predict to produce a new version for UFS next Wednesday.
Joao
>
> Thanks,
> Mark.
>
next prev parent reply other threads:[~2016-02-08 16:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 11:28 [PATCH 0/3] add support for DWC UFS Controller Joao Pinto
2016-02-03 11:28 ` [PATCH 1/3] fixed typo in ufshcd-pltfrm Joao Pinto
2016-02-03 11:28 ` [PATCH 2/3] added support for ufs 2.0 Joao Pinto
2016-02-03 11:28 ` [PATCH 3/3] add support for DWC UFS Host Controller Joao Pinto
2016-02-03 12:54 ` Arnd Bergmann
2016-02-03 15:01 ` Joao Pinto
2016-02-03 15:01 ` Joao Pinto
2016-02-03 15:39 ` Arnd Bergmann
2016-02-03 15:54 ` Joao Pinto
2016-02-03 15:54 ` Joao Pinto
2016-02-04 16:27 ` Mark Rutland
2016-02-04 16:27 ` Mark Rutland
2016-02-08 15:17 ` Joao Pinto
2016-02-08 15:17 ` Joao Pinto
2016-02-08 15:30 ` Mark Rutland
2016-02-08 15:36 ` Joao Pinto
2016-02-08 15:36 ` Joao Pinto
2016-02-08 16:15 ` Mark Rutland
2016-02-08 16:17 ` Joao Pinto [this message]
2016-02-08 16:17 ` Joao Pinto
2016-02-03 17:21 ` Joao Pinto
2016-02-03 17:21 ` Joao Pinto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B8BF90.3050602@synopsys.com \
--to=joao.pinto@synopsys.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=akinobu.mita@gmail.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=gbroner@codeaurora.org \
--cc=h.vinayak@samsung.com \
--cc=hch@infradead.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=julian.calaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=santosh.sy@samsung.com \
--cc=subhashj@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.