* [PATCH] iio: Fix documentation for iio_dev mlock
@ 2016-02-08 15:03 Daniel Baluta
2016-02-08 18:34 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Baluta @ 2016-02-08 15:03 UTC (permalink / raw)
To: jic23; +Cc: knaack.h, lars, pmeerw, linux-iio, linux-kernel
mlock *must* be used by core and drivers to protect access
to devices state changes.
Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
---
At a first glance there are few places where access to iio_dev
state changes are done without mlock protection. Will fix them
with follow up patches.
include/linux/iio/iio.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
index b589411..ce9e9c1 100644
--- a/include/linux/iio/iio.h
+++ b/include/linux/iio/iio.h
@@ -448,7 +448,7 @@ struct iio_buffer_setup_ops {
* @buffer: [DRIVER] any buffer present
* @buffer_list: [INTERN] list of all buffers currently attached
* @scan_bytes: [INTERN] num bytes captured to be fed to buffer demux
- * @mlock: [INTERN] lock used to prevent simultaneous device state
+ * @mlock: [DRIVER] lock used to prevent simultaneous device state
* changes
* @available_scan_masks: [DRIVER] optional array of allowed bitmasks
* @masklength: [INTERN] the length of the mask established from
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: Fix documentation for iio_dev mlock
2016-02-08 15:03 [PATCH] iio: Fix documentation for iio_dev mlock Daniel Baluta
@ 2016-02-08 18:34 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2016-02-08 18:34 UTC (permalink / raw)
To: Daniel Baluta; +Cc: knaack.h, lars, pmeerw, linux-iio, linux-kernel
On 08/02/16 15:03, Daniel Baluta wrote:
> mlock *must* be used by core and drivers to protect access
> to devices state changes.
>
> Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
Applied. Thanks for cleaning this up.
Jonathan
> ---
> At a first glance there are few places where access to iio_dev
> state changes are done without mlock protection. Will fix them
> with follow up patches.
>
> include/linux/iio/iio.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
> index b589411..ce9e9c1 100644
> --- a/include/linux/iio/iio.h
> +++ b/include/linux/iio/iio.h
> @@ -448,7 +448,7 @@ struct iio_buffer_setup_ops {
> * @buffer: [DRIVER] any buffer present
> * @buffer_list: [INTERN] list of all buffers currently attached
> * @scan_bytes: [INTERN] num bytes captured to be fed to buffer demux
> - * @mlock: [INTERN] lock used to prevent simultaneous device state
> + * @mlock: [DRIVER] lock used to prevent simultaneous device state
> * changes
> * @available_scan_masks: [DRIVER] optional array of allowed bitmasks
> * @masklength: [INTERN] the length of the mask established from
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-08 18:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-08 15:03 [PATCH] iio: Fix documentation for iio_dev mlock Daniel Baluta
2016-02-08 18:34 ` Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.