From: Corneliu ZUZU <czuzu@bitdefender.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Kevin Tian <kevin.tian@intel.com>,
Tamas K Lengyel <tamas@tklengyel.com>, Keir Fraser <keir@xen.org>,
Ian Campbell <ian.campbell@citrix.com>,
Razvan Cojocaru <rcojocaru@bitdefender.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel@lists.xen.org,
Stefano Stabellini <stefano.stabellini@citrix.com>,
Jun Nakajima <jun.nakajima@intel.com>
Subject: Re: [PATCH 2/7] x86: hvm events: merge 2 functions into 1
Date: Tue, 9 Feb 2016 14:24:22 +0200 [thread overview]
Message-ID: <56B9DA76.9000804@bitdefender.com> (raw)
In-Reply-To: <56B9E5C002000078000D005A@prv-mh.provo.novell.com>
On 2/9/2016 2:12 PM, Jan Beulich wrote:
>>>> On 09.02.16 at 12:52, <czuzu@bitdefender.com> wrote:
>> On 2/9/2016 1:19 PM, Jan Beulich wrote:
>>>>>> On 08.02.16 at 17:57, <czuzu@bitdefender.com> wrote:
>>>> This patch merges almost identical functions hvm_event_int3
>>>> and hvm_event_single_step into a single function called
>>>> hvm_event_software_breakpoint.
>>> Except that "software breakpoint" is rather questionable a name
>>> here, considering that on x86 this is basically an alias for "int3".
>>> If it was "breakpoint", one might argue (see the other responses
>>> you've got) that breakpoint event resulting from debug register
>>> settings might then be candidates to come here too.
>> Yeah..should I then:
>> * keep both functions and only rename hvm_event_int3 to
>> hvm_event_software_breakpoint
> I actually think that the intention of folding two almost identical
> functions is a good one. I'm merely suggesting to think of a
> better name - perhaps just "breakpoint" or "debug event"?
>
>
SGTM. I'll change it to hvm_event_breakpoint then.
Corneliu.
next prev parent reply other threads:[~2016-02-09 12:24 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 16:57 [PATCH 0/7] Vm-events: move monitor vm-events code to common code Corneliu ZUZU
2016-02-08 16:57 ` [PATCH 1/7] arm: move arch/arm/hvm.c to arch/arm/hvm/hvm.c Corneliu ZUZU
2016-02-08 17:04 ` Andrew Cooper
2016-02-08 17:12 ` Corneliu ZUZU
2016-02-08 17:14 ` Andrew Cooper
2016-02-09 11:03 ` Stefano Stabellini
2016-02-09 11:28 ` Corneliu ZUZU
2016-02-09 11:55 ` Jan Beulich
2016-02-09 12:22 ` Stefano Stabellini
2016-02-09 12:32 ` Corneliu ZUZU
2016-02-09 17:40 ` Tamas K Lengyel
2016-02-09 19:19 ` Corneliu ZUZU
2016-02-08 16:57 ` [PATCH 2/7] x86: hvm events: merge 2 functions into 1 Corneliu ZUZU
2016-02-08 17:15 ` Andrew Cooper
2016-02-08 17:30 ` Tamas K Lengyel
2016-02-08 17:49 ` Corneliu ZUZU
2016-02-08 18:17 ` Tamas K Lengyel
2016-02-08 18:45 ` Corneliu ZUZU
2016-02-09 11:19 ` Jan Beulich
2016-02-09 11:52 ` Corneliu ZUZU
2016-02-09 12:12 ` Jan Beulich
2016-02-09 12:24 ` Corneliu ZUZU [this message]
2016-02-08 16:57 ` [PATCH 3/7] xen/vm-events: Move monitor_domctl to common-side Corneliu ZUZU
2016-02-08 18:15 ` Tamas K Lengyel
2016-02-08 18:43 ` Corneliu ZUZU
2016-02-08 18:50 ` Tamas K Lengyel
2016-02-08 16:57 ` [PATCH 4/7] Rename monitor_x86.c to monitor.c and monitor_arch.h to monitor.h Corneliu ZUZU
2016-02-08 18:18 ` Tamas K Lengyel
2016-02-08 18:55 ` Corneliu ZUZU
2016-02-08 16:58 ` [PATCH 5/7] xen/vm-events: Move hvm_event_* functions to common-side Corneliu ZUZU
2016-02-08 16:58 ` [PATCH 6/7] Rename event_x86.c to event.c and event_arch.h to event.h + minor fixes Corneliu ZUZU
2016-02-08 16:58 ` [PATCH 7/7] arch.monitor: move bits to common (arch_domain to domain) Corneliu ZUZU
2016-02-08 18:29 ` Tamas K Lengyel
2016-02-09 7:14 ` Corneliu ZUZU
2016-02-08 17:06 ` [PATCH 0/7] Vm-events: move monitor vm-events code to common code Corneliu ZUZU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B9DA76.9000804@bitdefender.com \
--to=czuzu@bitdefender.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=jun.nakajima@intel.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=rcojocaru@bitdefender.com \
--cc=stefano.stabellini@citrix.com \
--cc=tamas@tklengyel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.