From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Kevin Tian <kevin.tian@intel.com>,
Tamas K Lengyel <tamas@tklengyel.com>, Keir Fraser <keir@xen.org>,
Ian Campbell <ian.campbell@citrix.com>,
Razvan Cojocaru <rcojocaru@bitdefender.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel@lists.xen.org,
Stefano Stabellini <stefano.stabellini@citrix.com>,
Jun Nakajima <jun.nakajima@intel.com>,
Corneliu ZUZU <czuzu@bitdefender.com>
Subject: Re: [PATCH 1/7] arm: move arch/arm/hvm.c to arch/arm/hvm/hvm.c
Date: Tue, 9 Feb 2016 12:22:31 +0000 [thread overview]
Message-ID: <alpine.DEB.2.02.1602091222180.27008@kaball.uk.xensource.com> (raw)
In-Reply-To: <56B9E1A602000078000CFFF5@prv-mh.provo.novell.com>
On Tue, 9 Feb 2016, Jan Beulich wrote:
> >>> On 09.02.16 at 12:28, <czuzu@bitdefender.com> wrote:
> > On 2/9/2016 1:03 PM, Stefano Stabellini wrote:
> >> On Mon, 8 Feb 2016, Corneliu ZUZU wrote:
> >>> X86-side hvm.c is @ arch/x86/hvm/hvm.c. To maintain arm<->x86 symmetry,
> >>> also move arch/arm/hvm.c to arch/arm/hvm/hvm.c.
> >> Why are we doing this? These are not header files, their paths don't
> >> necessarily need to be the same and xen/arch/x86/hvm/hvm.c is very
> >> different from xen/arch/arm/hvm.c.
> >>
> >> Please state the reason more clearly.
> >>
> >>
> >>> Signed-off-by: Corneliu ZUZU <czuzu@bitdefender.com>
> >>> ---
> >>> xen/arch/arm/Makefile | 2 +-
> >>> xen/arch/arm/hvm.c | 67 -----------------------------------------------
> >>> xen/arch/arm/hvm/Makefile | 1 +
> >>> xen/arch/arm/hvm/hvm.c | 66 ++++++++++++++++++++++++++++++++++++++++++++++
> >>>
> >
> > Because the ARM side hvm.c currently exists solely to add an implementation
> > for
> > do_hvm_op, which on x86 is @ arch/x86/hvm/hvm.c. I presume the ARM hvm.c got
> > its name
> > from the X86 file, so I thought a symmetry between the two was intended from
> > the start.
> > Also, the hvm directory was created to separate hvm-specific code, which is
> > the case w/
> > do_hvm_op on any arch.
>
> While I'm not an ARM maintainer, this change still strikes me as odd
> (or a change for the change's sake). A directory with just one file
> in it (and - afaict - no current perspective to gain more) is just
> pointless. In fact it's usually the other way around: When a file
> grows (or would grow) too large, a similarly named subdirectory
> gets introduced with the contents "scattered" across multiple files
> in that directory.
That's exactly what I thought.
next prev parent reply other threads:[~2016-02-09 12:22 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 16:57 [PATCH 0/7] Vm-events: move monitor vm-events code to common code Corneliu ZUZU
2016-02-08 16:57 ` [PATCH 1/7] arm: move arch/arm/hvm.c to arch/arm/hvm/hvm.c Corneliu ZUZU
2016-02-08 17:04 ` Andrew Cooper
2016-02-08 17:12 ` Corneliu ZUZU
2016-02-08 17:14 ` Andrew Cooper
2016-02-09 11:03 ` Stefano Stabellini
2016-02-09 11:28 ` Corneliu ZUZU
2016-02-09 11:55 ` Jan Beulich
2016-02-09 12:22 ` Stefano Stabellini [this message]
2016-02-09 12:32 ` Corneliu ZUZU
2016-02-09 17:40 ` Tamas K Lengyel
2016-02-09 19:19 ` Corneliu ZUZU
2016-02-08 16:57 ` [PATCH 2/7] x86: hvm events: merge 2 functions into 1 Corneliu ZUZU
2016-02-08 17:15 ` Andrew Cooper
2016-02-08 17:30 ` Tamas K Lengyel
2016-02-08 17:49 ` Corneliu ZUZU
2016-02-08 18:17 ` Tamas K Lengyel
2016-02-08 18:45 ` Corneliu ZUZU
2016-02-09 11:19 ` Jan Beulich
2016-02-09 11:52 ` Corneliu ZUZU
2016-02-09 12:12 ` Jan Beulich
2016-02-09 12:24 ` Corneliu ZUZU
2016-02-08 16:57 ` [PATCH 3/7] xen/vm-events: Move monitor_domctl to common-side Corneliu ZUZU
2016-02-08 18:15 ` Tamas K Lengyel
2016-02-08 18:43 ` Corneliu ZUZU
2016-02-08 18:50 ` Tamas K Lengyel
2016-02-08 16:57 ` [PATCH 4/7] Rename monitor_x86.c to monitor.c and monitor_arch.h to monitor.h Corneliu ZUZU
2016-02-08 18:18 ` Tamas K Lengyel
2016-02-08 18:55 ` Corneliu ZUZU
2016-02-08 16:58 ` [PATCH 5/7] xen/vm-events: Move hvm_event_* functions to common-side Corneliu ZUZU
2016-02-08 16:58 ` [PATCH 6/7] Rename event_x86.c to event.c and event_arch.h to event.h + minor fixes Corneliu ZUZU
2016-02-08 16:58 ` [PATCH 7/7] arch.monitor: move bits to common (arch_domain to domain) Corneliu ZUZU
2016-02-08 18:29 ` Tamas K Lengyel
2016-02-09 7:14 ` Corneliu ZUZU
2016-02-08 17:06 ` [PATCH 0/7] Vm-events: move monitor vm-events code to common code Corneliu ZUZU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1602091222180.27008@kaball.uk.xensource.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=czuzu@bitdefender.com \
--cc=ian.campbell@citrix.com \
--cc=jun.nakajima@intel.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=rcojocaru@bitdefender.com \
--cc=stefano.stabellini@citrix.com \
--cc=tamas@tklengyel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.