* [PATCH] iio: buffer-dmaengine: Use dmaengine_terminate_sync()
@ 2016-02-08 17:51 Lars-Peter Clausen
2016-02-09 21:07 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Lars-Peter Clausen @ 2016-02-08 17:51 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Hartmut Knaack, Peter Meerwald, linux-iio, Lars-Peter Clausen
The DMAengine framework gained support for synchronized transfer
termination. Use the new dmaengine_terminate_sync() function instead of
dmaengine_terminate_all(), this avoids a potential race condition when
disabling the buffer.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
drivers/iio/buffer/industrialio-buffer-dmaengine.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/iio/buffer/industrialio-buffer-dmaengine.c b/drivers/iio/buffer/industrialio-buffer-dmaengine.c
index ebdb838..9fabed4 100644
--- a/drivers/iio/buffer/industrialio-buffer-dmaengine.c
+++ b/drivers/iio/buffer/industrialio-buffer-dmaengine.c
@@ -93,12 +93,7 @@ static void iio_dmaengine_buffer_abort(struct iio_dma_buffer_queue *queue)
struct dmaengine_buffer *dmaengine_buffer =
iio_buffer_to_dmaengine_buffer(&queue->buffer);
- dmaengine_terminate_all(dmaengine_buffer->chan);
- /* FIXME: There is a slight chance of a race condition here.
- * dmaengine_terminate_all() does not guarantee that all transfer
- * callbacks have finished running. Need to introduce a
- * dmaengine_terminate_all_sync().
- */
+ dmaengine_terminate_sync(dmaengine_buffer->chan);
iio_dma_buffer_block_list_abort(queue, &dmaengine_buffer->active);
}
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: buffer-dmaengine: Use dmaengine_terminate_sync()
2016-02-08 17:51 [PATCH] iio: buffer-dmaengine: Use dmaengine_terminate_sync() Lars-Peter Clausen
@ 2016-02-09 21:07 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2016-02-09 21:07 UTC (permalink / raw)
To: Lars-Peter Clausen; +Cc: Hartmut Knaack, Peter Meerwald, linux-iio
On 08/02/16 17:51, Lars-Peter Clausen wrote:
> The DMAengine framework gained support for synchronized transfer
> termination. Use the new dmaengine_terminate_sync() function instead of
> dmaengine_terminate_all(), this avoids a potential race condition when
> disabling the buffer.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Applied - thanks,
Jonathan
> ---
> drivers/iio/buffer/industrialio-buffer-dmaengine.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/iio/buffer/industrialio-buffer-dmaengine.c b/drivers/iio/buffer/industrialio-buffer-dmaengine.c
> index ebdb838..9fabed4 100644
> --- a/drivers/iio/buffer/industrialio-buffer-dmaengine.c
> +++ b/drivers/iio/buffer/industrialio-buffer-dmaengine.c
> @@ -93,12 +93,7 @@ static void iio_dmaengine_buffer_abort(struct iio_dma_buffer_queue *queue)
> struct dmaengine_buffer *dmaengine_buffer =
> iio_buffer_to_dmaengine_buffer(&queue->buffer);
>
> - dmaengine_terminate_all(dmaengine_buffer->chan);
> - /* FIXME: There is a slight chance of a race condition here.
> - * dmaengine_terminate_all() does not guarantee that all transfer
> - * callbacks have finished running. Need to introduce a
> - * dmaengine_terminate_all_sync().
> - */
> + dmaengine_terminate_sync(dmaengine_buffer->chan);
> iio_dma_buffer_block_list_abort(queue, &dmaengine_buffer->active);
> }
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-09 21:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-08 17:51 [PATCH] iio: buffer-dmaengine: Use dmaengine_terminate_sync() Lars-Peter Clausen
2016-02-09 21:07 ` Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.