* [Buildroot] [PATCH 1/1] libuci: correct lua path
@ 2016-02-09 13:17 Neha Bairathi
2016-02-09 21:53 ` Arnout Vandecappelle
2016-02-23 22:45 ` Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Neha Bairathi @ 2016-02-09 13:17 UTC (permalink / raw)
To: buildroot
LUAPATH is used as the path for installing lua binding.
As buildroot specifies the install prefix, STAGING_DIR gets
appended to TARGET_DIR which is incorrect path for installation,
so use relative path.
Reviewed-by: Abhimanyu Vishwakarma <Abhimanyu.Vishwakarma@imgtec.com>
Reviewed-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
Signed-off-by: Neha Bairathi <Neha.Bairathi@imgtec.com>
---
package/libuci/libuci.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/libuci/libuci.mk b/package/libuci/libuci.mk
index a78048d..8c060d5 100644
--- a/package/libuci/libuci.mk
+++ b/package/libuci/libuci.mk
@@ -13,7 +13,7 @@ LIBUCI_DEPENDENCIES = libubox
ifeq ($(BR2_PACKAGE_LUA_5_1),y)
LIBUCI_DEPENDENCIES += lua
LIBUCI_CONF_OPTS += -DBUILD_LUA=ON \
- -DLUAPATH=$(STAGING_DIR)/usr/lib/lua/5.1 \
+ -DLUAPATH=/usr/lib/lua/5.1 \
-DLUA_CFLAGS=-I$(STAGING_DIR)/usr/include
else
LIBUCI_CONF_OPTS += -DBUILD_LUA=OFF
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] libuci: correct lua path
2016-02-09 13:17 [Buildroot] [PATCH 1/1] libuci: correct lua path Neha Bairathi
@ 2016-02-09 21:53 ` Arnout Vandecappelle
2016-02-23 22:45 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2016-02-09 21:53 UTC (permalink / raw)
To: buildroot
On 09-02-16 14:17, Neha Bairathi wrote:
> LUAPATH is used as the path for installing lua binding.
> As buildroot specifies the install prefix, STAGING_DIR gets
> appended to TARGET_DIR which is incorrect path for installation,
> so use relative path.
>
> Reviewed-by: Abhimanyu Vishwakarma <Abhimanyu.Vishwakarma@imgtec.com>
> Reviewed-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
> Signed-off-by: Neha Bairathi <Neha.Bairathi@imgtec.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Checked that it is only used to set the INSTALL command's DESTINATION argument,
and that means that DESTDIR will indeed be prefixed to it.
Regards,
Arnout
> ---
> package/libuci/libuci.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/libuci/libuci.mk b/package/libuci/libuci.mk
> index a78048d..8c060d5 100644
> --- a/package/libuci/libuci.mk
> +++ b/package/libuci/libuci.mk
> @@ -13,7 +13,7 @@ LIBUCI_DEPENDENCIES = libubox
> ifeq ($(BR2_PACKAGE_LUA_5_1),y)
> LIBUCI_DEPENDENCIES += lua
> LIBUCI_CONF_OPTS += -DBUILD_LUA=ON \
> - -DLUAPATH=$(STAGING_DIR)/usr/lib/lua/5.1 \
> + -DLUAPATH=/usr/lib/lua/5.1 \
> -DLUA_CFLAGS=-I$(STAGING_DIR)/usr/include
> else
> LIBUCI_CONF_OPTS += -DBUILD_LUA=OFF
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] libuci: correct lua path
2016-02-09 13:17 [Buildroot] [PATCH 1/1] libuci: correct lua path Neha Bairathi
2016-02-09 21:53 ` Arnout Vandecappelle
@ 2016-02-23 22:45 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2016-02-23 22:45 UTC (permalink / raw)
To: buildroot
Dear Neha Bairathi,
On Tue, 9 Feb 2016 18:47:37 +0530, Neha Bairathi wrote:
> LUAPATH is used as the path for installing lua binding.
> As buildroot specifies the install prefix, STAGING_DIR gets
> appended to TARGET_DIR which is incorrect path for installation,
> so use relative path.
>
> Reviewed-by: Abhimanyu Vishwakarma <Abhimanyu.Vishwakarma@imgtec.com>
> Reviewed-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
> Signed-off-by: Neha Bairathi <Neha.Bairathi@imgtec.com>
> ---
> package/libuci/libuci.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, thanks. Thanks Arnout for reviewing.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-23 22:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-09 13:17 [Buildroot] [PATCH 1/1] libuci: correct lua path Neha Bairathi
2016-02-09 21:53 ` Arnout Vandecappelle
2016-02-23 22:45 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.