[PATCH] xen-blkfront: rename indirect descriptor parameter

[PATCH] xen-blkfront: rename indirect descriptor parameter

[Jan Beulich]

"max" is rather ambiguous and carries pretty little meaning, the more
that there are also "max_queues" and "max_ring_page_order". Make this
"max_indirect_segments" instead, and at once change the type from int
to uint (to match the respective variable's type).

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
 drivers/block/xen-blkfront.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

--- 4.5-rc3/drivers/block/xen-blkfront.c
+++ 4.5-rc3-xen-blkfront-max-param/drivers/block/xen-blkfront.c
@@ -125,8 +125,10 @@ static const struct block_device_operati
  */
 
 static unsigned int xen_blkif_max_segments = 32;
-module_param_named(max, xen_blkif_max_segments, int, S_IRUGO);
-MODULE_PARM_DESC(max, "Maximum amount of segments in indirect requests (default is 32)");
+module_param_named(max_indirect_segments, xen_blkif_max_segments, uint,
+		   S_IRUGO);
+MODULE_PARM_DESC(max_indirect_segments,
+		 "Maximum amount of segments in indirect requests (default is 32)");
 
 static unsigned int xen_blkif_max_queues = 4;
 module_param_named(max_queues, xen_blkif_max_queues, uint, S_IRUGO);

Re: [PATCH] xen-blkfront: rename indirect descriptor parameter

[Roger Pau Monné]

El 10/2/16 a les 12:21, Jan Beulich ha escrit:
> "max" is rather ambiguous and carries pretty little meaning, the more
> that there are also "max_queues" and "max_ring_page_order". Make this
> "max_indirect_segments" instead, and at once change the type from int
> to uint (to match the respective variable's type).
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Re: [PATCH] xen-blkfront: rename indirect descriptor parameter

[Konrad Rzeszutek Wilk]

On Wed, Feb 10, 2016 at 01:22:40PM +0100, Roger Pau Monné wrote:
> El 10/2/16 a les 12:21, Jan Beulich ha escrit:
> > "max" is rather ambiguous and carries pretty little meaning, the more
> > that there are also "max_queues" and "max_ring_page_order". Make this
> > "max_indirect_segments" instead, and at once change the type from int
> > to uint (to match the respective variable's type).
> > 
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> Acked-by: Roger Pau Monné <roger.pau@citrix.com>
> 

applied.