From: "Madhani, Himanshu" <Himanshu.Madhani@cavium.com>
To: Bart Van Assche <bart.vanassche@sandisk.com>,
"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
"hch@infradead.org" <hch@infradead.org>,
"nab@linux-iscsi.org" <nab@linux-iscsi.org>
Cc: "Malavali, Giridhar" <Giridhar.Malavali@cavium.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 02/11] qla2xxx: Cleanup TMF code translation from qla_target.
Date: Wed, 11 Jan 2017 23:01:14 +0000 [thread overview]
Message-ID: <56BCC6A6-FEAC-4BBD-82BD-25060805ACBE@cavium.com> (raw)
In-Reply-To: <c749caca-08f2-4f47-f021-ce8cc5ec9c8f@sandisk.com>
On 1/11/17, 1:08 PM, "Bart Van Assche" <bart.vanassche@sandisk.com> wrote:
>On 12/23/2016 08:23 PM, Himanshu Madhani wrote:
>> From: Quinn Tran <quinn.tran@cavium.com>
>>
>> Move code code which converts Task Mgmt Command flags for
>> ATIO to TCM #defines, from qla2xxx driver to tcm_qla2xxx
>> driver.
>>
>> Reviewed-by: Christoph Hellwig <hch@lst.de>
>> Signed-off-by: Quinn Tran <quinn.tran@cavium.com>
>> Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com>
>> ---
>> drivers/scsi/qla2xxx/qla_target.c | 75 ++++----------------------------------
>> drivers/scsi/qla2xxx/qla_target.h | 6 ++-
>> drivers/scsi/qla2xxx/tcm_qla2xxx.c | 39 +++++++++++++++++++-
>> 3 files changed, 49 insertions(+), 71 deletions(-)
>>
>> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
>> index 47acc26..6e58848 100644
>> --- a/drivers/scsi/qla2xxx/qla_target.c
>> +++ b/drivers/scsi/qla2xxx/qla_target.c
>> @@ -1592,8 +1592,9 @@ static int __qlt_24xx_handle_abts(struct scsi_qla_host *vha,
>> mcmd->sess = sess;
>> memcpy(&mcmd->orig_iocb.abts, abts, sizeof(mcmd->orig_iocb.abts));
>> mcmd->reset_count = vha->hw->chip_reset;
>> + mcmd->tmr_func = QLA_TGT_ABTS;
>>
>> - rc = ha->tgt.tgt_ops->handle_tmr(mcmd, lun, TMR_ABORT_TASK,
>> + rc = ha->tgt.tgt_ops->handle_tmr(mcmd, 0, mcmd->tmr_func,
>> abts->exchange_addr_to_abort);
>
>Does this change remove the last user of the 'lun' variable from this
>function? If so, please remove that variable entirely.
We will need to preserve lun variable, since handle_tmr is also called from
qlt_issue_task_mgmt and qlt_handle_task_mgmt.
>
>Thanks,
>
>Bart.
next prev parent reply other threads:[~2017-01-11 23:01 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-24 4:23 [PATCH 00/11] qla2xxx: Feature updates for target Himanshu Madhani
2016-12-24 4:23 ` [PATCH 01/11] qla2xxx: Remove direct access of scsi_status field in se_cmd Himanshu Madhani
2016-12-24 4:23 ` [PATCH 02/11] qla2xxx: Cleanup TMF code translation from qla_target Himanshu Madhani
2017-01-11 20:05 ` Bart Van Assche
2017-01-11 20:43 ` Madhani, Himanshu
2017-01-11 21:08 ` Bart Van Assche
2017-01-11 23:01 ` Madhani, Himanshu [this message]
2016-12-24 4:23 ` [PATCH 03/11] qla2xxx: Make trace flags more readable Himanshu Madhani
2017-01-09 13:11 ` Christoph Hellwig
2017-01-09 18:36 ` Madhani, Himanshu
2017-01-11 20:47 ` Bart Van Assche
2017-01-11 20:54 ` Madhani, Himanshu
2016-12-24 4:23 ` [PATCH 04/11] qla2xxx: Cleanup SRR code Himanshu Madhani
2017-01-09 13:13 ` Christoph Hellwig
2017-01-10 17:55 ` Madhani, Himanshu
2016-12-24 4:23 ` [PATCH 05/11] qla2xxx: Fix wrong argument in sp done callback Himanshu Madhani
2017-01-09 13:17 ` Christoph Hellwig
2017-01-09 18:05 ` Madhani, Himanshu
2016-12-24 4:23 ` [PATCH 06/11] qla2xxx: Use d_id instead of s_id for more clarity Himanshu Madhani
2017-01-09 13:17 ` Christoph Hellwig
2016-12-24 4:23 ` [PATCH 07/11] qla2xxx: Track I-T nexus as single fc_port struct Himanshu Madhani
2017-01-09 13:28 ` Christoph Hellwig
2016-12-24 4:23 ` [PATCH 08/11] qla2xxx: Add framework for Async fabric discovery Himanshu Madhani
2017-01-11 20:08 ` Bart Van Assche
2017-01-13 17:50 ` Madhani, Himanshu
2016-12-24 4:23 ` [PATCH 09/11] qla2xxx: Add Dual mode support in the driver Himanshu Madhani
2017-01-11 19:51 ` Bart Van Assche
2017-01-13 22:13 ` Madhani, Himanshu
2016-12-24 4:23 ` [PATCH 10/11] qla2xxx: Remove unused reverse_ini_mode Himanshu Madhani
2016-12-24 4:23 ` [PATCH 11/11] qla2xxx: Improve RSCN handling in driver Himanshu Madhani
2017-01-11 21:05 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BCC6A6-FEAC-4BBD-82BD-25060805ACBE@cavium.com \
--to=himanshu.madhani@cavium.com \
--cc=Giridhar.Malavali@cavium.com \
--cc=bart.vanassche@sandisk.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.