* [PATCH] drm/exynos/decon: fix disable clocks order
@ 2016-02-11 11:25 Andrzej Hajda
2016-02-12 6:41 ` Inki Dae
0 siblings, 1 reply; 2+ messages in thread
From: Andrzej Hajda @ 2016-02-11 11:25 UTC (permalink / raw)
To: Inki Dae
Cc: Andrzej Hajda, linux-samsung-soc, Marek Szyprowski,
open list:DRM DRIVERS FOR EXYNOS, Bartlomiej Zolnierkiewicz
Decon requires that clocks should be disabled in reverse order. Otherwise
system hangs.
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
index 1bf6a21..98615e2 100644
--- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
+++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
@@ -582,9 +582,9 @@ out:
static int exynos5433_decon_suspend(struct device *dev)
{
struct decon_context *ctx = dev_get_drvdata(dev);
- int i;
+ int i = ARRAY_SIZE(decon_clks_name);
- for (i = 0; i < ARRAY_SIZE(decon_clks_name); i++)
+ while (--i >= 0)
clk_disable_unprepare(ctx->clks[i]);
return 0;
--
1.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/exynos/decon: fix disable clocks order
2016-02-11 11:25 [PATCH] drm/exynos/decon: fix disable clocks order Andrzej Hajda
@ 2016-02-12 6:41 ` Inki Dae
0 siblings, 0 replies; 2+ messages in thread
From: Inki Dae @ 2016-02-12 6:41 UTC (permalink / raw)
To: Andrzej Hajda
Cc: Bartlomiej Zolnierkiewicz, Marek Szyprowski,
open list:DRM DRIVERS FOR EXYNOS,
moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES
Picked it up.
Thanks,
Inki Dae
2016년 02월 11일 20:25에 Andrzej Hajda 이(가) 쓴 글:
> Decon requires that clocks should be disabled in reverse order. Otherwise
> system hangs.
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
> drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
> index 1bf6a21..98615e2 100644
> --- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
> +++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
> @@ -582,9 +582,9 @@ out:
> static int exynos5433_decon_suspend(struct device *dev)
> {
> struct decon_context *ctx = dev_get_drvdata(dev);
> - int i;
> + int i = ARRAY_SIZE(decon_clks_name);
>
> - for (i = 0; i < ARRAY_SIZE(decon_clks_name); i++)
> + while (--i >= 0)
> clk_disable_unprepare(ctx->clks[i]);
>
> return 0;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-12 6:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-11 11:25 [PATCH] drm/exynos/decon: fix disable clocks order Andrzej Hajda
2016-02-12 6:41 ` Inki Dae
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.