From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Simon Horman <horms@verge.net.au>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: linux-renesas-soc@vger.kernel.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
devicetree@vger.kernel.org, magnus.damm@gmail.com,
linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 5/5] ARM: dts: r8a7794: add sound support
Date: Fri, 12 Feb 2016 19:47:45 +0300 [thread overview]
Message-ID: <56BE0CB1.4070408@cogentembedded.com> (raw)
In-Reply-To: <20160210171455.GB17671@verge.net.au>
On 02/10/2016 08:14 PM, Simon Horman wrote:
>> Sorry for my un-ordered response
>>
>>> Define the generic R8A7794 part of the sound device node.
>>> This sound device is a complex one and comprises the Audio Clock Generator
>>> (ADG), Sampling Rate Converter Unit (SCU), Serial Sound Interface [Unit]
>>> (SSI[U]), and Audio DMAC-Peripheral-Peripheral.
>>> It is up to the board file to enable the device.
>>>
>>> This patch is based on the R8A7791 sound work by Kuninori Morimoto.
>>>
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> (snip)
>>> + rcar_sound,src {
>>> + src1: src@1 {
>>> + interrupts = <GIC_SPI 353 IRQ_TYPE_LEVEL_HIGH>;
>>> + dmas = <&audma0 0x87>, <&audma0 0x9c>;
>>> + dma-names = "rx", "tx";
>>> + };
>>> + src2: src@2 {
>>> + interrupts = <GIC_SPI 354 IRQ_TYPE_LEVEL_HIGH>;
>>> + dmas = <&audma0 0x89>, <&audma0 0x9e>;
>>> + dma-names = "rx", "tx";
>>> + };
>>> + src3: src@3 {
>>> + interrupts = <GIC_SPI 355 IRQ_TYPE_LEVEL_HIGH>;
>>> + dmas = <&audma0 0x8b>, <&audma0 0xa0>;
>>> + dma-names = "rx", "tx";
>>> + };
>>> + src4: src@4 {
>>> + interrupts = <GIC_SPI 356 IRQ_TYPE_LEVEL_HIGH>;
>>> + dmas = <&audma0 0x8d>, <&audma0 0xb0>;
>>> + dma-names = "rx", "tx";
>>> + };
>>> + src5: src@5 {
>>> + interrupts = <GIC_SPI 357 IRQ_TYPE_LEVEL_HIGH>;
>>> + dmas = <&audma0 0x8f>, <&audma0 0xb2>;
>>> + dma-names = "rx", "tx";
>>> + };
>>> + src6: src@6 {
>>> + interrupts = <GIC_SPI 358 IRQ_TYPE_LEVEL_HIGH>;
>>> + dmas = <&audma0 0x91>, <&audma0 0xb4>;
>>> + dma-names = "rx", "tx";
>>> + };
>>> + };
>>
>> I think this can't work correctly, because driver is assuming
>> DT has all channles (from 0). (see linux/sound/soc/sh/rcar/src.c :: rsnd_src_probe)
>> Can you adds dummy src0 with some comments ? or fix src.c driver ?
>
> I would prefer the driver to be fixed (I had a similar patchset locally
> and I found it doesn't work).
You mean you had R8A7794 sound patch set too?
> The reason is that DT should describe
> the hardware rather than the current state of the software.
Yes, of course. Just tell me do I have to fix the driver *before* this
patch set is accepted?
MBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/5] ARM: dts: r8a7794: add sound support
Date: Fri, 12 Feb 2016 19:47:45 +0300 [thread overview]
Message-ID: <56BE0CB1.4070408@cogentembedded.com> (raw)
In-Reply-To: <20160210171455.GB17671@verge.net.au>
On 02/10/2016 08:14 PM, Simon Horman wrote:
>> Sorry for my un-ordered response
>>
>>> Define the generic R8A7794 part of the sound device node.
>>> This sound device is a complex one and comprises the Audio Clock Generator
>>> (ADG), Sampling Rate Converter Unit (SCU), Serial Sound Interface [Unit]
>>> (SSI[U]), and Audio DMAC-Peripheral-Peripheral.
>>> It is up to the board file to enable the device.
>>>
>>> This patch is based on the R8A7791 sound work by Kuninori Morimoto.
>>>
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> (snip)
>>> + rcar_sound,src {
>>> + src1: src at 1 {
>>> + interrupts = <GIC_SPI 353 IRQ_TYPE_LEVEL_HIGH>;
>>> + dmas = <&audma0 0x87>, <&audma0 0x9c>;
>>> + dma-names = "rx", "tx";
>>> + };
>>> + src2: src at 2 {
>>> + interrupts = <GIC_SPI 354 IRQ_TYPE_LEVEL_HIGH>;
>>> + dmas = <&audma0 0x89>, <&audma0 0x9e>;
>>> + dma-names = "rx", "tx";
>>> + };
>>> + src3: src at 3 {
>>> + interrupts = <GIC_SPI 355 IRQ_TYPE_LEVEL_HIGH>;
>>> + dmas = <&audma0 0x8b>, <&audma0 0xa0>;
>>> + dma-names = "rx", "tx";
>>> + };
>>> + src4: src at 4 {
>>> + interrupts = <GIC_SPI 356 IRQ_TYPE_LEVEL_HIGH>;
>>> + dmas = <&audma0 0x8d>, <&audma0 0xb0>;
>>> + dma-names = "rx", "tx";
>>> + };
>>> + src5: src at 5 {
>>> + interrupts = <GIC_SPI 357 IRQ_TYPE_LEVEL_HIGH>;
>>> + dmas = <&audma0 0x8f>, <&audma0 0xb2>;
>>> + dma-names = "rx", "tx";
>>> + };
>>> + src6: src at 6 {
>>> + interrupts = <GIC_SPI 358 IRQ_TYPE_LEVEL_HIGH>;
>>> + dmas = <&audma0 0x91>, <&audma0 0xb4>;
>>> + dma-names = "rx", "tx";
>>> + };
>>> + };
>>
>> I think this can't work correctly, because driver is assuming
>> DT has all channles (from 0). (see linux/sound/soc/sh/rcar/src.c :: rsnd_src_probe)
>> Can you adds dummy src0 with some comments ? or fix src.c driver ?
>
> I would prefer the driver to be fixed (I had a similar patchset locally
> and I found it doesn't work).
You mean you had R8A7794 sound patch set too?
> The reason is that DT should describe
> the hardware rather than the current state of the software.
Yes, of course. Just tell me do I have to fix the driver *before* this
patch set is accepted?
MBR, Sergei
next prev parent reply other threads:[~2016-02-12 16:47 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 21:52 [PATCH v2 0/5] Add R8A7794 sound DT support Sergei Shtylyov
2016-02-09 21:52 ` Sergei Shtylyov
2016-02-09 21:53 ` [PATCH v2 1/5] ARM: dts: r8a7794: add audio clocks Sergei Shtylyov
2016-02-09 21:53 ` Sergei Shtylyov
2016-02-09 21:54 ` [PATCH v2 2/5] ARM: dts: r8a7794: add MSTP5 clocks Sergei Shtylyov
2016-02-09 21:54 ` Sergei Shtylyov
2016-02-09 21:55 ` [PATCH v2 3/5] ARM: dts: r8a7794: add MSTP10 clocks Sergei Shtylyov
2016-02-09 21:55 ` Sergei Shtylyov
2016-02-09 21:56 ` [PATCH v2 4/5] ARM: dts: r8a7794: add Audio-DMAC support Sergei Shtylyov
2016-02-09 21:56 ` Sergei Shtylyov
2016-02-09 21:58 ` [PATCH v2 5/5] ARM: dts: r8a7794: add sound support Sergei Shtylyov
2016-02-09 21:58 ` Sergei Shtylyov
2016-02-10 0:41 ` Kuninori Morimoto
2016-02-10 0:41 ` Kuninori Morimoto
2016-02-10 0:41 ` Kuninori Morimoto
2016-02-10 17:14 ` Simon Horman
2016-02-10 17:14 ` Simon Horman
2016-02-12 16:47 ` Sergei Shtylyov [this message]
2016-02-12 16:47 ` Sergei Shtylyov
2016-02-12 18:43 ` Simon Horman
2016-02-12 18:43 ` Simon Horman
2016-02-12 19:08 ` Sergei Shtylyov
2016-02-12 19:08 ` Sergei Shtylyov
2016-02-12 19:33 ` Simon Horman
2016-02-12 19:33 ` Simon Horman
2016-02-12 19:57 ` Sergei Shtylyov
2016-02-12 19:57 ` Sergei Shtylyov
2016-02-17 5:38 ` Simon Horman
2016-02-17 5:38 ` Simon Horman
2016-02-17 19:07 ` Sergei Shtylyov
2016-02-17 19:07 ` Sergei Shtylyov
2016-02-17 23:48 ` Simon Horman
2016-02-17 23:48 ` Simon Horman
2016-02-18 19:31 ` Sergei Shtylyov
2016-02-18 19:31 ` Sergei Shtylyov
2016-02-10 18:09 ` Sergei Shtylyov
2016-02-10 18:09 ` Sergei Shtylyov
2016-02-10 3:12 ` Kuninori Morimoto
2016-02-10 3:12 ` Kuninori Morimoto
2016-02-10 3:12 ` Kuninori Morimoto
2016-02-10 18:10 ` Sergei Shtylyov
2016-02-10 18:10 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BE0CB1.4070408@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=horms@verge.net.au \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.