From: Thomas Huth <thuth@redhat.com>
To: Andrew Jones <drjones@redhat.com>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org
Cc: dgibson@redhat.com, david@gibson.dropbear.id.au, agraf@suse.de,
lvivier@redhat.com, pbonzini@redhat.com
Subject: Re: [kvm-unit-tests PATCH v2 08/14] powerpc/ppc64: add HV putchar
Date: Fri, 12 Feb 2016 18:08:23 +0100 [thread overview]
Message-ID: <56BE1187.8050502@redhat.com> (raw)
In-Reply-To: <1454957594-30601-9-git-send-email-drjones@redhat.com>
On 08.02.2016 19:53, Andrew Jones wrote:
> Add the hvcall for putchar and use it in puts. That, along with a
> couple more lines in start to prepare for C code, and a branch to
> main(), gets us "hello world". Run with
>
> qemu-system-ppc64 -M pseries \
> -bios powerpc/boot_rom.bin \
> -display none -serial stdio \
> -kernel powerpc/selftest.elf
>
> (We're still not relocating yet, that comes in a later patch. Thus,
> testing hello-world at this point requires a hacked QEMU and linking
> the unit test at QEMU's kernel load address.)
Is that comment still valid? I thought that's what the boot_rom.bin was
good for?
Apart from that, this patch looks fine to me.
Thomas
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Huth <thuth@redhat.com>
To: Andrew Jones <drjones@redhat.com>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org
Cc: dgibson@redhat.com, david@gibson.dropbear.id.au, agraf@suse.de,
lvivier@redhat.com, pbonzini@redhat.com
Subject: Re: [kvm-unit-tests PATCH v2 08/14] powerpc/ppc64: add HV putchar
Date: Fri, 12 Feb 2016 17:08:23 +0000 [thread overview]
Message-ID: <56BE1187.8050502@redhat.com> (raw)
In-Reply-To: <1454957594-30601-9-git-send-email-drjones@redhat.com>
On 08.02.2016 19:53, Andrew Jones wrote:
> Add the hvcall for putchar and use it in puts. That, along with a
> couple more lines in start to prepare for C code, and a branch to
> main(), gets us "hello world". Run with
>
> qemu-system-ppc64 -M pseries \
> -bios powerpc/boot_rom.bin \
> -display none -serial stdio \
> -kernel powerpc/selftest.elf
>
> (We're still not relocating yet, that comes in a later patch. Thus,
> testing hello-world at this point requires a hacked QEMU and linking
> the unit test at QEMU's kernel load address.)
Is that comment still valid? I thought that's what the boot_rom.bin was
good for?
Apart from that, this patch looks fine to me.
Thomas
next prev parent reply other threads:[~2016-02-12 17:08 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 18:53 [kvm-unit-tests PATCH v2 00/14] ppc64: initial drop Andrew Jones
2016-02-08 18:53 ` Andrew Jones
2016-02-08 18:53 ` [kvm-unit-tests PATCH v2 01/14] lib: asm-generic: add missing casts Andrew Jones
2016-02-08 18:53 ` Andrew Jones
2016-02-12 12:05 ` Thomas Huth
2016-02-12 12:05 ` Thomas Huth
2016-02-12 13:58 ` Andrew Jones
2016-02-12 13:58 ` Andrew Jones
2016-02-08 18:53 ` [kvm-unit-tests PATCH v2 02/14] lib: share arm-selftest utility functions Andrew Jones
2016-02-08 18:53 ` Andrew Jones
2016-02-12 12:40 ` Thomas Huth
2016-02-12 12:40 ` Thomas Huth
2016-02-08 18:53 ` [kvm-unit-tests PATCH v2 03/14] config: no need to mix arch makefiles Andrew Jones
2016-02-08 18:53 ` Andrew Jones
2016-02-08 18:53 ` [kvm-unit-tests PATCH v2 04/14] powerpc/ppc64: start skeleton framework Andrew Jones
2016-02-08 18:53 ` Andrew Jones
2016-02-08 18:53 ` [kvm-unit-tests PATCH v2 05/14] powerpc/pp64: ppc-ify makefiles and linker script Andrew Jones
2016-02-08 18:53 ` Andrew Jones
2016-02-09 17:54 ` [kvm-unit-tests PATCH] align toc to 256 bytes Andrew Jones
2016-02-09 17:54 ` Andrew Jones
2016-02-08 18:53 ` [kvm-unit-tests PATCH v2 06/14] powerpc/ppc64: add boot rom source Andrew Jones
2016-02-08 18:53 ` Andrew Jones
2016-02-12 6:27 ` Thomas Huth
2016-02-12 6:27 ` Thomas Huth
2016-02-12 10:07 ` Andrew Jones
2016-02-12 10:07 ` Andrew Jones
2016-02-08 18:53 ` [kvm-unit-tests PATCH v2 07/14] powerpc/ppc64: add bootloader to bounce into memory Andrew Jones
2016-02-08 18:53 ` Andrew Jones
2016-02-08 18:53 ` [kvm-unit-tests PATCH v2 08/14] powerpc/ppc64: add HV putchar Andrew Jones
2016-02-08 18:53 ` Andrew Jones
2016-02-12 17:08 ` Thomas Huth [this message]
2016-02-12 17:08 ` Thomas Huth
2016-02-12 17:45 ` Thomas Huth
2016-02-12 17:45 ` Thomas Huth
2016-02-08 18:53 ` [kvm-unit-tests PATCH v2 09/14] powerpc/ppc64: adapt arm's setup Andrew Jones
2016-02-08 18:53 ` Andrew Jones
2016-02-12 11:50 ` Thomas Huth
2016-02-12 11:50 ` Thomas Huth
2016-02-12 13:59 ` Andrew Jones
2016-02-12 13:59 ` Andrew Jones
2016-02-08 18:53 ` [kvm-unit-tests PATCH v2 10/14] powerpc/ppc64: relocate linker VMAs Andrew Jones
2016-02-08 18:53 ` Andrew Jones
2016-02-08 18:53 ` [kvm-unit-tests PATCH v2 11/14] powerpc/ppc64: add run script and unittests.cfg Andrew Jones
2016-02-08 18:53 ` Andrew Jones
2016-02-08 18:53 ` [kvm-unit-tests PATCH v2 12/14] mkstandalone: add support for powerpc Andrew Jones
2016-02-08 18:53 ` Andrew Jones
2016-02-08 18:53 ` [kvm-unit-tests PATCH v2 13/14] powerpc/ppc64: add RTAS support Andrew Jones
2016-02-08 18:53 ` Andrew Jones
2016-02-12 17:51 ` Thomas Huth
2016-02-12 17:51 ` Thomas Huth
2016-02-08 18:53 ` [kvm-unit-tests PATCH v2 14/14] powerpc/ppc64: HACK: make a fake debug-exit Andrew Jones
2016-02-08 18:53 ` Andrew Jones
2016-02-12 18:07 ` Thomas Huth
2016-02-12 18:07 ` Thomas Huth
2016-02-12 22:50 ` Paolo Bonzini
2016-02-12 22:50 ` Paolo Bonzini
2016-02-09 17:49 ` [kvm-unit-tests PATCH v2 00/14] ppc64: initial drop Andrew Jones
2016-02-09 17:49 ` Andrew Jones
2016-02-10 14:27 ` Paolo Bonzini
2016-02-10 14:27 ` Paolo Bonzini
2016-02-11 11:56 ` Andrew Jones
2016-02-11 11:56 ` Andrew Jones
2016-02-11 12:36 ` Paolo Bonzini
2016-02-11 12:36 ` Paolo Bonzini
2016-02-11 13:36 ` Laurent Vivier
2016-02-11 13:36 ` Laurent Vivier
2016-02-11 15:29 ` Andrew Jones
2016-02-11 15:29 ` Andrew Jones
2016-02-11 16:44 ` Laurent Vivier
2016-02-11 16:44 ` Laurent Vivier
2016-02-11 17:22 ` Andrew Jones
2016-02-11 17:22 ` Andrew Jones
2016-02-11 17:47 ` Laurent Vivier
2016-02-11 17:47 ` Laurent Vivier
2016-02-12 10:06 ` Andrew Jones
2016-02-12 10:06 ` Andrew Jones
2016-02-12 10:31 ` Laurent Vivier
2016-02-12 10:31 ` Laurent Vivier
2016-02-12 10:57 ` Andrew Jones
2016-02-12 10:57 ` Andrew Jones
2016-02-12 13:44 ` Andrew Jones
2016-02-12 13:44 ` Andrew Jones
2016-02-14 22:43 ` David Gibson
2016-02-14 22:43 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BE1187.8050502@redhat.com \
--to=thuth@redhat.com \
--cc=agraf@suse.de \
--cc=david@gibson.dropbear.id.au \
--cc=dgibson@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.