[PATCH v2] rtc: s3c: Document in binding that only s3c6410 needs a src clk

[PATCH v2] rtc: s3c: Document in binding that only s3c6410 needs a src clk

[Javier Martinez Canillas]

The S3C binding doc says that the RTC and RTC source clocks are required
but the S3C driver supports different HW IP and only the s3c6410 needs a
source clock.

Fix the binding explaining that the source clock is only needed for the
s3c6410-rtc compatible controller.

Reported-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

---
Hello,

This patch depends on a previous one that was picked by Rob Herring so
this one has to go through his tree again and not through the RTC tree
to avoid conflicts.

Best regards,
Javier

Changes in v2:
- Remove the mention to a commit sha-1 that's not in mainline (Alexandre).
- Fix typo in commit message (Alexandre).
- Add Alexandre's Acked-by tag.

 Documentation/devicetree/bindings/rtc/s3c-rtc.txt | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.txt b/Documentation/devicetree/bindings/rtc/s3c-rtc.txt
index 1068ffce9f91..fdde63a5419c 100644
--- a/Documentation/devicetree/bindings/rtc/s3c-rtc.txt
+++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.txt
@@ -15,9 +15,10 @@ Required properties:
   is the rtc tick interrupt. The number of cells representing a interrupt
   depends on the parent interrupt controller.
 - clocks: Must contain a list of phandle and clock specifier for the rtc
-          and source clocks.
-- clock-names: Must contain "rtc" and "rtc_src" entries sorted in the
-               same order as the clocks property.
+          clock and in the case of a s3c6410 compatible controller, also
+          a source clock.
+- clock-names: Must contain "rtc" and for a s3c6410 compatible controller,
+               a "rtc_src" sorted in the same order as the clocks property.
 
 Example:
 
-- 
2.5.0

[rtc-linux] [PATCH v2] rtc: s3c: Document in binding that only s3c6410 needs a src clk

[Javier Martinez Canillas]

The S3C binding doc says that the RTC and RTC source clocks are required
but the S3C driver supports different HW IP and only the s3c6410 needs a
source clock.

Fix the binding explaining that the source clock is only needed for the
s3c6410-rtc compatible controller.

Reported-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

---
Hello,

This patch depends on a previous one that was picked by Rob Herring so
this one has to go through his tree again and not through the RTC tree
to avoid conflicts.

Best regards,
Javier

Changes in v2:
- Remove the mention to a commit sha-1 that's not in mainline (Alexandre).
- Fix typo in commit message (Alexandre).
- Add Alexandre's Acked-by tag.

 Documentation/devicetree/bindings/rtc/s3c-rtc.txt | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.txt b/Documentation/devicetree/bindings/rtc/s3c-rtc.txt
index 1068ffce9f91..fdde63a5419c 100644
--- a/Documentation/devicetree/bindings/rtc/s3c-rtc.txt
+++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.txt
@@ -15,9 +15,10 @@ Required properties:
   is the rtc tick interrupt. The number of cells representing a interrupt
   depends on the parent interrupt controller.
 - clocks: Must contain a list of phandle and clock specifier for the rtc
-          and source clocks.
-- clock-names: Must contain "rtc" and "rtc_src" entries sorted in the
-               same order as the clocks property.
+          clock and in the case of a s3c6410 compatible controller, also
+          a source clock.
+- clock-names: Must contain "rtc" and for a s3c6410 compatible controller,
+               a "rtc_src" sorted in the same order as the clocks property.
 
 Example:
 
-- 
2.5.0

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [PATCH v2] rtc: s3c: Document in binding that only s3c6410 needs a src clk

[Krzysztof Kozlowski]

On 15.02.2016 23:11, Javier Martinez Canillas wrote:
> The S3C binding doc says that the RTC and RTC source clocks are required
> but the S3C driver supports different HW IP and only the s3c6410 needs a
> source clock.
> 
> Fix the binding explaining that the source clock is only needed for the
> s3c6410-rtc compatible controller.
> 
> Reported-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> 
> ---
> Hello,
> 
> This patch depends on a previous one that was picked by Rob Herring so
> this one has to go through his tree again and not through the RTC tree
> to avoid conflicts.
> 
> Best regards,
> Javier
> 
> Changes in v2:
> - Remove the mention to a commit sha-1 that's not in mainline (Alexandre).
> - Fix typo in commit message (Alexandre).
> - Add Alexandre's Acked-by tag.
> 
>  Documentation/devicetree/bindings/rtc/s3c-rtc.txt | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

[rtc-linux] Re: [PATCH v2] rtc: s3c: Document in binding that only s3c6410 needs a src clk

[Krzysztof Kozlowski]

On 15.02.2016 23:11, Javier Martinez Canillas wrote:
> The S3C binding doc says that the RTC and RTC source clocks are required
> but the S3C driver supports different HW IP and only the s3c6410 needs a
> source clock.
> 
> Fix the binding explaining that the source clock is only needed for the
> s3c6410-rtc compatible controller.
> 
> Reported-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> 
> ---
> Hello,
> 
> This patch depends on a previous one that was picked by Rob Herring so
> this one has to go through his tree again and not through the RTC tree
> to avoid conflicts.
> 
> Best regards,
> Javier
> 
> Changes in v2:
> - Remove the mention to a commit sha-1 that's not in mainline (Alexandre).
> - Fix typo in commit message (Alexandre).
> - Add Alexandre's Acked-by tag.
> 
>  Documentation/devicetree/bindings/rtc/s3c-rtc.txt | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [PATCH v2] rtc: s3c: Document in binding that only s3c6410 needs a src clk

[Rob Herring]

On Mon, Feb 15, 2016 at 11:11:06AM -0300, Javier Martinez Canillas wrote:
> The S3C binding doc says that the RTC and RTC source clocks are required
> but the S3C driver supports different HW IP and only the s3c6410 needs a
> source clock.
> 
> Fix the binding explaining that the source clock is only needed for the
> s3c6410-rtc compatible controller.
> 
> Reported-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> 
> ---
> Hello,
> 
> This patch depends on a previous one that was picked by Rob Herring so
> this one has to go through his tree again and not through the RTC tree
> to avoid conflicts.

Ugg, sent pull request today. It should be in Linus' tree now.

This can go thru rtc tree if you prefer. Otherwise, I'll queue it up for 
4.6.

> 

[rtc-linux] Re: [PATCH v2] rtc: s3c: Document in binding that only s3c6410 needs a src clk

[Rob Herring]

On Mon, Feb 15, 2016 at 11:11:06AM -0300, Javier Martinez Canillas wrote:
> The S3C binding doc says that the RTC and RTC source clocks are required
> but the S3C driver supports different HW IP and only the s3c6410 needs a
> source clock.
> 
> Fix the binding explaining that the source clock is only needed for the
> s3c6410-rtc compatible controller.
> 
> Reported-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> 
> ---
> Hello,
> 
> This patch depends on a previous one that was picked by Rob Herring so
> this one has to go through his tree again and not through the RTC tree
> to avoid conflicts.

Ugg, sent pull request today. It should be in Linus' tree now.

This can go thru rtc tree if you prefer. Otherwise, I'll queue it up for 
4.6.

> 

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [PATCH v2] rtc: s3c: Document in binding that only s3c6410 needs a src clk

[Alexandre Belloni]

Hi Rob,

On 18/02/2016 at 08:38:53 -0600, Rob Herring wrote :
> On Mon, Feb 15, 2016 at 11:11:06AM -0300, Javier Martinez Canillas wrote:
> > The S3C binding doc says that the RTC and RTC source clocks are required
> > but the S3C driver supports different HW IP and only the s3c6410 needs a
> > source clock.
> > 
> > Fix the binding explaining that the source clock is only needed for the
> > s3c6410-rtc compatible controller.
> > 
> > Reported-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> > Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > 
> > ---
> > Hello,
> > 
> > This patch depends on a previous one that was picked by Rob Herring so
> > this one has to go through his tree again and not through the RTC tree
> > to avoid conflicts.
> 
> Ugg, sent pull request today. It should be in Linus' tree now.
> 
> This can go thru rtc tree if you prefer. Otherwise, I'll queue it up for 
> 4.6.
> 

Do you plan to send that one to Linus for 4.6? Else, I still have a few
patches to send before the end of the merge window.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[rtc-linux] Re: [PATCH v2] rtc: s3c: Document in binding that only s3c6410 needs a src clk

[Alexandre Belloni]

Hi Rob,

On 18/02/2016 at 08:38:53 -0600, Rob Herring wrote :
> On Mon, Feb 15, 2016 at 11:11:06AM -0300, Javier Martinez Canillas wrote:
> > The S3C binding doc says that the RTC and RTC source clocks are required
> > but the S3C driver supports different HW IP and only the s3c6410 needs a
> > source clock.
> > 
> > Fix the binding explaining that the source clock is only needed for the
> > s3c6410-rtc compatible controller.
> > 
> > Reported-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> > Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > 
> > ---
> > Hello,
> > 
> > This patch depends on a previous one that was picked by Rob Herring so
> > this one has to go through his tree again and not through the RTC tree
> > to avoid conflicts.
> 
> Ugg, sent pull request today. It should be in Linus' tree now.
> 
> This can go thru rtc tree if you prefer. Otherwise, I'll queue it up for 
> 4.6.
> 

Do you plan to send that one to Linus for 4.6? Else, I still have a few
patches to send before the end of the merge window.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [rtc-linux] [PATCH v2] rtc: s3c: Document in binding that only s3c6410 needs a src clk

[Alexandre Belloni]

On 15/02/2016 at 11:11:06 -0300, Javier Martinez Canillas wrote :
> The S3C binding doc says that the RTC and RTC source clocks are required
> but the S3C driver supports different HW IP and only the s3c6410 needs a
> source clock.
> 
> Fix the binding explaining that the source clock is only needed for the
> s3c6410-rtc compatible controller.
> 
> Reported-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> 
> ---
> Hello,
> 
> This patch depends on a previous one that was picked by Rob Herring so
> this one has to go through his tree again and not through the RTC tree
> to avoid conflicts.
> 

Well, I'm queuing that one in rtc-fixes for 4.6


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: [rtc-linux] [PATCH v2] rtc: s3c: Document in binding that only s3c6410 needs a src clk

[Javier Martinez Canillas]

Hello Alexandre,

On 03/28/2016 06:19 PM, Alexandre Belloni wrote:
> On 15/02/2016 at 11:11:06 -0300, Javier Martinez Canillas wrote :
>> The S3C binding doc says that the RTC and RTC source clocks are required
>> but the S3C driver supports different HW IP and only the s3c6410 needs a
>> source clock.
>>
>> Fix the binding explaining that the source clock is only needed for the
>> s3c6410-rtc compatible controller.
>>
>> Reported-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>>
>> ---
>> Hello,
>>
>> This patch depends on a previous one that was picked by Rob Herring so
>> this one has to go through his tree again and not through the RTC tree
>> to avoid conflicts.
>>
> 
> Well, I'm queuing that one in rtc-fixes for 4.6
> 

Are you still planning to push this fix for v4.6? I don't see the patch in
neither v4.6-rc4 nor linux-next.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Re: [rtc-linux] [PATCH v2] rtc: s3c: Document in binding that only s3c6410 needs a src clk

[Javier Martinez Canillas]

Hello Alexandre,

On 03/28/2016 06:19 PM, Alexandre Belloni wrote:
> On 15/02/2016 at 11:11:06 -0300, Javier Martinez Canillas wrote :
>> The S3C binding doc says that the RTC and RTC source clocks are required
>> but the S3C driver supports different HW IP and only the s3c6410 needs a
>> source clock.
>>
>> Fix the binding explaining that the source clock is only needed for the
>> s3c6410-rtc compatible controller.
>>
>> Reported-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>>
>> ---
>> Hello,
>>
>> This patch depends on a previous one that was picked by Rob Herring so
>> this one has to go through his tree again and not through the RTC tree
>> to avoid conflicts.
>>
> 
> Well, I'm queuing that one in rtc-fixes for 4.6
> 

Are you still planning to push this fix for v4.6? I don't see the patch in
neither v4.6-rc4 nor linux-next.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [rtc-linux] [PATCH v2] rtc: s3c: Document in binding that only s3c6410 needs a src clk

[Alexandre Belloni]

On 21/04/2016 at 08:46:33 -0400, Javier Martinez Canillas wrote :
> Hello Alexandre,
> 
> On 03/28/2016 06:19 PM, Alexandre Belloni wrote:
> > On 15/02/2016 at 11:11:06 -0300, Javier Martinez Canillas wrote :
> >> The S3C binding doc says that the RTC and RTC source clocks are required
> >> but the S3C driver supports different HW IP and only the s3c6410 needs a
> >> source clock.
> >>
> >> Fix the binding explaining that the source clock is only needed for the
> >> s3c6410-rtc compatible controller.
> >>
> >> Reported-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> >> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> >> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> >>
> >> ---
> >> Hello,
> >>
> >> This patch depends on a previous one that was picked by Rob Herring so
> >> this one has to go through his tree again and not through the RTC tree
> >> to avoid conflicts.
> >>
> > 
> > Well, I'm queuing that one in rtc-fixes for 4.6
> > 
> 
> Are you still planning to push this fix for v4.6? I don't see the patch in
> neither v4.6-rc4 nor linux-next.
> 

Well, I was expecting to get more fixes but didn't so I still didn't
send the PR to Linus. I'll do that this week.

thanks for the reminder!

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: [rtc-linux] [PATCH v2] rtc: s3c: Document in binding that only s3c6410 needs a src clk

[Alexandre Belloni]

On 21/04/2016 at 08:46:33 -0400, Javier Martinez Canillas wrote :
> Hello Alexandre,
> 
> On 03/28/2016 06:19 PM, Alexandre Belloni wrote:
> > On 15/02/2016 at 11:11:06 -0300, Javier Martinez Canillas wrote :
> >> The S3C binding doc says that the RTC and RTC source clocks are required
> >> but the S3C driver supports different HW IP and only the s3c6410 needs a
> >> source clock.
> >>
> >> Fix the binding explaining that the source clock is only needed for the
> >> s3c6410-rtc compatible controller.
> >>
> >> Reported-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> >> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> >> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> >>
> >> ---
> >> Hello,
> >>
> >> This patch depends on a previous one that was picked by Rob Herring so
> >> this one has to go through his tree again and not through the RTC tree
> >> to avoid conflicts.
> >>
> > 
> > Well, I'm queuing that one in rtc-fixes for 4.6
> > 
> 
> Are you still planning to push this fix for v4.6? I don't see the patch in
> neither v4.6-rc4 nor linux-next.
> 

Well, I was expecting to get more fixes but didn't so I still didn't
send the PR to Linus. I'll do that this week.

thanks for the reminder!

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.