From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 10/30] dm: blk: Rename get_device() to blk_get_device_str()
Date: Tue, 16 Feb 2016 16:14:15 -0700 [thread overview]
Message-ID: <56C3AD47.2090907@wwwdotorg.org> (raw)
In-Reply-To: <1455502619-16093-11-git-send-email-sjg@chromium.org>
On 02/14/2016 07:16 PM, Simon Glass wrote:
> The current name is too generic. The function returns a block device based
> on a provided string. Rename it to aid searching and make its purpose
> clearer. Also add a few comments.
> +int blk_get_device_str(const char *ifname, const char *dev_str,
> + struct blk_desc **dev_desc);
Bikeshed: s/_str/_by_str/? Otherwise it somewhat sounds like it returns
a "device_str" rather than returns a "device" and searches for it using
a "str".
Of course, this is a really annoying comment that would cause a large
amount of work, so feel free to ignore it.
next prev parent reply other threads:[~2016-02-16 23:14 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 2:16 [U-Boot] [PATCH 00/30] dm: Add driver-model support for block drivers Simon Glass
2016-02-15 2:16 ` [U-Boot] [PATCH 01/30] dm: Drop the block_dev_desc_t typedef Simon Glass
2016-02-16 10:09 ` Bin Meng
2016-02-15 2:16 ` [U-Boot] [PATCH 02/30] dm: pci: Break out the common region display code Simon Glass
2016-02-16 10:09 ` Bin Meng
2016-02-29 4:18 ` Simon Glass
2016-02-17 0:19 ` Stephen Warren
2016-02-15 2:16 ` [U-Boot] [PATCH 03/30] dm: part: Correct a sandbox build warning Simon Glass
2016-02-16 10:09 ` Bin Meng
2016-02-29 4:18 ` Simon Glass
2016-02-15 2:16 ` [U-Boot] [PATCH 04/30] dm: fdtdec: " Simon Glass
2016-02-15 2:16 ` [U-Boot] [PATCH 05/30] dm: part: Drop the common.h header Simon Glass
2016-02-16 10:09 ` Bin Meng
2016-02-15 2:16 ` [U-Boot] [PATCH 06/30] dm: Add a new header for block devices Simon Glass
2016-02-16 10:10 ` Bin Meng
2016-02-15 2:16 ` [U-Boot] [PATCH 07/30] dm: blk: Convert interface type to an enum Simon Glass
2016-02-16 10:10 ` Bin Meng
2016-02-15 2:16 ` [U-Boot] [PATCH 08/30] dm: blk: Add comments to a few functions Simon Glass
2016-02-16 10:10 ` Bin Meng
2016-02-15 2:16 ` [U-Boot] [PATCH 09/30] dm: blk: Rename get_dev() to blk_get_dev() Simon Glass
2016-02-16 10:10 ` Bin Meng
2016-02-15 2:16 ` [U-Boot] [PATCH 10/30] dm: blk: Rename get_device() to blk_get_device_str() Simon Glass
2016-02-16 14:02 ` Bin Meng
2016-02-16 23:14 ` Stephen Warren [this message]
2016-02-15 2:16 ` [U-Boot] [PATCH 11/30] dm: blk: Rename get_device_and_partition() Simon Glass
2016-02-16 14:02 ` Bin Meng
2016-02-15 2:16 ` [U-Boot] [PATCH 12/30] dm: part: Add a cast to avoid a compiler warning Simon Glass
2016-02-16 14:02 ` Bin Meng
2016-02-15 2:16 ` [U-Boot] [PATCH 13/30] dm: sandbox: Enable all partition types Simon Glass
2016-02-15 22:37 ` Tom Rini
2016-02-16 14:02 ` Bin Meng
2016-02-15 2:16 ` [U-Boot] [PATCH 14/30] dm: part: Convert partition API use to linker lists Simon Glass
2016-02-15 22:37 ` Tom Rini
2016-02-16 14:25 ` Bin Meng
2016-02-29 4:18 ` Simon Glass
2016-02-17 6:41 ` Stephen Warren
2016-02-29 4:48 ` Simon Glass
2016-02-15 2:16 ` [U-Boot] [PATCH 15/30] dm: part: Rename some partition functions Simon Glass
2016-02-16 14:25 ` Bin Meng
2016-02-29 4:19 ` Simon Glass
2016-02-15 2:16 ` [U-Boot] [PATCH 16/30] dm: cbfs: Fix handling of invalid type Simon Glass
2016-02-16 14:51 ` Bin Meng
2016-02-29 4:19 ` Simon Glass
2016-02-15 2:16 ` [U-Boot] [PATCH 17/30] dm: sandbox: Enable cbfs and cramfs Simon Glass
2016-02-16 14:51 ` Bin Meng
2016-02-15 2:16 ` [U-Boot] [PATCH 18/30] dm: block: Rename device number member dev to devnum Simon Glass
2016-02-16 14:51 ` Bin Meng
2016-02-16 23:23 ` Stephen Warren
2016-02-29 4:19 ` Simon Glass
2016-02-15 2:16 ` [U-Boot] [PATCH 19/30] dm: block: Adjust device calls to go through helpers function Simon Glass
2016-02-16 14:51 ` Bin Meng
2016-02-15 2:16 ` [U-Boot] [PATCH 20/30] dm: usb: Avoid exceeding available array size for storage devices Simon Glass
2016-02-15 2:16 ` [U-Boot] [PATCH 21/30] dm: usb: Tidy up storage code ready for driver model conversion Simon Glass
2016-02-15 2:16 ` [U-Boot] [PATCH 22/30] dm: blk: Add a block-device uclass Simon Glass
2016-02-17 4:49 ` Bin Meng
2016-02-15 2:16 ` [U-Boot] [PATCH 23/30] dm: sandbox: Prepare block driver for driver-model conversion Simon Glass
2016-02-15 2:16 ` [U-Boot] [PATCH 24/30] dm: sandbox: Add driver-model block-device support for sandbox Simon Glass
2016-02-16 23:34 ` Stephen Warren
2016-02-29 4:19 ` Simon Glass
2016-02-15 2:16 ` [U-Boot] [PATCH 25/30] dm: usb: Convert USB storage to use driver-model for block devs Simon Glass
2016-02-15 2:16 ` [U-Boot] [PATCH 26/30] dm: usb: Unbind old block devices when shutting down USB Simon Glass
2016-02-15 2:16 ` [U-Boot] [PATCH 27/30] dm: sandbox: Switch over to use DM for block devices Simon Glass
2016-02-15 2:16 ` [U-Boot] [PATCH 28/30] dm: sandbox: Drop the pre-DM host implementation Simon Glass
2016-02-15 2:16 ` [U-Boot] [PATCH 29/30] dm: usb: Clean up USB after each test Simon Glass
2016-02-15 2:16 ` [U-Boot] [PATCH 30/30] dm: blk: Add tests for block devices Simon Glass
2016-02-15 22:37 ` [U-Boot] [PATCH 00/30] dm: Add driver-model support for block drivers Tom Rini
2016-02-29 4:19 ` Simon Glass
2016-02-16 23:43 ` Stephen Warren
2016-02-29 4:19 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C3AD47.2090907@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.