[PATCH 0/3] thermal: exynos: Fixes for vtmu-supply regulator handling

[PATCH 0/3] thermal: exynos: Fixes for vtmu-supply regulator handling

[Javier Martinez Canillas]

Hello,

On a recent patch series to build a PMIC chip as a module [0], Krzysztof
asked me to check if all the consumer drivers, using the resources that
this PMIC provides, already support probe deferral.

While investigating that, I noticed that the Exynos TMU didn't do it so
this series fix that bug and other two minor issues that I noticed while
reviewing the driver and its DT binding.

The series are on top of Krzysztof's patches [1,2,3] not because there's
a dependency but to avoid merge conflicts with in-flight patches. Please
let me know if you prefer to use a different base instead.

[0]: https://lkml.org/lkml/2016/2/11/857
[1]: https://patchwork.kernel.org/patch/8345791/
[2]: https://patchwork.kernel.org/patch/8345741/
[3]: https://patchwork.kernel.org/patch/8345701/

Best regards,
Javier


Javier Martinez Canillas (3):
  thermal: exynos: List vtmu-supply as optional property in DT binding
  thermal: exynos: Use devm_regulator_get_optional() for vtmu
  thermal: exynos: Defer probe if vtmu is present but not registered

 Documentation/devicetree/bindings/thermal/exynos-thermal.txt | 9 ++++++---
 drivers/thermal/samsung/exynos_tmu.c                         | 4 +++-
 2 files changed, 9 insertions(+), 4 deletions(-)

-- 
2.5.0

[PATCH 0/3] thermal: exynos: Fixes for vtmu-supply regulator handling

[Javier Martinez Canillas]

Hello,

On a recent patch series to build a PMIC chip as a module [0], Krzysztof
asked me to check if all the consumer drivers, using the resources that
this PMIC provides, already support probe deferral.

While investigating that, I noticed that the Exynos TMU didn't do it so
this series fix that bug and other two minor issues that I noticed while
reviewing the driver and its DT binding.

The series are on top of Krzysztof's patches [1,2,3] not because there's
a dependency but to avoid merge conflicts with in-flight patches. Please
let me know if you prefer to use a different base instead.

[0]: https://lkml.org/lkml/2016/2/11/857
[1]: https://patchwork.kernel.org/patch/8345791/
[2]: https://patchwork.kernel.org/patch/8345741/
[3]: https://patchwork.kernel.org/patch/8345701/

Best regards,
Javier


Javier Martinez Canillas (3):
  thermal: exynos: List vtmu-supply as optional property in DT binding
  thermal: exynos: Use devm_regulator_get_optional() for vtmu
  thermal: exynos: Defer probe if vtmu is present but not registered

 Documentation/devicetree/bindings/thermal/exynos-thermal.txt | 9 ++++++---
 drivers/thermal/samsung/exynos_tmu.c                         | 4 +++-
 2 files changed, 9 insertions(+), 4 deletions(-)

-- 
2.5.0

[PATCH 1/3] thermal: exynos: List vtmu-supply as optional property in DT binding

[Javier Martinez Canillas]

The Exynos Thermal Management Unit binding says that the vtmu-supply
is optional but is listed in the required properties section. Add an
optional properties section and move the regulator property there.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 Documentation/devicetree/bindings/thermal/exynos-thermal.txt | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/thermal/exynos-thermal.txt b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
index faa62059b5c5..70b4c16c7ed8 100644
--- a/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
+++ b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
@@ -41,9 +41,6 @@
 		for current TMU channel
 	-- "tmu_sclk" clock for functional operation of the current TMU
 		channel
-- vtmu-supply: This entry is optional and provides the regulator node supplying
-		voltage to TMU. If needed this entry can be placed inside
-		board/platform specific dts file.
 
 The Exynos TMU supports generating interrupts when reaching given
 temperature thresholds. Number of supported thermal trip points depends
@@ -65,6 +62,12 @@ Following properties are mandatory (depending on SoC):
 - samsung,tmu_default_temp_offset: Default temperature offset
 - samsung,tmu_cal_type: Callibration type
 
+** Optional properties:
+
+- vtmu-supply: This entry is optional and provides the regulator node supplying
+		voltage to TMU. If needed this entry can be placed inside
+		board/platform specific dts file.
+
 Example 1):
 
 	tmu@100C0000 {
-- 
2.5.0

[PATCH 1/3] thermal: exynos: List vtmu-supply as optional property in DT binding

[Javier Martinez Canillas]

The Exynos Thermal Management Unit binding says that the vtmu-supply
is optional but is listed in the required properties section. Add an
optional properties section and move the regulator property there.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 Documentation/devicetree/bindings/thermal/exynos-thermal.txt | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/thermal/exynos-thermal.txt b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
index faa62059b5c5..70b4c16c7ed8 100644
--- a/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
+++ b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
@@ -41,9 +41,6 @@
 		for current TMU channel
 	-- "tmu_sclk" clock for functional operation of the current TMU
 		channel
-- vtmu-supply: This entry is optional and provides the regulator node supplying
-		voltage to TMU. If needed this entry can be placed inside
-		board/platform specific dts file.
 
 The Exynos TMU supports generating interrupts when reaching given
 temperature thresholds. Number of supported thermal trip points depends
@@ -65,6 +62,12 @@ Following properties are mandatory (depending on SoC):
 - samsung,tmu_default_temp_offset: Default temperature offset
 - samsung,tmu_cal_type: Callibration type
 
+** Optional properties:
+
+- vtmu-supply: This entry is optional and provides the regulator node supplying
+		voltage to TMU. If needed this entry can be placed inside
+		board/platform specific dts file.
+
 Example 1):
 
 	tmu at 100C0000 {
-- 
2.5.0

[PATCH 2/3] thermal: exynos: Use devm_regulator_get_optional() for vtmu

[Javier Martinez Canillas]

The Exynos TMU DT binding says that the vtmu-supply is optional but the
driver uses devm_regulator_get() that creates a dummy regulator if it's
not defined in the DT. For example the following message is in the log:

10060000.tmu supply vtmu not found, using dummy regulator

Use the optional version of regulator_get() that doesn't create a dummy
regulator and instead returns a -ENODEV errno code. Since it's expected
that a regulator may not be defined and the driver will inform about it:

exynos-tmu 10060000.tmu: Regulator node (vtmu) not found

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/thermal/samsung/exynos_tmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
index 6c6f59ba7423..f4f36bba7be9 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -1310,7 +1310,7 @@ static int exynos_tmu_probe(struct platform_device *pdev)
 	 * TODO: Add regulator as an SOC feature, so that regulator enable
 	 * is a compulsory call.
 	 */
-	data->regulator = devm_regulator_get(&pdev->dev, "vtmu");
+	data->regulator = devm_regulator_get_optional(&pdev->dev, "vtmu");
 	if (!IS_ERR(data->regulator)) {
 		ret = regulator_enable(data->regulator);
 		if (ret) {
-- 
2.5.0

[PATCH 2/3] thermal: exynos: Use devm_regulator_get_optional() for vtmu

[Javier Martinez Canillas]

The Exynos TMU DT binding says that the vtmu-supply is optional but the
driver uses devm_regulator_get() that creates a dummy regulator if it's
not defined in the DT. For example the following message is in the log:

10060000.tmu supply vtmu not found, using dummy regulator

Use the optional version of regulator_get() that doesn't create a dummy
regulator and instead returns a -ENODEV errno code. Since it's expected
that a regulator may not be defined and the driver will inform about it:

exynos-tmu 10060000.tmu: Regulator node (vtmu) not found

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/thermal/samsung/exynos_tmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
index 6c6f59ba7423..f4f36bba7be9 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -1310,7 +1310,7 @@ static int exynos_tmu_probe(struct platform_device *pdev)
 	 * TODO: Add regulator as an SOC feature, so that regulator enable
 	 * is a compulsory call.
 	 */
-	data->regulator = devm_regulator_get(&pdev->dev, "vtmu");
+	data->regulator = devm_regulator_get_optional(&pdev->dev, "vtmu");
 	if (!IS_ERR(data->regulator)) {
 		ret = regulator_enable(data->regulator);
 		if (ret) {
-- 
2.5.0

[PATCH 3/3] thermal: exynos: Defer probe if vtmu is present but not registered

[Javier Martinez Canillas]

The driver doesn't check if the regulator_get_optional return value is
-EPROBE_DEFER so it will wrongly assume that the regulator couldn't be
found just because the regulator driver wasn't registered yet, i.e:

exynos-tmu 10060000.tmu: Regulator node (vtmu) not found

In this case the return value should be propagated to allow the driver
probe function to be deferred until the regulator driver is registered.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

---

 drivers/thermal/samsung/exynos_tmu.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
index f4f36bba7be9..f3ce94ec73b5 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -1318,6 +1318,8 @@ static int exynos_tmu_probe(struct platform_device *pdev)
 			return ret;
 		}
 	} else {
+		if (PTR_ERR(data->regulator) == -EPROBE_DEFER)
+			return -EPROBE_DEFER;
 		dev_info(&pdev->dev, "Regulator node (vtmu) not found\n");
 	}
 
-- 
2.5.0

[PATCH 3/3] thermal: exynos: Defer probe if vtmu is present but not registered

[Javier Martinez Canillas]

The driver doesn't check if the regulator_get_optional return value is
-EPROBE_DEFER so it will wrongly assume that the regulator couldn't be
found just because the regulator driver wasn't registered yet, i.e:

exynos-tmu 10060000.tmu: Regulator node (vtmu) not found

In this case the return value should be propagated to allow the driver
probe function to be deferred until the regulator driver is registered.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

---

 drivers/thermal/samsung/exynos_tmu.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
index f4f36bba7be9..f3ce94ec73b5 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -1318,6 +1318,8 @@ static int exynos_tmu_probe(struct platform_device *pdev)
 			return ret;
 		}
 	} else {
+		if (PTR_ERR(data->regulator) == -EPROBE_DEFER)
+			return -EPROBE_DEFER;
 		dev_info(&pdev->dev, "Regulator node (vtmu) not found\n");
 	}
 
-- 
2.5.0

Re: [PATCH 1/3] thermal: exynos: List vtmu-supply as optional property in DT binding

[Krzysztof Kozlowski]

On 19.02.2016 03:19, Javier Martinez Canillas wrote:
> The Exynos Thermal Management Unit binding says that the vtmu-supply
> is optional but is listed in the required properties section. Add an
> optional properties section and move the regulator property there.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
> 
>  Documentation/devicetree/bindings/thermal/exynos-thermal.txt | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

[PATCH 1/3] thermal: exynos: List vtmu-supply as optional property in DT binding

[Krzysztof Kozlowski]

On 19.02.2016 03:19, Javier Martinez Canillas wrote:
> The Exynos Thermal Management Unit binding says that the vtmu-supply
> is optional but is listed in the required properties section. Add an
> optional properties section and move the regulator property there.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
> 
>  Documentation/devicetree/bindings/thermal/exynos-thermal.txt | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

Re: [PATCH 2/3] thermal: exynos: Use devm_regulator_get_optional() for vtmu

[Krzysztof Kozlowski]

On 19.02.2016 03:19, Javier Martinez Canillas wrote:
> The Exynos TMU DT binding says that the vtmu-supply is optional but the
> driver uses devm_regulator_get() that creates a dummy regulator if it's
> not defined in the DT. For example the following message is in the log:
> 
> 10060000.tmu supply vtmu not found, using dummy regulator
> 
> Use the optional version of regulator_get() that doesn't create a dummy
> regulator and instead returns a -ENODEV errno code. Since it's expected
> that a regulator may not be defined and the driver will inform about it:
> 
> exynos-tmu 10060000.tmu: Regulator node (vtmu) not found
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
> 
>  drivers/thermal/samsung/exynos_tmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

[PATCH 2/3] thermal: exynos: Use devm_regulator_get_optional() for vtmu

[Krzysztof Kozlowski]

On 19.02.2016 03:19, Javier Martinez Canillas wrote:
> The Exynos TMU DT binding says that the vtmu-supply is optional but the
> driver uses devm_regulator_get() that creates a dummy regulator if it's
> not defined in the DT. For example the following message is in the log:
> 
> 10060000.tmu supply vtmu not found, using dummy regulator
> 
> Use the optional version of regulator_get() that doesn't create a dummy
> regulator and instead returns a -ENODEV errno code. Since it's expected
> that a regulator may not be defined and the driver will inform about it:
> 
> exynos-tmu 10060000.tmu: Regulator node (vtmu) not found
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
> 
>  drivers/thermal/samsung/exynos_tmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

Re: [PATCH 3/3] thermal: exynos: Defer probe if vtmu is present but not registered

[Krzysztof Kozlowski]

On 19.02.2016 03:19, Javier Martinez Canillas wrote:
> The driver doesn't check if the regulator_get_optional return value is
> -EPROBE_DEFER so it will wrongly assume that the regulator couldn't be
> found just because the regulator driver wasn't registered yet, i.e:
> 
> exynos-tmu 10060000.tmu: Regulator node (vtmu) not found
> 
> In this case the return value should be propagated to allow the driver
> probe function to be deferred until the regulator driver is registered.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> ---
> 
>  drivers/thermal/samsung/exynos_tmu.c | 2 ++
>  1 file changed, 2 insertions(+)
> 

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

[PATCH 3/3] thermal: exynos: Defer probe if vtmu is present but not registered

[Krzysztof Kozlowski]

On 19.02.2016 03:19, Javier Martinez Canillas wrote:
> The driver doesn't check if the regulator_get_optional return value is
> -EPROBE_DEFER so it will wrongly assume that the regulator couldn't be
> found just because the regulator driver wasn't registered yet, i.e:
> 
> exynos-tmu 10060000.tmu: Regulator node (vtmu) not found
> 
> In this case the return value should be propagated to allow the driver
> probe function to be deferred until the regulator driver is registered.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> ---
> 
>  drivers/thermal/samsung/exynos_tmu.c | 2 ++
>  1 file changed, 2 insertions(+)
> 

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

Re: [PATCH 3/3] thermal: exynos: Defer probe if vtmu is present but not registered

[Andi Shyti]

Hi Javier,

Just a question...

> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> index f4f36bba7be9..f3ce94ec73b5 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -1318,6 +1318,8 @@ static int exynos_tmu_probe(struct platform_device *pdev)
>  			return ret;
>  		}
>  	} else {
> +		if (PTR_ERR(data->regulator) == -EPROBE_DEFER)
> +			return -EPROBE_DEFER;

shouldn't we return also in case of -ENOMEM? -ENOMEM is a Kernel
failure, not depending on the regulator itself.

Andi

>  		dev_info(&pdev->dev, "Regulator node (vtmu) not found\n");
>  	}

[PATCH 3/3] thermal: exynos: Defer probe if vtmu is present but not registered

[Andi Shyti]

Hi Javier,

Just a question...

> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> index f4f36bba7be9..f3ce94ec73b5 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -1318,6 +1318,8 @@ static int exynos_tmu_probe(struct platform_device *pdev)
>  			return ret;
>  		}
>  	} else {
> +		if (PTR_ERR(data->regulator) == -EPROBE_DEFER)
> +			return -EPROBE_DEFER;

shouldn't we return also in case of -ENOMEM? -ENOMEM is a Kernel
failure, not depending on the regulator itself.

Andi

>  		dev_info(&pdev->dev, "Regulator node (vtmu) not found\n");
>  	}

Re: [PATCH 3/3] thermal: exynos: Defer probe if vtmu is present but not registered

[Krzysztof Kozlowski]

On 19.02.2016 13:20, Andi Shyti wrote:
> Hi Javier,
> 
> Just a question...
> 
>> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
>> index f4f36bba7be9..f3ce94ec73b5 100644
>> --- a/drivers/thermal/samsung/exynos_tmu.c
>> +++ b/drivers/thermal/samsung/exynos_tmu.c
>> @@ -1318,6 +1318,8 @@ static int exynos_tmu_probe(struct platform_device *pdev)
>>  			return ret;
>>  		}
>>  	} else {
>> +		if (PTR_ERR(data->regulator) == -EPROBE_DEFER)
>> +			return -EPROBE_DEFER;
> 
> shouldn't we return also in case of -ENOMEM? -ENOMEM is a Kernel
> failure, not depending on the regulator itself.

Usually not because that would make this error path quite complicated
and difficult to keep consistent. If you choose this way then you will
have to probably extend the black list (e.g. EINVAL, some other)... or
use a white list.

Additionally the error codes can come from deeper layers. These layer
now can return ESOMETHING but later it might change to EDIFFERENT... you
cannot predict that.

Whatever the reason was (except defer), just ignore the regulator.

Best regards,
Krzysztof

[PATCH 3/3] thermal: exynos: Defer probe if vtmu is present but not registered

[Krzysztof Kozlowski]

On 19.02.2016 13:20, Andi Shyti wrote:
> Hi Javier,
> 
> Just a question...
> 
>> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
>> index f4f36bba7be9..f3ce94ec73b5 100644
>> --- a/drivers/thermal/samsung/exynos_tmu.c
>> +++ b/drivers/thermal/samsung/exynos_tmu.c
>> @@ -1318,6 +1318,8 @@ static int exynos_tmu_probe(struct platform_device *pdev)
>>  			return ret;
>>  		}
>>  	} else {
>> +		if (PTR_ERR(data->regulator) == -EPROBE_DEFER)
>> +			return -EPROBE_DEFER;
> 
> shouldn't we return also in case of -ENOMEM? -ENOMEM is a Kernel
> failure, not depending on the regulator itself.

Usually not because that would make this error path quite complicated
and difficult to keep consistent. If you choose this way then you will
have to probably extend the black list (e.g. EINVAL, some other)... or
use a white list.

Additionally the error codes can come from deeper layers. These layer
now can return ESOMETHING but later it might change to EDIFFERENT... you
cannot predict that.

Whatever the reason was (except defer), just ignore the regulator.

Best regards,
Krzysztof

Re: [PATCH 0/3] thermal: exynos: Fixes for vtmu-supply regulator handling

[Andi Shyti]

Hi Javier,

> Javier Martinez Canillas (3):
>   thermal: exynos: List vtmu-supply as optional property in DT binding
>   thermal: exynos: Use devm_regulator_get_optional() for vtmu
>   thermal: exynos: Defer probe if vtmu is present but not registered
> 
>  Documentation/devicetree/bindings/thermal/exynos-thermal.txt | 9 ++++++---
>  drivers/thermal/samsung/exynos_tmu.c                         | 4 +++-
>  2 files changed, 9 insertions(+), 4 deletions(-)

for all of them:

Reviewed-by: Andi Shyti <andi.shyti@samsung.com>

Andi

[PATCH 0/3] thermal: exynos: Fixes for vtmu-supply regulator handling

[Andi Shyti]

Hi Javier,

> Javier Martinez Canillas (3):
>   thermal: exynos: List vtmu-supply as optional property in DT binding
>   thermal: exynos: Use devm_regulator_get_optional() for vtmu
>   thermal: exynos: Defer probe if vtmu is present but not registered
> 
>  Documentation/devicetree/bindings/thermal/exynos-thermal.txt | 9 ++++++---
>  drivers/thermal/samsung/exynos_tmu.c                         | 4 +++-
>  2 files changed, 9 insertions(+), 4 deletions(-)

for all of them:

Reviewed-by: Andi Shyti <andi.shyti@samsung.com>

Andi

Re: [PATCH 1/3] thermal: exynos: List vtmu-supply as optional property in DT binding

[Rob Herring]

On Thu, Feb 18, 2016 at 03:19:09PM -0300, Javier Martinez Canillas wrote:
> The Exynos Thermal Management Unit binding says that the vtmu-supply
> is optional but is listed in the required properties section. Add an
> optional properties section and move the regulator property there.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
> 
>  Documentation/devicetree/bindings/thermal/exynos-thermal.txt | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)

Acked-by: Rob Herring <robh@kernel.org>

[PATCH 1/3] thermal: exynos: List vtmu-supply as optional property in DT binding

[Rob Herring]

On Thu, Feb 18, 2016 at 03:19:09PM -0300, Javier Martinez Canillas wrote:
> The Exynos Thermal Management Unit binding says that the vtmu-supply
> is optional but is listed in the required properties section. Add an
> optional properties section and move the regulator property there.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
> 
>  Documentation/devicetree/bindings/thermal/exynos-thermal.txt | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)

Acked-by: Rob Herring <robh@kernel.org>

Re: [PATCH 0/3] thermal: exynos: Fixes for vtmu-supply regulator handling

[Javier Martinez Canillas]

Hello Lukasz, Eduardo,

On 02/18/2016 03:19 PM, Javier Martinez Canillas wrote:
> Hello,
> 
> On a recent patch series to build a PMIC chip as a module [0], Krzysztof
> asked me to check if all the consumer drivers, using the resources that
> this PMIC provides, already support probe deferral.
> 
> While investigating that, I noticed that the Exynos TMU didn't do it so
> this series fix that bug and other two minor issues that I noticed while
> reviewing the driver and its DT binding.
> 
> The series are on top of Krzysztof's patches [1,2,3] not because there's
> a dependency but to avoid merge conflicts with in-flight patches. Please
> let me know if you prefer to use a different base instead.
> 
> [0]: https://lkml.org/lkml/2016/2/11/857
> [1]: https://patchwork.kernel.org/patch/8345791/
> [2]: https://patchwork.kernel.org/patch/8345741/
> [3]: https://patchwork.kernel.org/patch/8345701/
> 
> Best regards,
> Javier
> 

Any comments about this series?

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

[PATCH 0/3] thermal: exynos: Fixes for vtmu-supply regulator handling

[Javier Martinez Canillas]

Hello Lukasz, Eduardo,

On 02/18/2016 03:19 PM, Javier Martinez Canillas wrote:
> Hello,
> 
> On a recent patch series to build a PMIC chip as a module [0], Krzysztof
> asked me to check if all the consumer drivers, using the resources that
> this PMIC provides, already support probe deferral.
> 
> While investigating that, I noticed that the Exynos TMU didn't do it so
> this series fix that bug and other two minor issues that I noticed while
> reviewing the driver and its DT binding.
> 
> The series are on top of Krzysztof's patches [1,2,3] not because there's
> a dependency but to avoid merge conflicts with in-flight patches. Please
> let me know if you prefer to use a different base instead.
> 
> [0]: https://lkml.org/lkml/2016/2/11/857
> [1]: https://patchwork.kernel.org/patch/8345791/
> [2]: https://patchwork.kernel.org/patch/8345741/
> [3]: https://patchwork.kernel.org/patch/8345701/
> 
> Best regards,
> Javier
> 

Any comments about this series?

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Re: [PATCH 1/3] thermal: exynos: List vtmu-supply as optional property in DT binding

[Eduardo Valentin]

On Thu, Feb 18, 2016 at 03:19:09PM -0300, Javier Martinez Canillas wrote:
> The Exynos Thermal Management Unit binding says that the vtmu-supply
> is optional but is listed in the required properties section. Add an
> optional properties section and move the regulator property there.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
> 
>  Documentation/devicetree/bindings/thermal/exynos-thermal.txt | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/exynos-thermal.txt b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
> index faa62059b5c5..70b4c16c7ed8 100644
> --- a/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
> +++ b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
> @@ -41,9 +41,6 @@
>  		for current TMU channel
>  	-- "tmu_sclk" clock for functional operation of the current TMU
>  		channel
> -- vtmu-supply: This entry is optional and provides the regulator node supplying
> -		voltage to TMU. If needed this entry can be placed inside
> -		board/platform specific dts file.
>  
>  The Exynos TMU supports generating interrupts when reaching given
>  temperature thresholds. Number of supported thermal trip points depends

Where is this patch based on? I checked it on my fixes and linus
branches, also on linux-next 0308 branch, and none of those apply clean.

Can you please send this based on upstream kernel?

> @@ -65,6 +62,12 @@ Following properties are mandatory (depending on SoC):
>  - samsung,tmu_default_temp_offset: Default temperature offset
>  - samsung,tmu_cal_type: Callibration type
>  
> +** Optional properties:
> +
> +- vtmu-supply: This entry is optional and provides the regulator node supplying
> +		voltage to TMU. If needed this entry can be placed inside
> +		board/platform specific dts file.
> +
>  Example 1):
>  
>  	tmu@100C0000 {
> -- 
> 2.5.0
> 

[PATCH 1/3] thermal: exynos: List vtmu-supply as optional property in DT binding

[Eduardo Valentin]

On Thu, Feb 18, 2016 at 03:19:09PM -0300, Javier Martinez Canillas wrote:
> The Exynos Thermal Management Unit binding says that the vtmu-supply
> is optional but is listed in the required properties section. Add an
> optional properties section and move the regulator property there.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
> 
>  Documentation/devicetree/bindings/thermal/exynos-thermal.txt | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/exynos-thermal.txt b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
> index faa62059b5c5..70b4c16c7ed8 100644
> --- a/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
> +++ b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
> @@ -41,9 +41,6 @@
>  		for current TMU channel
>  	-- "tmu_sclk" clock for functional operation of the current TMU
>  		channel
> -- vtmu-supply: This entry is optional and provides the regulator node supplying
> -		voltage to TMU. If needed this entry can be placed inside
> -		board/platform specific dts file.
>  
>  The Exynos TMU supports generating interrupts when reaching given
>  temperature thresholds. Number of supported thermal trip points depends

Where is this patch based on? I checked it on my fixes and linus
branches, also on linux-next 0308 branch, and none of those apply clean.

Can you please send this based on upstream kernel?

> @@ -65,6 +62,12 @@ Following properties are mandatory (depending on SoC):
>  - samsung,tmu_default_temp_offset: Default temperature offset
>  - samsung,tmu_cal_type: Callibration type
>  
> +** Optional properties:
> +
> +- vtmu-supply: This entry is optional and provides the regulator node supplying
> +		voltage to TMU. If needed this entry can be placed inside
> +		board/platform specific dts file.
> +
>  Example 1):
>  
>  	tmu at 100C0000 {
> -- 
> 2.5.0
> 

Re: [PATCH 1/3] thermal: exynos: List vtmu-supply as optional property in DT binding

[Javier Martinez Canillas]

Hello Eduardo,

On 03/08/2016 06:07 PM, Eduardo Valentin wrote:
> On Thu, Feb 18, 2016 at 03:19:09PM -0300, Javier Martinez Canillas wrote:
>> The Exynos Thermal Management Unit binding says that the vtmu-supply
>> is optional but is listed in the required properties section. Add an
>> optional properties section and move the regulator property there.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>> ---
>>
>>  Documentation/devicetree/bindings/thermal/exynos-thermal.txt | 9 ++++++---
>>  1 file changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/thermal/exynos-thermal.txt b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
>> index faa62059b5c5..70b4c16c7ed8 100644
>> --- a/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
>> +++ b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
>> @@ -41,9 +41,6 @@
>>  		for current TMU channel
>>  	-- "tmu_sclk" clock for functional operation of the current TMU
>>  		channel
>> -- vtmu-supply: This entry is optional and provides the regulator node supplying
>> -		voltage to TMU. If needed this entry can be placed inside
>> -		board/platform specific dts file.
>>  
>>  The Exynos TMU supports generating interrupts when reaching given
>>  temperature thresholds. Number of supported thermal trip points depends
> 
> Where is this patch based on? I checked it on my fixes and linus
> branches, also on linux-next 0308 branch, and none of those apply clean.
>

I mentioned in the cover letter [0] that this series were based on top
of in-flight patches from Krzysztof Kozlowski to avoid merge conflicts.

Those have not landed yet either so maybe you could look at those first?
 
> Can you please send this based on upstream kernel?
>

Ok, my intention was to make picking both patch series easier but if
this is inconvenient to you, I can base on top of current mainline
and let you handle the merge conflicts (or ask Krzysztof to resend
on top of my patches).

[0]: https://lkml.org/lkml/2016/2/18/591
 
Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

[PATCH 1/3] thermal: exynos: List vtmu-supply as optional property in DT binding

[Javier Martinez Canillas]

Hello Eduardo,

On 03/08/2016 06:07 PM, Eduardo Valentin wrote:
> On Thu, Feb 18, 2016 at 03:19:09PM -0300, Javier Martinez Canillas wrote:
>> The Exynos Thermal Management Unit binding says that the vtmu-supply
>> is optional but is listed in the required properties section. Add an
>> optional properties section and move the regulator property there.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>> ---
>>
>>  Documentation/devicetree/bindings/thermal/exynos-thermal.txt | 9 ++++++---
>>  1 file changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/thermal/exynos-thermal.txt b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
>> index faa62059b5c5..70b4c16c7ed8 100644
>> --- a/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
>> +++ b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
>> @@ -41,9 +41,6 @@
>>  		for current TMU channel
>>  	-- "tmu_sclk" clock for functional operation of the current TMU
>>  		channel
>> -- vtmu-supply: This entry is optional and provides the regulator node supplying
>> -		voltage to TMU. If needed this entry can be placed inside
>> -		board/platform specific dts file.
>>  
>>  The Exynos TMU supports generating interrupts when reaching given
>>  temperature thresholds. Number of supported thermal trip points depends
> 
> Where is this patch based on? I checked it on my fixes and linus
> branches, also on linux-next 0308 branch, and none of those apply clean.
>

I mentioned in the cover letter [0] that this series were based on top
of in-flight patches from Krzysztof Kozlowski to avoid merge conflicts.

Those have not landed yet either so maybe you could look at those first?
 
> Can you please send this based on upstream kernel?
>

Ok, my intention was to make picking both patch series easier but if
this is inconvenient to you, I can base on top of current mainline
and let you handle the merge conflicts (or ask Krzysztof to resend
on top of my patches).

[0]: https://lkml.org/lkml/2016/2/18/591
 
Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Re: [PATCH 1/3] thermal: exynos: List vtmu-supply as optional property in DT binding

[Eduardo Valentin]

On Tue, Mar 08, 2016 at 06:30:17PM -0300, Javier Martinez Canillas wrote:
> Hello Eduardo,
> 
> On 03/08/2016 06:07 PM, Eduardo Valentin wrote:
> > On Thu, Feb 18, 2016 at 03:19:09PM -0300, Javier Martinez Canillas wrote:
> >> The Exynos Thermal Management Unit binding says that the vtmu-supply
> >> is optional but is listed in the required properties section. Add an
> >> optional properties section and move the regulator property there.
> >>
> >> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> >> ---
> >>
> >>  Documentation/devicetree/bindings/thermal/exynos-thermal.txt | 9 ++++++---
> >>  1 file changed, 6 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/thermal/exynos-thermal.txt b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
> >> index faa62059b5c5..70b4c16c7ed8 100644
> >> --- a/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
> >> +++ b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
> >> @@ -41,9 +41,6 @@
> >>  		for current TMU channel
> >>  	-- "tmu_sclk" clock for functional operation of the current TMU
> >>  		channel
> >> -- vtmu-supply: This entry is optional and provides the regulator node supplying
> >> -		voltage to TMU. If needed this entry can be placed inside
> >> -		board/platform specific dts file.
> >>  
> >>  The Exynos TMU supports generating interrupts when reaching given
> >>  temperature thresholds. Number of supported thermal trip points depends
> > 
> > Where is this patch based on? I checked it on my fixes and linus
> > branches, also on linux-next 0308 branch, and none of those apply clean.
> >
> 
> I mentioned in the cover letter [0] that this series were based on top
> of in-flight patches from Krzysztof Kozlowski to avoid merge conflicts.
> 
> Those have not landed yet either so maybe you could look at those first?
>  
> > Can you please send this based on upstream kernel?
> >
> 
> Ok, my intention was to make picking both patch series easier but if
> this is inconvenient to you, I can base on top of current mainline
> and let you handle the merge conflicts (or ask Krzysztof to resend
> on top of my patches).
> 
> [0]: https://lkml.org/lkml/2016/2/18/591

Got it. I am checking his patches first then.

>  
> Best regards,
> -- 
> Javier Martinez Canillas
> Open Source Group
> Samsung Research America

[PATCH 1/3] thermal: exynos: List vtmu-supply as optional property in DT binding

[Eduardo Valentin]

On Tue, Mar 08, 2016 at 06:30:17PM -0300, Javier Martinez Canillas wrote:
> Hello Eduardo,
> 
> On 03/08/2016 06:07 PM, Eduardo Valentin wrote:
> > On Thu, Feb 18, 2016 at 03:19:09PM -0300, Javier Martinez Canillas wrote:
> >> The Exynos Thermal Management Unit binding says that the vtmu-supply
> >> is optional but is listed in the required properties section. Add an
> >> optional properties section and move the regulator property there.
> >>
> >> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> >> ---
> >>
> >>  Documentation/devicetree/bindings/thermal/exynos-thermal.txt | 9 ++++++---
> >>  1 file changed, 6 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/thermal/exynos-thermal.txt b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
> >> index faa62059b5c5..70b4c16c7ed8 100644
> >> --- a/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
> >> +++ b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
> >> @@ -41,9 +41,6 @@
> >>  		for current TMU channel
> >>  	-- "tmu_sclk" clock for functional operation of the current TMU
> >>  		channel
> >> -- vtmu-supply: This entry is optional and provides the regulator node supplying
> >> -		voltage to TMU. If needed this entry can be placed inside
> >> -		board/platform specific dts file.
> >>  
> >>  The Exynos TMU supports generating interrupts when reaching given
> >>  temperature thresholds. Number of supported thermal trip points depends
> > 
> > Where is this patch based on? I checked it on my fixes and linus
> > branches, also on linux-next 0308 branch, and none of those apply clean.
> >
> 
> I mentioned in the cover letter [0] that this series were based on top
> of in-flight patches from Krzysztof Kozlowski to avoid merge conflicts.
> 
> Those have not landed yet either so maybe you could look at those first?
>  
> > Can you please send this based on upstream kernel?
> >
> 
> Ok, my intention was to make picking both patch series easier but if
> this is inconvenient to you, I can base on top of current mainline
> and let you handle the merge conflicts (or ask Krzysztof to resend
> on top of my patches).
> 
> [0]: https://lkml.org/lkml/2016/2/18/591

Got it. I am checking his patches first then.

>  
> Best regards,
> -- 
> Javier Martinez Canillas
> Open Source Group
> Samsung Research America