From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 1/4] slirp/slirp.h: Remove now-empty #ifdefs
Date: Tue, 23 Feb 2016 08:04:03 -0700 [thread overview]
Message-ID: <56CC74E3.9070905@redhat.com> (raw)
In-Reply-To: <1456237112-32662-2-git-send-email-peter.maydell@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 918 bytes --]
On 02/23/2016 07:18 AM, Peter Maydell wrote:
> After automatic cleanup to remove unnecessary #includes of headers that
> osdep.h provides, slirp.h has a few now unnecessary #ifdef/#endif pairs;
> remove them.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> slirp/slirp.h | 24 ------------------------
> 1 file changed, 24 deletions(-)
>
> diff --git a/slirp/slirp.h b/slirp/slirp.h
> index 07c13b4..7cfcf63 100644
> --- a/slirp/slirp.h
> +++ b/slirp/slirp.h
> @@ -26,28 +26,10 @@ typedef char *caddr_t;
> #endif
>
>
> -#ifdef HAVE_UNISTD_H
> -#endif
> -
> -#ifdef HAVE_STDLIB_H
> -#endif
> -
Once these are gone, slirp/slirp_config.h now has dead #defines (these
and others); it ought to be pruned down as well (either here or as
another followup).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-02-23 15:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 14:18 [Qemu-devel] [PATCH 0/4] post-include-cleanup followups Peter Maydell
2016-02-23 14:18 ` [Qemu-devel] [PATCH 1/4] slirp/slirp.h: Remove now-empty #ifdefs Peter Maydell
2016-02-23 15:04 ` Eric Blake [this message]
2016-02-24 18:58 ` Thomas Huth
2016-02-24 22:23 ` Peter Maydell
2016-02-23 14:18 ` [Qemu-devel] [PATCH 2/4] include/config.h: Remove Peter Maydell
2016-02-23 14:18 ` [Qemu-devel] [PATCH 3/4] update-linux-headers.sh: Fake types.h doesn't need to include anything Peter Maydell
2016-02-23 14:18 ` [Qemu-devel] [PATCH 4/4] util/base64.c: Clean includes Peter Maydell
2016-02-23 15:05 ` [Qemu-devel] [PATCH 0/4] post-include-cleanup followups Eric Blake
2016-03-16 12:49 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CC74E3.9070905@redhat.com \
--to=eblake@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.