Re: [Qemu-devel] [PATCH 1/4] slirp/slirp.h: Remove now-empty #ifdefs

From: Peter Maydell <peter.maydell@linaro.org>
To: Thomas Huth <thuth@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
	Patch Tracking <patches@linaro.org>
Subject: Re: [Qemu-devel] [PATCH 1/4] slirp/slirp.h: Remove now-empty #ifdefs
Date: Wed, 24 Feb 2016 22:23:45 +0000	[thread overview]
Message-ID: <CAFEAcA8PrHrW4rBk9OU8D_VSTpfBVmw77HdCO7_azVgbCsJgaw@mail.gmail.com> (raw)
In-Reply-To: <56CDFD42.6050906@redhat.com>

On 24 February 2016 at 18:58, Thomas Huth <thuth@redhat.com> wrote:
> On 23.02.2016 15:18, Peter Maydell wrote:
>> After automatic cleanup to remove unnecessary #includes of headers that
>> osdep.h provides, slirp.h has a few now unnecessary #ifdef/#endif pairs;
>> remove them.
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> ---
>>  slirp/slirp.h | 24 ------------------------
>>  1 file changed, 24 deletions(-)
>>
>> diff --git a/slirp/slirp.h b/slirp/slirp.h
>> index 07c13b4..7cfcf63 100644
>> --- a/slirp/slirp.h
>> +++ b/slirp/slirp.h
> ...
>> @@ -98,12 +80,6 @@ void free(void *ptr);
>>  #include <ppp/slirppp.h>
>>  #endif
>>
>> -#ifdef __STDC__
>> -#else
>> -#include <varargs.h>
>> -#endif
>
> That else branch isn't really empty ... OTOH, QEMU likely does not
> compile with a non-STDC-compliant compiler anyway, so I assume this is ok.

Indeed.

> Reviewed-by: Thomas Huth <thuth@redhat.com>

Thanks.

-- PMM