* [U-Boot] [PATCH] arm: socfpga: Enabling U-Boot environment support in QSPI
@ 2016-02-24 8:50 Chin Liang See
2016-02-24 17:44 ` Marek Vasut
0 siblings, 1 reply; 8+ messages in thread
From: Chin Liang See @ 2016-02-24 8:50 UTC (permalink / raw)
To: u-boot
Enabling the support of storing U-Boot environment
within serial NOR flash. By default, its still
store into SDMMC
Signed-off-by: Chin Liang See <clsee@altera.com>
Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
Cc: Dinh Nguyen <dinh.linux@gmail.com>
Cc: Pavel Machek <pavel@denx.de>
Cc: Marek Vasut <marex@denx.de>
Cc: Stefan Roese <sr@denx.de>
---
include/configs/socfpga_common.h | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/include/configs/socfpga_common.h b/include/configs/socfpga_common.h
index a09e906..c1eef54 100644
--- a/include/configs/socfpga_common.h
+++ b/include/configs/socfpga_common.h
@@ -291,6 +291,12 @@ unsigned int cm_get_qspi_controller_clk_hz(void);
#define CONFIG_ENV_OFFSET 512 /* just after the MBR */
#endif
+/* Environment for QSPI boot */
+#if defined(CONFIG_ENV_IS_IN_SPI_FLASH) && !defined(CONFIG_ENV_OFFSET)
+#define CONFIG_ENV_OFFSET 0x00100000
+#define CONFIG_ENV_SECT_SIZE (64 * 1024)
+#endif
+
/*
* mtd partitioning for serial NOR flash
*
--
1.9.2.468.g3f0c02a
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] arm: socfpga: Enabling U-Boot environment support in QSPI
2016-02-24 8:50 [U-Boot] [PATCH] arm: socfpga: Enabling U-Boot environment support in QSPI Chin Liang See
@ 2016-02-24 17:44 ` Marek Vasut
2016-02-26 13:06 ` Chin Liang See
0 siblings, 1 reply; 8+ messages in thread
From: Marek Vasut @ 2016-02-24 17:44 UTC (permalink / raw)
To: u-boot
On 02/24/2016 09:50 AM, Chin Liang See wrote:
> Enabling the support of storing U-Boot environment
> within serial NOR flash. By default, its still
> store into SDMMC
>
> Signed-off-by: Chin Liang See <clsee@altera.com>
> Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> Cc: Dinh Nguyen <dinh.linux@gmail.com>
> Cc: Pavel Machek <pavel@denx.de>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Stefan Roese <sr@denx.de>
I am fine with the patch, but why did I receive it thrice ? ;-)
> ---
> include/configs/socfpga_common.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/include/configs/socfpga_common.h b/include/configs/socfpga_common.h
> index a09e906..c1eef54 100644
> --- a/include/configs/socfpga_common.h
> +++ b/include/configs/socfpga_common.h
> @@ -291,6 +291,12 @@ unsigned int cm_get_qspi_controller_clk_hz(void);
> #define CONFIG_ENV_OFFSET 512 /* just after the MBR */
> #endif
>
> +/* Environment for QSPI boot */
> +#if defined(CONFIG_ENV_IS_IN_SPI_FLASH) && !defined(CONFIG_ENV_OFFSET)
> +#define CONFIG_ENV_OFFSET 0x00100000
> +#define CONFIG_ENV_SECT_SIZE (64 * 1024)
> +#endif
> +
> /*
> * mtd partitioning for serial NOR flash
> *
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] arm: socfpga: Enabling U-Boot environment support in QSPI
2016-02-24 17:44 ` Marek Vasut
@ 2016-02-26 13:06 ` Chin Liang See
2016-02-26 18:08 ` Marek Vasut
0 siblings, 1 reply; 8+ messages in thread
From: Chin Liang See @ 2016-02-26 13:06 UTC (permalink / raw)
To: u-boot
On Wed, 2016-02-24 at 18:44 +0100, Marek Vasut wrote:
> On 02/24/2016 09:50 AM, Chin Liang See wrote:
> > Enabling the support of storing U-Boot environment
> > within serial NOR flash. By default, its still
> > store into SDMMC
> >
> > Signed-off-by: Chin Liang See <clsee@altera.com>
> > Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> > Cc: Dinh Nguyen <dinh.linux@gmail.com>
> > Cc: Pavel Machek <pavel@denx.de>
> > Cc: Marek Vasut <marex@denx.de>
> > Cc: Stefan Roese <sr@denx.de>
>
> I am fine with the patch, but why did I receive it thrice ? ;-)
>
Sorry about this as I thought IT blocked the email sending. I noticed
the U-Boot mailing didn't show the patch after 10 mins. I was surprised
to see 3 and guess it took longer time to go through IT servers
screening :)
Thanks
Chin Liang
> > ---
> > include/configs/socfpga_common.h | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/include/configs/socfpga_common.h
> > b/include/configs/socfpga_common.h
> > index a09e906..c1eef54 100644
> > --- a/include/configs/socfpga_common.h
> > +++ b/include/configs/socfpga_common.h
> > @@ -291,6 +291,12 @@ unsigned int
> > cm_get_qspi_controller_clk_hz(void);
> > #define CONFIG_ENV_OFFSET 512 /* just after
> > the MBR */
> > #endif
> >
> > +/* Environment for QSPI boot */
> > +#if defined(CONFIG_ENV_IS_IN_SPI_FLASH) &&
> > !defined(CONFIG_ENV_OFFSET)
> > +#define CONFIG_ENV_OFFSET 0x00100000
> > +#define CONFIG_ENV_SECT_SIZE (64 * 1024)
> > +#endif
> > +
> > /*
> > * mtd partitioning for serial NOR flash
> > *
> >
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] arm: socfpga: Enabling U-Boot environment support in QSPI
2016-02-26 13:06 ` Chin Liang See
@ 2016-02-26 18:08 ` Marek Vasut
2016-03-01 6:38 ` Chin Liang See
0 siblings, 1 reply; 8+ messages in thread
From: Marek Vasut @ 2016-02-26 18:08 UTC (permalink / raw)
To: u-boot
On 02/26/2016 02:06 PM, Chin Liang See wrote:
> On Wed, 2016-02-24 at 18:44 +0100, Marek Vasut wrote:
>> On 02/24/2016 09:50 AM, Chin Liang See wrote:
>>> Enabling the support of storing U-Boot environment
>>> within serial NOR flash. By default, its still
>>> store into SDMMC
>>>
>>> Signed-off-by: Chin Liang See <clsee@altera.com>
>>> Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
>>> Cc: Dinh Nguyen <dinh.linux@gmail.com>
>>> Cc: Pavel Machek <pavel@denx.de>
>>> Cc: Marek Vasut <marex@denx.de>
>>> Cc: Stefan Roese <sr@denx.de>
>>
>> I am fine with the patch, but why did I receive it thrice ? ;-)
>>
>
> Sorry about this as I thought IT blocked the email sending. I noticed
> the U-Boot mailing didn't show the patch after 10 mins. I was surprised
> to see 3 and guess it took longer time to go through IT servers
> screening :)
Gotcha!
btw I started screening the patches a bit more. socfpga_sr1500 produces
a warning with this patch.
Please use buildman to build your patches, something like:
./tools/buildman/buildman -b u-boot/master..HEAD -defsS "socfpga"
will do the trick.
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] arm: socfpga: Enabling U-Boot environment support in QSPI
2016-02-26 18:08 ` Marek Vasut
@ 2016-03-01 6:38 ` Chin Liang See
2016-03-01 13:51 ` Marek Vasut
0 siblings, 1 reply; 8+ messages in thread
From: Chin Liang See @ 2016-03-01 6:38 UTC (permalink / raw)
To: u-boot
On Fri, 2016-02-26 at 19:08 +0100, Marek Vasut wrote:
> On 02/26/2016 02:06 PM, Chin Liang See wrote:
> > On Wed, 2016-02-24 at 18:44 +0100, Marek Vasut wrote:
> > > On 02/24/2016 09:50 AM, Chin Liang See wrote:
> > > > Enabling the support of storing U-Boot environment
> > > > within serial NOR flash. By default, its still
> > > > store into SDMMC
> > > >
> > > > Signed-off-by: Chin Liang See <clsee@altera.com>
> > > > Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> > > > Cc: Dinh Nguyen <dinh.linux@gmail.com>
> > > > Cc: Pavel Machek <pavel@denx.de>
> > > > Cc: Marek Vasut <marex@denx.de>
> > > > Cc: Stefan Roese <sr@denx.de>
> > >
> > > I am fine with the patch, but why did I receive it thrice ? ;-)
> > >
> >
> > Sorry about this as I thought IT blocked the email sending. I
> > noticed
> > the U-Boot mailing didn't show the patch after 10 mins. I was
> > surprised
> > to see 3 and guess it took longer time to go through IT servers
> > screening :)
>
> Gotcha!
>
> btw I started screening the patches a bit more. socfpga_sr1500
> produces
> a warning with this patch.
>
> Please use buildman to build your patches, something like:
>
> ./tools/buildman/buildman -b u-boot/master..HEAD -defsS "socfpga"
>
> will do the trick.
Oops, thanks for reminding this as we talked about this prior my long
holiday. I managed to get the buildman works but seems need 2 steps.
The first step is without the -defsS and without the "" too.
Thanks
Chin Liang
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] arm: socfpga: Enabling U-Boot environment support in QSPI
2016-03-01 6:38 ` Chin Liang See
@ 2016-03-01 13:51 ` Marek Vasut
2016-03-02 12:25 ` Chin Liang See
0 siblings, 1 reply; 8+ messages in thread
From: Marek Vasut @ 2016-03-01 13:51 UTC (permalink / raw)
To: u-boot
On 03/01/2016 07:38 AM, Chin Liang See wrote:
> On Fri, 2016-02-26 at 19:08 +0100, Marek Vasut wrote:
>> On 02/26/2016 02:06 PM, Chin Liang See wrote:
>>> On Wed, 2016-02-24 at 18:44 +0100, Marek Vasut wrote:
>>>> On 02/24/2016 09:50 AM, Chin Liang See wrote:
>>>>> Enabling the support of storing U-Boot environment
>>>>> within serial NOR flash. By default, its still
>>>>> store into SDMMC
>>>>>
>>>>> Signed-off-by: Chin Liang See <clsee@altera.com>
>>>>> Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
>>>>> Cc: Dinh Nguyen <dinh.linux@gmail.com>
>>>>> Cc: Pavel Machek <pavel@denx.de>
>>>>> Cc: Marek Vasut <marex@denx.de>
>>>>> Cc: Stefan Roese <sr@denx.de>
>>>>
>>>> I am fine with the patch, but why did I receive it thrice ? ;-)
>>>>
>>>
>>> Sorry about this as I thought IT blocked the email sending. I
>>> noticed
>>> the U-Boot mailing didn't show the patch after 10 mins. I was
>>> surprised
>>> to see 3 and guess it took longer time to go through IT servers
>>> screening :)
>>
>> Gotcha!
>>
>> btw I started screening the patches a bit more. socfpga_sr1500
>> produces
>> a warning with this patch.
>>
>> Please use buildman to build your patches, something like:
>>
>> ./tools/buildman/buildman -b u-boot/master..HEAD -defsS "socfpga"
>>
>> will do the trick.
>
> Oops, thanks for reminding this as we talked about this prior my long
> holiday. I managed to get the buildman works but seems need 2 steps.
> The first step is without the -defsS and without the "" too.
Ah, right. It's really convenient tool, right ? ;-)
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] arm: socfpga: Enabling U-Boot environment support in QSPI
2016-03-01 13:51 ` Marek Vasut
@ 2016-03-02 12:25 ` Chin Liang See
0 siblings, 0 replies; 8+ messages in thread
From: Chin Liang See @ 2016-03-02 12:25 UTC (permalink / raw)
To: u-boot
On Tue, 2016-03-01 at 14:51 +0100, Marek Vasut wrote:
> On 03/01/2016 07:38 AM, Chin Liang See wrote:
> > On Fri, 2016-02-26 at 19:08 +0100, Marek Vasut wrote:
> > > On 02/26/2016 02:06 PM, Chin Liang See wrote:
> > > > On Wed, 2016-02-24 at 18:44 +0100, Marek Vasut wrote:
> > > > > On 02/24/2016 09:50 AM, Chin Liang See wrote:
> > > > > > Enabling the support of storing U-Boot environment
> > > > > > within serial NOR flash. By default, its still
> > > > > > store into SDMMC
> > > > > >
> > > > > > Signed-off-by: Chin Liang See <clsee@altera.com>
> > > > > > Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> > > > > > Cc: Dinh Nguyen <dinh.linux@gmail.com>
> > > > > > Cc: Pavel Machek <pavel@denx.de>
> > > > > > Cc: Marek Vasut <marex@denx.de>
> > > > > > Cc: Stefan Roese <sr@denx.de>
> > > > >
> > > > > I am fine with the patch, but why did I receive it thrice ? ;
> > > > > -)
> > > > >
> > > >
> > > > Sorry about this as I thought IT blocked the email sending. I
> > > > noticed
> > > > the U-Boot mailing didn't show the patch after 10 mins. I was
> > > > surprised
> > > > to see 3 and guess it took longer time to go through IT servers
> > > > screening :)
> > >
> > > Gotcha!
> > >
> > > btw I started screening the patches a bit more. socfpga_sr1500
> > > produces
> > > a warning with this patch.
> > >
> > > Please use buildman to build your patches, something like:
> > >
> > > ./tools/buildman/buildman -b u-boot/master..HEAD -defsS "socfpga"
> > >
> > > will do the trick.
> >
> > Oops, thanks for reminding this as we talked about this prior my
> > long
> > holiday. I managed to get the buildman works but seems need 2
> > steps.
> > The first step is without the -defsS and without the "" too.
>
> Ah, right. It's really convenient tool, right ? ;-)
>
Yup, I fully agree :) The same command can be used even we added new
boards or socfpga devices.
Thanks
Chin Liang
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] arm: socfpga: Enabling U-Boot environment support in QSPI
@ 2016-02-24 8:40 Chin Liang See
0 siblings, 0 replies; 8+ messages in thread
From: Chin Liang See @ 2016-02-24 8:40 UTC (permalink / raw)
To: u-boot
Enabling the support of storing U-Boot environment
within serial NOR flash. By default, its still
store into SDMMC
Signed-off-by: Chin Liang See <clsee@altera.com>
Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
Cc: Dinh Nguyen <dinh.linux@gmail.com>
Cc: Pavel Machek <pavel@denx.de>
Cc: Marek Vasut <marex@denx.de>
Cc: Stefan Roese <sr@denx.de>
---
include/configs/socfpga_common.h | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/include/configs/socfpga_common.h b/include/configs/socfpga_common.h
index a09e906..c1eef54 100644
--- a/include/configs/socfpga_common.h
+++ b/include/configs/socfpga_common.h
@@ -291,6 +291,12 @@ unsigned int cm_get_qspi_controller_clk_hz(void);
#define CONFIG_ENV_OFFSET 512 /* just after the MBR */
#endif
+/* Environment for QSPI boot */
+#if defined(CONFIG_ENV_IS_IN_SPI_FLASH) && !defined(CONFIG_ENV_OFFSET)
+#define CONFIG_ENV_OFFSET 0x00100000
+#define CONFIG_ENV_SECT_SIZE (64 * 1024)
+#endif
+
/*
* mtd partitioning for serial NOR flash
*
--
1.9.2.468.g3f0c02a
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-03-02 12:25 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-24 8:50 [U-Boot] [PATCH] arm: socfpga: Enabling U-Boot environment support in QSPI Chin Liang See
2016-02-24 17:44 ` Marek Vasut
2016-02-26 13:06 ` Chin Liang See
2016-02-26 18:08 ` Marek Vasut
2016-03-01 6:38 ` Chin Liang See
2016-03-01 13:51 ` Marek Vasut
2016-03-02 12:25 ` Chin Liang See
-- strict thread matches above, loose matches on Subject: below --
2016-02-24 8:40 Chin Liang See
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.