[PATCH] Fix MAINTAINERS: remove any use of {a,b}

[PATCH] Fix MAINTAINERS: remove any use of {a,b}

[Anthony PERARD]

This is the complain from perl:
Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/^docs/misc/kconfig{ <-- HERE ,-language}\.txt/ at scripts/get_maintainer.pl line 731.

Also, it does not work.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 MAINTAINERS | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index db14cfe..cc44cbd 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -212,7 +212,8 @@ F:	xen/include/xen/iommu.h
 KCONFIG
 M:	Doug Goldstein <cardoe@cardoe.com>
 S:	Supported
-F:	docs/misc/kconfig{,-language}.txt
+F:	docs/misc/kconfig.txt
+F:	docs/misc/kconfig-language.txt
 F:	xen/tools/kconfig/
 
 KDD DEBUGGER
@@ -223,8 +224,10 @@ F:	tools/debugger/kdd/
 KEXEC
 M:      David Vrabel <david.vrabel@citrix.com>
 S:      Supported
-F:      xen/common/{kexec,kimage}.c
-F:      xen/include/{kexec,kimage}.h
+F:      xen/common/kexec.c
+F:      xen/common/kimage.c
+F:      xen/include/kexec.h
+F:      xen/include/kimage.h
 F:      xen/arch/x86/machine_kexec.c
 F:      xen/arch/x86/x86_64/kexec_reloc.S
 
-- 
Anthony PERARD


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] Fix MAINTAINERS: remove any use of {a,b}

[Jan Beulich]

>>> On 25.02.16 at 13:21, <anthony.perard@citrix.com> wrote:
> This is the complain from perl:
> Unescaped left brace in regex is deprecated, passed through in regex; marked 
> by <-- HERE in m/^docs/misc/kconfig{ <-- HERE ,-language}\.txt/ at 
> scripts/get_maintainer.pl line 731.
> 
> Also, it does not work.

But who said these are (expected to be) regex patterns? At the
top of the file, only K: is described as holding such. F:, otoh,
refers to wildcards, which {x,y} is kind of an extension of, so I'd
rather keep things as they are.

Jan

> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
>  MAINTAINERS | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index db14cfe..cc44cbd 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -212,7 +212,8 @@ F:	xen/include/xen/iommu.h
>  KCONFIG
>  M:	Doug Goldstein <cardoe@cardoe.com>
>  S:	Supported
> -F:	docs/misc/kconfig{,-language}.txt
> +F:	docs/misc/kconfig.txt
> +F:	docs/misc/kconfig-language.txt
>  F:	xen/tools/kconfig/
>  
>  KDD DEBUGGER
> @@ -223,8 +224,10 @@ F:	tools/debugger/kdd/
>  KEXEC
>  M:      David Vrabel <david.vrabel@citrix.com>
>  S:      Supported
> -F:      xen/common/{kexec,kimage}.c
> -F:      xen/include/{kexec,kimage}.h
> +F:      xen/common/kexec.c
> +F:      xen/common/kimage.c
> +F:      xen/include/kexec.h
> +F:      xen/include/kimage.h
>  F:      xen/arch/x86/machine_kexec.c
>  F:      xen/arch/x86/x86_64/kexec_reloc.S
>  
> -- 
> Anthony PERARD




_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] Fix MAINTAINERS: remove any use of {a,b}

[Ian Campbell]

On Thu, 2016-02-25 at 05:31 -0700, Jan Beulich wrote:
> > > > On 25.02.16 at 13:21, <anthony.perard@citrix.com> wrote:
> > This is the complain from perl:
> > Unescaped left brace in regex is deprecated, passed through in regex;
> > marked 
> > by <-- HERE in m/^docs/misc/kconfig{ <-- HERE ,-language}\.txt/ at 
> > scripts/get_maintainer.pl line 731.
> > 
> > Also, it does not work.
> 
> But who said these are (expected to be) regex patterns?

I expect this is a bug in get_maintainer.pl's regexes for parsing the file,
not that the field itself is expected to be a regex.

Ian

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] Fix MAINTAINERS: remove any use of {a,b}

[David Vrabel]

On 25/02/16 12:21, Anthony PERARD wrote:
> This is the complain from perl:
> Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/^docs/misc/kconfig{ <-- HERE ,-language}\.txt/ at scripts/get_maintainer.pl line 731.

F: is supposed to be globs, not regexes, I thought but...

> Also, it does not work.

> @@ -223,8 +224,10 @@ F:	tools/debugger/kdd/
>  KEXEC
>  M:      David Vrabel <david.vrabel@citrix.com>
>  S:      Supported
> -F:      xen/common/{kexec,kimage}.c
> -F:      xen/include/{kexec,kimage}.h
> +F:      xen/common/kexec.c
> +F:      xen/common/kimage.c
> +F:      xen/include/kexec.h
> +F:      xen/include/kimage.h
>  F:      xen/arch/x86/machine_kexec.c
>  F:      xen/arch/x86/x86_64/kexec_reloc.S

... I prefer this way of listing files since it's easier for humans to
parse.

Acked-by: David Vrabel <david.vrabel@citrix.com>

David

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] Fix MAINTAINERS: remove any use of {a,b}

[Anthony PERARD]

On Thu, Feb 25, 2016 at 12:34:43PM +0000, Ian Campbell wrote:
> On Thu, 2016-02-25 at 05:31 -0700, Jan Beulich wrote:
> > > > > On 25.02.16 at 13:21, <anthony.perard@citrix.com> wrote:
> > > This is the complain from perl:
> > > Unescaped left brace in regex is deprecated, passed through in regex;
> > > marked 
> > > by <-- HERE in m/^docs/misc/kconfig{ <-- HERE ,-language}\.txt/ at 
> > > scripts/get_maintainer.pl line 731.
> > > 
> > > Also, it does not work.
> > 
> > But who said these are (expected to be) regex patterns?
> 
> I expect this is a bug in get_maintainer.pl's regexes for parsing the file,
> not that the field itself is expected to be a regex.

I would say that it's a missing feature of get_maintainer.pl. It understand
. * and ?, and I guess also [].

I can try to handle {,} in get_maintainer.pl if you wish.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] Fix MAINTAINERS: remove any use of {a,b}

[Doug Goldstein]

[-- Attachment #1.1: Type: text/plain, Size: 979 bytes --]

On 2/25/16 6:21 AM, Anthony PERARD wrote:
> This is the complain from perl:
> Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/^docs/misc/kconfig{ <-- HERE ,-language}\.txt/ at scripts/get_maintainer.pl line 731.
> 
> Also, it does not work.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
>  MAINTAINERS | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index db14cfe..cc44cbd 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -212,7 +212,8 @@ F:	xen/include/xen/iommu.h
>  KCONFIG
>  M:	Doug Goldstein <cardoe@cardoe.com>
>  S:	Supported
> -F:	docs/misc/kconfig{,-language}.txt
> +F:	docs/misc/kconfig.txt
> +F:	docs/misc/kconfig-language.txt
>  F:	xen/tools/kconfig/
>  

I copied David's section so I assumed it was ok. But this is fine by me.

Reviewed-by: Doug Goldstein <cardoe@cardoe.com>

-- 
Doug Goldstein


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel