From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> To: Yoshihiro Kaneko <ykaneko0929@gmail.com> Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>, Simon Horman <horms@verge.net.au>, Magnus Damm <magnus.damm@gmail.com>, Linux-sh list <linux-sh@vger.kernel.org>, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH/RFC v4 net-next] ravb: Add dma queue interrupt support Date: Thu, 25 Feb 2016 22:22:57 +0000 [thread overview] Message-ID: <56CF7EC1.901@cogentembedded.com> (raw) In-Reply-To: <56CA0D1D.2090903@cogentembedded.com> On 02/21/2016 10:16 PM, Sergei Shtylyov wrote: [...] >>>>>>> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> >>>>>>> >>>>>>> This patch supports the following interrupts. >>>>>>> >>>>>>> - One interrupt for multiple (descriptor, error, management) >>>>>>> - One interrupt for emac >>>>>>> - Four interrupts for dma queue (best effort rx/tx, network control >>>>>>> rx/tx) >>>>>>> >>>>>>> This patch improve efficiency of the interrupt handler by adding the >>>>>>> interrupt handler corresponding to each interrupt source described >>>>>>> above. Additionally, it reduces the number of times of the access to >>>>>>> EthernetAVB IF. >>>>>>> >>>>>>> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> >>>>>>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com> > > [...] > >>>>>>> diff --git a/drivers/net/ethernet/renesas/ravb_main.c >>>>>>> b/drivers/net/ethernet/renesas/ravb_main.c >>>>>>> index ac43ed9..076f25f 100644 >>>>>>> --- a/drivers/net/ethernet/renesas/ravb_main.c >>>>>>> +++ b/drivers/net/ethernet/renesas/ravb_main.c > [...] >>>>>>> + struct net_device *ndev, struct device *dev, >>>>>>> + const char *ch) >>>>>>> +{ >>>>>>> + char *name; >>>>>>> + int error; >>>>>>> + >>>>>>> + name = devm_kasprintf(dev, GFP_KERNEL, "%s:%s", ndev->name, ch); >>>>>>> + error = request_irq(irq, handler, IRQF_SHARED, name, ndev); >>>>>> >>>>>> Not sure if we need IRQF_SHARED on those IRQs, they're not really >>>>>> shareable... >>>>> >>>>> I don't know whether this causes something bad. >>>>> I think this controller is supporting a shared IRQ. >>>> >>>> Based on the high-level trigger, I'd rather suspect not. Anyway, all the >>>> SoC IRQs are dedicated to a certain (single) source. >>> >>> I don't want to change that if there is no fatal issue in the use of >>> IRQF_SHARED. >>> However, I will remove the flag if it is simple waste... >> >> It's not a waste but it just shouldn't be needed. > > Actually for RX/TX DMA you're routing 2 interrupts to the same handler, so > it's needed, sorry. Scratch that, it's not multiple handlers, it's multiple IRQs... > [...] > >>> Thanks, >>> kaneko MBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> To: Yoshihiro Kaneko <ykaneko0929@gmail.com> Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>, Simon Horman <horms@verge.net.au>, Magnus Damm <magnus.damm@gmail.com>, Linux-sh list <linux-sh@vger.kernel.org>, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH/RFC v4 net-next] ravb: Add dma queue interrupt support Date: Fri, 26 Feb 2016 01:22:57 +0300 [thread overview] Message-ID: <56CF7EC1.901@cogentembedded.com> (raw) In-Reply-To: <56CA0D1D.2090903@cogentembedded.com> On 02/21/2016 10:16 PM, Sergei Shtylyov wrote: [...] >>>>>>> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> >>>>>>> >>>>>>> This patch supports the following interrupts. >>>>>>> >>>>>>> - One interrupt for multiple (descriptor, error, management) >>>>>>> - One interrupt for emac >>>>>>> - Four interrupts for dma queue (best effort rx/tx, network control >>>>>>> rx/tx) >>>>>>> >>>>>>> This patch improve efficiency of the interrupt handler by adding the >>>>>>> interrupt handler corresponding to each interrupt source described >>>>>>> above. Additionally, it reduces the number of times of the access to >>>>>>> EthernetAVB IF. >>>>>>> >>>>>>> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> >>>>>>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com> > > [...] > >>>>>>> diff --git a/drivers/net/ethernet/renesas/ravb_main.c >>>>>>> b/drivers/net/ethernet/renesas/ravb_main.c >>>>>>> index ac43ed9..076f25f 100644 >>>>>>> --- a/drivers/net/ethernet/renesas/ravb_main.c >>>>>>> +++ b/drivers/net/ethernet/renesas/ravb_main.c > [...] >>>>>>> + struct net_device *ndev, struct device *dev, >>>>>>> + const char *ch) >>>>>>> +{ >>>>>>> + char *name; >>>>>>> + int error; >>>>>>> + >>>>>>> + name = devm_kasprintf(dev, GFP_KERNEL, "%s:%s", ndev->name, ch); >>>>>>> + error = request_irq(irq, handler, IRQF_SHARED, name, ndev); >>>>>> >>>>>> Not sure if we need IRQF_SHARED on those IRQs, they're not really >>>>>> shareable... >>>>> >>>>> I don't know whether this causes something bad. >>>>> I think this controller is supporting a shared IRQ. >>>> >>>> Based on the high-level trigger, I'd rather suspect not. Anyway, all the >>>> SoC IRQs are dedicated to a certain (single) source. >>> >>> I don't want to change that if there is no fatal issue in the use of >>> IRQF_SHARED. >>> However, I will remove the flag if it is simple waste... >> >> It's not a waste but it just shouldn't be needed. > > Actually for RX/TX DMA you're routing 2 interrupts to the same handler, so > it's needed, sorry. Scratch that, it's not multiple handlers, it's multiple IRQs... > [...] > >>> Thanks, >>> kaneko MBR, Sergei
next prev parent reply other threads:[~2016-02-25 22:22 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-01-24 15:52 [PATCH/RFC v4 net-next] ravb: Add dma queue interrupt support Yoshihiro Kaneko 2016-01-24 15:52 ` Yoshihiro Kaneko 2016-01-26 0:23 ` Simon Horman 2016-01-26 0:23 ` Simon Horman 2016-01-26 19:00 ` Sergei Shtylyov 2016-01-26 19:00 ` Sergei Shtylyov 2016-01-27 1:49 ` Simon Horman 2016-01-27 1:49 ` Simon Horman 2016-01-28 15:50 ` Sergei Shtylyov 2016-01-28 15:50 ` Sergei Shtylyov 2016-01-28 18:36 ` Sergei Shtylyov 2016-01-28 18:36 ` Sergei Shtylyov 2016-01-28 16:48 ` Sergei Shtylyov 2016-01-28 16:48 ` Sergei Shtylyov 2016-02-07 16:50 ` Yoshihiro Kaneko 2016-02-07 16:50 ` Yoshihiro Kaneko 2016-02-07 17:09 ` Sergei Shtylyov 2016-02-07 17:09 ` Sergei Shtylyov 2016-02-08 17:19 ` Yoshihiro Kaneko 2016-02-08 17:19 ` Yoshihiro Kaneko 2016-02-21 15:42 ` Sergei Shtylyov 2016-02-21 15:42 ` Sergei Shtylyov 2016-02-21 19:16 ` Sergei Shtylyov 2016-02-21 19:16 ` Sergei Shtylyov 2016-02-25 22:22 ` Sergei Shtylyov [this message] 2016-02-25 22:22 ` Sergei Shtylyov 2016-01-28 17:32 ` Sergei Shtylyov 2016-01-28 17:32 ` Sergei Shtylyov 2016-02-07 16:56 ` Yoshihiro Kaneko 2016-02-07 16:56 ` Yoshihiro Kaneko 2016-02-07 17:18 ` Sergei Shtylyov 2016-02-07 17:18 ` Sergei Shtylyov 2016-01-28 17:51 ` Sergei Shtylyov 2016-01-28 17:51 ` Sergei Shtylyov 2016-02-07 17:18 ` Yoshihiro Kaneko 2016-02-07 17:18 ` Yoshihiro Kaneko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=56CF7EC1.901@cogentembedded.com \ --to=sergei.shtylyov@cogentembedded.com \ --cc=davem@davemloft.net \ --cc=horms@verge.net.au \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=linux-sh@vger.kernel.org \ --cc=magnus.damm@gmail.com \ --cc=netdev@vger.kernel.org \ --cc=ykaneko0929@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.