* [PATCH] cgroup: fix written mistake in warning message
@ 2016-02-26 2:42 Xiubo Li
[not found] ` <1456454528-10269-1-git-send-email-lixiubo-0p4V/sDNsUmm0O/7XYngnFaTQe2KTcn/@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Xiubo Li @ 2016-02-26 2:42 UTC (permalink / raw)
To: tj-DgEjT+Ai2ygdnm+yROfE0A, lizefan-hv44wF8Li93QT0dZR+AlfA
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA, Xiubo Li
There is written mistake about the print format name:id <--> %d:%s,
which the name is 'char *' type and id is 'int' type.
Signed-off-by: Xiubo Li <lixiubo-0p4V/sDNsUmm0O/7XYngnFaTQe2KTcn/@public.gmane.org>
---
kernel/cgroup.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index cc40463..0f82d16 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -5324,9 +5324,9 @@ int __init cgroup_init_early(void)
for_each_subsys(ss, i) {
WARN(!ss->css_alloc || !ss->css_free || ss->name || ss->id,
- "invalid cgroup_subsys %d:%s css_alloc=%p css_free=%p name:id=%d:%s\n",
+ "invalid cgroup_subsys %d:%s css_alloc=%p css_free=%p name:id=%s:%d\n",
i, cgroup_subsys_name[i], ss->css_alloc, ss->css_free,
- ss->id, ss->name);
+ ss->name, ss->id);
WARN(strlen(cgroup_subsys_name[i]) > MAX_CGROUP_TYPE_NAMELEN,
"cgroup_subsys_name %s too long\n", cgroup_subsys_name[i]);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cgroup: fix written mistake in warning message
[not found] ` <1456454528-10269-1-git-send-email-lixiubo-0p4V/sDNsUmm0O/7XYngnFaTQe2KTcn/@public.gmane.org>
@ 2016-02-26 4:16 ` Zefan Li
[not found] ` <56CFD18C.30305-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Zefan Li @ 2016-02-26 4:16 UTC (permalink / raw)
To: Xiubo Li, tj-DgEjT+Ai2ygdnm+yROfE0A; +Cc: cgroups-u79uwXL29TY76Z2rM5mHXA
On 2016/2/26 10:42, Xiubo Li wrote:
> There is written mistake about the print format name:id <--> %d:%s,
> which the name is 'char *' type and id is 'int' type.
>
> Signed-off-by: Xiubo Li <lixiubo-0p4V/sDNsUmm0O/7XYngnFaTQe2KTcn/@public.gmane.org>
Good catch. :)
but could instead change "name:id" to "id:name"? so it's consistent with
"cgroup_subsys %d:%s".
> ---
> kernel/cgroup.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/cgroup.c b/kernel/cgroup.c
> index cc40463..0f82d16 100644
> --- a/kernel/cgroup.c
> +++ b/kernel/cgroup.c
> @@ -5324,9 +5324,9 @@ int __init cgroup_init_early(void)
>
> for_each_subsys(ss, i) {
> WARN(!ss->css_alloc || !ss->css_free || ss->name || ss->id,
> - "invalid cgroup_subsys %d:%s css_alloc=%p css_free=%p name:id=%d:%s\n",
> + "invalid cgroup_subsys %d:%s css_alloc=%p css_free=%p name:id=%s:%d\n",
> i, cgroup_subsys_name[i], ss->css_alloc, ss->css_free,
> - ss->id, ss->name);
> + ss->name, ss->id);
> WARN(strlen(cgroup_subsys_name[i]) > MAX_CGROUP_TYPE_NAMELEN,
> "cgroup_subsys_name %s too long\n", cgroup_subsys_name[i]);
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cgroup: fix written mistake in warning message
[not found] ` <56CFD18C.30305-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
@ 2016-02-26 4:59 ` Xiubo Li
0 siblings, 0 replies; 3+ messages in thread
From: Xiubo Li @ 2016-02-26 4:59 UTC (permalink / raw)
To: Zefan Li, tj-DgEjT+Ai2ygdnm+yROfE0A; +Cc: cgroups-u79uwXL29TY76Z2rM5mHXA
On 26/02/2016 12:16, Zefan Li wrote:
> On 2016/2/26 10:42, Xiubo Li wrote:
>> There is written mistake about the print format name:id <--> %d:%s,
>> which the name is 'char *' type and id is 'int' type.
>>
>> Signed-off-by: Xiubo Li <lixiubo-0p4V/sDNsUmm0O/7XYngnFaTQe2KTcn/@public.gmane.org>
>
> Good catch. :)
>
> but could instead change "name:id" to "id:name"? so it's consistent with
> "cgroup_subsys %d:%s".
>
Sure, Please see the next version.
Thanks,
>> ---
>> kernel/cgroup.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/kernel/cgroup.c b/kernel/cgroup.c
>> index cc40463..0f82d16 100644
>> --- a/kernel/cgroup.c
>> +++ b/kernel/cgroup.c
>> @@ -5324,9 +5324,9 @@ int __init cgroup_init_early(void)
>>
>> for_each_subsys(ss, i) {
>> WARN(!ss->css_alloc || !ss->css_free || ss->name || ss->id,
>> - "invalid cgroup_subsys %d:%s css_alloc=%p css_free=%p name:id=%d:%s\n",
>> + "invalid cgroup_subsys %d:%s css_alloc=%p css_free=%p name:id=%s:%d\n",
>> i, cgroup_subsys_name[i], ss->css_alloc, ss->css_free,
>> - ss->id, ss->name);
>> + ss->name, ss->id);
>> WARN(strlen(cgroup_subsys_name[i]) > MAX_CGROUP_TYPE_NAMELEN,
>> "cgroup_subsys_name %s too long\n", cgroup_subsys_name[i]);
>>
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-26 4:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-26 2:42 [PATCH] cgroup: fix written mistake in warning message Xiubo Li
[not found] ` <1456454528-10269-1-git-send-email-lixiubo-0p4V/sDNsUmm0O/7XYngnFaTQe2KTcn/@public.gmane.org>
2016-02-26 4:16 ` Zefan Li
[not found] ` <56CFD18C.30305-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-02-26 4:59 ` Xiubo Li
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.